CVS commit: src/lib/libpanel
Module Name:src Committed By: blymn Date: Sun Jun 30 22:18:08 UTC 2019 Modified Files: src/lib/libpanel: shlib_version Log Message: Bump major number due to libcurses major bump To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/lib/libpanel/shlib_version Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/lib/libpanel/shlib_version diff -u src/lib/libpanel/shlib_version:1.1 src/lib/libpanel/shlib_version:1.2 --- src/lib/libpanel/shlib_version:1.1 Mon Oct 26 23:09:49 2015 +++ src/lib/libpanel/shlib_version Sun Jun 30 22:18:08 2019 @@ -1,5 +1,5 @@ -# $NetBSD: shlib_version,v 1.1 2015/10/26 23:09:49 uwe Exp $ +# $NetBSD: shlib_version,v 1.2 2019/06/30 22:18:08 blymn Exp $ # Remember to update distrib/sets/lists/base/shl.* when changing # -major=1 +major=2 minor=0
CVS commit: src/lib/libpanel
Module Name:src Committed By: blymn Date: Sun Jun 30 22:18:08 UTC 2019 Modified Files: src/lib/libpanel: shlib_version Log Message: Bump major number due to libcurses major bump To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/lib/libpanel/shlib_version Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/lib/libpanel
On Sun, Nov 22, 2015 at 06:37:55 +0100, Kamil Rytarowski wrote: > On 16.11.2015 12:25, Valery Ushakov wrote: > > > On Mon, Nov 16, 2015 at 00:00:48 +0100, Kamil Rytarowski wrote: > > > > > Are we ready to hook it into the build? > > > > Sorry, I don't have time. Feel free to. > > The libpanel(3) library has been landed. Thank you! Thanks! -uwe
Re: CVS commit: src/lib/libpanel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 16.11.2015 12:25, Valery Ushakov wrote: > On Mon, Nov 16, 2015 at 00:00:48 +0100, Kamil Rytarowski wrote: > >> On 27.10.2015 00:09, Valeriy E. Ushakov wrote: >>> Module Name:src Committed By: uwe Date: Mon Oct >>> 26 23:09:50 >>> UTC 2015 >>> >>> Added Files: src/lib/libpanel: Makefile _deck.c above.c >>> below.c bottom.c del.c getuser.c hidden.c hide.c move.c new.c >>> panel.h panel_impl.h replace.c setuser.c shlib_version show.c >>> top.c update.c window.c >>> >>> Log Message: First cut at ETI libpanel. Lacks man pages and >>> tests. Not hooked into the build yet. >> >> Are we ready to hook it into the build? > > Sorry, I don't have time. Feel free to. > > -uwe > The libpanel(3) library has been landed. Thank you! -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWUVSxAAoJEEuzCOmwLnZs5qQP/3IeGhQP6qF21z4B0ycyqoW+ fHWCB/JSHApiciI3tTCmdOQAzvyyBaQ4E6wbXjcGwgJpnKE5ucieDSKcYcBJbpR8 ME6DNY5hSVbUpgKci+ZGFaN89j5JGnYwhzME7RhLXYf6P1HulGdZsEBzpHr2xUMU mJSnZ7NaY8qCd4q/GpXt8IxDt1CCSEJ5W9ScViaXXoPslB1K7EwlJoT9ZJqEYspZ T9nneMC/SmnbzzHY8Tm2yXR2auTCmH4DumiAEPDfiFuwTswcMamwOJ8IUBAX0fYW +2zzv+eytkuhuXDNBeHr7g+8GJcxTHx/Wq1blgaKbhCPEjFVy0ywIP4D5X2fpoFs eMOaGs/Y7ooQQLO0ZdB/c0qiHtNyCe+MSfWrobEmDNe1yXST2kXuluaT1ySsE12y cZjcL0HJkip1nhLvO5fMZyHNpSEIGwk+187pRIcZglD4sU2YXxohrGNH8/QTbNI5 IVpZZrFAP11IKWUqvC7ioLHq1p9FiHdWyAoffise30S5cyH1LOoF/ryZXy/bYeZH l8lwkkkeJ4g4WJTWnYp9a/oXLmvkx5dpyi6zN2sF5kD8+I8LR5E73VjTdHGWrPD7 TaHN3+BWbSzQkqNNlU4H0/gT9p7lUBQ8rgW/wM9Q3D7a6uXPcWNiUZ4cfuiBupdz 5bU62g6Ea9ojy7FlI8b+ =u5z0 -END PGP SIGNATURE-
Re: CVS commit: src/lib/libpanel
On Mon, Nov 16, 2015 at 00:00:48 +0100, Kamil Rytarowski wrote: > On 27.10.2015 00:09, Valeriy E. Ushakov wrote: > > Module Name:src > > Committed By: uwe > > Date: Mon Oct 26 23:09:50 UTC 2015 > > > > Added Files: src/lib/libpanel: Makefile _deck.c above.c below.c > > bottom.c del.c getuser.c hidden.c hide.c move.c new.c panel.h > > panel_impl.h replace.c setuser.c shlib_version show.c top.c > > update.c window.c > > > > Log Message: First cut at ETI libpanel. Lacks man pages and > > tests. Not hooked into the build yet. > > Are we ready to hook it into the build? Sorry, I don't have time. Feel free to. -uwe
Re: CVS commit: src/lib/libpanel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27.10.2015 00:09, Valeriy E. Ushakov wrote: > Module Name: src Committed By: uwe Date: Mon Oct 26 > 23:09:50 UTC > 2015 > > Added Files: src/lib/libpanel: Makefile _deck.c above.c below.c > bottom.c del.c getuser.c hidden.c hide.c move.c new.c panel.h > panel_impl.h replace.c setuser.c shlib_version show.c top.c > update.c window.c > > Log Message: First cut at ETI libpanel. Lacks man pages and > tests. Not hooked into the build yet. > Are we ready to hook it into the build? -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWSQ6eAAoJEEuzCOmwLnZsRrAQAIoNwdXoUdeDqRQiKUDhGP8G Ogr+uLx4HETgHO8K7SgFIqzYLBZsfmBoYEeHqQWcfJTKhi7JMay084GrqiKGXaX7 exsy2pZgcYSqkU549ktl8wQQsj+Zz5vXt6Bm0xy3HOGFwxkL9HMd/SY9HlBSdYKM 6HcoCwv/u3UfAZOLZqSj+J91daRb0Pa7DsDlDsM8mrs+PgvTvRyiLwFlQzP06hXP ymK4MXr6UwjRD9BZ3cMbxvtiLN5FKcNY8Gfj6p7fbHd73PxgK+eIMR9Wiz712l31 vaqkX475XFOG85+7AogKgEX6Hmh97+mg9yhwG4kWlcbokFBnNH1dnkH0SxColP66 WkaZHRSa/je22au4kodSnqCrBjc0FUqtsDIUss/T7SerMXlt75SZP2cILW3TtUf4 Nx+4LYRrI/VBitpexa6nYnMHz1MppLMQXHpuwST9bHGYIPqxZ3Wh0lj6sKirWvUV 8dcJUwkuGmYZmCHGUP26nCVdAi32hRLGhvjPZz/DzQhn+K0Z+FmBgYg/7Ne2eaZF S4sxoeP+ayaGz/8sXsMONoz/g5xULHMvkjSb/HyTkvpKxd0FW4HDl1wKf5KrxVAk Z7U+uaHCPXuCK2RgbRO7TbWAiw4bvEvAWB7yLg5TnH/NM/l7neuZFNI5jDT5o4zs XBMUjuZPK4E2CyFpkvAw =0W3m -END PGP SIGNATURE-
Re: CVS commit: src/lib/libpanel
On Mon, Nov 02, 2015 at 01:06:15 +, Kamil Rytarowski wrote: > Modified Files: > src/lib/libpanel: above.c bottom.c del.c hidden.c new.c panel.h > panel_impl.h replace.c show.c top.c window.c > > Log Message: > No functional changes > > Make this code nicer for C++ compilers, don't assign char* to void*. > Add extra __prefix_false() CPU hint for failed malloc(3). > Normalize whitespace. Please, don't mix cosmetic and non-cosmetic changes in the single commit. As Christos already pointed out, blank line "after" absent declarations is part of style. C++ should never see library internals. -uwe
Re: CVS commit: src/lib/libpanel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02.11.2015 02:42, Christos Zoulas wrote: > In article <20151102010615.a199...@cvs.netbsd.org>, Kamil > Rytarowski wrote: >> -=-=-=-=-=- >> >> Module Name: src Committed By: kamil Date: Mon Nov 2 >> 01:06:15 >> UTC 2015 >> >> Modified Files: src/lib/libpanel: above.c bottom.c del.c hidden.c >> new.c panel.h panel_impl.h replace.c show.c top.c window.c >> >> Log Message: No functional changes >> >> Make this code nicer for C++ compilers, don't assign char* to >> void*. Add extra __prefix_false() CPU hint for failed malloc(3). >> Normalize whitespace. > > The blank line at the beginning of functions that don't contain > declarations is part of style... I am not enamored by it, but it is > what it is. I will revert this part. > As far as casts go, the casts that cast from void * to other types > (return of malloc) should go. This is not c++ (and if it was meant > to be compiled for c++ it should be using modern c++ casts) because > casting malloc only hides the fact that you forgot to include > ... > I integrated libpanel(8) with lldb(1) for NetBSD-7.0, as I'm using there our native curses(8). libpanel(8) is a missing part out there. The user member isn't used with malloc(3)-like functions. Should it stay for some reason void*? -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWNsM1AAoJEEuzCOmwLnZsvsoP/1aFfvVNy8ho73UnpYDSk7o8 bNh2jbksBt9mXmlysW5mSCGtPdthbJbfeW2haLV0zHyxVQkyh9BeeowrQmE1Ohnn ETZpGMkHlciou0nOM40qe9dCzH5wzNINeJn2Kaf1EmxiHRKz0Yb1nKubh67JX3n5 6+sE4DPkoV4+OTytoIfb43oSMgtXawgUS/AZVk1zaBOuAYdu9qzHlqLXgkP0gCX3 RRFc3izNNuKl0cNF3aPnYxiFdx9IlChocwF54EyRNygbjnnGvygp6jgh21BSLR0G ShyML0d3ENWjX95xVl45u+8XvCov4RFaYIdcW65mIda3+T+9UWH1v426lCeuypRi I0wOYWTcikMwNTOTtLYvJ8bPn3GrxjFPynitIzTydDJGXCnCM+9o4ItJCOoX+kac yjjJrLOId1ioHL7cM+qIRB1vEU0Xgw/ifzQP6WOjBiZLcGLuS4R3KuWeJ0iuEVpk a/SwIDtUOsna8dhpCXZe6g5b37FvbvssBLDPFvc/ez1IbgWfcDQgG42VNKp+afyv YKxaNdi5NeroXPV4Z3gzFNY6O9mH/HdCpBTydBO4gbuvONTH33oLWlr/tCwzp6Xd nOXCD5Fj0AVMLxVYByJ60cMg2U0wpp0SHzSm3l10slqZ2sqpEsJ8ZSArXUbelHsD WWeHhv1mhoDSX9z6hywf =Vie8 -END PGP SIGNATURE-
Re: CVS commit: src/lib/libpanel
In article <20151102010615.a199...@cvs.netbsd.org>, Kamil Rytarowski wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: kamil >Date: Mon Nov 2 01:06:15 UTC 2015 > >Modified Files: > src/lib/libpanel: above.c bottom.c del.c hidden.c new.c panel.h > panel_impl.h replace.c show.c top.c window.c > >Log Message: >No functional changes > >Make this code nicer for C++ compilers, don't assign char* to void*. >Add extra __prefix_false() CPU hint for failed malloc(3). >Normalize whitespace. The blank line at the beginning of functions that don't contain declarations is part of style... I am not enamored by it, but it is what it is. As far as casts go, the casts that cast from void * to other types (return of malloc) should go. This is not c++ (and if it was meant to be compiled for c++ it should be using modern c++ casts) because casting malloc only hides the fact that you forgot to include ... christos
Re: CVS commit: src/lib/libpanel
On Sun, Nov 01, 2015 at 09:42:11PM +0700, Robert Elz wrote: > Date:Sun, 1 Nov 2015 11:02:24 + > From:"Thomas Klausner" > Message-ID: <20151101110224.0f63...@cvs.netbsd.org> > > | Modified Files: > | src/lib/libpanel: panel_above.3 > | > | Log Message: > | Improve wording even more, suggested by Robert Elz. > > You changed the of "bottom and top" to "top and bottom". > > While I agree that's a more common usage, if you're going to do > that you also need to swap the order of the functions. > > panel_above(NULL) -> the bottom panel, panel_below(NULL) -> the top one. > > kre > > ps: I also agree with Paul, the extra "the", while not incorrect, makes > it harder to read. The functions don't behave like I thought they would. I've swapped the words again and removed the 'the'. Thomas
Re: CVS commit: src/lib/libpanel
Date:Sun, 1 Nov 2015 11:02:24 + From:"Thomas Klausner" Message-ID: <20151101110224.0f63...@cvs.netbsd.org> | Modified Files: | src/lib/libpanel: panel_above.3 | | Log Message: | Improve wording even more, suggested by Robert Elz. You changed the of "bottom and top" to "top and bottom". While I agree that's a more common usage, if you're going to do that you also need to swap the order of the functions. panel_above(NULL) -> the bottom panel, panel_below(NULL) -> the top one. kre ps: I also agree with Paul, the extra "the", while not incorrect, makes it harder to read.
Re: CVS commit: src/lib/libpanel
On Sun, 1 Nov 2015, Robert Elz wrote: Date:Sun, 1 Nov 2015 08:54:37 + From:"Thomas Klausner" Message-ID: <20151101085437.75bf...@cvs.netbsd.org> | Modified Files: | src/lib/libpanel: panel_above.3 | | Log Message: | Improve wording. It would be even better, more precise, and more useful, if it said ... The bottom and the top panels can be obtained by passing a Less wordy, and perhaps easier to say (at least for an American English speaker: The bottom and top panels can be obtained by passing a :) .Dv NULL argument to .Fn panel_above and .Fn panel_below , respectively. kre +--+--+-+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +--+--+-+
Re: CVS commit: src/lib/libpanel
On Sun, Nov 01, 2015 at 05:47:41PM +0700, Robert Elz wrote: > Date:Sun, 1 Nov 2015 08:54:37 + > From:"Thomas Klausner" > Message-ID: <20151101085437.75bf...@cvs.netbsd.org> > > | Modified Files: > | src/lib/libpanel: panel_above.3 > | > | Log Message: > | Improve wording. > > It would be even better, more precise, and more useful, > if it said ... > > > The bottom and the top panels can be obtained by passing a > .Dv NULL > argument to > .Fn panel_above > and > .Fn panel_below , > respectively. Thanks, committed. I switched "bottom" and "top" though :) Thomas
Re: CVS commit: src/lib/libpanel
Date:Sun, 1 Nov 2015 08:54:37 + From:"Thomas Klausner" Message-ID: <20151101085437.75bf...@cvs.netbsd.org> | Modified Files: | src/lib/libpanel: panel_above.3 | | Log Message: | Improve wording. It would be even better, more precise, and more useful, if it said ... The bottom and the top panels can be obtained by passing a .Dv NULL argument to .Fn panel_above and .Fn panel_below , respectively. kre
