Re: CVS commit: src/libexec/rpc.rstatd
Date:Wed, 31 Oct 2018 20:27:53 +1100 From:matthew green Message-ID: <16475.1540978...@splode.eterna.com.au> | hmmm... feels like KERN_BOOTTIMESPEC should be added instead, | and the compat restored for this old API. | | or should have been 9 years ago :-( ps: even if that might have been a reasonable thing to do, way back when, now it woulldn't work, as there are parts of the tree that know it is a timespec (before I started updating stuff) and other parts which did not. There's no way to provide compat with both. kre
Re: CVS commit: src/libexec/rpc.rstatd
Date:Wed, 31 Oct 2018 20:27:53 +1100 From:matthew green Message-ID: <16475.1540978...@splode.eterna.com.au> | hmmm... feels like KERN_BOOTTIMESPEC should be added instead, | and the compat restored for this old API. | | or should have been 9 years ago :-( A compat was added for it 9 years ago, kern.oboottime (currently not working I think, but that's an entirley different problem) - but that was compat with what existed before, which was a timeval with a 32 bit time_t Ever since, we've had timespecs in which almost no-one ever looks at the fractional seconds part (the kernfs /kern/boottime doesn't even include them). kre
re: CVS commit: src/libexec/rpc.rstatd
"Robert Elz" writes: > Module Name: src > Committed By: kre > Date: Tue Oct 30 21:18:39 UTC 2018 > > Modified Files: > src/libexec/rpc.rstatd: rstat_proc.c > > Log Message: > sysctl(KERN_BOOTTIME) is a struct timespec, not struct timeval > and has eben since 2009.Adapt. > > NFCI - while the tv_usec (now tv_nsec) field is used, we will > keep its uses to microsecond precision to avoid any compat issues. hmmm... feels like KERN_BOOTTIMESPEC should be added instead, and the compat restored for this old API. or should have been 9 years ago :-( .mrg.
Re: CVS commit: src/libexec/rpc.rstatd
On Tue, Jun 10, 2014 at 07:00:13AM +1000, matthew green wrote: Do we really want to zap the CSRG sccsids? They are part of the history. If someone is really interested in them, CVS still has the history. Otherwise they are basically just noise. Joerg removed the sccsids from sed too. This is not good because when we compare things with other BSD's we cannot tell if they came from the same origin or not. I'd put them back. They are ifdefed 0 anyway. They were not. i like keeping them there. they should be #if 0'd but having the original lines is useful to me at least several times a year. I agree, please let's restore these. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/libexec/rpc.rstatd
On Sun, Jun 08, 2014 at 01:17:26PM +, Christos Zoulas wrote: In article 20140608053602.ga5...@netbsd.org, David Holland dholland-sourcechan...@netbsd.org wrote: On Mon, Jun 02, 2014 at 05:40:05PM +, Joerg Sonnenberger wrote: Modified Files: src/libexec/rpc.rstatd: rstat_proc.c Log Message: Remove !BSD and lint branches. Do we really want to zap the CSRG sccsids? They are part of the history. If someone is really interested in them, CVS still has the history. Otherwise they are basically just noise. Joerg removed the sccsids from sed too. This is not good because when we compare things with other BSD's we cannot tell if they came from the same origin or not. I'd put them back. They are ifdefed 0 anyway. They were not. Joerg
re: CVS commit: src/libexec/rpc.rstatd
Joerg Sonnenberger writes: On Sun, Jun 08, 2014 at 01:17:26PM +, Christos Zoulas wrote: In article 20140608053602.ga5...@netbsd.org, David Holland dholland-sourcechan...@netbsd.org wrote: On Mon, Jun 02, 2014 at 05:40:05PM +, Joerg Sonnenberger wrote: Modified Files: src/libexec/rpc.rstatd: rstat_proc.c Log Message: Remove !BSD and lint branches. Do we really want to zap the CSRG sccsids? They are part of the history. If someone is really interested in them, CVS still has the history. Otherwise they are basically just noise. Joerg removed the sccsids from sed too. This is not good because when we compare things with other BSD's we cannot tell if they came from the same origin or not. I'd put them back. They are ifdefed 0 anyway. They were not. i like keeping them there. they should be #if 0'd but having the original lines is useful to me at least several times a year. .mrg.
Re: CVS commit: src/libexec/rpc.rstatd
In article 20140608053602.ga5...@netbsd.org, David Holland dholland-sourcechan...@netbsd.org wrote: On Mon, Jun 02, 2014 at 05:40:05PM +, Joerg Sonnenberger wrote: Modified Files: src/libexec/rpc.rstatd: rstat_proc.c Log Message: Remove !BSD and lint branches. Do we really want to zap the CSRG sccsids? They are part of the history. Joerg removed the sccsids from sed too. This is not good because when we compare things with other BSD's we cannot tell if they came from the same origin or not. I'd put them back. They are ifdefed 0 anyway. christos
Re: CVS commit: src/libexec/rpc.rstatd
On Mon, Jun 02, 2014 at 05:40:05PM +, Joerg Sonnenberger wrote: Modified Files: src/libexec/rpc.rstatd: rstat_proc.c Log Message: Remove !BSD and lint branches. Do we really want to zap the CSRG sccsids? They are part of the history. -- David A. Holland dholl...@netbsd.org
