Re: CVS commit: src/sbin/fsck_ext2fs
On 21.04.2017 20:08, co...@sdf.org wrote:
> On Fri, Apr 21, 2017 at 07:46:27PM +0200, Kamil Rytarowski wrote:
>>
>> It's a valid code.
>>
>
> Other things fail:
> http://releng.netbsd.org/builds/HEAD/201704202350Z/evbarm64-aarch64.build.failed
>
> /home/source/ab/HEAD/src/bin/ln/ln.c:357:1: error: function 'usage'
> could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn]
> {
> ^
> 1 error generated.
>
> I think that one is even more valid :-)
>
Sometimes we can specify WARNS=6 or similar in Makefiles to turn
warnings into errors.
signature.asc
Description: OpenPGP digital signature
Re: CVS commit: src/sbin/fsck_ext2fs
On Fri, Apr 21, 2017 at 07:46:27PM +0200, Kamil Rytarowski wrote:
>
> It's a valid code.
>
Other things fail:
http://releng.netbsd.org/builds/HEAD/201704202350Z/evbarm64-aarch64.build.failed
/home/source/ab/HEAD/src/bin/ln/ln.c:357:1: error: function 'usage'
could be declared with attribute 'noreturn' [-Werror,-Wmissing-noreturn]
{
^
1 error generated.
I think that one is even more valid :-)
Re: CVS commit: src/sbin/fsck_ext2fs
> Date: Fri, 21 Apr 2017 17:47:22 +
> From: co...@sdf.org
>
> /home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning:
> comparison of array 'dp->e2di_blocks' equal to a null pointer is always false
> [-Wtautological-pointer-compare]
> (EXT2_MAXSYMLINKLEN == 0 && dp->e2di_blocks == 0)) {
> ^~~~
I am pretty sure this was supposed to be dp->ed2i_nblock, not
vacuously true. Compare the analogous code in fsck_ffs/pass1.c, with
the same comment over it.
Re: CVS commit: src/sbin/fsck_ext2fs
On 21.04.2017 19:47, co...@sdf.org wrote:
> On Fri, Apr 21, 2017 at 01:33:05PM -0400, Christos Zoulas wrote:
>> e2di_block is an array; can't be NULL, (clang)
>
> I'm guessing this is from
> http://releng.netbsd.org/builds/HEAD-llvm/201704191240Z/amd64.build.failed
>
>
> /home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning:
> comparison of array 'dp->e2di_blocks' equal to a null pointer is always false
> [-Wtautological-pointer-compare]
> (EXT2_MAXSYMLINKLEN == 0 && dp->e2di_blocks == 0)) {
> ^~~~
>
> 1 warning generated.
>
> How come that warning wasn't fatal?
>
It's a valid code.
signature.asc
Description: OpenPGP digital signature
Re: CVS commit: src/sbin/fsck_ext2fs
On Fri, Apr 21, 2017 at 01:33:05PM -0400, Christos Zoulas wrote:
> e2di_block is an array; can't be NULL, (clang)
I'm guessing this is from
http://releng.netbsd.org/builds/HEAD-llvm/201704191240Z/amd64.build.failed
/home/source/ab/HEAD-llvm/src/sbin/fsck_ext2fs/pass1.c:242:39: warning:
comparison of array 'dp->e2di_blocks' equal to a null pointer is always false
[-Wtautological-pointer-compare]
(EXT2_MAXSYMLINKLEN == 0 && dp->e2di_blocks == 0)) {
^~~~
1 warning generated.
How come that warning wasn't fatal?
