Re: CVS commit: src/sys/arch/evbarm/rpi

[SAITOH Masanobu]

Hi.

On 2014/09/29 0:39, Michael Lorenz wrote:
 Module Name:  src
 Committed By: macallan
 Date: Sun Sep 28 15:39:36 UTC 2014
 
 Modified Files:
   src/sys/arch/evbarm/rpi: rpi_machdep.c
 
 Log Message:
 make global variables static
 also, make cursor test pattern red/green to highlight RGB vs. BGR
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.48 -r1.49 src/sys/arch/evbarm/rpi/rpi_machdep.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Did you forget something?

--- kern-RPI ---
rpi_machdep.o: In function `rpi_device_register':
rpi_machdep.c:(.text+0x54c): undefined reference to `rpi_alloc_mem'
rpi_machdep.c:(.text+0x554): undefined reference to `rpi_lock_mem'
rpi_machdep.c:(.text+0x5a0): undefined reference to `rpi_fb_movecursor'
rpi_machdep.c:(.text+0x680): undefined reference to `rpi_fb_initcursor'
rpi_machdep.o: In function `rpi_ioctl':
rpi_machdep.c:(.text+0x8c8): undefined reference to `rpi_fb_movecursor'
rpi_machdep.c:(.text+0x8f4): undefined reference to `rpi_fb_set_video'
rpi_machdep.c:(.text+0xaa4): undefined reference to `rpi_fb_initcursor'
rpi_machdep.c:(.text+0xac4): undefined reference to `rpi_fb_movecursor'

-- 
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)

Re: CVS commit: src/sys/arch/evbarm/rpi

[Michael]

Hello,

On Wed, 01 Oct 2014 02:51:12 +0900
SAITOH Masanobu msai...@execsw.org wrote:

 Hi.
 
 On 2014/09/29 0:39, Michael Lorenz wrote:
  Module Name:src
  Committed By:   macallan
  Date:   Sun Sep 28 15:39:36 UTC 2014
  
  Modified Files:
  src/sys/arch/evbarm/rpi: rpi_machdep.c
  
  Log Message:
  make global variables static
  also, make cursor test pattern red/green to highlight RGB vs. BGR
  
  
  To generate a diff of this commit:
  cvs rdiff -u -r1.48 -r1.49 src/sys/arch/evbarm/rpi/rpi_machdep.c
  
  Please note that diffs are not public domain; they are subject to
  the copyright notices on the relevant files.
 
 Did you forget something?
 
 --- kern-RPI ---
 rpi_machdep.o: In function `rpi_device_register':
 rpi_machdep.c:(.text+0x54c): undefined reference to `rpi_alloc_mem'
 rpi_machdep.c:(.text+0x554): undefined reference to `rpi_lock_mem'
 rpi_machdep.c:(.text+0x5a0): undefined reference to
 `rpi_fb_movecursor' rpi_machdep.c:(.text+0x680): undefined reference
 to `rpi_fb_initcursor' rpi_machdep.o: In function `rpi_ioctl':
 rpi_machdep.c:(.text+0x8c8): undefined reference to
 `rpi_fb_movecursor' rpi_machdep.c:(.text+0x8f4): undefined reference
 to `rpi_fb_set_video' rpi_machdep.c:(.text+0xaa4): undefined
 reference to `rpi_fb_initcursor' rpi_machdep.c:(.text+0xac4):
 undefined reference to `rpi_fb_movecursor'
 

Argh.
Yes, yes I did.
Sorry, will fix in a minute.

have fun
Michael

Re: CVS commit: src/sys/arch/evbarm/rpi

[Christos Zoulas]

In article 20140928143829.88f3...@cvs.netbsd.org,
Michael Lorenz source-changes-d@NetBSD.org wrote:
-=-=-=-=-=-

+  hcursor = rpi_alloc_mem(64 * 64 * 4, PAGE_SIZE,
+  MEM_FLAG_L1_NONALLOCATING | MEM_FLAG_HINT_PERMALOCK);

Can you put some constants here since this 64 * 64 * 4 gets repeated?
Maybe one constant for 64 and one for the whole thing?

+  int i, j, k;

uint32_t for the indexes?

+  copyin(cur-mask, cursor_mask, 64 * 8);
+  copyin(cur-image, cursor_bitmap, 64 * 8);

Error checking? More constants?

+  int i, j, idx;

uint32_t for the indexes?


christos