CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common

2023-08-02 Thread Christos Zoulas 
Module Name:src
Committed By:   christos
Date:   Wed Aug  2 10:31:46 UTC 2023

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common:
sanitizer_interceptors_ioctl_netbsd.inc
sanitizer_platform_limits_netbsd.cc
sanitizer_platform_limits_netbsd.h

Log Message:
Use the new struct and ioctl names for the compat functions (thanks Ryo)


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
cvs rdiff -u -r1.8 -r1.9 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
cvs rdiff -u -r1.6 -r1.7 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
diff -u src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.5 src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.6
--- src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.5	Mon Dec 26 17:22:22 2022
+++ src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc	Wed Aug  2 06:31:46 2023
@@ -452,7 +452,7 @@ static void ioctl_table_fill() {
   _(USB_SETDEBUG, READ, sizeof(int));
   _(USB_DISCOVER, NONE, 0);
   _(USB_DEVICEINFO, READWRITE, struct_usb_device_info_sz);
-  _(USB_DEVICEINFO_OLD, READWRITE, struct_usb_device_info_old_sz);
+  _(USB_DEVICEINFO_30, READWRITE, struct_usb_device_info30_sz);
   _(USB_DEVICESTATS, WRITE, struct_usb_device_stats_sz);
   _(USB_GET_REPORT_DESC, WRITE, struct_usb_ctl_report_desc_sz);
   _(USB_SET_IMMED, READ, sizeof(int));
@@ -472,7 +472,7 @@ static void ioctl_table_fill() {
   _(USB_GET_STRING_DESC, READWRITE, struct_usb_string_desc_sz);
   _(USB_DO_REQUEST, READWRITE, struct_usb_ctl_request_sz);
   _(USB_GET_DEVICEINFO, WRITE, struct_usb_device_info_sz);
-  _(USB_GET_DEVICEINFO_OLD, WRITE, struct_usb_device_info_old_sz);
+  _(USB_GET_DEVICEINFO_30, WRITE, struct_usb_device_info30_sz);
   _(USB_SET_SHORT_XFER, READ, sizeof(int));
   _(USB_SET_TIMEOUT, READ, sizeof(int));
   _(USB_SET_BULK_RA, READ, sizeof(int));
@@ -675,7 +675,7 @@ static void ioctl_table_fill() {
   _(BIOCGETIF, WRITE, struct_ifreq_sz);
   _(BIOCSETIF, READ, struct_ifreq_sz);
   _(BIOCGSTATS, WRITE, struct_bpf_stat_sz);
-  _(BIOCGSTATSOLD, WRITE, struct_bpf_stat_old_sz);
+  _(BIOCGSTATS_30, WRITE, struct_bpf_stat30_sz);
   _(BIOCIMMEDIATE, READ, sizeof(unsigned int));
   _(BIOCVERSION, WRITE, struct_bpf_version_sz);
   _(BIOCSTCPF, READ, struct_bpf_program_sz);

Index: src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
diff -u src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:1.8 src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:1.9
--- src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:1.8	Mon Dec 26 17:22:22 2022
+++ src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc	Wed Aug  2 06:31:46 2023
@@ -549,7 +549,7 @@ unsigned struct_blue_interface_sz = size
 unsigned struct_blue_stats_sz = sizeof(blue_stats);
 unsigned struct_bpf_dltlist_sz = sizeof(bpf_dltlist);
 unsigned struct_bpf_program_sz = sizeof(bpf_program);
-unsigned struct_bpf_stat_old_sz = sizeof(bpf_stat_old);
+unsigned struct_bpf_stat30_sz = sizeof(bpf_stat30);
 unsigned struct_bpf_stat_sz = sizeof(bpf_stat);
 unsigned struct_bpf_version_sz = sizeof(bpf_version);
 unsigned struct_btreq_sz = sizeof(btreq);
@@ -856,7 +856,7 @@ unsigned struct_spi_ioctl_transfer_sz = 
 unsigned struct_autofs_daemon_request_sz = sizeof(autofs_daemon_request);
 unsigned struct_autofs_daemon_done_sz = sizeof(autofs_daemon_done);
 unsigned struct_sctp_connectx_addrs_sz = sizeof(sctp_connectx_addrs);
-unsigned struct_usb_device_info_old_sz = sizeof(usb_device_info_old);
+unsigned struct_usb_device_info30_sz = sizeof(usb_device_info30);
 unsigned struct_usb_device_info_sz = sizeof(usb_device_info);
 unsigned struct_usb_device_stats_sz = sizeof(usb_device_stats);
 unsigned struct_usb_endpoint_desc_sz = sizeof(usb_endpoint_desc);
@@ -1419,7 +1419,7 @@ unsigned IOCTL_USB_REQUEST = USB_REQUEST
 unsigned IOCTL_USB_SETDEBUG = USB_SETDEBUG;
 unsigned IOCTL_USB_DISCOVER = USB_DISCOVER;
 unsigned IOCTL_USB_DEVICEINFO = USB_DEVICEINFO;
-unsigned IOCTL_USB_DEVICEINFO_OLD = USB_DEVICEINFO_OLD;
+unsigned IOCTL_USB_DEVICEINFO_30 = USB_DEVICEINFO_30;
 unsigned IOCTL_USB_DEVICESTATS = USB_DEVICESTATS;
 unsigned IOCTL_USB_GET_REPORT_DESC =

CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common

2023-08-02 Thread Christos Zoulas 
Module Name:src
Committed By:   christos
Date:   Wed Aug  2 10:31:46 UTC 2023

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common:
sanitizer_interceptors_ioctl_netbsd.inc
sanitizer_platform_limits_netbsd.cc
sanitizer_platform_limits_netbsd.h

Log Message:
Use the new struct and ioctl names for the compat functions (thanks Ryo)


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
cvs rdiff -u -r1.8 -r1.9 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
cvs rdiff -u -r1.6 -r1.7 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm

2021-06-30 Thread Nick Hudson 

On 30/06/2021 15:13, Joerg Sonnenberger wrote:

On Tue, Jun 29, 2021 at 11:26:00PM +, Rin Okuyama wrote:

Module Name:src
Committed By:   rin
Date:   Tue Jun 29 23:26:00 UTC 2021

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm: aeabi_cfcmp.S
divmodsi4.S divsi3.S modsi3.S

Log Message:
Align sp to 8-byte boundary as required by EABI.


Why not just push/pop another register? That's how it is normally done
for generated code.


https://mail-index.netbsd.org/port-arm/2021/06/30/msg007341.html

Nick

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm

2021-06-30 Thread Joerg Sonnenberger 
On Tue, Jun 29, 2021 at 11:26:00PM +, Rin Okuyama wrote:
> Module Name:  src
> Committed By: rin
> Date: Tue Jun 29 23:26:00 UTC 2021
> 
> Modified Files:
>   src/sys/external/bsd/compiler_rt/dist/lib/builtins/arm: aeabi_cfcmp.S
>   divmodsi4.S divsi3.S modsi3.S
> 
> Log Message:
> Align sp to 8-byte boundary as required by EABI.

Why not just push/pop another register? That's how it is normally done
for generated code.

Joerg

CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/msan

2019-10-23 Thread Kamil Rytarowski 
Module Name:src
Committed By:   kamil
Date:   Wed Oct 23 11:27:08 UTC 2019

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/msan: msan_interceptors.cc

Log Message:
Correct the __libc_thr_keycreate signature in the MSan interceptor

Noted by gcc8.

In practice it might have no impact on the functionality.


To generate a diff of this commit:
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc
diff -u src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc:1.1.1.1 src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc:1.2
--- src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc:1.1.1.1	Tue Jan  8 05:40:32 2019
+++ src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc	Wed Oct 23 11:27:08 2019
@@ -1057,7 +1057,7 @@ INTERCEPTOR(int, pthread_key_create, __s
 }
 
 #if SANITIZER_NETBSD
-INTERCEPTOR(void, __libc_thr_keycreate, void *m, void (*dtor)(void *value)) \
+INTERCEPTOR(int, __libc_thr_keycreate, __sanitizer_pthread_key_t *m, void (*dtor)(void *value)) \
   ALIAS(WRAPPER_NAME(pthread_key_create));
 #endif

CVS commit: src/sys/external/bsd/compiler_rt/dist/lib/msan

2019-10-23 Thread Kamil Rytarowski 
Module Name:src
Committed By:   kamil
Date:   Wed Oct 23 11:27:08 UTC 2019

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/msan: msan_interceptors.cc

Log Message:
Correct the __libc_thr_keycreate signature in the MSan interceptor

Noted by gcc8.

In practice it might have no impact on the functionality.


To generate a diff of this commit:
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/msan/msan_interceptors.cc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2019-08-13 Thread Kamil Rytarowski 
Module Name:src
Committed By:   kamil
Date:   Wed Aug 14 00:51:48 UTC 2019

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/asan: asan_posix.cc
src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common:
sanitizer_interceptors_ioctl_netbsd.inc
sanitizer_platform_limits_netbsd.cc
sanitizer_platform_limits_netbsd.h

Log Message:
Cherry-pick upstream compiler-rt patches for LLVM sanitizers

Upstream no longer accepts patches for LLVM-8, therefore pull needed changes 
downstream.

Enhancements:

 * resolved build failured with NetBSD 9.99.3
 * ioctl(2) lists are synced with NetBSD 9.99.3
 * fixes dynamic asan (-fsanitize=address -shared-libasa) crash on init

commit 092068cd7429659138d6779a3072298462ad3e9c
Author: Kamil Rytarowski 
Date:   Wed Aug 7 21:56:43 2019 +

Restrict the NetBSD ASan TSD fallback to !ASAN_DYNAMIC

The fallback to the alternative implementation of TSD with TLS
is only needed for the static version of ASan for NetBSD.

The same code cannot be reused for the dynamic version of ASan as
TLS breaks and TSD code works.

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@368219 
91177308-0d34-0410-b5e6-96231b3b80d8

commit 0bd9d23c4317d5d1c440e19892e178a29c9fe7be
Author: Kamil Rytarowski 
Date:   Thu Aug 8 02:21:44 2019 +

Sync ioctl(2) list with NetBSD 9.99.3

Register 36 new ioctl(2) calls.

Enable NVMM for amd64 as the API has been stabilized.

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@368247 
91177308-0d34-0410-b5e6-96231b3b80d8

commit 08d3c10606f09a4545487e9c3fad919ee396e3a6
Author: Tom Stellard 
Date:   Wed May 15 20:29:49 2019 +

Merging r360212:


r360212 | kamil | 2019-05-07 17:44:41 -0700 (Tue, 07 May 2019) | 6 lines

Fix build on NetBSD 8.99.38

With recent changes the dev/nvmm/nvmm_ioctl.h header is no longer
a standalone NVMM header. Disable it until the NVMM operations will
stabilize and be included in the ioctl(2) interceptors.



git-svn-id: 
https://llvm.org/svn/llvm-project/compiler-rt/branches/release_80@360811 
91177308-0d34-0410-b5e6-96231b3b80d8


To generate a diff of this commit:
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc
cvs rdiff -u -r1.1.1.1 -r1.2 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc
diff -u src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc:1.1.1.1 src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc:1.2
--- src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc:1.1.1.1	Tue Jan  8 05:40:28 2019
+++ src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc	Wed Aug 14 00:51:48 2019
@@ -40,8 +40,8 @@ void AsanOnDeadlySignal(int signo, void 
 
 // -- TSD  {{{1
 
-#if SANITIZER_NETBSD || SANITIZER_FREEBSD
-// Thread Static Data cannot be used in early init on NetBSD and FreeBSD.
+#if (SANITIZER_NETBSD && !ASAN_DYNAMIC) || SANITIZER_FREEBSD
+// Thread Static Data cannot be used in early static ASan init on NetBSD.
 // Reuse the Asan TSD API for compatibility with existing code
 // with an alternative implementation.
 

Index: src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
diff -u src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.1.1.1 src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.2
--- src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc:1.1.1.1	Tue Jan  8 05:40:29 2019
+++ src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc	Wed Aug 14 00:51:48 2019
@@ -25,7 +25,7 @@ struct ioctl_desc {
   const char *name;
 };
 
-const unsigned ioctl_table_max = 1202;
+const unsigned ioctl_table_max = 1236;
 static ioctl_desc ioctl_table[ioctl_table_max];
 static unsigned ioctl_table_size = 0;
 
@@ -298,9 +298,6 @@ static void ioctl_table_fill() {
   _(IRFRAMETTY_GET_DEVICE, WRITE, sizeof(unsigned int));
   _(IRFRAMETTY_GET_DONGLE, WRITE, sizeof(unsigned int));
   _(IRFRAMETTY_SET_DONGLE, READ, sizeof(unsigned int));
-  /* Entries from file: dev/isa/satlinkio.h */
-  _(SATIORESET, NONE, 0);
-  _(SATIOGID, WRITE,

CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2019-08-13 Thread Kamil Rytarowski 
Module Name:src
Committed By:   kamil
Date:   Wed Aug 14 00:51:48 UTC 2019

Modified Files:
src/sys/external/bsd/compiler_rt/dist/lib/asan: asan_posix.cc
src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common:
sanitizer_interceptors_ioctl_netbsd.inc
sanitizer_platform_limits_netbsd.cc
sanitizer_platform_limits_netbsd.h

Log Message:
Cherry-pick upstream compiler-rt patches for LLVM sanitizers

Upstream no longer accepts patches for LLVM-8, therefore pull needed changes 
downstream.

Enhancements:

 * resolved build failured with NetBSD 9.99.3
 * ioctl(2) lists are synced with NetBSD 9.99.3
 * fixes dynamic asan (-fsanitize=address -shared-libasa) crash on init

commit 092068cd7429659138d6779a3072298462ad3e9c
Author: Kamil Rytarowski 
Date:   Wed Aug 7 21:56:43 2019 +

Restrict the NetBSD ASan TSD fallback to !ASAN_DYNAMIC

The fallback to the alternative implementation of TSD with TLS
is only needed for the static version of ASan for NetBSD.

The same code cannot be reused for the dynamic version of ASan as
TLS breaks and TSD code works.

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@368219 
91177308-0d34-0410-b5e6-96231b3b80d8

commit 0bd9d23c4317d5d1c440e19892e178a29c9fe7be
Author: Kamil Rytarowski 
Date:   Thu Aug 8 02:21:44 2019 +

Sync ioctl(2) list with NetBSD 9.99.3

Register 36 new ioctl(2) calls.

Enable NVMM for amd64 as the API has been stabilized.

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@368247 
91177308-0d34-0410-b5e6-96231b3b80d8

commit 08d3c10606f09a4545487e9c3fad919ee396e3a6
Author: Tom Stellard 
Date:   Wed May 15 20:29:49 2019 +

Merging r360212:


r360212 | kamil | 2019-05-07 17:44:41 -0700 (Tue, 07 May 2019) | 6 lines

Fix build on NetBSD 8.99.38

With recent changes the dev/nvmm/nvmm_ioctl.h header is no longer
a standalone NVMM header. Disable it until the NVMM operations will
stabilize and be included in the ioctl(2) interceptors.



git-svn-id: 
https://llvm.org/svn/llvm-project/compiler-rt/branches/release_80@360811 
91177308-0d34-0410-b5e6-96231b3b80d8


To generate a diff of this commit:
cvs rdiff -u -r1.1.1.1 -r1.2 \
src/sys/external/bsd/compiler_rt/dist/lib/asan/asan_posix.cc
cvs rdiff -u -r1.1.1.1 -r1.2 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_interceptors_ioctl_netbsd.inc
 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
 \

src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Christos Zoulas 
In article 20140218222457.ga1...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:
On Tue, Feb 18, 2014 at 03:54:34PM -0500, Christos Zoulas wrote:
 Module Name: src
 Committed By:christos
 Date:Tue Feb 18 20:54:34 UTC 2014
 
 Modified Files:
  src/sys/external/bsd/compiler_rt/dist/lib: int_util.h
 
 Log Message:
 prefer __func__ instead of __FUNCTION__

Can we please avoid cosmetic local changes?

Do we want portable code or not? And if we can't improve the local code
what's the point of importing it?

christos

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Christos Zoulas 
In article 20140218222555.gb1...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:
On Tue, Feb 18, 2014 at 03:53:44PM -0500, Christos Zoulas wrote:
 Module Name: src
 Committed By:christos
 Date:Tue Feb 18 20:53:44 UTC 2014
 
 Modified Files:
  src/sys/external/bsd/compiler_rt/dist/lib: int_util.c
 
 Log Message:
 - include sys/cdefs.h for compiler definitions
 - add a lint comment

Please revert this, it doesn't add value and it makes it harder to deal
with prestine upstream. More importantly, please bring up such changes
upstream first.

What's the upstream? In this particular case we depend on sys/cdefs.h
to define __attribute__() and other extensions properly for compilers
that don't have it. How else do you propose to fix it? Or are you saying
everything needs to support all the gcc/clang extensions?

christos

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Joerg Sonnenberger 
On Wed, Feb 19, 2014 at 03:52:58PM +, Christos Zoulas wrote:
 In article 20140218222555.gb1...@britannica.bec.de,
 Joerg Sonnenberger  jo...@britannica.bec.de wrote:
 On Tue, Feb 18, 2014 at 03:53:44PM -0500, Christos Zoulas wrote:
  Module Name:   src
  Committed By:  christos
  Date:  Tue Feb 18 20:53:44 UTC 2014
  
  Modified Files:
 src/sys/external/bsd/compiler_rt/dist/lib: int_util.c
  
  Log Message:
  - include sys/cdefs.h for compiler definitions
  - add a lint comment
 
 Please revert this, it doesn't add value and it makes it harder to deal
 with prestine upstream. More importantly, please bring up such changes
 upstream first.
 
 What's the upstream? In this particular case we depend on sys/cdefs.h
 to define __attribute__() and other extensions properly for compilers
 that don't have it. How else do you propose to fix it? Or are you saying
 everything needs to support all the gcc/clang extensions?

What mysterious compilers are you talking about?

Joerg

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Joerg Sonnenberger 
On Wed, Feb 19, 2014 at 03:50:03PM +, Christos Zoulas wrote:
 In article 20140218222457.ga1...@britannica.bec.de,
 Joerg Sonnenberger  jo...@britannica.bec.de wrote:
 On Tue, Feb 18, 2014 at 03:54:34PM -0500, Christos Zoulas wrote:
  Module Name:   src
  Committed By:  christos
  Date:  Tue Feb 18 20:54:34 UTC 2014
  
  Modified Files:
 src/sys/external/bsd/compiler_rt/dist/lib: int_util.h
  
  Log Message:
  prefer __func__ instead of __FUNCTION__
 
 Can we please avoid cosmetic local changes?
 
 Do we want portable code or not? And if we can't improve the local code
 what's the point of importing it?

I have no problem with going over the code in the upstream repository,
but I have a problem with adding pointless local changes. They just
increase the cost of maintainance for absolute no good reason.

Joerg

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Christos Zoulas 
In article 20140219205453.gb22...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:

I have no problem with going over the code in the upstream repository,
but I have a problem with adding pointless local changes. They just
increase the cost of maintainance for absolute no good reason.

There is a semantic difference here between the two, aside from __FUNCTION__
not being in any standard. Do you think that the change is controvercial?

christos

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-19 Thread Matt Thomas 

On Feb 19, 2014, at 2:40 PM, Christos Zoulas chris...@astron.com wrote:

 In article 20140219205453.gb22...@britannica.bec.de,
 Joerg Sonnenberger  jo...@britannica.bec.de wrote:
 
 I have no problem with going over the code in the upstream repository,
 but I have a problem with adding pointless local changes. They just
 increase the cost of maintainance for absolute no good reason.
 
 There is a semantic difference here between the two, aside from __FUNCTION__
 not being in any standard. Do you think that the change is controvercial?

I've held off on committing local changes and worked with Joerg to feed
things upstream first.  It's been fairly painless.

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-18 Thread Joerg Sonnenberger 
On Tue, Feb 18, 2014 at 03:54:34PM -0500, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Tue Feb 18 20:54:34 UTC 2014
 
 Modified Files:
   src/sys/external/bsd/compiler_rt/dist/lib: int_util.h
 
 Log Message:
 prefer __func__ instead of __FUNCTION__

Can we please avoid cosmetic local changes?

Joerg

Re: CVS commit: src/sys/external/bsd/compiler_rt/dist/lib

2014-02-18 Thread Joerg Sonnenberger 
On Tue, Feb 18, 2014 at 03:53:44PM -0500, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Tue Feb 18 20:53:44 UTC 2014
 
 Modified Files:
   src/sys/external/bsd/compiler_rt/dist/lib: int_util.c
 
 Log Message:
 - include sys/cdefs.h for compiler definitions
 - add a lint comment

Please revert this, it doesn't add value and it makes it harder to deal
with prestine upstream. More importantly, please bring up such changes
upstream first.

Joerg