CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: christos Date: Tue Jun 18 01:40:29 UTC 2019 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: Add QUOTA define To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src
Committed By: christos
Date: Tue Jun 18 01:40:29 UTC 2019
Modified Files:
src/sys/modules/compat_netbsd32: Makefile
Log Message:
Add QUOTA define
To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/modules/compat_netbsd32/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/modules/compat_netbsd32/Makefile
diff -u src/sys/modules/compat_netbsd32/Makefile:1.24 src/sys/modules/compat_netbsd32/Makefile:1.25
--- src/sys/modules/compat_netbsd32/Makefile:1.24 Fri Mar 22 23:04:57 2019
+++ src/sys/modules/compat_netbsd32/Makefile Mon Jun 17 21:40:29 2019
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.24 2019/03/23 03:04:57 pgoyette Exp $
+# $NetBSD: Makefile,v 1.25 2019/06/18 01:40:29 christos Exp $
.include "../Makefile.inc"
.include "../Makefile.assym"
@@ -8,7 +8,7 @@ KMOD= compat_netbsd32
CPPFLAGS+= -DCOMPAT_NETBSD32
CPPFLAGS+= -DEXEC_ELF32 -DEXEC_ELF64
CPPFLAGS+= -DCOREDUMP -DNTP -DVMSWAP
-CPPFLAGS+= -DKTRACE -DMODULAR
+CPPFLAGS+= -DKTRACE -DMODULAR -DQUOTA
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/libnv/dist
.PATH: ${S}/compat/netbsd32
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: christos Date: Tue Aug 20 09:36:41 UTC 2019 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: Add netbsd32 drm support from Surya Shankar at GSoC 2019 To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src
Committed By: christos
Date: Tue Aug 20 09:36:41 UTC 2019
Modified Files:
src/sys/modules/compat_netbsd32: Makefile
Log Message:
Add netbsd32 drm support from Surya Shankar at GSoC 2019
To generate a diff of this commit:
cvs rdiff -u -r1.25 -r1.26 src/sys/modules/compat_netbsd32/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/modules/compat_netbsd32/Makefile
diff -u src/sys/modules/compat_netbsd32/Makefile:1.25 src/sys/modules/compat_netbsd32/Makefile:1.26
--- src/sys/modules/compat_netbsd32/Makefile:1.25 Mon Jun 17 21:40:29 2019
+++ src/sys/modules/compat_netbsd32/Makefile Tue Aug 20 05:36:40 2019
@@ -1,17 +1,33 @@
-# $NetBSD: Makefile,v 1.25 2019/06/18 01:40:29 christos Exp $
+# $NetBSD: Makefile,v 1.26 2019/08/20 09:36:40 christos Exp $
.include "../Makefile.inc"
.include "../Makefile.assym"
KMOD= compat_netbsd32
+.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
+NETBSD32_DRMKMS?=yes
+.endif
+
CPPFLAGS+= -DCOMPAT_NETBSD32
CPPFLAGS+= -DEXEC_ELF32 -DEXEC_ELF64
CPPFLAGS+= -DCOREDUMP -DNTP -DVMSWAP
CPPFLAGS+= -DKTRACE -DMODULAR -DQUOTA
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/libnv/dist
+.if ${NETBSD32_DRMKMS:Uno} == "yes"
+CPPFLAGS+= -DNETBSD32_DRMKMS
+CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/common/include
+CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/include
+CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/dist
+CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/dist/include
+CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/dist/uapi
+.endif
+
.PATH: ${S}/compat/netbsd32
+.if ${NETBSD32_DRMKMS:Uno} == "yes"
+SRCS+= netbsd32_drm.c
+.endif
SRCS+= netbsd32_core.c netbsd32_event.c
SRCS+= netbsd32_exec_elf32.c netbsd32_execve.c
SRCS+= netbsd32_fd.c netbsd32_fs.c
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src
Committed By: christos
Date: Sat Sep 28 15:15:09 UTC 2019
Modified Files:
src/sys/modules/compat_netbsd32: Makefile
Log Message:
Disable NETBSD32_DRMKMS by not using it, but keep compiling it.
To generate a diff of this commit:
cvs rdiff -u -r1.28 -r1.29 src/sys/modules/compat_netbsd32/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/modules/compat_netbsd32/Makefile
diff -u src/sys/modules/compat_netbsd32/Makefile:1.28 src/sys/modules/compat_netbsd32/Makefile:1.29
--- src/sys/modules/compat_netbsd32/Makefile:1.28 Wed Sep 25 22:01:02 2019
+++ src/sys/modules/compat_netbsd32/Makefile Sat Sep 28 11:15:09 2019
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.28 2019/09/26 02:01:02 christos Exp $
+# $NetBSD: Makefile,v 1.29 2019/09/28 15:15:09 christos Exp $
.include "../Makefile.inc"
.include "../Makefile.assym"
@@ -6,7 +6,7 @@
KMOD= compat_netbsd32
.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
-#NETBSD32_DRMKMS?=yes
+NETBSD32_DRMKMS?=yes
.endif
CPPFLAGS+= -DCOMPAT_NETBSD32
@@ -16,7 +16,8 @@ CPPFLAGS+= -DKTRACE -DMODULAR -DQUOTA
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/libnv/dist
.if ${NETBSD32_DRMKMS:Uno} == "yes"
-CPPFLAGS+= -DNETBSD32_DRMKMS
+# disable for now
+#CPPFLAGS+= -DNETBSD32_DRMKMS
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/common/include
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/include
CPPFLAGS+= -I${NETBSDSRCDIR}/sys/external/bsd/drm2/dist
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: christos Date: Sat Sep 28 15:15:09 UTC 2019 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: Disable NETBSD32_DRMKMS by not using it, but keep compiling it. To generate a diff of this commit: cvs rdiff -u -r1.28 -r1.29 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src Committed By: christos Date: Wed Aug 30 12:18:59 UTC 2023 Modified Files: src/sys/modules/compat_netbsd32: Makefile Log Message: Add missing netbsd32_epoll.c To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/sys/modules/compat_netbsd32/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/modules/compat_netbsd32
Module Name:src
Committed By: christos
Date: Wed Aug 30 12:18:59 UTC 2023
Modified Files:
src/sys/modules/compat_netbsd32: Makefile
Log Message:
Add missing netbsd32_epoll.c
To generate a diff of this commit:
cvs rdiff -u -r1.37 -r1.38 src/sys/modules/compat_netbsd32/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/modules/compat_netbsd32/Makefile
diff -u src/sys/modules/compat_netbsd32/Makefile:1.37 src/sys/modules/compat_netbsd32/Makefile:1.38
--- src/sys/modules/compat_netbsd32/Makefile:1.37 Sat Nov 7 16:42:32 2020
+++ src/sys/modules/compat_netbsd32/Makefile Wed Aug 30 08:18:59 2023
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.37 2020/11/07 21:42:32 christos Exp $
+# $NetBSD: Makefile,v 1.38 2023/08/30 12:18:59 christos Exp $
.include "../Makefile.inc"
.include "../Makefile.assym"
@@ -30,6 +30,7 @@ CPPFLAGS+= -I${NETBSDSRCDIR}/sys/externa
SRCS+= netbsd32_drm.c
.endif
SRCS+= netbsd32_acl.c netbsd32_event.c
+SRCS+= netbsd32_epoll.c
SRCS+= netbsd32_exec_elf32.c netbsd32_execve.c
SRCS+= netbsd32_fd.c netbsd32_fs.c
SRCS+= netbsd32_futex.c
Re: CVS commit: src/sys/modules/compat_netbsd32
Good news everyone. Does not affect any release at all.
Also might not have been a security issue, because christos did a weird
thing where it is compiled but somehow still disabled.
On Sun, Apr 19, 2020 at 05:40:50PM +, Maya Rashish wrote:
> Module Name: src
> Committed By: maya
> Date: Sun Apr 19 17:40:50 UTC 2020
>
> Modified Files:
> src/sys/modules/compat_netbsd32: Makefile
>
> Log Message:
> Turn off compat drm.
> XXX issue security advisory
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.32 -r1.33 src/sys/modules/compat_netbsd32/Makefile
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: src/sys/modules/compat_netbsd32/Makefile
> diff -u src/sys/modules/compat_netbsd32/Makefile:1.32
> src/sys/modules/compat_netbsd32/Makefile:1.33
> --- src/sys/modules/compat_netbsd32/Makefile:1.32 Thu Mar 12 15:02:29 2020
> +++ src/sys/modules/compat_netbsd32/Makefile Sun Apr 19 17:40:49 2020
> @@ -1,13 +1,13 @@
> -#$NetBSD: Makefile,v 1.32 2020/03/12 15:02:29 pgoyette Exp $
> +#$NetBSD: Makefile,v 1.33 2020/04/19 17:40:49 maya Exp $
>
> .include "../Makefile.inc"
> .include "../Makefile.assym"
>
> KMOD=compat_netbsd32
>
> -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
> -NETBSD32_DRMKMS?=yes
> -.endif
> +#.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
> +#NETBSD32_DRMKMS?=yes
> +#.endif
>
> CPPFLAGS+= -DCOMPAT_NETBSD32
> CPPFLAGS+= -DEXEC_ELF32 -DEXEC_ELF64
>
Re: CVS commit: src/sys/modules/compat_netbsd32
I almost got a heart attack between your first email and your second one,
wondering how this code got re-enabled. Thanks for clarifying.
Relevant example, by the way.
Committed on August 20th 2019 at 09:32
https://mail-index.netbsd.org/source-changes/2019/08/20/msg108321.html
Disabled by me the same day at 12:25
https://mail-index.netbsd.org/source-changes/2019/08/20/msg108332.html
No rocket science here, I just saw that the code qualified as close to
structurally deficient, and went ahead. In case you people are wondering,
I think I did it with strictly no discussion.
Unsurprisingly, it looks like it has saved us a lot of trouble here.
This is what sane policy looks like.
Le 19/04/2020 à 19:58, m...@netbsd.org a écrit :
> Good news everyone. Does not affect any release at all.
> Also might not have been a security issue, because christos did a weird
> thing where it is compiled but somehow still disabled.
>
> On Sun, Apr 19, 2020 at 05:40:50PM +, Maya Rashish wrote:
>> Module Name: src
>> Committed By:maya
>> Date:Sun Apr 19 17:40:50 UTC 2020
>>
>> Modified Files:
>> src/sys/modules/compat_netbsd32: Makefile
>>
>> Log Message:
>> Turn off compat drm.
>> XXX issue security advisory
>>
>>
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.32 -r1.33 src/sys/modules/compat_netbsd32/Makefile
>>
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>>
>
>> Modified files:
>>
>> Index: src/sys/modules/compat_netbsd32/Makefile
>> diff -u src/sys/modules/compat_netbsd32/Makefile:1.32
>> src/sys/modules/compat_netbsd32/Makefile:1.33
>> --- src/sys/modules/compat_netbsd32/Makefile:1.32Thu Mar 12 15:02:29 2020
>> +++ src/sys/modules/compat_netbsd32/Makefile Sun Apr 19 17:40:49 2020
>> @@ -1,13 +1,13 @@
>> -# $NetBSD: Makefile,v 1.32 2020/03/12 15:02:29 pgoyette Exp $
>> +# $NetBSD: Makefile,v 1.33 2020/04/19 17:40:49 maya Exp $
>>
>> .include "../Makefile.inc"
>> .include "../Makefile.assym"
>>
>> KMOD= compat_netbsd32
>>
>> -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
>> -NETBSD32_DRMKMS?=yes
>> -.endif
>> +#.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "x86_64"
>> +#NETBSD32_DRMKMS?=yes
>> +#.endif
>>
>> CPPFLAGS+= -DCOMPAT_NETBSD32
>> CPPFLAGS+= -DEXEC_ELF32 -DEXEC_ELF64
