Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-19 Thread Jason Thorpe


> On Aug 18, 2018, at 5:02 PM, Rin Okuyama  wrote:
> 
> (1) rename majors.arm32 to majors.arm
> (2) remove majors.aarch64
> (3) make everyone include majors.arm
> 
> I will commit if there's no objection.


Correct.  Thank you for making this change.

-- thorpej



Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-19 Thread Christos Zoulas
In article <27877.1534674...@splode.eterna.com.au>,
matthew green   wrote:
>> OK. I will leave it as is for now. Please let me know if you
>> remember the problems.
>
>try, and see? :-)
>
>if nothing else, please make them the same now, and add large
>SHOUTING COMMENTS at the top to keep them in sync.

Yes, please make them the same and whatever break we will fix.

christos



re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-19 Thread matthew green
> OK. I will leave it as is for now. Please let me know if you
> remember the problems.

try, and see? :-)

if nothing else, please make them the same now, and add large
SHOUTING COMMENTS at the top to keep them in sync.

thanks.


.mrg.


Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-19 Thread Rin Okuyama

On 2018/08/19 14:33, Nick Hudson wrote:
...

On 19/08/2018 01:02, Rin Okuyama wrote:

It seems harmless to add these devices in majors.aarch64. Therefore,
I propose:

(1) rename majors.arm32 to majors.arm
(2) remove majors.aarch64
(3) make everyone include majors.arm

I will commit if there's no objection.

...

I support the goal of a single majors file for both arm and aarch64, but when I 
tried to do this I found problems in MAKEDEV generation or similar.  I forget 
the exact details.


OK. I will leave it as is for now. Please let me know if you
remember the problems.

Thanks,
rin


Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-18 Thread Nick Hudson

On 19/08/2018 01:02, Rin Okuyama wrote:

Oops, I forgot to CC to source-changes-d@.


[snip]


On 2018/08/19 3:48, matthew green wrote:

can't we make arm and arm64 use the identical majors file?

please!


Diff between majors.arm32 and aarch64 reads


[snip]



- ctcom was added by matt@ back in 2014, but no one uses it now
- vchiq is a device of RPI, not still supported in aarch64 mode
- zynquart is a device of Xilinx Zynq boards, whose 64bit models are
   not currently supported

It seems harmless to add these devices in majors.aarch64. Therefore,
I propose:

(1) rename majors.arm32 to majors.arm
(2) remove majors.aarch64
(3) make everyone include majors.arm

I will commit if there's no objection.

rin



I support the goal of a single majors file for both arm and aarch64, but 
when I tried to do this I found problems in MAKEDEV generation or 
similar.  I forget the exact details.


Nick


Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-18 Thread Rin Okuyama

Oops, I forgot to CC to source-changes-d@.

 Forwarded Message 
Subject: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: 
src/sys/arch/evbarm/conf)
To: matthew green 
Cc: Jared McNeill , Nick Hudson , Ryo 
Shimizu 
From: Rin Okuyama 
Date: Sun, 19 Aug 2018 08:57:53 +0900

On 2018/08/19 3:48, matthew green wrote:

can't we make arm and arm64 use the identical majors file?

please!


Diff between majors.arm32 and aarch64 reads


--- arm/conf/majors.arm32   2015-04-24 08:22:51.0 +0900
+++ aarch64/conf/majors.aarch64 2015-04-24 08:22:51.0 +0900
@@ -1,4 +1,4 @@
-#  $NetBSD: majors.arm32,v 1.37 2015/04/23 23:22:51 pgoyette Exp $
+# $NetBSD: majors.aarch64,v 1.2 2015/04/23 23:22:51 pgoyette Exp $
 #
 # Device majors for arm32
 #
@@ -91,7 +91,6 @@
 device-major   irframe char 95 irframedrv
 device-major   cir char 96 cir
 device-major   radio   char 97 radio
-device-major   ctcom   char 98 ctcom
 device-major   kttcp   char 99 kttcp
 device-major   ixpcom  char 100ixpcom
 device-major   sysmon  char 101sysmon
@@ -105,8 +104,7 @@
 device-major   tslcd   char 108tslcd
 device-major   twe char 109twe
 device-major   nsmbchar 110nsmb
-device-major   vchiq   char 111vchiq
-device-major   zynquartchar 112zynquart
+#device-major  vchiq   char 111vchiq

 # Majors up to 143 are reserved for machine-dependent drivers.
 # New machine-independent driver majors are assigned in


- ctcom was added by matt@ back in 2014, but no one uses it now
- vchiq is a device of RPI, not still supported in aarch64 mode
- zynquart is a device of Xilinx Zynq boards, whose 64bit models are
  not currently supported

It seems harmless to add these devices in majors.aarch64. Therefore,
I propose:

(1) rename majors.arm32 to majors.arm
(2) remove majors.aarch64
(3) make everyone include majors.arm

I will commit if there's no objection.

rin