Re: CVS commit: src/etc/mtree

2020-09-30 Thread Roy Marples

On 30/09/2020 08:55, matthew green wrote:

Module Name:src
Committed By:   mrg
Date:   Wed Sep 30 07:55:31 UTC 2020

Modified Files:
src/etc/mtree: NetBSD.dist.tests

Log Message:
add missing new if_vether subdir.


Thanks!


Re: CVS commit: src/etc/mtree

2017-10-21 Thread Jared McNeill

On Sat, 21 Oct 2017, Robert Elz wrote:


Log Message:
Create directory for new bwfm firmware to be installed into.


Thank you!


re: CVS commit: src/etc/mtree

2015-08-12 Thread matthew green
Takeshi Nakayama writes:
 Module Name:  src
 Committed By: nakayama
 Date: Wed Aug 12 21:55:05 UTC 2015
 
 Modified Files:
   src/etc/mtree: NetBSD.dist.base
 
 Log Message:
 Remove obsolete directory ./usr/include/gcc-4.5

thanks.  i meant to do this.

and thanks for fixing the sparc builds.


.mrg.


Re: CVS commit: src/etc/mtree

2015-06-28 Thread Joerg Sonnenberger
On Sun, Jun 28, 2015 at 09:28:46AM +, Martin Husemann wrote:
 Module Name:  src
 Committed By: martin
 Date: Sun Jun 28 09:28:46 UTC 2015
 
 Modified Files:
   src/etc/mtree: Makefile
 
 Log Message:
 Guard a few $MK... != no tests by an additional defined(MK...) clause
 and make the emit_dist_file target depend on EXTRA_DIST_FILES.
 Part of fixing PR toolchain/50004.

Please use :U for those.

Joerg


Re: CVS commit: src/etc/mtree

2013-08-21 Thread Joerg Sonnenberger
On Wed, Aug 21, 2013 at 08:52:45PM +, Matthias Scheler wrote:
 Module Name:  src
 Committed By: tron
 Date: Wed Aug 21 20:52:45 UTC 2013
 
 Modified Files:
   src/etc/mtree: NetBSD.dist.base
 
 Log Message:
 Remove more obsolete directories:
 - /usr/include/gcc-4.1

This is not true, i.e. vax still uses GCC 4.1.

Joerg


Re: CVS commit: src/etc/mtree

2012-04-13 Thread Jukka Ruohonen
On Sat, Apr 14, 2012 at 12:14:22AM +, Paul Goyette wrote:
 Module Name:  src
 Committed By: pgoyette
 Date: Sat Apr 14 00:14:22 UTC 2012
 
 Modified Files:
   src/etc/mtree: NetBSD.dist.tests
 
 Log Message:
 Create the directory for the helper program; hopefully fixes the build
 break.
 
 XXX It's odd that k_helper3 needs to have its directory pre-created, when
 XXX k_helper, k_helper2, and k_uvm don't need it...

Thanks for fixing this. I was (also) kind of lost with the src/tests/modules 
build mechanisms...

- Jukka.


Re: CVS commit: src/etc/mtree

2011-09-11 Thread Alan Barrett

On Tue, 06 Sep 2011, Alan Barrett wrote:

On Tue, 06 Sep 2011, Christos Zoulas wrote:
We definitely don't want to add such magic. Please revert. Otherwise 
we should go and do this in 100's of Makefiles.


I have an idea for letting make cleandir deal with this problem,
and may be willing to revert if that works out.


I have committed the changes to make cleandir, and reverted the
change to etc/mtee/Makefile.

--apb (Alan Barrett)


Re: CVS commit: src/etc/mtree

2011-09-11 Thread Christos Zoulas
In article 2011091027.gb...@apb-laptoy.apb.alt.za,
Alan Barrett  a...@cequrux.com wrote:
On Tue, 06 Sep 2011, Alan Barrett wrote:
On Tue, 06 Sep 2011, Christos Zoulas wrote:
We definitely don't want to add such magic. Please revert. Otherwise 
we should go and do this in 100's of Makefiles.

I have an idea for letting make cleandir deal with this problem,
and may be willing to revert if that works out.

I have committed the changes to make cleandir, and reverted the
change to etc/mtee/Makefile.

Thanks!

christos



Re: CVS commit: src/etc/mtree

2011-09-07 Thread David Holland
On Tue, Sep 06, 2011 at 02:53:58PM +0400, Valeriy E. Ushakov wrote:
  Are you saying you are going to add a special case for each foo.o file
  each time an accidental non-objdir build left foo.o in src? (and no,
  that's not a rhetoric question).

The fundamental problem is that the make library finds files by
implicit path searches (of various kinds) which is inherently wobbly
no matter how many bandaids are applied.

The robust approach is to change the makefiles to do

.for S in $(SRCS:M*.c)
$(OBJDIR)/$(S:T:R).o: $(S)
$(COMPILE.c) $(S) -o $(.TARGET)
.endfor

and forget about make's builtin objdir hackery entirely. Unfortunately
there are many reasons why this is not a trivial undertaking...

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/etc/mtree

2011-09-07 Thread David Laight
On Wed, Sep 07, 2011 at 08:13:20AM +, David Holland wrote:
 
 The fundamental problem is that the make library finds files by
 implicit path searches (of various kinds) which is inherently wobbly
 no matter how many bandaids are applied.

Especially in large items like libc andthe kernel...

 The robust approach is to change the makefiles to do
 
 .for S in $(SRCS:M*.c)
 $(OBJDIR)/$(S:T:R).o: $(S)
   $(COMPILE.c) $(S) -o $(.TARGET)
 .endfor

I tried to do that (without the actual commands) just to force
the .o file to depend on the relevant .c .S (or .cpp) file.
It would save make doing a lot of stat() calls searching for
the source - and always get the right one when, for example,
libc has a .S file that you don't want.

Unfortunately it all exploded due to the way lex and yacc
generate stuff.

In my case I was still using the commands from the suffix rule.

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/etc/mtree

2011-09-06 Thread Iain Hibbert
On Mon, 5 Sep 2011, Valeriy E. Ushakov wrote:

 On Mon, Sep 05, 2011 at 15:13:49 +0100, Iain Hibbert wrote:

  On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:
 
   On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
Module Name:src
Committed By:   apb
Date:   Mon Sep  5 09:57:02 UTC 2011
   
Modified Files:
src/etc/mtree: Makefile
   
Log Message:
Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
This fixes a problem in which NetBSD.dist.tmp had been created in
the SRCDIR by an earlier build (performed without an OBJDIR), and
the existence of the file in the SRCDIR confused a subsequent build
(performed with an OBJDIR).
  
   Do we really want to add special cases like this? There are all kinds of
   mysterious errors triggered by unclean SRCDIR, I don't think it is worth
   adding this specific hack.
 
  IMO these cases are worth handling just because if an OBJDIR is specified,
  it should be used. The alternative being that the OBJDIR is used
  sometimes?  Thats just wrong..

 So whay do you treat NetBSD.dist.tmp and NetBSD.dist differently then?

Well, I don't know but ${.OBJDIR}/NetBSD.dist is already referenced in
that file?

 If you go down that path, where do you stop?

You can sleep when you have a system that works as expected, not one that
fails with mysterious errors because even though you told it to use an
OBJDIR for work files, it was confused by some it found elsewhere. As
noted, most of this is handled invisibly by the make framework, but some
of it needs to be manually handled. I guess people fix things as they
notice them..

iain


Re: CVS commit: src/etc/mtree

2011-09-06 Thread Valeriy E. Ushakov
On Tue, Sep 06, 2011 at 08:43:10 +0100, Iain Hibbert wrote:

 On Mon, 5 Sep 2011, Valeriy E. Ushakov wrote:
 
  On Mon, Sep 05, 2011 at 15:13:49 +0100, Iain Hibbert wrote:
 
   On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:
  
On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
 Module Name:  src
 Committed By: apb
 Date: Mon Sep  5 09:57:02 UTC 2011

 Modified Files:
   src/etc/mtree: Makefile

 Log Message:
 Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
 This fixes a problem in which NetBSD.dist.tmp had been created in
 the SRCDIR by an earlier build (performed without an OBJDIR), and
 the existence of the file in the SRCDIR confused a subsequent build
 (performed with an OBJDIR).
   
Do we really want to add special cases like this? There are all kinds of
mysterious errors triggered by unclean SRCDIR, I don't think it is worth
adding this specific hack.
  
   IMO these cases are worth handling just because if an OBJDIR is specified,
   it should be used. The alternative being that the OBJDIR is used
   sometimes?  Thats just wrong..
 
  So whay do you treat NetBSD.dist.tmp and NetBSD.dist differently then?
 
 Well, I don't know but ${.OBJDIR}/NetBSD.dist is already referenced in
 that file?
 
  If you go down that path, where do you stop?
 
 You can sleep when you have a system that works as expected, not one that
 fails with mysterious errors because even though you told it to use an
 OBJDIR for work files, it was confused by some it found elsewhere. As
 noted, most of this is handled invisibly by the make framework, but some
 of it needs to be manually handled. I guess people fix things as they
 notice them..

Are you saying you are going to add a special case for each foo.o file
each time an accidental non-objdir build left foo.o in src? (and no,
that's not a rhetoric question).

-uwe


Re: CVS commit: src/etc/mtree

2011-09-06 Thread Christos Zoulas
In article 20110905111014.gb12...@britannica.bec.de,
Joerg Sonnenberger  jo...@britannica.bec.de wrote:
On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
 Module Name: src
 Committed By:apb
 Date:Mon Sep  5 09:57:02 UTC 2011
 
 Modified Files:
  src/etc/mtree: Makefile
 
 Log Message:
 Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
 This fixes a problem in which NetBSD.dist.tmp had been created in
 the SRCDIR by an earlier build (performed without an OBJDIR), and
 the existence of the file in the SRCDIR confused a subsequent build
 (performed with an OBJDIR).

Do we really want to add special cases like this? There are all kinds of
mysterious errors triggered by unclean SRCDIR, I don't think it is worth
adding this specific hack.

We definitely don't want to add such magic. Please revert. Otherwise we should
go and do this in 100's of Makefiles.

christos



Re: CVS commit: src/etc/mtree

2011-09-06 Thread Alan Barrett

On Tue, 06 Sep 2011, Christos Zoulas wrote:

Modified Files:
src/etc/mtree: Makefile

Log Message:
Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
This fixes a problem in which NetBSD.dist.tmp had been created in
the SRCDIR by an earlier build (performed without an OBJDIR), and
the existence of the file in the SRCDIR confused a subsequent build
(performed with an OBJDIR).


We definitely don't want to add such magic. Please 
revert. Otherwise we should go and do this in 100's of 
Makefiles.


I certainly see no reason to make similar changes in hundreds of 
Makefiles; only in the few places where people actually encounter 
(and report) problems traceable to this sort of issue.  There have 
been only a few such issues, and we have fixed all the others 
(elsewhere under src/etc).


I have an idea for letting make cleandir deal with this problem,
and may be willing to revert if that works out.

--apb (Alan Barrett)


Re: CVS commit: src/etc/mtree

2011-09-06 Thread Iain Hibbert
On Tue, 6 Sep 2011, Valeriy E. Ushakov wrote:

 On Tue, Sep 06, 2011 at 08:43:10 +0100, Iain Hibbert wrote:

  On Mon, 5 Sep 2011, Valeriy E. Ushakov wrote:
 
   On Mon, Sep 05, 2011 at 15:13:49 +0100, Iain Hibbert wrote:
  
On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:
   
 On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
  Module Name:src
  Committed By:   apb
  Date:   Mon Sep  5 09:57:02 UTC 2011
 
  Modified Files:
  src/etc/mtree: Makefile
 
  Log Message:
  Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
  This fixes a problem in which NetBSD.dist.tmp had been created in
  the SRCDIR by an earlier build (performed without an OBJDIR), and
  the existence of the file in the SRCDIR confused a subsequent build
  (performed with an OBJDIR).

 Do we really want to add special cases like this? There are all kinds 
 of
 mysterious errors triggered by unclean SRCDIR, I don't think it is 
 worth
 adding this specific hack.
   
IMO these cases are worth handling just because if an OBJDIR is 
specified,
it should be used. The alternative being that the OBJDIR is used
sometimes?  Thats just wrong..
  
   So whay do you treat NetBSD.dist.tmp and NetBSD.dist differently then?
 
  Well, I don't know but ${.OBJDIR}/NetBSD.dist is already referenced in
  that file?
 
   If you go down that path, where do you stop?
 
  You can sleep when you have a system that works as expected, not one that
  fails with mysterious errors because even though you told it to use an
  OBJDIR for work files, it was confused by some it found elsewhere. As
  noted, most of this is handled invisibly by the make framework, but some
  of it needs to be manually handled. I guess people fix things as they
  notice them..

 Are you saying you are going to add a special case for each foo.o file
 each time an accidental non-objdir build left foo.o in src? (and no,
 that's not a rhetoric question).

clearly not, since the foo.o files are already handled by a general case

iain


Re: CVS commit: src/etc/mtree

2011-09-05 Thread Joerg Sonnenberger
On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
 Module Name:  src
 Committed By: apb
 Date: Mon Sep  5 09:57:02 UTC 2011
 
 Modified Files:
   src/etc/mtree: Makefile
 
 Log Message:
 Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
 This fixes a problem in which NetBSD.dist.tmp had been created in
 the SRCDIR by an earlier build (performed without an OBJDIR), and
 the existence of the file in the SRCDIR confused a subsequent build
 (performed with an OBJDIR).

Do we really want to add special cases like this? There are all kinds of
mysterious errors triggered by unclean SRCDIR, I don't think it is worth
adding this specific hack.

Joerg


Re: CVS commit: src/etc/mtree

2011-09-05 Thread Alan Barrett

On Mon, 05 Sep 2011, Joerg Sonnenberger wrote:

On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:

Modified Files:
src/etc/mtree: Makefile

Log Message:
Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.


Do we really want to add special cases like this? There are all 
kinds of mysterious errors triggered by unclean SRCDIR, I don't 
think it is worth adding this specific hack.


I am not sure.  We have done this sort of thing before, for other 
files under src/etc, and I think it's reasonable to treat src/etc 
differently from the rest of the source tree because etcupdate and 
postinstall may run make in src/etc without the user being aware 
that their source directory is being polluted.


On the other hand, if we can get postinstall and etcupdate to run 
make clean afterwards, then I'd be happier for this and similar 
special cases to be removed.


--apb (Alan Barrett)


Re: CVS commit: src/etc/mtree

2011-09-05 Thread Iain Hibbert
On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:

 On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
  Module Name:src
  Committed By:   apb
  Date:   Mon Sep  5 09:57:02 UTC 2011
 
  Modified Files:
  src/etc/mtree: Makefile
 
  Log Message:
  Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
  This fixes a problem in which NetBSD.dist.tmp had been created in
  the SRCDIR by an earlier build (performed without an OBJDIR), and
  the existence of the file in the SRCDIR confused a subsequent build
  (performed with an OBJDIR).

 Do we really want to add special cases like this? There are all kinds of
 mysterious errors triggered by unclean SRCDIR, I don't think it is worth
 adding this specific hack.

IMO these cases are worth handling just because if an OBJDIR is specified,
it should be used. The alternative being that the OBJDIR is used
sometimes?  Thats just wrong..

iain


Re: CVS commit: src/etc/mtree

2011-09-05 Thread Valeriy E. Ushakov
On Mon, Sep 05, 2011 at 15:13:49 +0100, Iain Hibbert wrote:

 On Mon, 5 Sep 2011, Joerg Sonnenberger wrote:
 
  On Mon, Sep 05, 2011 at 09:57:02AM +, Alan Barrett wrote:
   Module Name:  src
   Committed By: apb
   Date: Mon Sep  5 09:57:02 UTC 2011
  
   Modified Files:
 src/etc/mtree: Makefile
  
   Log Message:
   Use ${.OBJDIR}/NetBSD.dist.tmp instead of just NetBSD.dist.tmp.
   This fixes a problem in which NetBSD.dist.tmp had been created in
   the SRCDIR by an earlier build (performed without an OBJDIR), and
   the existence of the file in the SRCDIR confused a subsequent build
   (performed with an OBJDIR).
 
  Do we really want to add special cases like this? There are all kinds of
  mysterious errors triggered by unclean SRCDIR, I don't think it is worth
  adding this specific hack.
 
 IMO these cases are worth handling just because if an OBJDIR is specified,
 it should be used. The alternative being that the OBJDIR is used
 sometimes?  Thats just wrong..

So whay do you treat NetBSD.dist.tmp and NetBSD.dist differently then?
If you go down that path, where do you stop?

-uwe


Re: CVS commit: src/etc/mtree

2011-09-05 Thread David Laight
On Mon, Sep 05, 2011 at 03:13:49PM +0100, Iain Hibbert wrote:
 
 IMO these cases are worth handling just because if an OBJDIR is specified,
 it should be used. The alternative being that the OBJDIR is used
 sometimes?  Thats just wrong..

A lot of the OBJDIR support happens by magic in make.
Mostly make will look for files in SRCDIR before OBJDIR.

David

-- 
David Laight: da...@l8s.co.uk


Re: CVS commit: src/etc/mtree

2011-01-10 Thread David Young
On Mon, Jan 10, 2011 at 05:17:37PM +, Nicolas Joly wrote:
 Module Name:  src
 Committed By: njoly
 Date: Mon Jan 10 17:17:36 UTC 2011
 
 Modified Files:
   src/etc/mtree: NetBSD.dist.tests
 
 Log Message:
 Add lib/libc/sys test dirs.

Thanks!

Dave

-- 
David Young OJC Technologies
dyo...@ojctech.com  Urbana, IL * (217) 278-3933


Re: CVS commit: src/etc/mtree

2011-01-01 Thread Adam Hamsik

On Jan,Saturday 1 2011, at 11:11 PM, Adam Hamsik wrote:

 Module Name:  src
 Committed By: haad
 Date: Sat Jan  1 22:11:45 UTC 2011
 
 Modified Files:
   src/etc/mtree: NetBSD.dist.base
 
 Log Message:
 Remove optional keyword from directory definition.
 
 

This fixes PR misc/44308

Regards

Adam.