Re: CVS commit: src/usr.sbin/inetd

2021-08-31 Thread Roland Illig
Am 31.08.2021 um 18:29 schrieb Tobias Nygren:
> -   SWAP(int, cp->se_type, sep->se_type);
> +   SWAP(enum service_type, cp->se_type, sep->se_type);

Thanks for the note, I just fixed it.

I left out the 'enum' since there is a typedef for it.

Roland


Re: CVS commit: src/usr.sbin/inetd

2021-08-31 Thread Tobias Nygren
On Mon, 30 Aug 2021 18:21:11 +
Roland Illig  wrote:

> Module Name:  src
> Committed By: rillig
> Date: Mon Aug 30 18:21:11 UTC 2021
> 
> Modified Files:
>   src/usr.sbin/inetd: Makefile inetd.c parse_v2.c
> 
> Log Message:
> inetd: raise WARNS from 5 to 6

clang complains:

/work/src/usr.sbin/inetd/inetd.c:763:18: error: implicit conversion changes 
signedness: 'service_type' (aka 'enum service_type') to 'int' 
[-Werror,-Wsign-conversion]
SWAP(int, cp->se_type, sep->se_type);
~~^~

Works for me:

--- inetd.c 30 Aug 2021 18:21:11 -  1.131
+++ inetd.c 31 Aug 2021 16:26:45 -
@@ -760,7 +760,7 @@ config(void)
 #ifdef IPSEC
SWAP(char *, sep->se_policy, cp->se_policy);
 #endif
-   SWAP(int, cp->se_type, sep->se_type);
+   SWAP(enum service_type, cp->se_type, sep->se_type);
SWAP(size_t, cp->se_service_max, sep->se_service_max);
SWAP(size_t, cp->se_ip_max, sep->se_ip_max);


Re: CVS commit: src/usr.sbin/inetd

2017-10-18 Thread Ryota Ozaki
On Tue, Oct 17, 2017 at 9:03 PM, Christos Zoulas  wrote:
> In article <20171017071319.a4380f...@cvs.netbsd.org>,
> Ryota Ozaki  wrote:
>>-=-=-=-=-=-
>>
>>Module Name:   src
>>Committed By:  ozaki-r
>>Date:  Tue Oct 17 07:13:19 UTC 2017
>>
>>Modified Files:
>>   src/usr.sbin/inetd: inetd.c
>>
>>Log Message:
>>Don't setup SPs if no policy sepecifier is specified
>>
>>We expect that SPs are set up iff some policy sepecifier(s) are specified.
>
> Why not just flip the order ?
>
> if (policy != NULL && ipsecfoo(...) < 0) {
> }

I just wanted to pull ipsecsetup out from the conditional statement.

  ozaki-r


Re: CVS commit: src/usr.sbin/inetd

2017-10-17 Thread Christos Zoulas
In article <20171017071319.a4380f...@cvs.netbsd.org>,
Ryota Ozaki  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  ozaki-r
>Date:  Tue Oct 17 07:13:19 UTC 2017
>
>Modified Files:
>   src/usr.sbin/inetd: inetd.c
>
>Log Message:
>Don't setup SPs if no policy sepecifier is specified
>
>We expect that SPs are set up iff some policy sepecifier(s) are specified.

Why not just flip the order ?

if (policy != NULL && ipsecfoo(...) < 0) {
}

christos



Re: CVS commit: src/usr.sbin/inetd

2009-10-22 Thread Alan Barrett
On Thu, 22 Oct 2009, Jochen Kunz wrote:
> Modified Files:
>   src/usr.sbin/inetd: Makefile inetd.8 inetd.c
> 
> Log Message:
> Add mDNS Service Directory support to inetd(8).
> inetd(8) can now advertize services in the mDNS-SD.
> (Per service configuration option in inetd.conf(5).)

Where was this discussed?  In particular, any syntax changes in
inetd.conf should be discussed before implementation.

--apb (Alan Barrett)


Re: CVS commit: src/usr.sbin/inetd

2009-10-22 Thread Ty Sarna

On Oct 22, 2009, at 12:34 PM, Jochen Kunz wrote:


Add mDNS Service Directory support to inetd(8).
inetd(8) can now advertize services in the mDNS-SD.
(Per service configuration option in inetd.conf(5).)


Thanks for coordinating with me. :-(

I think the problem is more complicated than you realize. I appreciate  
that you gave quite some thought to some of the implementation issues  
(handling interface restrictions, marking the mdnsd socket CLOEXEC),  
but you seem to have missed other issues entirely (service name  
support, TXT records, etc). The feature as-is is of limited utility.