Re: CVS commit: src/usr.sbin/mtree
On Jan 2, 8:55am, g...@ir.bbn.com (Greg Troxel) wrote: -- Subject: Re: CVS commit: src/usr.sbin/mtree | Then it seems that the tests should have been changed in the same | commit, and new tests added for netbsd flavor! I did not know about the tests. I will fix them. christos
Re: CVS commit: src/usr.sbin/mtree
chris...@zoulas.com (Christos Zoulas) writes: > On Jan 2, 10:19am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: > -- Subject: Re: CVS commit: src/usr.sbin/mtree > > | On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote: > | > Module Name: src > | > Committed By: christos > | > Date: Thu Dec 20 16:43:17 UTC 2012 > | > > | > Modified Files: > | > src/usr.sbin/mtree: create.c extern.h mtree.8 mtree.c spec.c > | > > | > Log Message: > | > Implement the "flavor" output discussed in tech-userlevel@, by Brooks > Davis > | This broke the mtree atf tests. Output now differs by additional size > | values for symlinks and directories: > | > | -2 type=dir nlink=2 > | +2 type=dir nlink=2 size=0 > | > | See for example: > | > http://www.netbsd.org/~martin/sparc64-atf/147_atf.html#usr.sbin_mtree_t_mtree_create > > Yes, we agreed to change the format for the default and if you want > the backwards > compatible one, we you need to say netbsd flavor. Then it seems that the tests should have been changed in the same commit, and new tests added for netbsd flavor! pgpwIjxnuv4aW.pgp Description: PGP signature
Re: CVS commit: src/usr.sbin/mtree
On Wed, 2 Jan 2013, Christos Zoulas wrote: On Jan 2, 10:19am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.sbin/mtree | On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote: | > Module Name: src | > Committed By:christos | > Date:Thu Dec 20 16:43:17 UTC 2012 | > | > Modified Files: | > src/usr.sbin/mtree: create.c extern.h mtree.8 mtree.c spec.c | > | > Log Message: | > Implement the "flavor" output discussed in tech-userlevel@, by Brooks Davis | > | > | > To generate a diff of this commit: | > cvs rdiff -u -r1.67 -r1.68 src/usr.sbin/mtree/create.c | > cvs rdiff -u -r1.36 -r1.37 src/usr.sbin/mtree/extern.h | > cvs rdiff -u -r1.64 -r1.65 src/usr.sbin/mtree/mtree.8 | > cvs rdiff -u -r1.43 -r1.44 src/usr.sbin/mtree/mtree.c | > cvs rdiff -u -r1.84 -r1.85 src/usr.sbin/mtree/spec.c | | This broke the mtree atf tests. Output now differs by additional size | values for symlinks and directories: | | -2 type=dir nlink=2 | +2 type=dir nlink=2 size=0 | | | See for example: | http://www.netbsd.org/~martin/sparc64-atf/147_atf.html#usr.sbin_mtree_t_mtree_create Yes, we agreed to change the format for the default and if you want the backwards compatible one, we you need to say netbsd flavor. Seems to me we to get the tests updated * to reflect the changes in expected output, and also * additional test cases to ensure that "compatability mode" works correctly. christos !DSPAM:50e43a9b17431864914745! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/usr.sbin/mtree
On Jan 2, 10:19am, mar...@homeworld.netbsd.org (Martin Husemann) wrote: -- Subject: Re: CVS commit: src/usr.sbin/mtree | On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote: | > Module Name:src | > Committed By: christos | > Date: Thu Dec 20 16:43:17 UTC 2012 | > | > Modified Files: | > src/usr.sbin/mtree: create.c extern.h mtree.8 mtree.c spec.c | > | > Log Message: | > Implement the "flavor" output discussed in tech-userlevel@, by Brooks Davis | > | > | > To generate a diff of this commit: | > cvs rdiff -u -r1.67 -r1.68 src/usr.sbin/mtree/create.c | > cvs rdiff -u -r1.36 -r1.37 src/usr.sbin/mtree/extern.h | > cvs rdiff -u -r1.64 -r1.65 src/usr.sbin/mtree/mtree.8 | > cvs rdiff -u -r1.43 -r1.44 src/usr.sbin/mtree/mtree.c | > cvs rdiff -u -r1.84 -r1.85 src/usr.sbin/mtree/spec.c | | This broke the mtree atf tests. Output now differs by additional size | values for symlinks and directories: | | -2 type=dir nlink=2 | +2 type=dir nlink=2 size=0 | | | See for example: | http://www.netbsd.org/~martin/sparc64-atf/147_atf.html#usr.sbin_mtree_t_mtree_create Yes, we agreed to change the format for the default and if you want the backwards compatible one, we you need to say netbsd flavor. christos
Re: CVS commit: src/usr.sbin/mtree
On Thu, Dec 20, 2012 at 11:43:17AM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Thu Dec 20 16:43:17 UTC 2012 > > Modified Files: > src/usr.sbin/mtree: create.c extern.h mtree.8 mtree.c spec.c > > Log Message: > Implement the "flavor" output discussed in tech-userlevel@, by Brooks Davis > > > To generate a diff of this commit: > cvs rdiff -u -r1.67 -r1.68 src/usr.sbin/mtree/create.c > cvs rdiff -u -r1.36 -r1.37 src/usr.sbin/mtree/extern.h > cvs rdiff -u -r1.64 -r1.65 src/usr.sbin/mtree/mtree.8 > cvs rdiff -u -r1.43 -r1.44 src/usr.sbin/mtree/mtree.c > cvs rdiff -u -r1.84 -r1.85 src/usr.sbin/mtree/spec.c This broke the mtree atf tests. Output now differs by additional size values for symlinks and directories: -2 type=dir nlink=2 +2 type=dir nlink=2 size=0 See for example: http://www.netbsd.org/~martin/sparc64-atf/147_atf.html#usr.sbin_mtree_t_mtree_create Martin
Re: CVS commit: src/usr.sbin/mtree
On Sat, 04 Apr 2009, Alan Barrett wrote: > Modified Files: > src/usr.sbin/mtree: mtree.h spec.c > > Log Message: > Tags are internally stored with leading and trailing commas, for ease > of using strcmp(3) to check them against inclusion or exclusion lists. > Don't output the leading or trailing commas. That should have been strstr(3), not strcmp(3). I have modified the log message in the repository. --apb (Alan Barrett)
