Re: CVS commit: src/bin/ksh

2018-06-12 Thread Valery Ushakov
On Tue, Jun 12, 2018 at 14:13:55 +, Kamil Rytarowski wrote:

> UBSan can detect that during switching a login to root there is unportable
> left shift operation:
> 
> $ su -
> Password:
> /public/src.git/bin/ksh/eval.c:598:13: runtime error: left shift of 
> 1073741824 by 1 places cannot be represented in type 'int'
> #

Is this, seriously, how you reproduce it?  It doesn't trigger on just
running ksh?  In which case what is the real problem here - it must be
triggered by some .profile code, which your "reproducer" doesn't
provide.

-uwe


Re: CVS commit: src/bin/ksh

2017-06-22 Thread Kamil Rytarowski
On 23.06.2017 02:12, matthew green wrote:
> "Kamil Rytarowski" writes:
>> Module Name: src
>> Committed By:kamil
>> Date:Thu Jun 22 13:32:04 UTC 2017
>>
>> Modified Files:
>>  src/bin/ksh: c_ksh.c edit.c path.c sh.h
>>
>> Log Message:
>> Remove ancient cygwin support in ksh(1)
>>
>> OK by 
> 
> i thought ksh was upstream owned code, so changes like this
> seem to be out of place in netbsd tree.
> 
> why are you doing all this?
> 
> 
> .mrg
> 

I haven't found active upstream development since around 1999; I have
local patches and I took maintainership. This is what happened in other
BSDs.

I got some old patches and I will try to upstream them after removing
K code. This will also help to address some local bugs that affect my
shell usage.

The domain for multiplatform legacy Unices is covered by MKSH (developed
against gcc1, gcc2). So no need to compete with them for this niche.



signature.asc
Description: OpenPGP digital signature


re: CVS commit: src/bin/ksh

2017-06-22 Thread matthew green
"Kamil Rytarowski" writes:
> Module Name:  src
> Committed By: kamil
> Date: Thu Jun 22 13:32:04 UTC 2017
> 
> Modified Files:
>   src/bin/ksh: c_ksh.c edit.c path.c sh.h
> 
> Log Message:
> Remove ancient cygwin support in ksh(1)
> 
> OK by 

i thought ksh was upstream owned code, so changes like this
seem to be out of place in netbsd tree.

why are you doing all this?


.mrg.