Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau

[Jaromír Doleček]

The static variable was in #ifdef __NetBSD__ part, so I assumed it
doesn't influence the merge.

Christos already reverted the fallthrough warning fix.

Jaromir

Le jeu. 13 févr. 2020 à 09:18, matthew green  a écrit :
>
> "Jaromir Dolecek" writes:
> > Module Name:  src
> > Committed By: jdolecek
> > Date: Wed Feb 12 20:31:46 UTC 2020
> >
> > Modified Files:
> >   src/sys/external/bsd/drm2/dist/drm/nouveau: nouveau_fbcon.c
> >
> > Log Message:
> > remove superfluous static variable used only to zero attach args
>
> is this necessary for 3rd party code?
>
> please try to avoid changing these for cosmetic reasons.
>
> same for warned code that is forced to warning not error.
> the reason we/i didn't change them is to avoid making
> future drm updates harder -- they're already *really* hard.
>
> thanks.
>
>
> .mrg.

re: CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau

[matthew green]

"Jaromir Dolecek" writes:
> Module Name:  src
> Committed By: jdolecek
> Date: Wed Feb 12 20:31:46 UTC 2020
> 
> Modified Files:
>   src/sys/external/bsd/drm2/dist/drm/nouveau: nouveau_fbcon.c
> 
> Log Message:
> remove superfluous static variable used only to zero attach args

is this necessary for 3rd party code?

please try to avoid changing these for cosmetic reasons.

same for warned code that is forced to warning not error.
the reason we/i didn't change them is to avoid making
future drm updates harder -- they're already *really* hard.

thanks.


.mrg.

Re: CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau

[Christos Zoulas]

In article <20151014001256.2650...@cvs.netbsd.org>,
matthew green  wrote:
> #ifdef __NetBSD__
>-  /* XXX pa_dmat or pa_dmat64? */
>-  const bus_dma_tag_t dmat = pdev->pd_pa.pa_dmat64;
>+  const bus_dma_tag_t dmat = pci_dma64_available(&pdev->pd_pa) ?
>+  pdev->pd_pa.pa_dmat64 : pdev->pd_pa.pa_dmat;

Shouldn't there be a pci_dma_get() or something macro for that?

christos