Re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread Alan Barrett

On Mon, 11 Apr 2011, Brett Lymn wrote:

Modified Files:
src/tests/lib/libcurses/slave: curses_commands.c

+static int
+internal_vw_printw(WINDOW *win, char *arg1, ...)
+{
+   va_list va;
+   int rv;
+
+   va_start(va, arg1);
+   rv = vw_printw(win, arg1, va);
+   va_end(va);
+
+   return rv;
+}


This code looks identical to that in wprintw().  Why does it need to
be duplicated under another name?

--apb (Alan Barrett)


re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread matthew green

> On Mon, 11 Apr 2011, Brett Lymn wrote:
> >Modified Files:
> > src/tests/lib/libcurses/slave: curses_commands.c
> > 
> >+static int
> >+internal_vw_printw(WINDOW *win, char *arg1, ...)
> >+{
> >+va_list va;
> >+int rv;
> >+
> >+va_start(va, arg1);
> >+rv = vw_printw(win, arg1, va);
> >+va_end(va);
> >+
> >+return rv;
> >+}
> 
> This code looks identical to that in wprintw().  Why does it need to
> be duplicated under another name?

well, the test is about testing vw_printw() directly, not
wprintw().


.mrg.


Re: CVS commit: src/tests/lib/libcurses/slave

2011-04-11 Thread Alan Barrett

On Tue, 12 Apr 2011, matthew green wrote:

>+static int
>+internal_vw_printw(WINDOW *win, char *arg1, ...)

This code looks identical to that in wprintw().  Why does it 
need to be duplicated under another name?


well, the test is about testing vw_printw() directly, not 
wprintw().


Ah, of course.

--apb (Alan Barrett)