CVS commit: src/tests/lib/libprop
Module Name:src
Committed By: thorpej
Date: Sat Jun 6 21:45:07 UTC 2020
Modified Files:
src/tests/lib/libprop: t_proplib.c
Log Message:
Don't use deprecated proplib APIs (in the old "basic" test case).
To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libprop/t_proplib.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/libprop/t_proplib.c
diff -u src/tests/lib/libprop/t_proplib.c:1.1 src/tests/lib/libprop/t_proplib.c:1.2
--- src/tests/lib/libprop/t_proplib.c:1.1 Sat Jun 6 21:26:00 2020
+++ src/tests/lib/libprop/t_proplib.c Sat Jun 6 21:45:07 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: t_proplib.c,v 1.1 2020/06/06 21:26:00 thorpej Exp $ */
+/* $NetBSD: t_proplib.c,v 1.2 2020/06/06 21:45:07 thorpej Exp $ */
/*
* Copyright (c) 2008, 2020 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
#include
__COPYRIGHT("@(#) Copyright (c) 2008, 2020\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: t_proplib.c,v 1.1 2020/06/06 21:26:00 thorpej Exp $");
+__RCSID("$NetBSD: t_proplib.c,v 1.2 2020/06/06 21:45:07 thorpej Exp $");
#include
#include
@@ -110,7 +110,7 @@ ATF_TC_BODY(prop_basic, tc)
ATF_REQUIRE(dict != NULL);
{
- prop_number_t num = prop_number_create_integer(1);
+ prop_number_t num = prop_number_create_signed(1);
ATF_REQUIRE(num != NULL);
ATF_REQUIRE_EQ(prop_dictionary_set(dict, "one", num), true);
@@ -118,7 +118,7 @@ ATF_TC_BODY(prop_basic, tc)
}
{
- prop_string_t str = prop_string_create_cstring("number-two");
+ prop_string_t str = prop_string_create_copy("number-two");
ATF_REQUIRE(str != NULL);
ATF_REQUIRE_EQ(prop_dictionary_set(dict, "two", str), true);
CVS commit: src/tests/lib/libprop
Module Name:src
Committed By: thorpej
Date: Mon Jun 8 21:31:17 UTC 2020
Modified Files:
src/tests/lib/libprop: t_proplib.c
Log Message:
Ensure copy_data_create_copy() is tolerant of creating empty data objects.
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libprop/t_proplib.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/libprop/t_proplib.c
diff -u src/tests/lib/libprop/t_proplib.c:1.2 src/tests/lib/libprop/t_proplib.c:1.3
--- src/tests/lib/libprop/t_proplib.c:1.2 Sat Jun 6 21:45:07 2020
+++ src/tests/lib/libprop/t_proplib.c Mon Jun 8 21:31:17 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: t_proplib.c,v 1.2 2020/06/06 21:45:07 thorpej Exp $ */
+/* $NetBSD: t_proplib.c,v 1.3 2020/06/08 21:31:17 thorpej Exp $ */
/*
* Copyright (c) 2008, 2020 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
#include
__COPYRIGHT("@(#) Copyright (c) 2008, 2020\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: t_proplib.c,v 1.2 2020/06/06 21:45:07 thorpej Exp $");
+__RCSID("$NetBSD: t_proplib.c,v 1.3 2020/06/08 21:31:17 thorpej Exp $");
#include
#include
@@ -224,6 +224,26 @@ ATF_TC_BODY(prop_data_basic, tc)
* API contract.
*/
+ d1 = prop_data_create_copy(const_data1, 0);
+ ATF_REQUIRE(d1 != NULL);
+ ATF_REQUIRE(prop_data_value(d1) == NULL);
+ prop_object_release(d1);
+
+ d1 = prop_data_create_copy(NULL, sizeof(const_data1));
+ ATF_REQUIRE(d1 != NULL);
+ ATF_REQUIRE(prop_data_value(d1) == NULL);
+ prop_object_release(d1);
+
+ d1 = prop_data_create_nocopy(const_data1, 0);
+ ATF_REQUIRE(d1 != NULL);
+ ATF_REQUIRE(prop_data_value(d1) == NULL);
+ prop_object_release(d1);
+
+ d1 = prop_data_create_nocopy(NULL, sizeof(const_data1));
+ ATF_REQUIRE(d1 != NULL);
+ ATF_REQUIRE(prop_data_value(d1) == NULL);
+ prop_object_release(d1);
+
d1 = prop_data_create_nocopy(const_data1, sizeof(const_data1));
ATF_REQUIRE(d1 != NULL);
ATF_REQUIRE(prop_data_value(d1) == const_data1);
CVS commit: src/tests/lib/libprop
Module Name:src
Committed By: thorpej
Date: Wed Jun 24 14:28:10 UTC 2020
Modified Files:
src/tests/lib/libprop: t_proplib.c
Log Message:
Fix pasto; use {,U}LLONG{MIN,MAX} correctly in the {u,}llong{min,max}
range checks.
PR lib/55414
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libprop/t_proplib.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/libprop/t_proplib.c
diff -u src/tests/lib/libprop/t_proplib.c:1.3 src/tests/lib/libprop/t_proplib.c:1.4
--- src/tests/lib/libprop/t_proplib.c:1.3 Mon Jun 8 21:31:17 2020
+++ src/tests/lib/libprop/t_proplib.c Wed Jun 24 14:28:10 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: t_proplib.c,v 1.3 2020/06/08 21:31:17 thorpej Exp $ */
+/* $NetBSD: t_proplib.c,v 1.4 2020/06/24 14:28:10 thorpej Exp $ */
/*
* Copyright (c) 2008, 2020 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
#include
__COPYRIGHT("@(#) Copyright (c) 2008, 2020\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: t_proplib.c,v 1.3 2020/06/08 21:31:17 thorpej Exp $");
+__RCSID("$NetBSD: t_proplib.c,v 1.4 2020/06/24 14:28:10 thorpej Exp $");
#include
#include
@@ -551,16 +551,16 @@ ATF_TC_BODY(prop_number_range_check, tc)
#endif
ATF_REQUIRE(prop_number_longlong_value(n_llong_max, &val.v_llong) &&
- val.v_llong == INTPTR_MAX);
+ val.v_llong == LLONG_MAX);
ATF_REQUIRE(prop_number_longlong_value(n_llong_min, &val.v_llong) &&
- val.v_llong == INTPTR_MIN);
+ val.v_llong == LLONG_MIN);
ATF_REQUIRE(!prop_number_longlong_value(n_ullong_max, &val.v_llong));
ATF_REQUIRE(prop_number_ulonglong_value(n_llong_max, &val.v_ullong) &&
- val.v_ullong == INTPTR_MAX);
+ val.v_ullong == LLONG_MAX);
ATF_REQUIRE(!prop_number_ulonglong_value(n_llong_min, &val.v_ullong));
ATF_REQUIRE(prop_number_ulonglong_value(n_ullong_max, &val.v_ullong) &&
- val.v_ullong == UINTPTR_MAX);
+ val.v_ullong == ULLONG_MAX);
/* int8_t / uint8_t */
ATF_REQUIRE(prop_number_int8_value(n_int8_max, &val.v_int8) &&
CVS commit: src/tests/lib/libprop
Module Name:src
Committed By: jruoho
Date: Wed Apr 6 17:41:27 UTC 2011
Modified Files:
src/tests/lib/libprop: t_basic.c
Log Message:
Add a test case for the segfault reported in PR lib/43964.
To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libprop/t_basic.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/libprop/t_basic.c
diff -u src/tests/lib/libprop/t_basic.c:1.2 src/tests/lib/libprop/t_basic.c:1.3
--- src/tests/lib/libprop/t_basic.c:1.2 Wed Nov 3 16:10:22 2010
+++ src/tests/lib/libprop/t_basic.c Wed Apr 6 17:41:27 2011
@@ -1,4 +1,4 @@
-/* $NetBSD: t_basic.c,v 1.2 2010/11/03 16:10:22 christos Exp $ */
+/* $NetBSD: t_basic.c,v 1.3 2011/04/06 17:41:27 jruoho Exp $ */
/*
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
#include
__COPYRIGHT("@(#) Copyright (c) 2008\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: t_basic.c,v 1.2 2010/11/03 16:10:22 christos Exp $");
+__RCSID("$NetBSD: t_basic.c,v 1.3 2011/04/06 17:41:27 jruoho Exp $");
#include
#include
@@ -79,12 +79,13 @@
"\n"
"\n";
-ATF_TC(simple);
-ATF_TC_HEAD(simple, tc)
+ATF_TC(prop_basic);
+ATF_TC_HEAD(prop_basic, tc)
{
- atf_tc_set_md_var(tc, "descr", "Checks basic functionality of proplib");
+ atf_tc_set_md_var(tc, "descr", "A basic test of proplib(3)");
}
-ATF_TC_BODY(simple, tc)
+
+ATF_TC_BODY(prop_basic, tc)
{
prop_dictionary_t dict;
char *ext1;
@@ -160,10 +161,38 @@
free(ext1);
}
+ATF_TC(prop_dictionary_equals);
+ATF_TC_HEAD(prop_dictionary_equals, tc)
+{
+ atf_tc_set_md_var(tc, "descr", "Test prop_dictionary_equals(3)");
+}
+
+ATF_TC_BODY(prop_dictionary_equals, tc)
+{
+ prop_dictionary_t c, d;
+
+ atf_tc_expect_death("PR lib/43964");
+
+ d = prop_dictionary_internalize(compare1);
+
+ ATF_REQUIRE(d != NULL);
+
+ c = prop_dictionary_copy(d);
+
+ ATF_REQUIRE(c != NULL);
+
+ if (prop_dictionary_equals(c, d) != true)
+ atf_tc_fail("dictionaries are not equal");
+
+ prop_object_release(c);
+ prop_object_release(d);
+}
+
ATF_TP_ADD_TCS(tp)
{
- ATF_TP_ADD_TC(tp, simple);
+ ATF_TP_ADD_TC(tp, prop_basic);
+ ATF_TP_ADD_TC(tp, prop_dictionary_equals);
return atf_no_error();
}
CVS commit: src/tests/lib/libprop
Module Name:src
Committed By: martin
Date: Wed Apr 20 20:02:58 UTC 2011
Modified Files:
src/tests/lib/libprop: t_basic.c
Log Message:
PR fixed, remove expected failure.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libprop/t_basic.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/tests/lib/libprop/t_basic.c
diff -u src/tests/lib/libprop/t_basic.c:1.3 src/tests/lib/libprop/t_basic.c:1.4
--- src/tests/lib/libprop/t_basic.c:1.3 Wed Apr 6 17:41:27 2011
+++ src/tests/lib/libprop/t_basic.c Wed Apr 20 20:02:58 2011
@@ -1,4 +1,4 @@
-/* $NetBSD: t_basic.c,v 1.3 2011/04/06 17:41:27 jruoho Exp $ */
+/* $NetBSD: t_basic.c,v 1.4 2011/04/20 20:02:58 martin Exp $ */
/*
* Copyright (c) 2008 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
#include
__COPYRIGHT("@(#) Copyright (c) 2008\
The NetBSD Foundation, inc. All rights reserved.");
-__RCSID("$NetBSD: t_basic.c,v 1.3 2011/04/06 17:41:27 jruoho Exp $");
+__RCSID("$NetBSD: t_basic.c,v 1.4 2011/04/20 20:02:58 martin Exp $");
#include
#include
@@ -171,7 +171,12 @@
{
prop_dictionary_t c, d;
+ /*
+ * Fixed, should not fail any more...
+ *
atf_tc_expect_death("PR lib/43964");
+ *
+ */
d = prop_dictionary_internalize(compare1);
