[Spacewalk-devel] 2 bugs for 0.5
I'd really like to solve these 2 bugs before 0.5 goes out but time is running out for me since I'm going on PTO for half day tomorrow and also on Friday: #1: Bug 474774 - Probe details do not show neither graph nor event log https://bugzilla.redhat.com/show_bug.cgi?id=474774 reproducer is here in a priv comment with internal hostname: https://bugzilla.redhat.com/show_bug.cgi?id=474774#c3 #2: Bug 472595 - Extreme kickstart performance problem https://bugzilla.redhat.com/show_bug.cgi?id=472595 So if we do end up delaying 0.5 until perhaps the end of next week it should give me time to get these 2 nasties done. If not I can just check them into 0.5 after the release and push new packages when I'm complete. I wouldn't hold up the release for them. Mike -- Mike McCune mmccune AT redhat.com Engineering | Portland, OR RHN Satellite | 650.567.9039x79248 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk
On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=6c1be4e0cc992afb834e8fedf7c3094746466ba4 'git pull --rebase' next time? It should be possible to do a post commit hook to refuse commits which introduce merges that have the default commit message (= likely not intended merge). Is this something we might want to try setting up? We should also be able to try to enforce the ^((\d+)\s-\s)? format for bugzilla numbers. -- Jan Pazdziora | adelton at #satellite*, #brno Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Status of Spacewalk @ Fedora
Michael Stahnke wrote: Me again. rhnpush is emailing us every night about issues in Fedora. Will Fedora be shipping a rhnlib package? rhnpush has broken dependencies in the development tree: On i386: rhnpush-0.4.5-1.fc11.noarch requires rhnlib Please resolve this as soon as possible. As soon as somebody review it: https://bugzilla.redhat.com/show_bug.cgi?id=486937 If you have some spare time please pick it up. It is sitting in queue too long. -- Miroslav Suchy RHN Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Code Review Tool
Seeing as Jesus likes reviewing commit... I'm just wondering - do we want to setup some Code Review tools? Will we use it? Or gitk/tig and sending mails to spacewalk-devel is sufficient? If I see here majority of positive response I will be happy to set up some tool. Hmm probably some time after space05 when things will slows down. -- Miroslav Suchy RHN Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk
On Thu, Mar 12, 2009 at 09:17:34AM -0300, Devan Goodwin wrote: Would like too, only reason not too I can think of is if you'd done some package tagging and intentionally done a pull without --rebase so as not to have to redo it. In that case you probably should --amend the commit to say why you did that merge. In which case the regexp will no longer match and you'll be OK. -- Jan Pazdziora Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk
Jan Pazdziora wrote: % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: % On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: % http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=6c1be4e0cc992afb834e8fedf7c3094746466ba4 % % 'git pull --rebase' next time? % % It should be possible to do a post commit hook to refuse commits % which introduce merges that have the default commit message (= likely % not intended merge). % % Is this something we might want to try setting up? % % We should also be able to try to enforce the % % ^((\d+)\s-\s)? % % format for bugzilla numbers. I agree with commit hooks. Anyway format bugzilla numbers is more complicated (multiple bz numbers or none). -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] 481180 - update KickstartFormatter to not include --interpetter in profile f...
Thanks for the tip. Will update today. jmrodri wrote: If isInterpreter() returns a string you could've used StringUtils.isEmpty(kss.getInterpreter()) to avoid having to do the null and empty checks as isEmpty does both for you. jesus Sent to you by jmrodri via Google Reader: 481180 - update KickstartFormatter to not include --interpetter in profile for script... http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h=dce5d37f99dc77b8b611be1e62f8653cd322b318 via Fedora Hosted Git Repositories - spacewalk.git/rss log http://git.fedoraproject.org/git/?p=spacewalk.git;a=summary by Brad Buckingham bbucking...@redhat.com on 3/11/09 481180 - update KickstartFormatter to not include --interpetter in profile for scripts where the Scripting Language is omitted/blank. * [D http://git.fedoraproject.org/git/?p=spacewalk.git;a=blobdiff;f=java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java;fp=java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java;h=9fccb02acfa8b45f5f9d168fcfd80ccd5dd18f31;hp=78217b985888d54b0f509ca434f938cf489e7921;hb=dce5d37f99dc77b8b611be1e62f8653cd322b318;hpb=f2218f0e0467ad6fe9cf578f0420f3421095ed1eH http://git.fedoraproject.org/git/?p=spacewalk.git;a=history;f=java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java;h=dce5d37f99dc77b8b611be1e62f8653cd322b318] java/code/src/com/redhat/rhn/manager/kickstart/KickstartFormatter.java Things you can do from here: * Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log http://www.google.com/reader/view/feed%2Fhttp%3A%2F%2Fgit.fedoraproject.org%2Fgit%2F%3Fp%3Dspacewalk.git%3Ba%3Drss?source=email using *Google Reader* * Get started using Google Reader http://www.google.com/reader/?source=email to easily keep up with *all your favorite sites* ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] F10 nightly repo
On Thu, Mar 12, 2009 at 2:31 AM, Jan Pazdziora jpazdzi...@redhat.com wrote: On Thu, Mar 12, 2009 at 12:00:41AM -0400, Jesus Rodriguez wrote: I tried to install the F10 nightly repo tonight on a fresh (and updated) F10 box. I got the following dependency errors: http://fpaste.org/paste/5924 the el5 nightly has hibernate3 in it while the F10 repo doesn't. Where does hibernate 3 come from if not in the F10 repo? From jpackage.org. See https://www.redhat.com/archives/spacewalk-devel/2009-February/msg00217.html Thanks Jan, I didn't know we were using jpackage rpms :) And how do you quote mailing lists so well? :) jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Code Review Tool
Pradeep Kilambi wrote: % Miroslav Suchý wrote: % Seeing as Jesus likes reviewing commit... I'm just wondering - do we % want to setup some Code Review tools? Will we use it? Or gitk/tig and % sending mails to spacewalk-devel is sufficient? % If I see here majority of positive response I will be happy to set up % some tool. Hmm probably some time after space05 when things will slows % down. % % % I like the idea, sounds nice. But how do we plan on using it? Unless % people volunteer to post their commits to the tool and request for a % review, I think we'll be in the same position again where zeus or mike % or someone else looking at the commits feeds and suggesting changes. % I think if we have a tool like such, it comes down to the discipline of % individual developer to ask for a review. Honestly I dont see that % happening very frequently :) I like the idea either. IMHO post commit review would be enough (we do it now when reading commit logs) so commits could be taken automaticaly from git and then wait for review by another developer. -- Michael Mráka Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Code Review Tool
2009/3/12 Michael Mraka michael.mr...@redhat.com: Pradeep Kilambi wrote: % Miroslav Suchý wrote: % Seeing as Jesus likes reviewing commit... I'm just wondering - do we % want to setup some Code Review tools? Will we use it? Or gitk/tig and % sending mails to spacewalk-devel is sufficient? % If I see here majority of positive response I will be happy to set up % some tool. Hmm probably some time after space05 when things will slows % down. % % % I like the idea, sounds nice. But how do we plan on using it? Unless % people volunteer to post their commits to the tool and request for a % review, I think we'll be in the same position again where zeus or mike % or someone else looking at the commits feeds and suggesting changes. % I think if we have a tool like such, it comes down to the discipline of % individual developer to ask for a review. Honestly I dont see that % happening very frequently :) I like the idea either. IMHO post commit review would be enough (we do it now when reading commit logs) so commits could be taken automaticaly from git and then wait for review by another developer. I would be game for having a tool. I'd also be happy if others would simply look at the commit logs as mike I do. I look at them for a few reasons: 1) understand what's going on 2) looking for glaring errors and duplicate code While a tool might help us get better, if everyone spent sometime reviewing the commit logs. I don't think the process will work if it is up to a developer to ask for reviews, having done that in the past it never really worked for me. jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Code Review Tool
On Thu, Mar 12, 2009 at 3:31 PM, Jesus M. Rodriguez jmro...@gmail.com wrote: 2009/3/12 Michael Mraka michael.mr...@redhat.com: Pradeep Kilambi wrote: I like the idea either. IMHO post commit review would be enough (we do it now when reading commit logs) so commits could be taken automaticaly from git and then wait for review by another developer. I would be game for having a tool. I'd also be happy if others would simply look at the commit logs as mike I do. I look at them for a few reasons: 1) understand what's going on 2) looking for glaring errors and duplicate code While a tool might help us get better, if everyone spent sometime reviewing the commit logs. I don't think the process will work if it is up to a developer to ask for reviews, having done that in the past it never really worked for me. That being said, if the code review tool pulls commits automatically, and I can have the ability to flag a commit for review, that would be ok. I do not want any commit to 'wait' for review before being accepted into the repository (I don't think that was being said but making sure) jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk
2009/3/12 Michael Mraka michael.mr...@redhat.com: Jan Pazdziora wrote: % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: % On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: % http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=6c1be4e0cc992afb834e8fedf7c3094746466ba4 % % 'git pull --rebase' next time? % % It should be possible to do a post commit hook to refuse commits % which introduce merges that have the default commit message (= likely % not intended merge). % % Is this something we might want to try setting up? % % We should also be able to try to enforce the % % ^((\d+)\s-\s)? % % format for bugzilla numbers. I agree with commit hooks. Anyway format bugzilla numbers is more complicated (multiple bz numbers or none). +1 to the enforcement. Sounds like a good idea. Agreed with Michael here that the commit message, my regex sucks but I'll try to at least describe it :) \d*(,\d*) - msg so you can have 0 or more bugzilla numbers separated by commas. The list of bugzilla numbers is set apart from the msg by a space hyphen space, then followed by a commit message. If there is no bugzilla number there should be no hyphen. jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Fixed a iprange issue where the iprange delete URLs weren't being correctly ...
Why do we have to pass in the /rhn/ to the url here where we don't on the others? jesus Sent to you by jmrodri via Google Reader: Fixed a iprange issue where the iprange delete URLs weren't being correctly rendered via Fedora Hosted Git Repositories - spacewalk.git/rss log by Partha Aji p...@redhat.com on 3/12/09 Fixed a iprange issue where the iprange delete URLs weren't being correctly rendered - [DH] java/code/webapp/WEB-INF/pages/kickstart/kickstartips.jsp - [DH] java/code/webapp/WEB-INF/pages/kickstart/wizard/profile/advanced/iprange.jsp Things you can do from here: - Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log using Google Reader - Get started using Google Reader to easily keep up with all your favorite sites ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] 489792- fixing incorrect api return types
Instead of
+ List list = (List) listErrata(sessionKey, channelLabel, , );
+ //
+ for (Map item : list) {
+ item.put(date, item.get(issue_date));
+ }
+ return list;
why not change the query to return date as the column name instead of
issue_date OR
change it to return both issue_date and date together. That avoids
having to
loop through the list simply to change the keys.
Also, remove the empty // line.
jesus
Sent to you by jmrodri via Google Reader: 489792- fixing incorrect api
return types via Fedora Hosted Git Repositories - spacewalk.git/rss log
by Justin Sherrill jsher...@redhat.com on 3/12/09 489792- fixing
incorrect api return types
- [DH]
java/code/src/com/redhat/rhn/common/db/datasource/xml/Errata_queries.xml
- [DH]
java/code/src/com/redhat/rhn/frontend/xmlrpc/channel/software/ChannelSoftwareHandler.java
- [DH]
java/code/src/com/redhat/rhn/frontend/xmlrpc/channel/software/test/ChannelSoftwareHandlerTest.java
Things you can do from here:
- Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log
using Google Reader
- Get started using Google Reader to easily keep up with all your
favorite sites
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] 489775 - fixing listERrata api due to bad query
why is this a BAD query? I think this was done on purpose to return the issue_date as date. jesus Sent to you by jmrodri via Google Reader: 489775 - fixing listERrata api due to bad query via Fedora Hosted Git Repositories - spacewalk.git/rss log by Justin Sherrill jsher...@redhat.com on 3/12/09 489775 - fixing listERrata api due to bad query - [DH] java/code/src/com/redhat/rhn/common/db/datasource/xml/Errata_queries.xml Things you can do from here: - Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss log using Google Reader - Get started using Google Reader to easily keep up with all your favorite sites ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Merge branch 'master' of ssh://jlsherr...@git.fedorahosted.org/git/spacewalk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesus M. Rodriguez wrote: 2009/3/12 Michael Mraka michael.mr...@redhat.com: Jan Pazdziora wrote: % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: % On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: % http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=6c1be4e0cc992afb834e8fedf7c3094746466ba4 % % 'git pull --rebase' next time? % % It should be possible to do a post commit hook to refuse commits % which introduce merges that have the default commit message (= likely % not intended merge). % % Is this something we might want to try setting up? % % We should also be able to try to enforce the % % ^((\d+)\s-\s)? % % format for bugzilla numbers. I agree with commit hooks. Anyway format bugzilla numbers is more complicated (multiple bz numbers or none). +1 to the enforcement. Sounds like a good idea. Agreed with Michael here that the commit message, my regex sucks but I'll try to at least describe it :) \d*(,\d*) - msg so you can have 0 or more bugzilla numbers separated by commas. The list of bugzilla numbers is set apart from the msg by a space hyphen space, then followed by a commit message. If there is no bugzilla number there should be no hyphen. jesus You just had to bait the perl guys didn't you? ;) I think what you meant is: (\d+(,\d+)*\ \-\ )?.+ and as can be seen on my cube wall: http://xkcd.com/208/ Thanks. Brandon -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org iD8DBQFJucw2hwQhj8l1t/cRAj3wAKCjc1kRnnULFUcv0vLhtHmtsc/+ZACdFvYW zbXQy+dwnwzZZj1k/m8M0qM= =dCxK -END PGP SIGNATURE- ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
