Re: [Spacewalk-devel] spacewalk-commits

2009-03-27 Thread Miroslav Suchý

Dennis Gilmore wrote:
would anyone object to me creating a spacewalk-comm...@lists.fedorahosted.org 
and having all commits pushed to fedorahosted emailed there?


I do not mind, but I do not care as well.
I currently use gitk --all to review commits.
As we previously discussed, I plan to use some review code tool soon.
--
Miroslav Suchy
RHN Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] 0.5 State of the Union

2009-03-27 Thread Jan Pazdziora
On Thu, Mar 26, 2009 at 09:32:44PM -0400, Jesus M. Rodriguez wrote:
 
  Jan please look at this bug:
  https://bugzilla.redhat.com/show_bug.cgi?id=492194
 
  After long investigation, I've filed bugzilla 492378 for that.
 
  I'll try to find a way to work around the problem tomorrow.
 
 Ok that would be great.

Done. I've built spacewalk-setup-0.5.27-1.fc10.noarch.rpm, please give
it a try.

-- 
Jan Pazdziora
Senior Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] 0.5 State of the Union

2009-03-27 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Fri, 27 Mar 2009 12:00:40 +0100
Jan Pazdziora jpazdzi...@redhat.com wrote:

 On Thu, Mar 26, 2009 at 09:32:44PM -0400, Jesus M. Rodriguez wrote:
  
   Jan please look at this bug:
   https://bugzilla.redhat.com/show_bug.cgi?id=492194
  
   After long investigation, I've filed bugzilla 492378 for that.
  
   I'll try to find a way to work around the problem tomorrow.
  
  Ok that would be great.
 
 Done. I've built spacewalk-setup-0.5.27-1.fc10.noarch.rpm, please give
 it a try.
 

Tested and looking good on F10, I'll hit CentOS 5 soon as I can wrap
up this other issue blocking it. Thanks Jan.

Devan

- -- 
  Devan Goodwin dgood...@redhat.com
  Software Engineer Spacewalk / RHN Satellite
  Halifax, Canada   650.567.9039x79267
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAknMxjUACgkQAyHWaPV9my4PmwCguq/bdtrO2rmtNPAxg0ZDdO3i
4LcAn0Ci73IOB8+5y5CrA5sNe8JMq+Xw
=ITJU
-END PGP SIGNATURE-

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] spacewalk-commits

2009-03-27 Thread Dennis Gilmore
On Thursday 26 March 2009 07:19:17 pm Dennis Gilmore wrote:
 would anyone object to me creating a
 spacewalk-comm...@lists.fedorahosted.org and having all commits pushed to
 fedorahosted emailed there?

https://fedorahosted.org/mailman/listinfo/spacewalk-commits

its all setup. I've not subscribed anybody to the list.  

Dennis

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


[Spacewalk-devel] Re: java/code

2009-03-27 Thread Mike McCune

the below is a good example of how to convert a simple page to the new LT.

Nice!

Justin Sherrill wrote:

 
java/code/src/com/redhat/rhn/frontend/action/systems/monitoring/ProbesListSetupAction.java
 |   55 +-
 java/code/webapp/WEB-INF/pages/systems/probes/index.jsp
|   79 +++---
 2 files changed, 99 insertions(+), 35 deletions(-)

New commits:
commit 98c6b6f4c4698aef8bfe2a70a827a46eb5ae9b47
Author: Justin Sherrill jsher...@redhat.com
Date:   Fri Mar 27 15:54:19 2009 -0400

144325 - converting system probe list to the new list tag, featuring all 
the bells and whistles the new list tag has to offer

diff --git 
a/java/code/src/com/redhat/rhn/frontend/action/systems/monitoring/ProbesListSetupAction.java
 
b/java/code/src/com/redhat/rhn/frontend/action/systems/monitoring/ProbesListSetupAction.java
index 4c43361..deeb922 100644
--- 
a/java/code/src/com/redhat/rhn/frontend/action/systems/monitoring/ProbesListSetupAction.java
+++ 
b/java/code/src/com/redhat/rhn/frontend/action/systems/monitoring/ProbesListSetupAction.java
@@ -14,34 +14,59 @@
  */
 package com.redhat.rhn.frontend.action.systems.monitoring;
 
-import com.redhat.rhn.common.db.datasource.DataResult;

 import com.redhat.rhn.domain.server.Server;
-import com.redhat.rhn.frontend.listview.PageControl;
-import com.redhat.rhn.frontend.struts.BaseListAction;
 import com.redhat.rhn.frontend.struts.RequestContext;
+import com.redhat.rhn.frontend.struts.RhnAction;
+import com.redhat.rhn.frontend.taglibs.list.helper.ListHelper;
+import com.redhat.rhn.frontend.taglibs.list.helper.Listable;
 import com.redhat.rhn.manager.monitoring.MonitoringManager;
 
+import org.apache.struts.action.ActionForm;

+import org.apache.struts.action.ActionForward;
+import org.apache.struts.action.ActionMapping;
+
+import java.util.List;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
 /**
  * ProbesListSetupAction
  * @version $Rev: 59372 $
  */
-public class ProbesListSetupAction extends BaseListAction {
-
-protected DataResult getDataResult(RequestContext rctx, PageControl pc) {

-DataResult dr;
-Server server = rctx.lookupAndBindServer();
-// Null page control, we dont paginate this list.
-dr = MonitoringManager.getInstance().
-probesForSystem(rctx.getCurrentUser(), server, null);
-return dr;
+public class ProbesListSetupAction extends RhnAction implements Listable {
+
+/**
+ *
+ * {...@inheritdoc}
+ */
+public ActionForward execute(ActionMapping mapping,
+ActionForm formIn,
+HttpServletRequest request,
+HttpServletResponse response) {
+
+ListHelper helper = new ListHelper(this, request);
+helper.execute();
+
+RequestContext requestContext = new RequestContext(request);
+Server server = requestContext.lookupAndBindServer();
+
+request.setAttribute(sid, server.getId());
+return mapping.findForward(default);
 }
 
+

+
+
 /**
+ *
  * {...@inheritdoc}
  */
-protected void processRequestAttributes(RequestContext rctx) {
-super.processRequestAttributes(rctx);
-rctx.lookupAndBindServer();
+public List getResult(RequestContext rctx) {
+Server server = rctx.lookupAndBindServer();
+return MonitoringManager.getInstance().
+probesForSystem(rctx.getCurrentUser(), server, null);
 }
+
 }
 
diff --git a/java/code/webapp/WEB-INF/pages/systems/probes/index.jsp b/java/code/webapp/WEB-INF/pages/systems/probes/index.jsp

index ba623b5..82993f6 100644
--- a/java/code/webapp/WEB-INF/pages/systems/probes/index.jsp
+++ b/java/code/webapp/WEB-INF/pages/systems/probes/index.jsp
@@ -4,6 +4,7 @@
 %@ taglib uri=http://jakarta.apache.org/struts/tags-html; prefix=html %
 %@ taglib uri=http://jakarta.apache.org/struts/tags-bean; prefix=bean %
 %@ taglib uri=http://java.sun.com/jsp/jstl/functions; prefix=fn %
+%@ taglib uri=http://rhn.redhat.com/tags/list; prefix=rl %
 
 html:xhtml/

 html
@@ -31,26 +32,64 @@
 /p
   /div
 
-rhn:list pageList=${requestScope.pageList} noDataText=probes.index.jsp.noprobes legend=probes-list
-  rhn:listdisplay set=${requestScope.set} exportColumns=id,description,stateString,stateOutputString 
-hiddenvars=${requestScope.newset}

-%@ include 
file=/WEB-INF/pages/common/fragments/probes/probe-state-column.jspf %
-rhn:column header=probes.index.jsp.description nowrap=nowrap
-  a 
href=ProbeDetails.do?probe_id=${current.id}sid=${system.id}${current.description}/A
-/rhn:column
-rhn:column header=probes.index.jsp.status sortProperty=stateOutputString  
-  ${current.stateOutputString}

-/rhn:column
-rhn:column header=probes.index.jsp.type
-c:if test=${current.isSuiteProbe}
-  a title='bean:message key=probes.index.jsp.suiteedit/' 

[Spacewalk-devel] 2 failed units

2009-03-27 Thread Mike McCune

All Failed Tests
Test Name   DurationAge
com.redhat.rhn.frontend.action.errata.test.CloneErrataActionTest.testEmptySet 
0.207	3
com.redhat.rhn.frontend.action.errata.test.CloneErrataActionTest.testNonEmptySet 
0.685	3

All Tests

FYI.

--
Mike McCune
mmccune AT redhat.com
Engineering   | Portland, OR
RHN Satellite | 650.567.9039x79248

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel