Re: [Spacewalk-devel] Commits should reference public bugzillas

2009-04-10 Thread Jan Pazdziora
On Wed, Apr 08, 2009 at 11:03:02AM +0200, Jan Pazdziora wrote:
 
 Hello,
 
 if you like me in the past committed a fix to Spacewalk repo

Note!

If you've for some reason parsed my previous email in such a way that
it made you think the commit hook is in the repo on fedorahosted.org
so you are automatically covered while running git push, please
re-read that previous email.

Thank you,

-- 
Jan Pazdziora
Senior Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] Spacewalk Proxy 0.5

2009-04-10 Thread Miroslav Suchý

Rob James wrote:

- At the point we get to the activate in the script httpd is not yet
installed any more so it can't chown systemid to the apache user (so
it fails)

Already fixed
https://bugzilla.redhat.com/show_bug.cgi?id=494290
https://bugzilla.redhat.com/show_bug.cgi?id=492871


- If the system has already been registered as a Proxy the activation
fails (need to delete the system and reregister it)

Already fixed
https://bugzilla.redhat.com/show_bug.cgi?id=489395
This one was really ugly and went into Hibernate internals. I want to 
thx Partha on work on it.



- It would probably be good to check somewhere in the installer that
the machine you're trying to activate is registered in the Spacewalk
server (since it's clearly not going to work otherwise!)

Done as side effect of
https://bugzilla.redhat.com/show_bug.cgi?id=494290
In commit
779a210cfaf3220f463b8cbaa33991b1b8765bcf
I moved the check of existence systemid to top of the script.
I'm aware the you can have systemid and not be registered. But I suppose 
for those minor it should be ok, that you give errors after you respond 
the questions. But I'm open to discussion.



- The error /usr/sbin/configure-proxy.sh: line 236: cat: No such file
or directory is given if you don't choose to install monitoring
(probably need to wrap this bit in an if monitoring block)

Oh. I made new BZ from this one:
https://bugzilla.redhat.com/show_bug.cgi?id=495194


- On line 311 there's a missing line continuation character which
means it'll just stop - should be -e s|/VirtualHost|SSLProxyEngine
on\n/VirtualHost| \

Already commited in
dc627e0f137df32b4febb445eb8be8be376a8122
There was one similar error:
8c5c20138df48000c7e7f312e77340c23b0f0be8


Hopefully those notes are helpful to you. Let me know if you want me
to bugzilla them.

Finally I couldn't actually get it to work afterwards - trying to
register a client gives the error below (i've tryed deleting
/var/spool/up2date/loginAuth.pkl) - any help much appriciated:


Already reported as:
https://bugzilla.redhat.com/show_bug.cgi?id=493428
Missing dependecy on spacewalk-proxy-selinux
if you install this package (or disable selinux) it will work.

Thx for your report and home my answers helps.
--
Miroslav Suchy
RHN Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel