Re: [Spacewalk-devel] request to merge audit viewing to master
On 07/02/2009 06:40 PM, Mike McCune wrote: On 07/02/2009 06:32 PM, Mike McCune wrote: On 06/29/2009 06:15 AM, Joshua Roys wrote: On 06/26/2009 08:03 PM, Mike McCune wrote: Joshua, I'm also getting this compile error: [javac] Compiling 2455 source files to /home/mmccune/devel/spacewalk/java/build/classes [javac] /home/mmccune/devel/spacewalk/java/code/src/com/redhat/rhn/manager/audit/AuditManager.java:253: cannot find symbol [javac] symbol : constructor DataResult() [javac] location: class com.redhat.rhn.common.db.datasource.DataResult [javac] return new DataResult(); [javac]^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error looks like AuditMachineDto is missing the default constructor. Mike, Try the patch located here to avoid the conflict: http://www.stl.gtri.gatech.edu/jroys/spacewalk-audit-20090625-master-96465f0.patch Also, attached is a patch to remove the recently (re)moved html:messages from my jsp pages, and fix that compile error. Thanks! Integrated the patches and it complies fine now. thanks for the updates. I'm testing the pages now. Committed locally and filed a bug to track its inclusion in Spacewalk 0.6: https://bugzilla.redhat.com/show_bug.cgi?id=509474 Mike Joshua: I'm getting this exception when I hit the Audit tab: 2009-07-27 18:03:00,250 [TP-Processor2] ERROR org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/rhn].[action] - Servlet.service() for servlet action threw exception java.lang.NullPointerException at com.redhat.rhn.manager.audit.AuditManager.getMachines(AuditManager.java:256) at com.redhat.rhn.frontend.action.audit.AuditAction.getResult(AuditAction.java:60) at com.redhat.rhn.frontend.action.audit.AuditAction.getResult(AuditAction.java:27) at com.redhat.rhn.frontend.taglibs.list.helper.ListHelper.setupDataSet(ListHelper.java:107) at com.redhat.rhn.frontend.taglibs.list.helper.ListHelper.execute(ListHelper.java:100) at com.redhat.rhn.frontend.action.audit.AuditAction.execute(AuditAction.java:41) at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:237) at com.redhat.rhn.frontend.struts.RhnRequestProcessor.process(RhnRequestProcessor.java:82) at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) thoughts? ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] request to merge audit viewing to master
On 07/02/2009 09:40 PM, Mike McCune wrote: On 07/02/2009 06:32 PM, Mike McCune wrote: On 06/29/2009 06:15 AM, Joshua Roys wrote: On 06/26/2009 08:03 PM, Mike McCune wrote: Joshua, I'm also getting this compile error: [javac] Compiling 2455 source files to /home/mmccune/devel/spacewalk/java/build/classes [javac] /home/mmccune/devel/spacewalk/java/code/src/com/redhat/rhn/manager/audit/AuditManager.java:253: cannot find symbol [javac] symbol : constructor DataResult() [javac] location: class com.redhat.rhn.common.db.datasource.DataResult [javac] return new DataResult(); [javac]^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error looks like AuditMachineDto is missing the default constructor. Mike, Try the patch located here to avoid the conflict: http://www.stl.gtri.gatech.edu/jroys/spacewalk-audit-20090625-master-96465f0.patch Also, attached is a patch to remove the recently (re)moved html:messages from my jsp pages, and fix that compile error. Thanks! Integrated the patches and it complies fine now. thanks for the updates. I'm testing the pages now. Committed locally and filed a bug to track its inclusion in Spacewalk 0.6: https://bugzilla.redhat.com/show_bug.cgi?id=509474 Mike Mike, One more patch that adds the tabs to the PXT side of things. Thanks, Joshua Roys diff --git a/web/html/nav/sitenav-authenticated.xml b/web/html/nav/sitenav-authenticated.xml index 698121c..e9794dd 100644 --- a/web/html/nav/sitenav-authenticated.xml +++ b/web/html/nav/sitenav-authenticated.xml @@ -112,6 +112,16 @@ + +/rhn/audit + + + + + /rhn/configuration ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Extra Git Push Output
On 07/27/2009 03:38 PM, Devan Goodwin wrote: You may notice a huge batch of script output when running git push, this is just some temporary verbosity while we debug this issue: $ git push --tags Counting objects: 1, done. Writing objects: 100% (1/1), 234 bytes, done. Total 1 (delta 0), reused 0 (delta 0) fatal: Invalid revision range ..9819b729122602f79cf144954f7f0e478e9622dd To ssh://msu...@git.fedorahosted.org/git/spacewalk.git/ * [new tag] spacewalk-proxy-installer-0.6.16-1 -> spacewalk-proxy-installer-0.6.16-1 Should you happen to see this error when pushing a tag, please reply here with the output from the script so we can pass it along to Fedora Infra. We'll disable the output soon. Fedora Infra ticket 1362 if anyone is interested. Thanks, Devan Hello all, I believe this is caused by your pre-receive hook: https://fedorahosted.org/fedora-infrastructure/attachment/ticket/1342/pre-receive https://fedorahosted.org/fedora-infrastructure/ticket/1342 I just set up a test repo with that hook and pushed a few tags and it gave the same error: [jro...@sis-jrr foo]$ git push --tags Counting objects: 1, done. Writing objects: 100% (1/1), 174 bytes, done. Total 1 (delta 0), reused 0 (delta 0) + read old_sha1 new_sha1 refname + git rev-list --parents ..35f792639eb4ddcef04ba65f940fca8d3086921b + read sha1 parents fatal: Invalid revision range ..35f792639eb4ddcef04ba65f940fca8d3086921b + '[' 0 -ne 0 ']' + : + read old_sha1 new_sha1 refname + exit 0 refs/tags/project-0.0.3: -> 35f792639eb4ddcef04ba65f940fca8d3086921b To ssh://production-ps/~/foo.git * [new tag] project-0.0.3 -> project-0.0.3 Maybe add something like... while read old_sha1 new_sha1 refname ; do +if expr "$old_sha1" : '0*$' > /dev/null ; then +continue +fi Joshua Roys ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Extra Git Push Output
You may notice a huge batch of script output when running git push, this is just some temporary verbosity while we debug this issue: $ git push --tags Counting objects: 1, done. Writing objects: 100% (1/1), 234 bytes, done. Total 1 (delta 0), reused 0 (delta 0) fatal: Invalid revision range ..9819b729122602f79cf144954f7f0e478e9622dd To ssh://msu...@git.fedorahosted.org/git/spacewalk.git/ * [new tag] spacewalk-proxy-installer-0.6.16-1 -> spacewalk-proxy-installer-0.6.16-1 Should you happen to see this error when pushing a tag, please reply here with the output from the script so we can pass it along to Fedora Infra. We'll disable the output soon. Fedora Infra ticket 1362 if anyone is interested. Thanks, Devan pgp6hQAaqtSij.pgp Description: PGP signature ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] pgsql branch merged to master
Devan Goodwin wrote: On Mon Jul 27/2009 @ 2:07:P -0500 asdasd, Jeff Ortel wrote: All, The pgsql branch has been merged to master. As most of you know, this involves some changes in schema (source) directory structure, conventions and development procedures. I'm working on a wiki page that defines these changes and procedures. Note: It is still a work in progress. https://fedorahosted.org/spacewalk/wiki/DatabaseGuide If you have any questions or problems please ping me or dgoodwin. Regards, Jeff ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel Package rebuilds are underway, should be in the devel repo within 24 hours. I'll start testing Oracle installations tomorrow morning to make sure we're ready for 0.6. Then we can start looking at how and where pgsql installation will die. Sounds good. I haven't test loaded the PG schema since the last few merges from master so don't be surprised if it's busted. Cheers, Devan ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] pgsql branch merged to master
On Mon Jul 27/2009 @ 2:07:P -0500 asdasd, Jeff Ortel wrote: > All, > > The pgsql branch has been merged to master. As most of you know, this > involves some changes in schema (source) directory structure, conventions > and development procedures. I'm working on a wiki page that defines these > changes and procedures. Note: It is still a work in progress. > > https://fedorahosted.org/spacewalk/wiki/DatabaseGuide > > If you have any questions or problems please ping me or dgoodwin. > > Regards, > > Jeff > > ___ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel Package rebuilds are underway, should be in the devel repo within 24 hours. I'll start testing Oracle installations tomorrow morning to make sure we're ready for 0.6. Then we can start looking at how and where pgsql installation will die. Cheers, Devan pgp8kxbkCP20x.pgp Description: PGP signature ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] pgsql branch merged to master
On Mon, 27 Jul 2009, Jeff Ortel wrote: All, The pgsql branch has been merged to master. As most of you know, this involves some changes in schema (source) directory structure, conventions and development procedures. I'm working on a wiki page that defines these changes and procedures. Note: It is still a work in progress. https://fedorahosted.org/spacewalk/wiki/DatabaseGuide If you have any questions or problems please ping me or dgoodwin. /me claps. Bravo, Jeff. Long time coming. --g -- Computer Science professors should be teaching open source. Help make it happen. Visit http://teachingopensource.org. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] pgsql branch merged to master
All, The pgsql branch has been merged to master. As most of you know, this involves some changes in schema (source) directory structure, conventions and development procedures. I'm working on a wiki page that defines these changes and procedures. Note: It is still a work in progress. https://fedorahosted.org/spacewalk/wiki/DatabaseGuide If you have any questions or problems please ping me or dgoodwin. Regards, Jeff ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Branch 'sha256-support' - 135 commits - ... schema/spacewalk ...
On Mon, Jul 27, 2009 at 07:54:32PM +0200, Milan Zazrivec wrote: > On Monday 27 July 2009 15:54:13 Pradeep Kilambi wrote: > > diff --git a/schema/spacewalk/rhnsat/tables/rhnChannel.sql > > b/schema/spacewalk/rhnsat/tables/rhnChannel.sql index 95a54dc..b4e1fab > > 100644 > > --- a/schema/spacewalk/rhnsat/tables/rhnChannel.sql > > +++ b/schema/spacewalk/rhnsat/tables/rhnChannel.sql > > @@ -49,6 +49,8 @@ rhnChannel > > gpg_key_id varchar2(14), > > gpg_key_fp varchar2(50), > > end_of_life date, > > +checksum_type_id number constraint rhn_channel_checksum_fk > > + references rhnChecksumType(id), > > receiving_updates char(1) > > default 'Y' > > constraint rhn_channel_ru_nn not null > > Now that rhnChannel table depends on rhnChecksumType, this relation > needs to be put into the Makefile.deps (and the pgsql branch equivalent) > so that the resulting schema deploys cleanly. Also, shouldn't the id in rhnChecksumType and that checksum_type_id here be some type of integer? It seems strange to see it defined as generic number. -- Jan Pazdziora Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Re: Branch 'sha256-support' - 135 commits - ... schema/spacewalk ...
On 07/27/2009 01:54 PM, Milan Zazrivec wrote: On Monday 27 July 2009 15:54:13 Pradeep Kilambi wrote: diff --git a/schema/spacewalk/rhnsat/tables/rhnChannel.sql b/schema/spacewalk/rhnsat/tables/rhnChannel.sql index 95a54dc..b4e1fab 100644 --- a/schema/spacewalk/rhnsat/tables/rhnChannel.sql +++ b/schema/spacewalk/rhnsat/tables/rhnChannel.sql @@ -49,6 +49,8 @@ rhnChannel gpg_key_id varchar2(14), gpg_key_fp varchar2(50), end_of_life date, +checksum_type_id number constraint rhn_channel_checksum_fk + references rhnChecksumType(id), receiving_updates char(1) default 'Y' constraint rhn_channel_ru_nn not null Now that rhnChannel table depends on rhnChecksumType, this relation needs to be put into the Makefile.deps (and the pgsql branch equivalent) so that the resulting schema deploys cleanly. Thanks milan. Yea I was waiting for jortel to finish his merge. Before I make any further db changes. ~ Prad -MZ ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel -- -- Pradeep Kilambi RHN Satellite Engineering pkila...@redhat.com Phone: +1 919 754 4285 RHCE # 805008680430554 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Re: Branch 'sha256-support' - 135 commits - ... schema/spacewalk ...
On Monday 27 July 2009 15:54:13 Pradeep Kilambi wrote: > diff --git a/schema/spacewalk/rhnsat/tables/rhnChannel.sql > b/schema/spacewalk/rhnsat/tables/rhnChannel.sql index 95a54dc..b4e1fab > 100644 > --- a/schema/spacewalk/rhnsat/tables/rhnChannel.sql > +++ b/schema/spacewalk/rhnsat/tables/rhnChannel.sql > @@ -49,6 +49,8 @@ rhnChannel > gpg_key_id varchar2(14), > gpg_key_fp varchar2(50), > end_of_life date, > +checksum_type_id number constraint rhn_channel_checksum_fk > + references rhnChecksumType(id), > receiving_updates char(1) > default 'Y' > constraint rhn_channel_ru_nn not null Now that rhnChannel table depends on rhnChecksumType, this relation needs to be put into the Makefile.deps (and the pgsql branch equivalent) so that the resulting schema deploys cleanly. -MZ ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
