- Original Message -
> On 02/14/2013 05:59 PM, Tomas Lestach wrote:
> > Hi Duncan,
> >
> > thanks for your patches.
> > I committed following:
> > eb7beb3277fb8db48376e44c058bde8ad5d1be45
> > 1db45d611fbc307b4eac1fa35d25ed3b30dc6fac
> > 668f52d928590b4bc7e2d3c955f2b6a59e5d3fb8
> >
> > I didn't commit following ones:
> > *TaskoRun Log tail: Handle the case where more bytes are
> > requested than the
> > current size of the log.
> > - I rather return the whole log file in case more bytes are
> > requested, so I
> > committed this code: 6012adfcc5d4ae182c164a3e64e442255f44751c
> > - anyway thank you for pointing on that situation
> Makes sense
>
> >
> > * both ChannelStatus commits
> > - generally I like the idea, implementation, spinning icons, but
> > I mean they
> > aren't complete
> > - I didn't find a way the 'Repo Cache Status' would say
> > 'Completed' or
> > 'Failed'.
> For the reposync, the result of the task will determine those
> statuses.
> For the repodata generation, only in-progress and scheduled is
> supported. But you are right in this second case if
> there are no items in the queue, it may be seen as completed instead
> of
> unknown.
>
> > - are you sure you sent everything?
> > - even if my repo was regenerated, I saw just '(none)' on the
> > page
> Probably because of the above. The repodata-generation should return
> Completed in the "else" case and not "Unknown".
> > - please check and I'd be happy to commit your patches
> >
> > Btw. would you run checkstyle before sending patches, please?
> >
> I am working on a ant-task to do checkstyle from the command line.
> Currently it is done in the rpm and not very comfortable.
You always can run 'ant checkstyle' from the command line as we have the ant
task defined. However because of the different incompatible checkstyle versions
you may use it on RHEL6 only.
>
> Thanks for the review, I will improve the patches, merge the ones you
> committed and try again soon.
Thank you,
Tomas
--
Tomas Lestach
RHN Satellite Engineering, Red Hat
>
> Duncan
>
> ___
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
>
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel