Re: [Spacewalk-devel] I seem to have hit a known fixed satellite bug in spacewalk 1.7

2012-08-17 Thread Jan Pazdziora
On Thu, Aug 16, 2012 at 05:29:20PM -0400, Paul Robert Marino wrote:
 Hey guys I seem to have hit a known fixed satellite bug in spacewalk 1.7
 
 https://bugzilla.redhat.com/show_bug.cgi?id=496318
 
 Is there any plan to back port this to spacewalk 1.7 or should I hack
 my copy my self?

Given the fact that the bug was fixed in 2009 in Spacewalk like 0.6,
you either are hitting different bug, or we introduced a regression.
In any case, we have no current report of whatever issue you might be
facing at this point, and we have no known fix.

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] I seem to have hit a known fixed satellite bug in spacewalk 1.7

2012-08-17 Thread Paul Robert Marino
Hmm
I hadn't noticed the date on the ticket just that the symptoms were
identical.
There may be also some other factors here I am running postgresql 9.1 and
while I didn't see a trace back I didn't check the postgresql logs. Ill
take a look and see if there are any bad queries. I've already had to. Back
port several patches from 1.8 to 1.7 to make it work. By the way in case
there is any question yes I will be submitting git patches made against the
1.7 branch of the git repo as soon as I'm done with testing
On Aug 17, 2012 3:39 AM, Jan Pazdziora jpazdzi...@redhat.com wrote:

 On Thu, Aug 16, 2012 at 05:29:20PM -0400, Paul Robert Marino wrote:
  Hey guys I seem to have hit a known fixed satellite bug in spacewalk 1.7
 
  https://bugzilla.redhat.com/show_bug.cgi?id=496318
 
  Is there any plan to back port this to spacewalk 1.7 or should I hack
  my copy my self?

 Given the fact that the bug was fixed in 2009 in Spacewalk like 0.6,
 you either are hitting different bug, or we introduced a regression.
 In any case, we have no current report of whatever issue you might be
 facing at this point, and we have no known fix.

 --
 Jan Pazdziora
 Principal Software Engineer, Satellite Engineering, Red Hat

 ___
 Spacewalk-devel mailing list
 Spacewalk-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/spacewalk-devel

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] I seem to have hit a known fixed satellite bug in spacewalk 1.7

2012-08-17 Thread Paul Robert Marino
Ive done a little more digging I haven't found the problem yet but I
can eliminate a few things
1) its not a regression in the code
2) There is nothing in the PostgreSQL logs that indicate a failed
query so i dont think the fact that I'm using PostgreSQL 9.1 is
causing the issue.

I have added the patches mentioned here
https://www.redhat.com/archives/spacewalk-devel/2012-March/msg00056.html
and
https://bugzilla.redhat.com/show_bug.cgi?id=809936

Im fairly sure the issue is here
java/code/src/com/redhat/rhn/manager/kickstart/KickstartScheduleCommand.java

because this only seems to happen when i schedule a box to rekickstart
via the web interface.

some how this doesn't seem right to me specifically I think this
function may be getting called with a usage limit of 0 but to be
honest Im not sure why in this context you would ever need it to be
any thing else other than 1.

/**
 * Create a one time activation key for use with a kickstart
 * @param creator of the key
 * @param ksdata associated with the key
 * @param server being kickstarted (can be null)
 * @param session associated with the kickstart (NOT NULL)
 * @param note to add to key
 * @param usageLimit to apply to the key.  null for unlimited.
 * @return ActivationKey that has been saved to the DB.
 */
 public static ActivationKey createKickstartActivationKey(User creator,
KickstartData ksdata,
Server server,
KickstartSession session,
Long usageLimit,
String note) {

// Now create ActivationKey
ActivationKey key = ActivationKeyManager.getInstance().
createNewReActivationKey(creator,
server, note, session);

key.addEntitlement(ServerConstants.getServerGroupTypeProvisioningEntitled());
key.setDeployConfigs(false);
key.setUsageLimit(usageLimit);
if (KickstartVirtualizationType.paraHost().
equals(ksdata.getKickstartDefaults().getVirtualizationType())) {
//we'll have to setup the key for virt

key.addEntitlement(ServerConstants.getServerGroupTypeVirtualizationEntitled());
}
ActivationKeyFactory.save(key);


// Add child channels to the key
if (ksdata.getChildChannels() != null 
ksdata.getChildChannels().size()  0) {
Iterator i = ksdata.getChildChannels().iterator();
log.debug(Add the child Channels);
while (i.hasNext()) {
   key.addChannel((Channel) i.next());
}
}

log.debug(** Saving new token);
ActivationKeyFactory.save(key);
log.debug(** Saved new token:  + key.getId());
return key;
}


Ill create a bug report latter today


On Fri, Aug 17, 2012 at 9:00 AM, Paul Robert Marino prmari...@gmail.com wrote:
 Hmm
 I hadn't noticed the date on the ticket just that the symptoms were
 identical.
 There may be also some other factors here I am running postgresql 9.1 and
 while I didn't see a trace back I didn't check the postgresql logs. Ill take
 a look and see if there are any bad queries. I've already had to. Back port
 several patches from 1.8 to 1.7 to make it work. By the way in case there is
 any question yes I will be submitting git patches made against the 1.7
 branch of the git repo as soon as I'm done with testing

 On Aug 17, 2012 3:39 AM, Jan Pazdziora jpazdzi...@redhat.com wrote:

 On Thu, Aug 16, 2012 at 05:29:20PM -0400, Paul Robert Marino wrote:
  Hey guys I seem to have hit a known fixed satellite bug in spacewalk 1.7
 
  https://bugzilla.redhat.com/show_bug.cgi?id=496318
 
  Is there any plan to back port this to spacewalk 1.7 or should I hack
  my copy my self?

 Given the fact that the bug was fixed in 2009 in Spacewalk like 0.6,
 you either are hitting different bug, or we introduced a regression.
 In any case, we have no current report of whatever issue you might be
 facing at this point, and we have no known fix.

 --
 Jan Pazdziora
 Principal Software Engineer, Satellite Engineering, Red Hat

 ___
 Spacewalk-devel mailing list
 Spacewalk-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/spacewalk-devel

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel