Jan Pazdziora wrote:
% in the satellite/ directory, we have the following packages:
%
% $ find satellite -name '*.spec'
% satellite/admin/spacewalk-admin.spec
% satellite/certs/spacewalk-certs-tools.spec
% satellite/config/spacewalk-config.spec
% satellite/install/Spacewalk-Setup/spacewalk-setup.spec
% satellite/schema/schema.spec
% satellite/spacewalk.spec
%
% The name of the directory (satellite) is misleading, so I plan to
% rename it to ... let's see ... spacewalk?
Hello Jan,
this is one of things on my todo list so I completely agree.
% Packages spacewalk-admin, spacewalk-certs-tools, and spacewalk-config
% are OK, except for certs which could have certs-tools in the directory
% name to match the package name.
Yes.
% The satellite/install/ directory contains a lot of code that we do not
% use in Spacewalk -- the original Satellite installer. I'd like to
% remove it as well but we shall see what the layout of the Satellite
% repo will be. In any case, I propose moving
% satellite/install/Spacewalk-Setup/ up, away from that directory.
%
% The satellite/schema/schema.spec is a rhns-schema-tools package which
% was never tagged or built in Spacewalk, so I propose to remove it
% completely.
Again agree with purging unused code.
% The problem with satellite/spacewalk.spec being on this level is that
%
% git-untagged-commits.pl
%
% will show
%
% spacewalk-0.4.2-3..HEAD:
% d7f34f039f8334a8ef173367a124ad3d8ecf Automatic commit of package
[spacewalk-setup] release [0.4.23-1].
% 8aeb652ed014e2721406ccb9cf0eef72cb1a4981 remove legacy satellite
upgrade message (not required in Spacewalk)
% aebb69c70457c7231a958aeebfa6b03bb84acbe0 don't setup monitoring during
upgrade (it's already configured)
% e6bf13edf49a724c97b89e9e8b80561c2b823eca run ssl virtual host
configuration even for upgrades
% 104bbdd663aca0cc72ccc9ed5c24a227dc28757f Automatic commit of package
[spacewalk-config] release [0.4.24-1].
% ce0b2bcb362d7d0b85bdbedd120f54ab5f1f85e7 480095 - old package name.
% [...]
%
% even if those commits belong to packages stored in subdirectories of
% satellite/ -- git-untagged-commits.pl does not know that the
% spacewalk package is only about the spacewalk.spec file and nothing
% else. We might try to do some changes to the git-untagged-commits.pl
% but I'd prefer to find new home for the spacewalk package, where it
% will not have anything underneath it.
And what about merging spacewalk and spacewalk-setup packages (whatever new
name will be)? If you configure a package via spacewalk-setup you definitely
need all that packge installed so it sould be required by spacewalk-setup
package. The rest of packages should be installed as dependencies of those
first level packages.
% So sum up, I plan to do the following changes:
%
% satellite/admin/ = spacewalk/admin/
% satellite/certs/ = spacewalk/certs-tools/
% satellite/config/ = spacewalk/config/
% satellite/install/Spacewalk-Setup/ = spacewalk/setup/
remove the rest of satellite/install/*
% remove satellite/schema/
% satellite/spacewalk.spec = spacewalk/package/spacewalk.spec
% satellite/Makefile = spacewalk/package/Makefile
Couple of other things:
* gzipstream/ contains zlib-python interface so we should move
gzipstream/ = spec-tree/python/gzipstream/
* projects/cobbler/ - no spec there. I can see cobbler-setup there but
there is another cobbler-setup in satellite/install/Spacewalk-Setup/bin/.
Should be projects/cobbler safely removed?
* projects/ssl-cert-check/ - what about moving
projects/ssl-cert-check/ = spacewalk/ssl-cert-check/
where people expects spacewalk-* packages?
% Please raise your objections,
And we should not forget to tag moved packages so rel-eng/packages/* point to
right location.
--
Michael Mráka
Satellite Engineering, Red Hat
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
