Re: [Spacewalk-devel] Removed the bulk-subscribe and unsubscribe which is not used anywhere

2010-06-14 Thread Jan Pazdziora 
On Fri, Jun 11, 2010 at 11:49:17AM -0400, Partha Aji wrote:
> 
> Jan the ssm change channel stuff got ported to Java. I should remove alter 
> pxt also.. I 'll dig a bit more on this later today. Thanks for thepointer..
> 

Hmmm, alter_subscriptions_conf.pxt is still referenced in
Sniglets::ChannelLicense::channel_license_dialog_cb. And
rhn:channel_license_dialog_cb is set as trap only in channel_license.pxt
and that one is listed as the second rhn-tab-url.

So maybe channel_license.pxt could go, taking some of
Sniglets::ChannelLicense with it, taking alter_subscriptions_conf.pxt
with it. While we are at it, display_license.pxt which is the other
remaining place using Sniglets::ChannelLicense is only referenced as



and get_license_path does

SELECT CFL.license_path INTO license_val
  FROM rhnChannelFamilyLicense CFL, rhnChannelFamilyMembers CFM
 WHERE CFM.channel_id = channel_id_in
   AND CFM.channel_family_id = CFL.channel_family_id;

and rhnChannelFamilyLicense is empty on my Satellite 5.3. Is this
table and rhnChannelFamilyLicenseConsent somehow used in Spacewalk /
Satellite?

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Removed the bulk-subscribe and unsubscribe which is not used anywhere

2010-06-11 Thread Partha Aji 

Jan the ssm change channel stuff got ported to Java. I should remove alter pxt 
also.. I 'll dig a bit more on this later today. Thanks for thepointer..

Partha


- Original Message -
From: "Jan Pazdziora" 
To: "Partha Aji" 
Cc: spacewalk-devel@redhat.com
Sent: Thursday, June 10, 2010 8:51:49 AM GMT -05:00 US/Canada Eastern
Subject: Re: Removed the bulk-subscribe and unsubscribe which is not used 
anywhere

> commit 59a24c76ec52099cdea609e94923d3af4e34c57e
> Author: Partha Aji 
> Date:   Fri May 28 19:09:01 2010 -0400
> 
> Removed the bulk-subscribe and unsubscribe which is not used anywhere
> 
> diff --git a/web/modules/sniglets/Sniglets/ListView/SystemList.pm 
> b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> index 70f422a..647b058 100644
> --- a/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> +++ b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> @@ -85,11 +85,6 @@ sub _register_modes {
>-datasource => RHN::DataSource::System->new,
>-provider => \&visible_to_uid_provider);
>  
> -  Sniglets::ListView::List->add_mode(-mode => "ssm_channel_change_conf",
> -  -datasource => RHN::DataSource::System->new,
> -  -provider => \&ssm_channel_change_conf_provider,
> -  -action_callback => \&ssm_channel_change_conf_cb);
> -
>Sniglets::ListView::List->add_mode(-mode => 
> "systems_with_package_nvre_in_set",
>-datasource => RHN::DataSource::System->new);
>  
> @@ -663,85 +658,6 @@ sub ssm_channel_change_conf_provider {
>return %ret;

Partha, the ssm_channel_change_conf seems to be used in
web/html/network/systems/ssm/channels/alter_subscriptions_conf.pxt:


  
No systems would be affected by your channel subscription choices.
  

  

  
  

  


Is it correct that we are removing it? Or does the .pxt refer to
different ssm_channel_change_conf?

-- 
Jan Pazdziora | adelton at #satellite*, #brno
Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Removed the bulk-subscribe and unsubscribe which is not used anywhere

2010-06-10 Thread Jan Pazdziora 
> commit 59a24c76ec52099cdea609e94923d3af4e34c57e
> Author: Partha Aji 
> Date:   Fri May 28 19:09:01 2010 -0400
> 
> Removed the bulk-subscribe and unsubscribe which is not used anywhere
> 
> diff --git a/web/modules/sniglets/Sniglets/ListView/SystemList.pm 
> b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> index 70f422a..647b058 100644
> --- a/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> +++ b/web/modules/sniglets/Sniglets/ListView/SystemList.pm
> @@ -85,11 +85,6 @@ sub _register_modes {
>-datasource => RHN::DataSource::System->new,
>-provider => \&visible_to_uid_provider);
>  
> -  Sniglets::ListView::List->add_mode(-mode => "ssm_channel_change_conf",
> -  -datasource => RHN::DataSource::System->new,
> -  -provider => \&ssm_channel_change_conf_provider,
> -  -action_callback => \&ssm_channel_change_conf_cb);
> -
>Sniglets::ListView::List->add_mode(-mode => 
> "systems_with_package_nvre_in_set",
>-datasource => RHN::DataSource::System->new);
>  
> @@ -663,85 +658,6 @@ sub ssm_channel_change_conf_provider {
>return %ret;

Partha, the ssm_channel_change_conf seems to be used in
web/html/network/systems/ssm/channels/alter_subscriptions_conf.pxt:


  
No systems would be affected by your channel subscription choices.
  

  

  
  

  


Is it correct that we are removing it? Or does the .pxt refer to
different ssm_channel_change_conf?

-- 
Jan Pazdziora | adelton at #satellite*, #brno
Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel