Re: [Spacewalk-devel] Fix a memory leak in rhnsd

2010-03-20 Thread Jan Pazdziora 
On Fri, Mar 19, 2010 at 11:22:38AM +0100, Jan Pazdziora wrote:
  commit f987184526fb2cecf47b9dce8bf69c1c66a86d88
  Author: Joshua Roys joshua.r...@gtri.gatech.edu
  Date:   Thu Mar 18 14:00:07 2010 +
  
  Fix a memory leak in rhnsd
  
  diff --git a/client/rhel/rhnsd/rhnsd.c b/client/rhel/rhnsd/rhnsd.c
  index 357c59d..1e8fe21 100644
  --- a/client/rhel/rhnsd/rhnsd.c
  +++ b/client/rhel/rhnsd/rhnsd.c
  @@ -604,6 +604,7 @@ static int parse_systemid_path(char* systemid_path, int 
  systemid_path_length)
   }
   fclose(config_file);
   }
  +regfree(re_systemIdPath);
   return ret;
   }
 
 Joshua,
 
 thanks for catching this.
 
 I wonder if you also want to add a check for the return value of that
 regcomp call.

FYI, I've now tagged and built rhnsd-4.9.3-1.* into nightly client repo.

Thanks!

-- 
Jan Pazdziora | adelton at #satellite*, #brno
Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Re: [Spacewalk-devel] Fix a memory leak in rhnsd

2010-03-19 Thread Jan Pazdziora 
 commit f987184526fb2cecf47b9dce8bf69c1c66a86d88
 Author: Joshua Roys joshua.r...@gtri.gatech.edu
 Date:   Thu Mar 18 14:00:07 2010 +
 
 Fix a memory leak in rhnsd
 
 diff --git a/client/rhel/rhnsd/rhnsd.c b/client/rhel/rhnsd/rhnsd.c
 index 357c59d..1e8fe21 100644
 --- a/client/rhel/rhnsd/rhnsd.c
 +++ b/client/rhel/rhnsd/rhnsd.c
 @@ -604,6 +604,7 @@ static int parse_systemid_path(char* systemid_path, int 
 systemid_path_length)
  }
  fclose(config_file);
  }
 +regfree(re_systemIdPath);
  return ret;
  }

Joshua,

thanks for catching this.

I wonder if you also want to add a check for the return value of that
regcomp call.

Yours,

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel