Re: [PATCH] ESP driver

2008-02-19 Thread David Miller 
From: BERTRAND_Joël [EMAIL PROTECTED]
Date: Tue, 19 Feb 2008 10:20:10 +0100

   Only one question. For you, where can I find this bug ? In
 arch/sparc, in shared code or in ESP driver itself ?

I have to be terse and frank with you, I do not have the
time necessary to sit down and teach someone how to debug
these problems.

Besides, you will learn much more about the system if you try to
explore it yourself.
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ESP driver

2008-02-18 Thread BERTRAND Joël 

Hello,

	I think I have found a bug in esp_scsi.c. Without this patch, my 
SS20/SMP was not able to rebuild its internal raid1 volume due to esp0 
DMA errors. With the following patch, same workstation is building a 
kernel, doing a rsync (between two local directories) and rebuilding a 
26 GB raid1 volume without any trouble.


Signed-off-by: BERTRAND Joel [EMAIL PROTECTED]

Index: linux/drivers/scsi/esp_scsi.c
===
--- linux/drivers/scsi/esp_scsi.c.orig 2008-02-18 16:50:14.0 +0100
+++ linux/drivers/scsi/esp_scsi.c  2008-02-18 16:52:17.0 +0100
@@ -961,6 +961,7 @@
switch (esp-rev) {
case ESP100:
case ESP100A:
+   case FAS100A:
  /* The interrupt pending bit of the status register cannot
   * be trusted on these revisions.
   */


Regards,

JKB
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ESP driver

2008-02-18 Thread David Miller 
From: BERTRAND_Joël [EMAIL PROTECTED]
Date: Mon, 18 Feb 2008 22:34:25 +0100

   I think I have found a bug in esp_scsi.c. Without this patch, my 
 SS20/SMP was not able to rebuild its internal raid1 volume due to esp0 
 DMA errors. With the following patch, same workstation is building a 
 kernel, doing a rsync (between two local directories) and rebuilding a 
 26 GB raid1 volume without any trouble.
 
 Signed-off-by: BERTRAND Joel [EMAIL PROTECTED]

It may correct your problem for some reason, but this change
is not correct (and your email client or your editor used
spaces instead of tab characters in your change).  The FAS100A
implements the ESP_STAT_INTR bit correctly.

If the FAS100A needed this change, you would get spurious IRQs or
other state machine errors, not DMA errors.

I think your change merely changes timings, making the DMA problem
harder to trigger.

I'm sorry I don't have more desirable feedback for your patch, but
it's the best I can do :-)
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html