Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base

2008-02-13 Thread Kumar Gala


On Feb 13, 2008, at 8:20 AM, Jon Loeliger wrote:


So, like, the other day Kumar Gala mumbled:
If we add to an empty lmb region with a non-zero base we will not  
coalesce
the number of regions done to one.  This causes problems on ppc32  
for the


s/done/down


will fix.


memory region as its assumed to only have one region.

We can fix this be easily specially casing the initial add to just  
replace

the dummy region.

---

Posting this since Dave's looking a pulling the lmb code out into  
lib/ and

sharing it between powerpc and sparc.


Did you want to S-o-b: this patch?  Or was this just informational?


this was info/for review, the git tree has a s-o-b.

- k
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base

2008-02-13 Thread Jon Loeliger
So, like, the other day Kumar Gala mumbled:
 If we add to an empty lmb region with a non-zero base we will not coalesce
 the number of regions done to one.  This causes problems on ppc32 for the

s/done/down

 memory region as its assumed to only have one region.
 
 We can fix this be easily specially casing the initial add to just replace
 the dummy region.
 
 ---

 Posting this since Dave's looking a pulling the lmb code out into lib/ and
 sharing it between powerpc and sparc.

Did you want to S-o-b: this patch?  Or was this just informational?

Thanks,
jdl
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base

2008-02-13 Thread David Miller
From: Kumar Gala [EMAIL PROTECTED]
Date: Wed, 13 Feb 2008 07:37:27 -0600 (CST)

 If we add to an empty lmb region with a non-zero base we will not coalesce
 the number of regions done to one.  This causes problems on ppc32 for the
 memory region as its assumed to only have one region.
 
 We can fix this be easily specially casing the initial add to just replace
 the dummy region.
 
 ---
 
 Posting this since Dave's looking a pulling the lmb code out into lib/ and
 sharing it between powerpc and sparc.
 
 (this is my git tree 
 git.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git)

I noticed this issue when I use lmb on sparc64 and I intended to bring
it up eventually.  Thanks for fixing it!
-
To unsubscribe from this list: send the line unsubscribe sparclinux in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html