[PATCH] spi/pl022: Activate resourses before deactivate them in suspend
From: Ulf Hansson ulf.hans...@linaro.org To be able to deactivate resourses in suspend, the resourses must first be surely active. This is done with a pm_runtime_get_sync. Once the resourses are restored to active state again in resume, the runtime pm usage count can be decreased with a pm_runtime_put. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/spi/spi-pl022.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 9194641..c3590e0 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2350,6 +2350,8 @@ static int pl022_suspend(struct device *dev) dev_warn(dev, cannot suspend master\n); return ret; } + + pm_runtime_get_sync(dev); pl022_suspend_resources(pl022); dev_dbg(dev, suspended\n); @@ -2362,6 +2364,7 @@ static int pl022_resume(struct device *dev) int ret; pl022_resume_resources(pl022); + pm_runtime_put(dev); /* Start the queue running */ ret = spi_master_resume(pl022-master); -- 1.7.10 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi: spi-rspi: fix build error for the latest shdma driver
On Thu, Aug 02, 2012 at 05:17:33PM +0900, Shimoda, Yoshihiro wrote: Because the latest shdma driver changed, it caused build error in the spi-rspi driver. This patch fixed the build error. Applied, thanks. This should really have been done as part of the shdma update... -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi: tsc2005: delete soon-obsolete e-mail address
On Fri, Aug 17, 2012 at 02:47:30PM +0300, Aaro Koskinen wrote: Delete soon-obsolete e-mail address. Applied, thanks. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 3/3] spi: spi-pl022: Minor simplification for runtime pm
On Thu, Oct 4, 2012 at 11:07 AM, Ulf Hansson ulf.hans...@linaro.org wrote:
Mark, I am not sure this particular patch is actually wanted. Realized
that when reading up on the driver/base/* patches for PM changes this
summer. Especially how device probe/suspend/shutdown etc. has been
changed for runtime PM point of view.
Mark will get you for top-posting ;-)
From: Ulf Hansson ulf.hans...@linaro.org
In probe pm_runtime_put_autosuspend has the same effect as doing
pm_runtime_put. This due to upper layer in driver core is preventing
the device from being runtime suspended by a pm_runtime_get*.
Signed-off-by: Ulf Hansson ulf.hans...@linaro.org
Reviewed-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-pl022.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index a1db91a..51b7a95 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2246,10 +2246,9 @@ pl022_probe(struct amba_device *adev, const struct
amba_id *id)
pm_runtime_set_autosuspend_delay(dev,
platform_info-autosuspend_delay);
pm_runtime_use_autosuspend(dev);
- pm_runtime_put_autosuspend(dev);
- } else {
- pm_runtime_put(dev);
}
+ pm_runtime_put(dev);
+
return 0;
I'm paging Rafael and Magnus for their comments so we don't
overload Mark with runtime PM semantics...
Yours,
Linus Walleij
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/3] spi: spi-pl022: Fixup use of runtime pm
On Thu, Oct 4, 2012 at 10:04 AM, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org Some old runtime pm patches got merged whiched messed up things. These are now reverted. Additionaly one patch do a simplification of the use of runtime pm functions. V2: Rebased patches and updated commit messages. Ulf Hansson (3): Revert spi/pl022: fix spi-pl022 pm enable at probe Revert spi/pl022: enable runtime PM spi: spi-pl022: Minor simplification for runtime pm I think patch 1/3 and 2/3 needs to go into the -rc fixes. Who's funneling this now? Grant or Mark? Yours, Linus Walleij -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe
On Thu, Oct 04, 2012 at 10:04:39AM +0200, Ulf Hansson wrote: From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 6887237cd7da904184dab2750504040c68f3a080. This reverts is done due to earlier wrong commit, which is also reverted. Revert spi/pl022: enable runtime PM Why? Wrong isn't terribly detailed... -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/3] spi: spi-pl022: Fixup use of runtime pm
On Fri, Oct 05, 2012 at 02:21:15PM +0200, Linus Walleij wrote: I think patch 1/3 and 2/3 needs to go into the -rc fixes. Who's funneling this now? Grant or Mark? Me still for the moment. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 15/16] spi/s3c64xx: use correct dma_transfer_direction type
There is a subtle difference between dma_transfer_direction and
dma_data_direction: the former is used by the dmaengine framework,
while the latter is used by the dma-mapping API. Although the
purpose is comparable, the actual values are different and must
not be mixed. In this case, the driver just wants to use
dma_transfer_direction.
Without this patch, building s3c6400_defconfig results in:
drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_dmacb':
drivers/spi/spi-s3c64xx.c:239:21: warning: comparison between
'enum dma_data_direction' and 'enum dma_transfer_direction'
[-Wenum-compare]
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Ben Dooks ben-li...@fluff.org
Cc: Kukjin Kim kgene@samsung.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Cc: spi-devel-general@lists.sourceforge.net
---
drivers/spi/spi-s3c64xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index d1c8441f..2e44dd6 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -132,7 +132,7 @@
struct s3c64xx_spi_dma_data {
unsignedch;
- enum dma_data_direction direction;
+ enum dma_transfer_direction direction;
enum dma_ch dmach;
struct property *dma_prop;
};
--
1.7.10
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/3] spi: spi-pl022: Fixup use of runtime pm
On 5 October 2012 14:23, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Oct 05, 2012 at 02:21:15PM +0200, Linus Walleij wrote: I think patch 1/3 and 2/3 needs to go into the -rc fixes. Who's funneling this now? Grant or Mark? Me still for the moment. I will post a new series, removing the 3/3 patch and updating the commitmsg accordingly. Kind regards Ulf Hansson -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 2/2] Revert spi/pl022: enable runtime PM
From: Ulf Hansson ulf.hans...@linaro.org
This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99.
This patch introduced runtime PM issues and is not needed at all.
Thus we should revert it.
Conflicts:
drivers/spi/spi-pl022.c
Signed-off-by: Ulf Hansson ulf.hans...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-pl022.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index 5cf0643..a1db91a 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2186,9 +2186,6 @@ pl022_probe(struct amba_device *adev, const struct
amba_id *id)
printk(KERN_INFO pl022: mapped registers from 0x%08x to %p\n,
adev-res.start, pl022-virtbase);
- pm_runtime_enable(dev);
- pm_runtime_resume(dev);
-
pl022-clk = devm_clk_get(adev-dev, NULL);
if (IS_ERR(pl022-clk)) {
status = PTR_ERR(pl022-clk);
@@ -2293,7 +2290,6 @@ pl022_remove(struct amba_device *adev)
clk_disable(pl022-clk);
clk_unprepare(pl022-clk);
- pm_runtime_disable(adev-dev);
amba_release_regions(adev);
tasklet_disable(pl022-pump_transfers);
spi_unregister_master(pl022-master);
--
1.7.10
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 1/2] Revert spi/pl022: fix spi-pl022 pm enable at probe
From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 6887237cd7da904184dab2750504040c68f3a080. Commit spi/pl022: enable runtime PM introduced runtime PM issues. Due to that commit, spi/pl022: fix spi-pl022 pm enable at probe was merged to fix part of those issues. Instead of adding another fix, let's clean up and revert everything back to when it was already fine. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 9194641..5cf0643 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2186,6 +2186,7 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id) printk(KERN_INFO pl022: mapped registers from 0x%08x to %p\n, adev-res.start, pl022-virtbase); + pm_runtime_enable(dev); pm_runtime_resume(dev); pl022-clk = devm_clk_get(adev-dev, NULL); -- 1.7.10 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Offre Promo 2 mois offerts
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTIxNjk2JmM9NDgzNjEyJmQ9MjAxMi0xMC0wNiAwNToxMDowMSZlPTEmaD0yMTY5NSZmPTIxNjk2Jmc9MjE2OTY= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTIxNjk2JmM9NDgzNjEyJmQ9MjAxMi0xMC0wNiAwNToxMDowMSZlPTEmaD0yMTY5NSZmPTIxNjk2Jmc9MjE2OTY= -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Mois anniversaire : tous les jours des offres de folie jusqu'a moins 72 pourcent
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTIxNzMzJmM9NDgzNjEyJmQ9MjAxMi0xMC0wNiAwNToxMDowMSZlPTEmaD0yMTczMiZmPTIxNzMzJmc9MjE3MzM= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTIxNzMzJmM9NDgzNjEyJmQ9MjAxMi0xMC0wNiAwNToxMDowMSZlPTEmaD0yMTczMiZmPTIxNzMzJmc9MjE3MzM= -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
