Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-11 Thread Sekhar Nori 
On 3/6/2013 9:45 PM, Matt Porter wrote:
> The binding definition is based on the generic DMA controller
> binding.
> 
> Signed-off-by: Matt Porter 

Okay the bindings the documented after they are used leading to some
confusion. This patch should be moved up the series. As I noted in my
other e-mail, some of these bindings are not really hardware description
and need to be re-looked.

Thanks,
Sekhar

> ---
>  Documentation/devicetree/bindings/dma/ti-edma.txt |   49 
> +
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/ti-edma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/ti-edma.txt 
> b/Documentation/devicetree/bindings/dma/ti-edma.txt
> new file mode 100644
> index 000..075a60e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti-edma.txt
> @@ -0,0 +1,49 @@
> +TI EDMA
> +
> +Required properties:
> +- compatible : "ti,edma3"
> +- ti,hwmods: Name of the hwmods associated to the EDMA
> +- ti,edma-regions: Number of regions
> +- ti,edma-slots: Number of slots
> +- ti,edma-queue-tc-map: List of transfer control to queue mappings
> +- ti,edma-queue-priority-map: List of queue priority mappings
> +- ti,edma-default-queue: Default queue value
> +
> +Optional properties:
> +- ti,edma-reserved-channels: List of reserved channel regions
> +- ti,edma-reserved-slots: List of reserved slot regions
> +- ti,edma-xbar-event-map: Crossbar event to channel map
> +
> +Example:
> +
> +edma: edma@4900 {
> + reg = <0x4900 0x1>;
> + interrupt-parent = <&intc>;
> + interrupts = <12 13 14>;
> + compatible = "ti,edma3";
> + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2";
> + #dma-cells = <1>;
> + dma-channels = <64>;
> + ti,edma-regions = <4>;
> + ti,edma-slots = <256>;
> + ti,edma-reserved-channels = <0  2
> +  14 2
> +  26 6
> +  48 4
> +  56 8>;
> + ti,edma-reserved-slots = <0  2
> +   14 2
> +   26 6
> +   48 4
> +   56 8
> +   64 127>;
> + ti,edma-queue-tc-map = <0 0
> + 1 1
> + 2 2>;
> + ti,edma-queue-priority-map = <0 0
> +   1 1
> +   2 2>;
> + ti,edma-default-queue = <0>;
> + ti,edma-xbar-event-map = <1 12
> +   2 13>;
> +};
> 

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH v9 3/9] ARM: edma: add AM33XX support to the private EDMA API

2013-03-11 Thread Sekhar Nori 


On 3/6/2013 9:45 PM, Matt Porter wrote:
> Adds support for parsing the TI EDMA DT data into the
> required EDMA private API platform data. Enables runtime
> PM support to initialize the EDMA hwmod. Adds AM33XX EDMA
> crossbar event mux support. Enables build on OMAP.
> 
> Signed-off-by: Matt Porter 
> Acked-by: Sekhar Nori 
> ---
>  arch/arm/common/edma.c |  300 
> ++--
>  arch/arm/mach-omap2/Kconfig|1 +
>  include/linux/platform_data/edma.h |1 +
>  3 files changed, 292 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
> index a1db6cd..e68ac38 100644
> --- a/arch/arm/common/edma.c
> +++ b/arch/arm/common/edma.c
> @@ -24,6 +24,13 @@
>  #include 
>  #include 
>  #include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
>  
>  #include 
>  
> @@ -1369,31 +1376,278 @@ void edma_clear_event(unsigned channel)
>  EXPORT_SYMBOL(edma_clear_event);
>  
>  /*---*/
> +static int edma_of_read_u32_to_s8_array(const struct device_node *np,
> +  const char *propname, s8 *out_values,
> +  size_t sz)
> +{
> + int ret;
> +
> + ret = of_property_read_u8_array(np, propname, out_values, sz);
> + if (ret)
> + return ret;
> +
> + /* Terminate it */
> + *out_values++ = -1;
> + *out_values++ = -1;
> +
> + return 0;
> +}
> +
> +static int edma_of_read_u32_to_s16_array(const struct device_node *np,
> +  const char *propname, s16 *out_values,
> +  size_t sz)
> +{
> + int ret;
> +
> + ret = of_property_read_u16_array(np, propname, out_values, sz);
> + if (ret)
> + return ret;
> +
> + /* Terminate it */
> + *out_values++ = -1;
> + *out_values++ = -1;
> +
> + return 0;
> +}
> +
> +static int edma_xbar_event_map(struct device *dev,
> +struct device_node *node,
> +struct edma_soc_info *pdata, int len)
> +{

It will be nice to separate the xbar feature from DT'fication of the
existing driver. Right now because of the mix the patch has become
pretty big and its becoming tough to review in isolation.

> + int ret = 0;
> + int i;
> + struct resource res;
> + void *xbar;
> + const s16 (*xbar_chans)[2];
> + u32 shift, offset, mux;
> +
> + xbar_chans = devm_kzalloc(dev,
> +   len/sizeof(s16) + 2*sizeof(s16),
> +   GFP_KERNEL);
> + if (!xbar_chans)
> + return -ENOMEM;
> +
> + ret = of_address_to_resource(node, 1, &res);
> + if (ret)
> + return -EIO;
> +
> + xbar = devm_ioremap(dev, res.start, resource_size(&res));
> + if (!xbar)
> + return -ENOMEM;
> +
> + ret = edma_of_read_u32_to_s16_array(node,
> + "ti,edma-xbar-event-map",
> + (s16 *)xbar_chans,
> + len/sizeof(u32));
> + if (ret)
> + return -EIO;
> +
> + for (i = 0; xbar_chans[i][0] != -1; i++) {
> + shift = (xbar_chans[i][1] % 4) * 8;
> + offset = xbar_chans[i][1] >> 2;
> + offset <<= 2;
> + mux = readl((void *)((u32)xbar + offset));
> + mux &= ~(0xff << shift);
> + mux |= xbar_chans[i][0] << shift;
> + writel(mux, (void *)((u32)xbar + offset));
> + }
> +
> + pdata->xbar_chans = xbar_chans;
> +
> + return 0;
> +}
> +
> +static int edma_of_parse_dt(struct device *dev,
> + struct device_node *node,
> + struct edma_soc_info *pdata)
> +{
> + int ret = 0;
> + u32 value;
> + struct property *prop;
> + size_t sz;
> + struct edma_rsv_info *rsv_info;
> + const s16 (*rsv_chans)[2], (*rsv_slots)[2];
> + const s8 (*queue_tc_map)[2], (*queue_priority_map)[2];
> +
> + memset(pdata, 0, sizeof(struct edma_soc_info));
> +
> + ret = of_property_read_u32(node, "dma-channels", &value);
> + if (ret < 0)
> + return ret;
> + pdata->n_channel = value;
> +
> + ret = of_property_read_u32(node, "ti,edma-regions", &value);
> + if (ret < 0)
> + return ret;
> + pdata->n_region = value;
> +
> + ret = of_property_read_u32(node, "ti,edma-slots", &value);
> + if (ret < 0)
> + return ret;
> + pdata->n_slot = value;
> +
> + pdata->n_cc = 1;
> + pdata->n_tc = 3;

Will this mean the DT portion of this driver cannot be used on SoCs
where there are two CCs like DA850? If you are hard-coding this, will it
make sense to set to to EDMA_MAX_CC instead? Okay I see a comment down
below saying DT will support only one

Re: [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's

2013-03-11 Thread Girish KS 
On Sun, Mar 3, 2013 at 4:26 AM, Grant Likely  wrote:
> On Wed, 13 Feb 2013 12:03:46 -0800, Girish K S  wrote:
>> Currently the drivers supports only the GPIO based i/o pins.
>> But there are Exynos SoC's that use the same controller with
>> dedicated i/o pins.
>>
>> This patch  provides provision to support gpio/dedicated pins.
>> The decision is made by parsing the "gpios" property in the spi
>> node.
>>
>> Signed-off-by: Girish K S 
>> ---
>> changes in v2:
>>   Removed the gpio quirk. Parse the "gpios" property
>>   to decide whether  gpio / dedicated i/o lines should
>>   be used.
>
> It is perfectly valid to support both at the same time. The gpios
> property can be 'sparse' in that when a gpio is specified, use that for
> the CS control, but use a dedicated line with it is not. Instead of
> doing this it would be better off to switch this driver to use the new
> cs_gpios parsing in driver/spi/spi.c
what i understand from you comment is, you want me to use "cs-gpios"
property for cs control. correct me if i am wrong.
This particular patch is applicable only for MISO/MSIO/CLK. The CS pin
is handled as you mentioned in the next patch of this series.
>
> g.
>
>

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH V2] spi: add driver for BCM2835

2013-03-11 Thread Stephen Warren 
From: Chris Boot 

The BCM2835 contains two forms of SPI master controller (one known
simply as SPI0, and the other known as the "Universal SPI Master", in
the auxilliary block) and one form of SPI slave controller. This patch
adds support for the SPI0 controller.

This driver is taken from Chris Boot's repository at
git://github.com/bootc/linux.git rpi-linear
as of commit 6de2905 "spi-bcm2708: fix printf with spurious %s".
In the first SPI-related commit there, Chris wrote:

Thanks to csoutreach / A Robinson for his driver which I used as an
inspiration. You can find his version here:
http://piface.openlx.org.uk/raspberry-pi-spi-kernel-driver-available-for

Changes made during upstreaming:
* Renamed bcm2708 to bcm2835 as per upstream naming for this SoC.
* Removed support for brcm,realtime property.
* Increased transfer timeout to 30 seconds.
* Return IRQ_NONE from the IRQ handler if no interrupt was handled.
* Disable TA (Transfer Active) and clear FIFOs on a transfer timeout.
* Wrote device tree binding documentation.
* Request unnamed clock rather than "sys_pclk"; the DT will provide the
  correct clock.
* Assume that tfr->speed_hz and tfr->bits_per_word are always set in
  bcm2835_spi_start_transfer(), bcm2835_spi_transfer_one(), so no need
  to check spi->speed_hz or tft->bits_per_word.
* Re-ordered probe() to remove the need for temporary variables.
* Call clk_disable_unprepare() rather than just clk_unprepare() on probe()
  failure.
* Don't use devm_request_irq(), to ensure that the IRQ doesn't fire after
  we've torn down the device, but not unhooked the IRQ.
* Moved probe()'s call to clk_prepare_enable() so we can be sure the clock
  is enabled if the IRQ handler fires immediately.
* Remove redundant checks from bcm2835_spi_check_transfer() and
  bcm2835_spi_setup().
* Re-ordered IRQ handler to check for RXR before DONE. Added comments to
  ISR.
* Removed empty prepare/unprepare implementations.
* Removed use of devinit/devexit.
* Added BCM2835_ prefix to defines.

Signed-off-by: Chris Boot 
Signed-off-by: Stephen Warren 
---
v2:
* Removed support for brcm,realtime property.
* Increased transfer timeout to 30 seconds.
* Return IRQ_NONE from the IRQ handler if no interrupt was handled.
* Disable TA (Transfer Active) and clear FIFOs on a transfer timeout.
* Call clk_disable_unprepare() rather than just clk_unprepare() on probe()
  failure.
* Moved probe()'s call to clk_prepare_enable() so we can be sure the clock
  is enabled if the IRQ handler fires immediately.
* Remove redundant checks from bcm2835_spi_check_transfer() and
  bcm2835_spi_setup().
* Re-ordered IRQ handler to check for RXR before DONE. Added comments to
  ISR.
---
 .../devicetree/bindings/spi/brcm,bcm2835-spi.txt   |   22 +
 drivers/spi/Kconfig|   11 +
 drivers/spi/Makefile   |1 +
 drivers/spi/spi-bcm2835.c  |  456 
 4 files changed, 490 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt
 create mode 100644 drivers/spi/spi-bcm2835.c

diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt 
b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt
new file mode 100644
index 000..8bf89c6
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt
@@ -0,0 +1,22 @@
+Broadcom BCM2835 SPI0 controller
+
+The BCM2835 contains two forms of SPI master controller, one known simply as
+SPI0, and the other known as the "Universal SPI Master"; part of the
+auxilliary block. This binding applies to the SPI0 controller.
+
+Required properties:
+- compatible: Should be "brcm,bcm2835-spi".
+- reg: Should contain register location and length.
+- interrupts: Should contain interrupt.
+- clocks: The clock feeding the SPI controller.
+
+Example:
+
+spi@20204000 {
+   compatible = "brcm,bcm2835-spi";
+   reg = <0x7e204000 0x1000>;
+   interrupts = <2 22>;
+   clocks = <&clk_spi>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+};
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f80eee7..32b85d4 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -74,6 +74,17 @@ config SPI_ATMEL
  This selects a driver for the Atmel SPI Controller, present on
  many AT32 (AVR32) and AT91 (ARM) chips.
 
+config SPI_BCM2835
+   tristate "BCM2835 SPI controller"
+   depends on ARCH_BCM2835
+   help
+ This selects a driver for the Broadcom BCM2835 SPI master.
+
+ The BCM2835 contains two types of SPI master controller; the
+ "universal SPI master", and the regular SPI controller. This driver
+ is for the regular SPI controller. Slave mode operation is not also
+ not supported.
+
 config SPI_BFIN5XX
tristate "SPI controller driver for ADI Blackfin5xx"
depends on BLACKFIN
diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
index e53c309..3ce1d08 100644
--

RE: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel spi

2013-03-11 Thread Yang, Wenyou 
Hi JC,

> -Original Message-
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com]
> Sent: 2013年3月11日 21:11
> To: Yang, Wenyou
> Cc: linux-arm-ker...@lists.infradead.org; grant.lik...@secretlab.ca; Ferre,
> Nicolas; richard.gen...@gmail.com; Lin, JM;
> spi-devel-general@lists.sourceforge.net; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel spi
> 
> On 11:34 Thu 07 Mar , Wenyou Yang wrote:
> > Signed-off-by: Wenyou Yang 
> > Cc: spi-devel-general@lists.sourceforge.net
> > Cc: linux-ker...@vger.kernel.org
> > ---
> >  drivers/spi/spi-atmel.c |8 
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> > index 1e212d1..6b166f4 100644
> > --- a/drivers/spi/spi-atmel.c
> > +++ b/drivers/spi/spi-atmel.c
> > @@ -23,6 +23,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >
> >  #include 
> >  #include 
> > @@ -1493,11 +1494,18 @@ static int atmel_spi_probe(struct
> platform_device *pdev)
> > int ret;
> > struct spi_master   *master;
> > struct atmel_spi*as;
> > +   struct pinctrl  *pinctrl;
> >
> > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > if (!regs)
> > return -ENXIO;
> >
> > +   pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > +   if (IS_ERR(pinctrl)) {
> > +   dev_err(&pdev->dev, "Failed to request pinctrl\n");
> > +   return PTR_ERR(pinctrl);
> > +   }
> 
> drop this, this is handled at bus level
> 
Thanks a lot for your advance.

> Best Regards,
> J.

Best Regards
Wenyou Yang
> > +
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0)
> > return irq;
> > --
> > 1.7.9.5
> >
--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 03/12] spi/bcm63xx: properly prepare clocks before enabling them

2013-03-11 Thread Jonas Gorski 
Use proper clk_prepare/unprepare calls in preparation for switching
to the generic clock framework.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index d7df435..ef9b89f 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -493,7 +493,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
}
 
/* Initialize hardware */
-   clk_enable(bs->clk);
+   clk_prepare_enable(bs->clk);
bcm_spi_writeb(bs, SPI_INTR_CLEAR_ALL, SPI_INT_STATUS);
 
/* register and we are done */
@@ -509,7 +509,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
return 0;
 
 out_clk_disable:
-   clk_disable(clk);
+   clk_disable_unprepare(clk);
 out_err:
platform_set_drvdata(pdev, NULL);
spi_master_put(master);
@@ -530,7 +530,7 @@ static int bcm63xx_spi_remove(struct platform_device *pdev)
bcm_spi_writeb(bs, 0, SPI_INT_MASK);
 
/* HW shutdown */
-   clk_disable(bs->clk);
+   clk_disable_unprepare(bs->clk);
clk_put(bs->clk);
 
platform_set_drvdata(pdev, 0);
@@ -549,7 +549,7 @@ static int bcm63xx_spi_suspend(struct device *dev)
 
spi_master_suspend(master);
 
-   clk_disable(bs->clk);
+   clk_disable_unprepare(bs->clk);
 
return 0;
 }
@@ -560,7 +560,7 @@ static int bcm63xx_spi_resume(struct device *dev)
platform_get_drvdata(to_platform_device(dev));
struct bcm63xx_spi *bs = spi_master_get_devdata(master);
 
-   clk_enable(bs->clk);
+   clk_prepare_enable(bs->clk);
 
spi_master_resume(master);
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 04/12] spi/bcm63xx: remove duplicated mode bits check

2013-03-11 Thread Jonas Gorski 
The spi subsystem already checks the mode bits before calling setup.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index ef9b89f..79ad8bc 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -158,12 +158,6 @@ static int bcm63xx_spi_setup(struct spi_device *spi)
if (!spi->bits_per_word)
spi->bits_per_word = 8;
 
-   if (spi->mode & ~MODEBITS) {
-   dev_err(&spi->dev, "%s, unsupported mode bits %x\n",
-   __func__, spi->mode & ~MODEBITS);
-   return -EINVAL;
-   }
-
dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u nsec/bit\n",
__func__, spi->mode & MODEBITS, spi->bits_per_word, 0);
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 05/12] spi/bcm63xx: remove unneeded debug message

2013-03-11 Thread Jonas Gorski 
The spi subsystem already provides this info in a more extensive
debug print except for the nsecs/bit - which wasn't calculated anyway
and fixed to 0.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 79ad8bc..13806e3 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -158,9 +158,6 @@ static int bcm63xx_spi_setup(struct spi_device *spi)
if (!spi->bits_per_word)
spi->bits_per_word = 8;
 
-   dev_dbg(&spi->dev, "%s, mode %d, %u bits/w, %u nsec/bit\n",
-   __func__, spi->mode & MODEBITS, spi->bits_per_word, 0);
-
return 0;
 }
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 09/12] spi/bcm63xx: remove spi chip select validity check

2013-03-11 Thread Jonas Gorski 
The check would belong in bcm63xx_spi_setup if the spi subsystem
weren't already doing the check for us, so just drop it.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index b9c9431..9574e47 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -102,12 +102,6 @@ static int bcm63xx_spi_check_transfer(struct spi_device 
*spi,
return -EINVAL;
}
 
-   if (spi->chip_select > spi->master->num_chipselect) {
-   dev_err(&spi->dev, "%s, unsupported slave %d\n",
-   __func__, spi->chip_select);
-   return -EINVAL;
-   }
-
return 0;
 }
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 01/12] spi/bcm63xx: Remove unused variable

2013-03-11 Thread Jonas Gorski 
From: Kevin Cernekee 

This fixes the following warning:

drivers/spi/spi-bcm63xx.c: In function 'bcm63xx_spi_setup':
drivers/spi/spi-bcm63xx.c:157:6: warning: unused variable 'ret'

Signed-off-by: Kevin Cernekee 
---
 drivers/spi/spi-bcm63xx.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 9578af7..0415a32 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -152,7 +152,6 @@ static void bcm63xx_spi_setup_transfer(struct spi_device 
*spi,
 static int bcm63xx_spi_setup(struct spi_device *spi)
 {
struct bcm63xx_spi *bs;
-   int ret;
 
bs = spi_master_get_devdata(spi->master);
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 08/12] spi/bcm63xx: simplify bcm63xx_spi_check_transfer

2013-03-11 Thread Jonas Gorski 
bcm63xx_spi_check_transfer is only called from one place that has
t always set, so directly check the transfer's bits_per_word.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index b64229c..b9c9431 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -96,12 +96,9 @@ static const unsigned 
bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
 static int bcm63xx_spi_check_transfer(struct spi_device *spi,
struct spi_transfer *t)
 {
-   u8 bits_per_word;
-
-   bits_per_word = (t) ? t->bits_per_word : spi->bits_per_word;
-   if (bits_per_word != 8) {
+   if (t->bits_per_word != 8) {
dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
-   __func__, bits_per_word);
+   __func__, t->bits_per_word);
return -EINVAL;
}
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 12/12] spi/bcm63xx: use devm_ioremap_resource()

2013-03-11 Thread Jonas Gorski 
Use devm_ioremap_resource() which provides its own error messages.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |   15 +++
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 2d64db4..973099b 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -412,18 +412,9 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, master);
bs->pdev = pdev;
 
-   if (!devm_request_mem_region(&pdev->dev, r->start,
-   resource_size(r), PFX)) {
-   dev_err(dev, "iomem request failed\n");
-   ret = -ENXIO;
-   goto out_err;
-   }
-
-   bs->regs = devm_ioremap_nocache(&pdev->dev, r->start,
-   resource_size(r));
-   if (!bs->regs) {
-   dev_err(dev, "unable to ioremap regs\n");
-   ret = -ENOMEM;
+   bs->regs = devm_ioremap_resource(&pdev->dev, r);
+   if (IS_ERR(bs->regs)) {
+   ret = PTR_ERR(bs->regs);
goto out_err;
}
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 02/12] spi/bcm63xx: don't disable non enabled clocks in probe error path

2013-03-11 Thread Jonas Gorski 
When msg_ctl_width is set to an invalid value we try to disable the
clock despite it never being enabled. Fix it by jumping to the correct
label.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 0415a32..d7df435 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -489,7 +489,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
default:
dev_err(dev, "unsupported MSG_CTL width: %d\n",
 bs->msg_ctl_width);
-   goto out_clk_disable;
+   goto out_err;
}
 
/* Initialize hardware */
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 11/12] spi/bcm63xx: inline hz usage in bcm63xx_spi_setup_transfer

2013-03-11 Thread Jonas Gorski 
bcm63xx_spi_setup_transfer is called from only one place, and that has
t always set, to hz will always be t->speed_hz - just use it directly in
the two places instead of moving it in a local variable.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index d777f63..2d64db4 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -97,15 +97,12 @@ static void bcm63xx_spi_setup_transfer(struct spi_device 
*spi,
  struct spi_transfer *t)
 {
struct bcm63xx_spi *bs = spi_master_get_devdata(spi->master);
-   u32 hz;
u8 clk_cfg, reg;
int i;
 
-   hz = (t) ? t->speed_hz : spi->max_speed_hz;
-
/* Find the closest clock configuration */
for (i = 0; i < SPI_CLK_MASK; i++) {
-   if (hz >= bcm63xx_spi_freq_table[i][0]) {
+   if (t->speed_hz >= bcm63xx_spi_freq_table[i][0]) {
clk_cfg = bcm63xx_spi_freq_table[i][1];
break;
}
@@ -122,7 +119,7 @@ static void bcm63xx_spi_setup_transfer(struct spi_device 
*spi,
 
bcm_spi_writeb(bs, reg, SPI_CLK_CFG);
dev_dbg(&spi->dev, "Setting clock register to %02x (hz %d)\n",
-   clk_cfg, hz);
+   clk_cfg, t->speed_hz);
 }
 
 /* the spi->mode bits understood by this driver: */
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 00/12] spi/bcm63xx: various small cleanups and fixes

2013-03-11 Thread Jonas Gorski 
This patch series cleans up spi-bcm63xx and removes mostly redundant
checks that are already done by the spi core system itself, and also
adds some clock handling improvements. All in all nothing serious,
just some corner cases.

The only Patch I'm not 100% sure about is patch 7/12 ("check spi
bits_per_word in spi_setup"), because I'm not sure if setup is the
right place for that.

For all we care the spi can claim what it wants as its bit_per_word
as long as all transfers have it set to 8, so arguably we maybe
shouldn't reject it then.

Jonas Gorski (11):
  spi/bcm63xx: don't disable non enabled clocks in probe error path
  spi/bcm63xx: properly prepare clocks before enabling them
  spi/bcm63xx: remove duplicated mode bits check
  spi/bcm63xx: remove unneeded debug message
  spi/bcm63xx: remove unused variable bs from bcm63xx_spi_setup
  spi/bcm63xx: check spi bits_per_word in spi_setup
  spi/bcm63xx: simplify bcm63xx_spi_check_transfer
  spi/bcm63xx: remove spi chip select validity check
  spi/bcm63xx: inline bcm63xx_spi_check_transfer
  spi/bcm63xx: inline hz usage in bcm63xx_spi_setup_transfer
  spi/bcm63xx: use devm_ioremap_resource()

Kevin Cernekee (1):
  spi/bcm63xx: Remove unused variable

 drivers/spi/spi-bcm63xx.c |   79 +++--
 1 file changed, 19 insertions(+), 60 deletions(-)

-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 10/12] spi/bcm63xx: inline bcm63xx_spi_check_transfer

2013-03-11 Thread Jonas Gorski 
It only does one check, so just do the check directly in the caller.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |   19 +--
 1 file changed, 5 insertions(+), 14 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 9574e47..d777f63 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -93,18 +93,6 @@ static const unsigned 
bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
{   391000, SPI_CLK_0_391MHZ }
 };
 
-static int bcm63xx_spi_check_transfer(struct spi_device *spi,
-   struct spi_transfer *t)
-{
-   if (t->bits_per_word != 8) {
-   dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
-   __func__, t->bits_per_word);
-   return -EINVAL;
-   }
-
-   return 0;
-}
-
 static void bcm63xx_spi_setup_transfer(struct spi_device *spi,
  struct spi_transfer *t)
 {
@@ -293,9 +281,12 @@ static int bcm63xx_spi_transfer_one(struct spi_master 
*master,
 * full-duplex transfers.
 */
list_for_each_entry(t, &m->transfers, transfer_list) {
-   status = bcm63xx_spi_check_transfer(spi, t);
-   if (status < 0)
+   if (t->bits_per_word != 8) {
+   dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
+   __func__, t->bits_per_word);
+   status = -EINVAL;
goto exit;
+   }
 
if (!first)
first = t;
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 06/12] spi/bcm63xx: remove unused variable bs from bcm63xx_spi_setup

2013-03-11 Thread Jonas Gorski 
It is only written, but never read.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 13806e3..04c460e 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -151,10 +151,6 @@ static void bcm63xx_spi_setup_transfer(struct spi_device 
*spi,
 
 static int bcm63xx_spi_setup(struct spi_device *spi)
 {
-   struct bcm63xx_spi *bs;
-
-   bs = spi_master_get_devdata(spi->master);
-
if (!spi->bits_per_word)
spi->bits_per_word = 8;
 
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 07/12] spi/bcm63xx: check spi bits_per_word in spi_setup

2013-03-11 Thread Jonas Gorski 
Instead of fixing up the bits_per_word (which the spi subsystem already
does for us), check it for supported values.

Signed-off-by: Jonas Gorski 
---
 drivers/spi/spi-bcm63xx.c |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 04c460e..b64229c 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -151,8 +151,11 @@ static void bcm63xx_spi_setup_transfer(struct spi_device 
*spi,
 
 static int bcm63xx_spi_setup(struct spi_device *spi)
 {
-   if (!spi->bits_per_word)
-   spi->bits_per_word = 8;
+   if (spi->bits_per_word != 8) {
+   dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
+   __func__, spi->bits_per_word);
+   return -EINVAL;
+   }
 
return 0;
 }
-- 
1.7.10.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH v2] spi: spi-mpc512x-psc: add support for gpio chip selects

2013-03-11 Thread Anatolij Gustschin 
Currently the driver only uses one internal chip select.
Add support for gpio chip selects configured by cs-gpios
DT binding.

Signed-off-by: Anatolij Gustschin 
---
v2:
 - do not parse GPIO chip selects manually

 drivers/spi/spi-mpc512x-psc.c |   31 +--
 1 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 89480b2..4263ed4 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 struct mpc512x_psc_spi {
@@ -113,7 +114,7 @@ static void mpc512x_psc_spi_activate_cs(struct spi_device 
*spi)
out_be32(&psc->ccr, ccr);
mps->bits_per_word = cs->bits_per_word;
 
-   if (mps->cs_control)
+   if (mps->cs_control && gpio_is_valid(spi->cs_gpio))
mps->cs_control(spi, (spi->mode & SPI_CS_HIGH) ? 1 : 0);
 }
 
@@ -121,7 +122,7 @@ static void mpc512x_psc_spi_deactivate_cs(struct spi_device 
*spi)
 {
struct mpc512x_psc_spi *mps = spi_master_get_devdata(spi->master);
 
-   if (mps->cs_control)
+   if (mps->cs_control && gpio_is_valid(spi->cs_gpio))
mps->cs_control(spi, (spi->mode & SPI_CS_HIGH) ? 0 : 1);
 
 }
@@ -278,6 +279,7 @@ static int mpc512x_psc_spi_setup(struct spi_device *spi)
struct mpc512x_psc_spi *mps = spi_master_get_devdata(spi->master);
struct mpc512x_psc_spi_cs *cs = spi->controller_state;
unsigned long flags;
+   int ret;
 
if (spi->bits_per_word % 8)
return -EINVAL;
@@ -286,6 +288,19 @@ static int mpc512x_psc_spi_setup(struct spi_device *spi)
cs = kzalloc(sizeof *cs, GFP_KERNEL);
if (!cs)
return -ENOMEM;
+
+   if (gpio_is_valid(spi->cs_gpio)) {
+   ret = gpio_request(spi->cs_gpio, dev_name(&spi->dev));
+   if (ret) {
+   dev_err(&spi->dev, "can't get CS gpio: %d\n",
+   ret);
+   kfree(cs);
+   return ret;
+   }
+   gpio_direction_output(spi->cs_gpio,
+   spi->mode & SPI_CS_HIGH ? 0 : 1);
+   }
+
spi->controller_state = cs;
}
 
@@ -319,6 +334,8 @@ static int mpc512x_psc_spi_transfer(struct spi_device *spi,
 
 static void mpc512x_psc_spi_cleanup(struct spi_device *spi)
 {
+   if (gpio_is_valid(spi->cs_gpio))
+   gpio_free(spi->cs_gpio);
kfree(spi->controller_state);
 }
 
@@ -405,6 +422,11 @@ static irqreturn_t mpc512x_psc_spi_isr(int irq, void 
*dev_id)
return IRQ_NONE;
 }
 
+static void mpc512x_spi_cs_control(struct spi_device *spi, bool onoff)
+{
+   gpio_set_value(spi->cs_gpio, onoff);
+}
+
 /* bus_num is used only for the case dev->platform_data == NULL */
 static int mpc512x_psc_spi_do_probe(struct device *dev, u32 regaddr,
  u32 size, unsigned int irq,
@@ -425,12 +447,9 @@ static int mpc512x_psc_spi_do_probe(struct device *dev, 
u32 regaddr,
mps->irq = irq;
 
if (pdata == NULL) {
-   dev_err(dev, "probe called without platform data, no "
-   "cs_control function will be called\n");
-   mps->cs_control = NULL;
+   mps->cs_control = mpc512x_spi_cs_control;
mps->sysclk = 0;
master->bus_num = bus_num;
-   master->num_chipselect = 255;
} else {
mps->cs_control = pdata->cs_control;
mps->sysclk = pdata->sysclk;
-- 
1.7.5.4


--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 00/12] spi/bcm63xx: various small cleanups and fixes

2013-03-11 Thread Florian Fainelli 
On Tuesday 12 March 2013 00:13:35 Jonas Gorski wrote:
> This patch series cleans up spi-bcm63xx and removes mostly redundant
> checks that are already done by the spi core system itself, and also
> adds some clock handling improvements. All in all nothing serious,
> just some corner cases.
> 
> The only Patch I'm not 100% sure about is patch 7/12 ("check spi
> bits_per_word in spi_setup"), because I'm not sure if setup is the
> right place for that.
> 
> For all we care the spi can claim what it wants as its bit_per_word
> as long as all transfers have it set to 8, so arguably we maybe
> shouldn't reject it then.

For the entire serie:
Acked-by: Florian Fainelli 

thanks Jonas!
-- 
Florian

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 2/2] spi: spi-mpc512x-psc: add support for gpio chip selects

2013-03-11 Thread Anatolij Gustschin 
On Tue, 05 Feb 2013 14:18:46 +
Grant Likely  wrote:

> On Mon, 14 Jan 2013 21:27:01 +0100, Anatolij Gustschin  wrote:
> > Currently the driver only uses one internal chip select. Add support
> > for gpio chip selects configured by gpio specifiers in the device tree.
> > 
> > Signed-off-by: Anatolij Gustschin 
> 
> GPIO chip selects are now in the core spi library. Take a look at
> master->cs_gpios and Documentation/devicetree/bindings/spi/spi-bus.txt.
> You don't need to parse them manually.

Thanks for the hint! I'll rework the patch and resubmit.

Anatolij

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH] spi: s3c64xx: let device core setup the default pin configuration

2013-03-11 Thread Doug Anderson 
Thomas,

On Wed, Mar 6, 2013 at 3:42 AM, Thomas Abraham
 wrote:
> With device core now able to setup the default pin configuration,
> the pin configuration code based on the deprecated Samsung specific
> gpio bindings is removed.
>
> Signed-off-by: Thomas Abraham 
> ---
>  .../devicetree/bindings/spi/spi-samsung.txt|8 +--
>  drivers/spi/spi-s3c64xx.c  |   66 +--
>  2 files changed, 6 insertions(+), 68 deletions(-)

With  on exynos5250-snow
(ARM Chromebook):

Reviewed-by: Doug Anderson 
Tested-by: Doug Anderson 

-Doug

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[SPAM] Votre complémentaire santé à partir de 10,83 euros par mois

2013-03-11 Thread Mutuelle Bleue par Vitoule 

Complémentaire santé

à partir de10,83€ / mois(1)
CÉLIBATAIRE
exigeant

a trouvé mutuelle
efficace

à prix mini
(http://obfm43.com/qykjnuelgm1iw1foss/index0.html)
OFFRES
EXCLUSIVES
2013(2)
5
sÉjours center parcs

  À gagner(3)

jusqu´au 31/03/2013
Avec Mutuelle Bleue, trouvez vous aussi
LA protection adaptée à vos besoins
(1) Tarif en vigueur à la date du 01/01/2013, garantie Hospi Soins pour un 
adulte de 20 ans résidant en Isère.

(2) Offres soumises à conditions.

(3) Par tirage au sort. Valeur unitaire des séjours : 2 000 € TTC. Le règlement 
des opérations est déposé à la SELARL Michaud Jorry André et Tixier - Huissiers 
de justice Associés à Melun (77). Il est adressé à titre gratuit à toute 
personne qui en fait la demande auprès de Mutuelle Bleue 14 rue René Cassin 
77014 Melun Cedex.

Mutuelle soumise aux dispositions du Livre II du Code de la Mutualité. SIREN n° 
775 671 993.

Crédits photos : Getty Images - Pierre & Vacances
Document et photos non contractuels.
--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH v6 12/16] spi/spi-atmel: add pinctrl support for atmel spi

2013-03-11 Thread Jean-Christophe PLAGNIOL-VILLARD 
On 11:34 Thu 07 Mar , Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang 
> Cc: spi-devel-general@lists.sourceforge.net
> Cc: linux-ker...@vger.kernel.org
> ---
>  drivers/spi/spi-atmel.c |8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 1e212d1..6b166f4 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -23,6 +23,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  #include 
>  #include 
> @@ -1493,11 +1494,18 @@ static int atmel_spi_probe(struct platform_device 
> *pdev)
>   int ret;
>   struct spi_master   *master;
>   struct atmel_spi*as;
> + struct pinctrl  *pinctrl;
>  
>   regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   if (!regs)
>   return -ENXIO;
>  
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl)) {
> + dev_err(&pdev->dev, "Failed to request pinctrl\n");
> + return PTR_ERR(pinctrl);
> + }

drop this, this is handled at bus level

Best Regards,
J.
> +
>   irq = platform_get_irq(pdev, 0);
>   if (irq < 0)
>   return irq;
> -- 
> 1.7.9.5
> 

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Un site web qui s adapte automatiquement aux smartphones et tablettes

2013-03-11 Thread laurent thenaud - altaéa 
Un site web qui s adapte automatiquement aux smartphones et tablettes

Le futur pour votre site web !

Un site web qui s'adapte automatiquement aux smartphones et tablettes

Vous ne visualisez pas correctement ce mail? version web ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fwww.altaea.com%2Fnewsletter%2Fun-site-web-qui-s-adapte-automatiquement-aux-smartphones-et-tablettes-3%2F&c=0
 ) 

http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fwww.altaea.com%2Flavenir-du-web-le-responsive-web-design%2F&c=0

Vous avez reçu cet email parce que vous vous êtes inscrit à agence de 
communication Paris La Défense (92) ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fwww.altaea.com&c=0
 ) via spi-devel-general@lists.sourceforge.net ( 
mailto:spi-devel-general@lists.sourceforge.net )]. Si vous ne voulez plus 
recevoir d'email merci de vous désinscription ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fwww.altaea.com%2Fnewsletter-2%2F%3Funsubscribe%3D8bc2619ef25f0262c75b2577baa0ea1a&c=0
 )
© 2013 agence de communication Paris La Défense (92), Tous droits réservés

( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=https%3A%2F%2Ftwitter.com&c=0
 ) ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=https%3A%2F%2Ffacebook.com&c=0
 ) ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fwindows.com&c=0
 ) ( 
http://www.altaea.com/?mymail=383244&k=177e60514af7dac5cd855407b70a143b&t=http%3A%2F%2Fapple.com&c=0
 )

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

RE: [PATCH v2 1/4] spi/davinci: add DT binding documentation

2013-03-11 Thread Manjunathappa, Prakash 
On Wed, Mar 06, 2013 at 01:02:41, Arnd Bergmann wrote:
> On Tuesday 05 March 2013, Manjunathappa, Prakash wrote:
> > On Mon, Mar 04, 2013 at 21:59:16, Arnd Bergmann wrote:
> > > On Monday 04 March 2013 18:29:12 Manjunathappa, Prakash wrote:
> > > > +- reg: Offset and length of SPI controller register space
> > > > +- num-cs: Number of chip selects
> > > > +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> > > > +   IP to the interrupt controller withn the SoC. Possible values
> > > > +   are 0 and 1. Manual says one of the two possible interrupt
> > > > +   lines can be tied to the interrupt controller. Set this
> > > > +   based on a specifc SoC configuration.
> > > > +- interrupts: interrupt number offset at the irq parent
> > > 
> > > I would not call this an "offset". It is an interrupt descriptor
> > > which may be something other than a simple number.
> > > 
> > 
> > I am planning to drop from this documentation as it is common property.
> 
> I think it makese sense to document the fact that there should be exactly
> one interrupt listed in the interrupts property, especially since the
> hardware has two outputs.
> 

Agreed, will consider this property for documenting.

Thanks,
Prakash

--
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general