Re: [PATCH 1/2] spi: spi-oc-tiny: Use of_match_ptr() macro
Hi Sachin,
On 03/14/2013 06:01 PM, Sachin Kamat wrote:
> This eliminates having an #ifdef returning NULL for the case
> when OF is disabled.
>
> Signed-off-by: Sachin Kamat
> Cc: Thomas Chou
> ---
> drivers/spi/spi-oc-tiny.c |4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Acked-by: Thomas Chou
Thanks.
Thomas
>
> diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c
> index cb2e284..e60a776 100644
> --- a/drivers/spi/spi-oc-tiny.c
> +++ b/drivers/spi/spi-oc-tiny.c
> @@ -393,8 +393,6 @@ static const struct of_device_id tiny_spi_match[] = {
> {},
> };
> MODULE_DEVICE_TABLE(of, tiny_spi_match);
> -#else /* CONFIG_OF */
> -#define tiny_spi_match NULL
> #endif /* CONFIG_OF */
>
> static struct platform_driver tiny_spi_driver = {
> @@ -404,7 +402,7 @@ static struct platform_driver tiny_spi_driver = {
> .name = DRV_NAME,
> .owner = THIS_MODULE,
> .pm = NULL,
> - .of_match_table = tiny_spi_match,
> + .of_match_table = of_match_ptr(tiny_spi_match),
> },
> };
> module_platform_driver(tiny_spi_driver);
>
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Votre complémentaire santé à partir de 10,83 euros par mois
Complémentaire santé à partir de10,83€ / mois(1) CÉLIBATAIRE exigeant a trouvé mutuelle efficace à prix mini (http://obfm43.com/yjynlng51tc14rg4go/index0.html) OFFRES EXCLUSIVES 2013(2) 5 sÉjours center parcs À gagner(3) jusqu´au 31/03/2013 Avec Mutuelle Bleue, trouvez vous aussi LA protection adaptée à vos besoins (1) Tarif en vigueur à la date du 01/01/2013, garantie Hospi Soins pour un adulte de 20 ans résidant en Isère. (2) Offres soumises à conditions. (3) Par tirage au sort. Valeur unitaire des séjours : 2 000 € TTC. Le règlement des opérations est déposé à la SELARL Michaud Jorry André et Tixier - Huissiers de justice Associés à Melun (77). Il est adressé à titre gratuit à toute personne qui en fait la demande auprès de Mutuelle Bleue 14 rue René Cassin 77014 Melun Cedex. Mutuelle soumise aux dispositions du Livre II du Code de la Mutualité. SIREN n° 775 671 993. Crédits photos : Getty Images - Pierre & Vacances Document et photos non contractuels. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Empruntez aux meilleurs taux
(http://obfm42.com/t1i4qfs15udn1ja1cq/index0.html) (http://obfm42.com/2birwfpm5y0wgoi1xo/index1.html) (http://obfm42.com/bfinsfqv5xenmx3g1g/index2.html) (http://obfm42.com/00i5pfwl55wwhfhgfj/index3.html) (http://obfm42.com/efe3s34eazknct3xpo/index4.html) *Hors offre promotionnelle, pour la même durée d´emprunt et le même montant, sur le prêt personnel à la consommation, Prêt d´Union propose la plupart du temps des TAEG moins chers. ** Moyenne des TAEG observée pour un prêt personnel entre 6 000€ et 21 000€, d´une durée de 24 mois. Offres valables au 25/10/2012. ***Après acceptation définitive de votre dossier et dans le respect du délai légal de rétractation. Exemple de prêt personnel (hors assurances facultatives) : pour un montant total de crédit de 15 000€ remboursable en 24 mensualités de 650,90€ (hors assurances facultatives). Taux Annuel Effectif Global fixe de 5,28% (hors assurances facultatives). Taux débiteur fixe de 3,93%. Perceptions forfaitaires (frais de dossier) : 187,50€. Coût total du crédit : 809,10€. Montant total dû par l´emprunteur : 15621,60€. Vous bénéficiez d´une première échéance à 30 jours à 60 jours, la durée effective du crédit est de 24 mois. Offre valable au 07/11/2012. Le crédit Prêt d´Union est accordé sous réserve de l´acceptation d´étude et d´acceptation par Prêt d´Union SA. Vous disposez d´un droit de rétractation. Prêt d´Union SA. Etablissement de crédit. SA au capital de 297 012 euros. Numéro de RCS Nanterre : 517 586 376. Numéro ORIAS : 11 061 269. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
RE: [PATCH v3 0/5] Enable SPI flash support on da850-evm DT kernel
On Thu, Mar 14, 2013 at 15:54:26, Nori, Sekhar wrote: > On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote: > > Patch enables support for m25p64 SPI flash support on > > da850-EVM. > > This patch set looks good to me except the comments I had on 2/5. I > tested it using SPI flash on DA850 EVM and it worked fine on basic > read/write tests. > Thanks I will add your Reviewed-by. > Grant, > > With your ack I would like to merge the series through DaVinci tree so > its easy to manage the conflicts in DT files. > > > > > Testing information: > > da850-evm comes with partitions specified in DT blob. > > Able to mount/umount and create/delete files on filesystem partition. > > > > Depends on below patch in spi-next branch of > > git://git.secretlab.ca/git/linux-2.6.git. > > "spi/davinci: add OF support for the spi controller" > > Prakash, there is no need to mention this dependency. The patch is > already in mainline. > Yes, I mentioned it here as my patches were based on linux-davinci: v3.9/dt-2 branch. Will rebase my next versions on davinci/master. Thanks, Prakash -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 1/2] spi: spi-oc-tiny: Use of_match_ptr() macro
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat
Cc: Thomas Chou
---
drivers/spi/spi-oc-tiny.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c
index cb2e284..e60a776 100644
--- a/drivers/spi/spi-oc-tiny.c
+++ b/drivers/spi/spi-oc-tiny.c
@@ -393,8 +393,6 @@ static const struct of_device_id tiny_spi_match[] = {
{},
};
MODULE_DEVICE_TABLE(of, tiny_spi_match);
-#else /* CONFIG_OF */
-#define tiny_spi_match NULL
#endif /* CONFIG_OF */
static struct platform_driver tiny_spi_driver = {
@@ -404,7 +402,7 @@ static struct platform_driver tiny_spi_driver = {
.name = DRV_NAME,
.owner = THIS_MODULE,
.pm = NULL,
- .of_match_table = tiny_spi_match,
+ .of_match_table = of_match_ptr(tiny_spi_match),
},
};
module_platform_driver(tiny_spi_driver);
--
1.7.4.1
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 2/2] spi: spi-sh-msiof: Use of_match_ptr() macro
This eliminates having an #ifdef returning NULL for the case
when OF is disabled.
Signed-off-by: Sachin Kamat
---
drivers/spi/spi-sh-msiof.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 8b40d08..2bc5a6b 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -764,8 +764,6 @@ static const struct of_device_id sh_msiof_match[] = {
{},
};
MODULE_DEVICE_TABLE(of, sh_msiof_match);
-#else
-#define sh_msiof_match NULL
#endif
static struct dev_pm_ops sh_msiof_spi_dev_pm_ops = {
@@ -780,7 +778,7 @@ static struct platform_driver sh_msiof_spi_drv = {
.name = "spi_sh_msiof",
.owner = THIS_MODULE,
.pm = &sh_msiof_spi_dev_pm_ops,
- .of_match_table = sh_msiof_match,
+ .of_match_table = of_match_ptr(sh_msiof_match),
},
};
module_platform_driver(sh_msiof_spi_drv);
--
1.7.4.1
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v3 0/5] Enable SPI flash support on da850-evm DT kernel
On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote: > Patch enables support for m25p64 SPI flash support on > da850-EVM. This patch set looks good to me except the comments I had on 2/5. I tested it using SPI flash on DA850 EVM and it worked fine on basic read/write tests. Grant, With your ack I would like to merge the series through DaVinci tree so its easy to manage the conflicts in DT files. > > Testing information: > da850-evm comes with partitions specified in DT blob. > Able to mount/umount and create/delete files on filesystem partition. > > Depends on below patch in spi-next branch of > git://git.secretlab.ca/git/linux-2.6.git. > "spi/davinci: add OF support for the spi controller" Prakash, there is no need to mention this dependency. The patch is already in mainline. Thanks, Sekhar -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
RE: [PATCH v3 2/5] spi/davinci: add DT binding documentation
Hi Sekhar,
On Thu, Mar 14, 2013 at 14:46:54, Nori, Sekhar wrote:
> On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote:
> > From: Murali Karicheri
> >
> > Get back missed out binding documentation submitted along
> > with below patch:
> > "spi/davinci: add OF support for the spi controller"
>
> This is not really the correct description of this patch. Years later
> its mostly irrelevant that binding documentation did not get applied
> along with the actual usage.
>
Agreed, I will change the commit message. This could have been below
scissors lines
> >
> > [prakash...@ti.com: Follow DT naming convention for compatible property]
> > Signed-off-by: Murali Karicheri
> > Reviewed-by: Grant Likely
> > Signed-off-by: Manjunathappa, Prakash
> > ---
> > .../devicetree/bindings/spi/spi-davinci.txt| 51
> >
> > 1 files changed, 51 insertions(+), 0 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-davinci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt
> > b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> > new file mode 100644
> > index 000..75ad9ac
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> > @@ -0,0 +1,51 @@
> > +Davinci SPI controller device bindings
> > +
> > +Required properties:
> > +- #address-cells: number of cells required to define a chip select
> > + address on the SPI bus. Should be set to 1.
> > +- #size-cells: should be zero.
> > +- compatible:
> > + - "ti,dm6441-spi" for SPI used similar to that on DM644x SoC family
> > + - "ti,da830-spi" for SPI used similar to that on DA8xx SoC family
> > +- reg: Offset and length of SPI controller register space
> > +- num-cs: Number of chip selects
> > +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> > + IP to the interrupt controller withn the SoC. Possible values
> > + are 0 and 1. Manual says one of the two possible interrupt
> > + lines can be tied to the interrupt controller. Set this
> > + based on a specifc SoC configuration.
> > +- interrupts: interrupt number mapped to CPU.
> > +- clocks: spi clk phandle
> > +
> > +Example of a NOR flash slave device (n25q032) connected to DaVinci
> > +SPI controller device over the SPI bus.
> > +
> > +spi0:spi@20BF {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "ti,dm6446-spi";
> > + reg = <0x20BF 0x1000>;
> > + num-cs = <4>;
> > + ti,davinci-spi-intr-line= <0>;
> > + interrupts = <338>;
> > + clocks = <&clkspi>;
> > +
> > + flash: n25q032@0 {
> > +#address-cells = <1>;
> > +#size-cells = <1>;
> > +compatible = "st,m25p32";
> > +spi-max-frequency = <2500>;
> > +reg = <0>;
> > +
> > +partition@0 {
> > +label = "u-boot-spl";
> > +reg = <0x0 0x8>;
> > +read-only;
> > +};
> > +
> > +partition@1 {
> > +label = "test";
> > +reg = <0x8 0x38>;
> > +};
> > + };
>
> Looks like the tabs were messed up when you took Murali's patch.
>
Ok I will fix this.
Thanks,
Prakash
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH] drivers: spi: Use PTR_RET function
Replaced calls to IS_ERR and PTR_ERR with PTR_RET function.
Patch found using coccinelle.
Signed-off-by: Alexandru Gheorghiu
---
drivers/spi/spidev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 2e0655d..911e9e0 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -603,7 +603,7 @@ static int spidev_probe(struct spi_device *spi)
dev = device_create(spidev_class, &spi->dev, spidev->devt,
spidev, "spidev%d.%d",
spi->master->bus_num, spi->chip_select);
- status = IS_ERR(dev) ? PTR_ERR(dev) : 0;
+ status = PTR_RET(dev);
} else {
dev_dbg(&spi->dev, "no minor number available!\n");
status = -ENODEV;
--
1.7.9.5
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v3 2/5] spi/davinci: add DT binding documentation
On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote:
> From: Murali Karicheri
>
> Get back missed out binding documentation submitted along
> with below patch:
> "spi/davinci: add OF support for the spi controller"
This is not really the correct description of this patch. Years later
its mostly irrelevant that binding documentation did not get applied
along with the actual usage.
>
> [prakash...@ti.com: Follow DT naming convention for compatible property]
> Signed-off-by: Murali Karicheri
> Reviewed-by: Grant Likely
> Signed-off-by: Manjunathappa, Prakash
> ---
> .../devicetree/bindings/spi/spi-davinci.txt| 51
>
> 1 files changed, 51 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-davinci.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt
> b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> new file mode 100644
> index 000..75ad9ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-davinci.txt
> @@ -0,0 +1,51 @@
> +Davinci SPI controller device bindings
> +
> +Required properties:
> +- #address-cells: number of cells required to define a chip select
> + address on the SPI bus. Should be set to 1.
> +- #size-cells: should be zero.
> +- compatible:
> + - "ti,dm6441-spi" for SPI used similar to that on DM644x SoC family
> + - "ti,da830-spi" for SPI used similar to that on DA8xx SoC family
> +- reg: Offset and length of SPI controller register space
> +- num-cs: Number of chip selects
> +- ti,davinci-spi-intr-line: interrupt line used to connect the SPI
> + IP to the interrupt controller withn the SoC. Possible values
> + are 0 and 1. Manual says one of the two possible interrupt
> + lines can be tied to the interrupt controller. Set this
> + based on a specifc SoC configuration.
> +- interrupts: interrupt number mapped to CPU.
> +- clocks: spi clk phandle
> +
> +Example of a NOR flash slave device (n25q032) connected to DaVinci
> +SPI controller device over the SPI bus.
> +
> +spi0:spi@20BF {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "ti,dm6446-spi";
> + reg = <0x20BF 0x1000>;
> + num-cs = <4>;
> + ti,davinci-spi-intr-line= <0>;
> + interrupts = <338>;
> + clocks = <&clkspi>;
> +
> + flash: n25q032@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "st,m25p32";
> + spi-max-frequency = <2500>;
> + reg = <0>;
> +
> + partition@0 {
> + label = "u-boot-spl";
> + reg = <0x0 0x8>;
> + read-only;
> + };
> +
> + partition@1 {
> + label = "test";
> + reg = <0x8 0x38>;
> + };
> + };
Looks like the tabs were messed up when you took Murali's patch.
Thanks,
Sekhar
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
5 échantillons de thé gratuits + 21 pourcent de réduction
Recevez 5 échantillons de thé gratuits avec TEATOWER (http://obfm40.com/xjnldh1fg22giig52o/index0.html) (http://obfm40.com/clnjrhvpgnlqrho5tq/index1.html) (http://obfm40.com/fqnsohbkghngqrqa0j/index2.html) (http://obfm40.com/1snq4hasggvqcmjabg/index3.html) (http://obfm40.com/hqm1o1hu1lzghnqmzq/index4.html) (http://obfm40.com/3smb412y1vuqmwjmwo/index5.html) TEATOWER / TT PACKAGING SPRL Rue Saint-Denis 112 - 1190 Bruxelles - Belgique - Tél 00.32.28.08.01.27 -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH] drivers: spi: Use PTR_RET function
Replaced calls to IS_ERR and PTR_ERR with PTR_RET function. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu --- drivers/spi/spi-fsl-spi.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index 086a9ee..1985ba3 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -1134,9 +1134,7 @@ static int plat_mpc8xxx_spi_probe(struct platform_device *pdev) return -EINVAL; master = fsl_spi_probe(&pdev->dev, mem, irq); - if (IS_ERR(master)) - return PTR_ERR(master); - return 0; + return PTR_RET(master); } static int plat_mpc8xxx_spi_remove(struct platform_device *pdev) -- 1.7.9.5 -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
