[PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting
Currently, in case of reading date from SPI flash, command is sent twice. The cause is that tx-memory clear processing is missing . This patch adds the tx-momory clear processing. Signed-off-by: Tomoya MORINAGA --- drivers/spi/spi-topcliff-pch.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 540c290..1b98b7e 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data *data) dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent, DMA_FROM_DEVICE); + + dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent, + DMA_FROM_DEVICE); + memset(data->dma.tx_buf_virt, 0, PAGE_SIZE); + async_tx_ack(dma->desc_rx); async_tx_ack(dma->desc_tx); kfree(dma->sg_tx_p); -- 1.7.4.4 -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting
Hi Grant, 1 month has passed. You look very busy, right ? We've been long waiting for your accept. Could you review these patch series ? Thanks in advance. (2011/09/06 16:58), Tomoya MORINAGA wrote: > Currently, in case of reading date from SPI flash, > command is sent twice. > The cause is that tx-memory clear processing is missing . > This patch adds the tx-momory clear processing. > > Signed-off-by: Tomoya MORINAGA > --- > drivers/spi/spi-topcliff-pch.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index 540c290..1b98b7e 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data > *data) > > dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent, > DMA_FROM_DEVICE); > + > + dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent, > + DMA_FROM_DEVICE); > + memset(data->dma.tx_buf_virt, 0, PAGE_SIZE); > + > async_tx_ack(dma->desc_rx); > async_tx_ack(dma->desc_tx); > kfree(dma->sg_tx_p); -- tomoya ROHM Co., Ltd. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting
On Tue, 04 Oct 2011 18:15:26 +0900 Tomoya MORINAGA wrote: > Hi Grant, > > 1 month has passed. You look very busy, right ? > We've been long waiting for your accept. > Could you review these patch series ? If you've not had a response in a month for something that is a trivial fix to a driver you maintain anyway then send it direct to Linus with a note that Grant hasn't responded for a month. Ditto the GPIO driver. Alan -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/5] spi-topcliff-pch: add tx-memory clear after complete transmitting
On Tue, Oct 04, 2011 at 06:15:26PM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > 1 month has passed. You look very busy, right ? > We've been long waiting for your accept. > Could you review these patch series ? > > Thanks in advance. Just looked at it now. I'm picking it up and I'll send the pull req to Linus right away g. > > (2011/09/06 16:58), Tomoya MORINAGA wrote: > > Currently, in case of reading date from SPI flash, > > command is sent twice. > > The cause is that tx-memory clear processing is missing . > > This patch adds the tx-momory clear processing. > > > > Signed-off-by: Tomoya MORINAGA > > --- > > drivers/spi/spi-topcliff-pch.c |5 + > > 1 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > > index 540c290..1b98b7e 100644 > > --- a/drivers/spi/spi-topcliff-pch.c > > +++ b/drivers/spi/spi-topcliff-pch.c > > @@ -839,6 +839,11 @@ static void pch_spi_start_transfer(struct pch_spi_data > > *data) > > > > dma_sync_sg_for_cpu(&data->master->dev, dma->sg_rx_p, dma->nent, > > DMA_FROM_DEVICE); > > + > > + dma_sync_sg_for_cpu(&data->master->dev, dma->sg_tx_p, dma->nent, > > + DMA_FROM_DEVICE); > > + memset(data->dma.tx_buf_virt, 0, PAGE_SIZE); > > + > > async_tx_ack(dma->desc_rx); > > async_tx_ack(dma->desc_tx); > > kfree(dma->sg_tx_p); > > > -- > tomoya > ROHM Co., Ltd. -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
