RE: [PATCH 10/14] drivers/spi/spi-ep93xx.c: fix error return code

2012-08-22 Thread H Hartley Sweeten 
On Sunday, August 19, 2012 1:44 AM, Julia Lawall wrote:
 From: Julia Lawall julia.law...@lip6.fr

 Initialize return variable before exiting on an error path.

snip

 Signed-off-by: Julia Lawall julia.law...@lip6.fr

 ---
  drivers/spi/spi-ep93xx.c |1 +
  1 file changed, 1 insertion(+)

 diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
 index f97f1d2..9e7fdfd 100644
 --- a/drivers/spi/spi-ep93xx.c
 +++ b/drivers/spi/spi-ep93xx.c
 @@ -1105,6 +1105,7 @@ static int __devinit ep93xx_spi_probe(struct 
 platform_device *pdev)
   espi-wq = create_singlethread_workqueue(ep93xx_spid);
   if (!espi-wq) {
   dev_err(pdev-dev, unable to create workqueue\n);
 + error = -ENOMEM;
   goto fail_free_dma;
   }
   INIT_WORK(espi-msg_work, ep93xx_spi_work);

Looks ok to me... Thanks!

Reviewed-by: H Hartley Sweeten hswee...@visionengravers.com

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 10/14] drivers/spi/spi-ep93xx.c: fix error return code

2012-08-19 Thread Julia Lawall 
From: Julia Lawall julia.law...@lip6.fr

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// smpl
(
if@p1 (\(ret  0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != ret
*if(...)
{
  ... when != ret = e2
  when forall
 return ret;
}

// /smpl

Signed-off-by: Julia Lawall julia.law...@lip6.fr

---
 drivers/spi/spi-ep93xx.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index f97f1d2..9e7fdfd 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -1105,6 +1105,7 @@ static int __devinit ep93xx_spi_probe(struct 
platform_device *pdev)
espi-wq = create_singlethread_workqueue(ep93xx_spid);
if (!espi-wq) {
dev_err(pdev-dev, unable to create workqueue\n);
+   error = -ENOMEM;
goto fail_free_dma;
}
INIT_WORK(espi-msg_work, ep93xx_spi_work);


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general