[PATCH 3/3 v4] ARM: DTS: fix the chip select gpios definition in the SPI nodes

2014-06-12 Thread Naveen Krishna Chatradhi 
This patch replaces the cs-gpio from controller-data node
as was specified in the old binding and use the standard
cs-gpios property expected by the SPI core as is defined in
the new binding.

Respective changes are preposed to spi-s3c64xx.c driver.
@ http://www.spinics.net/lists/linux-samsung-soc/msg32282.html

Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Acked-by: Rob Herring r...@kernel.org
Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
Cc: Doug Anderson diand...@chromium.org
Cc: Tomasz Figa t.f...@samsung.com
---
 arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +-
 arch/arm/boot/dts/exynos4412-trats2.dts   |2 +-
 arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts 
b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 636d166..9191491 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -169,6 +169,7 @@
 
spi_2: spi@1394 {
status = okay;
+   cs-gpios = gpc1 2 0;
 
w25x80@0 {
#address-cells = 1;
@@ -178,7 +179,6 @@
spi-max-frequency = 100;
 
controller-data {
-   cs-gpio = gpc1 2 0;
samsung,spi-feedback-delay = 0;
};
 
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
b/arch/arm/boot/dts/exynos4412-trats2.dts
index 8a558b7..204b0de 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -512,6 +512,7 @@
spi_1: spi@1393 {
pinctrl-names = default;
pinctrl-0 = spi1_bus;
+   cs-gpios = gpb 5 0;
status = okay;
 
s5c73m3_spi: s5c73m3 {
@@ -519,7 +520,6 @@
spi-max-frequency = 5000;
reg = 0;
controller-data {
-   cs-gpio = gpb 5 0;
samsung,spi-feedback-delay = 2;
};
};
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts 
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index a794a70..0c6433a 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -316,6 +316,7 @@
};
 
spi_1: spi@12d3 {
+   cs-gpios = gpa2 5 0;
status = okay;
 
w25q80bw@0 {
@@ -326,7 +327,6 @@
spi-max-frequency = 100;
 
controller-data {
-   cs-gpio = gpa2 5 0;
samsung,spi-feedback-delay = 0;
};
 
-- 
1.7.9.5


--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing  Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 3/3 v4] ARM: DTS: fix the chip select gpios definition in the SPI nodes

2014-06-12 Thread Javier Martinez Canillas 
Hello Naveen,

On 06/12/2014 03:13 PM, Naveen Krishna Chatradhi wrote:
 This patch replaces the cs-gpio from controller-data node
 as was specified in the old binding and use the standard
 cs-gpios property expected by the SPI core as is defined in
 the new binding.
 
 Respective changes are preposed to spi-s3c64xx.c driver.
 @ http://www.spinics.net/lists/linux-samsung-soc/msg32282.html
 
 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 Acked-by: Rob Herring r...@kernel.org
 Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
 Cc: Doug Anderson diand...@chromium.org
 Cc: Tomasz Figa t.f...@samsung.com
 ---
  arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +-
  arch/arm/boot/dts/exynos4412-trats2.dts   |2 +-
  arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts 
 b/arch/arm/boot/dts/exynos4210-smdkv310.dts
 index 636d166..9191491 100644
 --- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
 +++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
 @@ -169,6 +169,7 @@
  
   spi_2: spi@1394 {
   status = okay;
 + cs-gpios = gpc1 2 0;
  
   w25x80@0 {
   #address-cells = 1;
 @@ -178,7 +179,6 @@
   spi-max-frequency = 100;
  
   controller-data {
 - cs-gpio = gpc1 2 0;
   samsung,spi-feedback-delay = 0;
   };
  
 diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts 
 b/arch/arm/boot/dts/exynos4412-trats2.dts
 index 8a558b7..204b0de 100644
 --- a/arch/arm/boot/dts/exynos4412-trats2.dts
 +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
 @@ -512,6 +512,7 @@
   spi_1: spi@1393 {
   pinctrl-names = default;
   pinctrl-0 = spi1_bus;
 + cs-gpios = gpb 5 0;
   status = okay;
  
   s5c73m3_spi: s5c73m3 {
 @@ -519,7 +520,6 @@
   spi-max-frequency = 5000;
   reg = 0;
   controller-data {
 - cs-gpio = gpb 5 0;
   samsung,spi-feedback-delay = 2;
   };
   };
 diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts 
 b/arch/arm/boot/dts/exynos5250-smdk5250.dts
 index a794a70..0c6433a 100644
 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
 +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
 @@ -316,6 +316,7 @@
   };
  
   spi_1: spi@12d3 {
 + cs-gpios = gpa2 5 0;
   status = okay;
  
   w25q80bw@0 {
 @@ -326,7 +327,6 @@
   spi-max-frequency = 100;
  
   controller-data {
 - cs-gpio = gpa2 5 0;
   samsung,spi-feedback-delay = 0;
   };
  
 

Looks good to me.

Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk

Best regards,
Javier

--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing  Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 3/3 v4] ARM: DTS: fix the chip select gpios definition in the SPI nodes

2014-06-12 Thread Doug Anderson 
Hi,

On Thu, Jun 12, 2014 at 6:13 AM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
 This patch replaces the cs-gpio from controller-data node
 as was specified in the old binding and use the standard
 cs-gpios property expected by the SPI core as is defined in
 the new binding.

 Respective changes are preposed to spi-s3c64xx.c driver.
 @ http://www.spinics.net/lists/linux-samsung-soc/msg32282.html

 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 Acked-by: Rob Herring r...@kernel.org
 Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
 Cc: Doug Anderson diand...@chromium.org
 Cc: Tomasz Figa t.f...@samsung.com
 ---
  arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +-
  arch/arm/boot/dts/exynos4412-trats2.dts   |2 +-
  arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

This looks fine, though I will note that you're not very consistent
with the ordering of cs-gpios and status.

Reviewed-by: Doug Anderson diand...@chromium.org

--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing  Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general