Re: [PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver
On 11/16/2011 09:13 AM, Lars-Peter Clausen wrote: > Use the newly introduced module_spi_driver macro for registering SPI drivers. > This allows us to remove a few lines of boilerplate code. > > Signed-off-by: Lars-Peter Clausen Acked-by: Jonathan Cameron > --- > drivers/staging/iio/accel/adis16201_core.c | 13 + > drivers/staging/iio/accel/adis16203_core.c | 13 + > drivers/staging/iio/accel/adis16204_core.c | 13 + > drivers/staging/iio/accel/adis16209_core.c | 13 + > drivers/staging/iio/accel/adis16220_core.c | 13 + > drivers/staging/iio/accel/adis16240_core.c | 13 + > drivers/staging/iio/accel/kxsd9.c | 13 + > drivers/staging/iio/accel/lis3l02dq_core.c | 13 + > drivers/staging/iio/accel/sca3000_core.c | 13 + > drivers/staging/iio/adc/ad7192.c | 13 + > drivers/staging/iio/adc/ad7280a.c | 13 + > drivers/staging/iio/adc/ad7298_core.c | 13 + > drivers/staging/iio/adc/ad7476_core.c | 13 + > drivers/staging/iio/adc/ad7606_spi.c | 13 + > drivers/staging/iio/adc/ad7780.c | 13 + > drivers/staging/iio/adc/ad7793.c | 13 + > drivers/staging/iio/adc/ad7816.c | 14 +- > drivers/staging/iio/adc/ad7887_core.c | 13 + > drivers/staging/iio/adc/adt7310.c | 14 +- > drivers/staging/iio/addac/adt7316-spi.c| 14 +- > drivers/staging/iio/dac/ad5064.c | 13 + > drivers/staging/iio/dac/ad5360.c | 13 + > drivers/staging/iio/dac/ad5446.c | 13 + > drivers/staging/iio/dac/ad5504.c | 13 + > drivers/staging/iio/dac/ad5624r_spi.c | 13 + > drivers/staging/iio/dac/ad5686.c | 13 + > drivers/staging/iio/dac/ad5791.c | 13 + > drivers/staging/iio/dds/ad5930.c | 13 + > drivers/staging/iio/dds/ad9832.c | 13 + > drivers/staging/iio/dds/ad9834.c | 13 + > drivers/staging/iio/dds/ad9850.c | 13 + > drivers/staging/iio/dds/ad9852.c | 13 + > drivers/staging/iio/dds/ad9910.c | 13 + > drivers/staging/iio/dds/ad9951.c | 13 + > drivers/staging/iio/gyro/adis16080_core.c | 13 + > drivers/staging/iio/gyro/adis16130_core.c | 13 + > drivers/staging/iio/gyro/adis16260_core.c | 13 + > drivers/staging/iio/gyro/adxrs450_core.c | 13 + > drivers/staging/iio/imu/adis16400_core.c | 13 + > drivers/staging/iio/meter/ade7753.c| 13 + > drivers/staging/iio/meter/ade7754.c| 13 + > drivers/staging/iio/meter/ade7758_core.c | 13 + > drivers/staging/iio/meter/ade7759.c| 13 + > drivers/staging/iio/meter/ade7854-spi.c| 13 + > drivers/staging/iio/resolver/ad2s1200.c| 13 + > drivers/staging/iio/resolver/ad2s1210.c| 13 + > drivers/staging/iio/resolver/ad2s90.c | 13 + > 47 files changed, 47 insertions(+), 567 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16201_core.c > b/drivers/staging/iio/accel/adis16201_core.c > index 1c5dad5..97f747e 100644 > --- a/drivers/staging/iio/accel/adis16201_core.c > +++ b/drivers/staging/iio/accel/adis16201_core.c > @@ -549,18 +549,7 @@ static struct spi_driver adis16201_driver = { > .probe = adis16201_probe, > .remove = __devexit_p(adis16201_remove), > }; > - > -static __init int adis16201_init(void) > -{ > - return spi_register_driver(&adis16201_driver); > -} > -module_init(adis16201_init); > - > -static __exit void adis16201_exit(void) > -{ > - spi_unregister_driver(&adis16201_driver); > -} > -module_exit(adis16201_exit); > +module_spi_driver(adis16201_driver); > > MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); > MODULE_DESCRIPTION("Analog Devices ADIS16201 Programmable Digital Vibration > Sensor driver"); > diff --git a/drivers/staging/iio/accel/adis16203_core.c > b/drivers/staging/iio/accel/adis16203_core.c > index 8a33374..a6d6d27 100644 > --- a/drivers/staging/iio/accel/adis16203_core.c > +++ b/drivers/staging/iio/accel/adis16203_core.c > @@ -504,18 +504,7 @@ static struct spi_driver adis16203_driver = { > .probe = adis16203_probe, > .remove = __devexit_p(adis16203_remove), > }; > - > -static __init int adis16203_init(void) > -{ > - return spi_register_driver(&adis16203_driver); > -} > -module_init(adis16203_init); > - > -static __exit void adis16203_exit(void) > -{ > - spi_unregister_driver(&adis16203_driver); > -} >
Re: [PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver
On 11/16/2011 05:15 PM, Grant Likely wrote: > On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen wrote: >> Use the newly introduced module_spi_driver macro for registering SPI drivers. >> This allows us to remove a few lines of boilerplate code. >> >> Signed-off-by: Lars-Peter Clausen > > Acked-by: Grant Likely Acked-by: Jonathan Cameron > > g. > >> --- >> drivers/staging/iio/accel/adis16201_core.c | 13 + >> drivers/staging/iio/accel/adis16203_core.c | 13 + >> drivers/staging/iio/accel/adis16204_core.c | 13 + >> drivers/staging/iio/accel/adis16209_core.c | 13 + >> drivers/staging/iio/accel/adis16220_core.c | 13 + >> drivers/staging/iio/accel/adis16240_core.c | 13 + >> drivers/staging/iio/accel/kxsd9.c | 13 + >> drivers/staging/iio/accel/lis3l02dq_core.c | 13 + >> drivers/staging/iio/accel/sca3000_core.c | 13 + >> drivers/staging/iio/adc/ad7192.c | 13 + >> drivers/staging/iio/adc/ad7280a.c | 13 + >> drivers/staging/iio/adc/ad7298_core.c | 13 + >> drivers/staging/iio/adc/ad7476_core.c | 13 + >> drivers/staging/iio/adc/ad7606_spi.c | 13 + >> drivers/staging/iio/adc/ad7780.c | 13 + >> drivers/staging/iio/adc/ad7793.c | 13 + >> drivers/staging/iio/adc/ad7816.c | 14 +- >> drivers/staging/iio/adc/ad7887_core.c | 13 + >> drivers/staging/iio/adc/adt7310.c | 14 +- >> drivers/staging/iio/addac/adt7316-spi.c| 14 +- >> drivers/staging/iio/dac/ad5064.c | 13 + >> drivers/staging/iio/dac/ad5360.c | 13 + >> drivers/staging/iio/dac/ad5446.c | 13 + >> drivers/staging/iio/dac/ad5504.c | 13 + >> drivers/staging/iio/dac/ad5624r_spi.c | 13 + >> drivers/staging/iio/dac/ad5686.c | 13 + >> drivers/staging/iio/dac/ad5791.c | 13 + >> drivers/staging/iio/dds/ad5930.c | 13 + >> drivers/staging/iio/dds/ad9832.c | 13 + >> drivers/staging/iio/dds/ad9834.c | 13 + >> drivers/staging/iio/dds/ad9850.c | 13 + >> drivers/staging/iio/dds/ad9852.c | 13 + >> drivers/staging/iio/dds/ad9910.c | 13 + >> drivers/staging/iio/dds/ad9951.c | 13 + >> drivers/staging/iio/gyro/adis16080_core.c | 13 + >> drivers/staging/iio/gyro/adis16130_core.c | 13 + >> drivers/staging/iio/gyro/adis16260_core.c | 13 + >> drivers/staging/iio/gyro/adxrs450_core.c | 13 + >> drivers/staging/iio/imu/adis16400_core.c | 13 + >> drivers/staging/iio/meter/ade7753.c| 13 + >> drivers/staging/iio/meter/ade7754.c| 13 + >> drivers/staging/iio/meter/ade7758_core.c | 13 + >> drivers/staging/iio/meter/ade7759.c| 13 + >> drivers/staging/iio/meter/ade7854-spi.c| 13 + >> drivers/staging/iio/resolver/ad2s1200.c| 13 + >> drivers/staging/iio/resolver/ad2s1210.c| 13 + >> drivers/staging/iio/resolver/ad2s90.c | 13 + >> 47 files changed, 47 insertions(+), 567 deletions(-) >> >> diff --git a/drivers/staging/iio/accel/adis16201_core.c >> b/drivers/staging/iio/accel/adis16201_core.c >> index 1c5dad5..97f747e 100644 >> --- a/drivers/staging/iio/accel/adis16201_core.c >> +++ b/drivers/staging/iio/accel/adis16201_core.c >> @@ -549,18 +549,7 @@ static struct spi_driver adis16201_driver = { >>.probe = adis16201_probe, >>.remove = __devexit_p(adis16201_remove), >> }; >> - >> -static __init int adis16201_init(void) >> -{ >> - return spi_register_driver(&adis16201_driver); >> -} >> -module_init(adis16201_init); >> - >> -static __exit void adis16201_exit(void) >> -{ >> - spi_unregister_driver(&adis16201_driver); >> -} >> -module_exit(adis16201_exit); >> +module_spi_driver(adis16201_driver); >> >> MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); >> MODULE_DESCRIPTION("Analog Devices ADIS16201 Programmable Digital Vibration >> Sensor driver"); >> diff --git a/drivers/staging/iio/accel/adis16203_core.c >> b/drivers/staging/iio/accel/adis16203_core.c >> index 8a33374..a6d6d27 100644 >> --- a/drivers/staging/iio/accel/adis16203_core.c >> +++ b/drivers/staging/iio/accel/adis16203_core.c >> @@ -504,18 +504,7 @@ static struct spi_driver adis16203_driver = { >>.probe = adis16203_probe, >>.remove = __devexit_p(adis16203_remove), >> }; >> - >> -static __init int adis16203_init(void) >> -{ >> -
Re: [PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver
On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen wrote: > Use the newly introduced module_spi_driver macro for registering SPI drivers. > This allows us to remove a few lines of boilerplate code. > > Signed-off-by: Lars-Peter Clausen Acked-by: Grant Likely g. > --- > drivers/staging/iio/accel/adis16201_core.c | 13 + > drivers/staging/iio/accel/adis16203_core.c | 13 + > drivers/staging/iio/accel/adis16204_core.c | 13 + > drivers/staging/iio/accel/adis16209_core.c | 13 + > drivers/staging/iio/accel/adis16220_core.c | 13 + > drivers/staging/iio/accel/adis16240_core.c | 13 + > drivers/staging/iio/accel/kxsd9.c | 13 + > drivers/staging/iio/accel/lis3l02dq_core.c | 13 + > drivers/staging/iio/accel/sca3000_core.c | 13 + > drivers/staging/iio/adc/ad7192.c | 13 + > drivers/staging/iio/adc/ad7280a.c | 13 + > drivers/staging/iio/adc/ad7298_core.c | 13 + > drivers/staging/iio/adc/ad7476_core.c | 13 + > drivers/staging/iio/adc/ad7606_spi.c | 13 + > drivers/staging/iio/adc/ad7780.c | 13 + > drivers/staging/iio/adc/ad7793.c | 13 + > drivers/staging/iio/adc/ad7816.c | 14 +- > drivers/staging/iio/adc/ad7887_core.c | 13 + > drivers/staging/iio/adc/adt7310.c | 14 +- > drivers/staging/iio/addac/adt7316-spi.c | 14 +- > drivers/staging/iio/dac/ad5064.c | 13 + > drivers/staging/iio/dac/ad5360.c | 13 + > drivers/staging/iio/dac/ad5446.c | 13 + > drivers/staging/iio/dac/ad5504.c | 13 + > drivers/staging/iio/dac/ad5624r_spi.c | 13 + > drivers/staging/iio/dac/ad5686.c | 13 + > drivers/staging/iio/dac/ad5791.c | 13 + > drivers/staging/iio/dds/ad5930.c | 13 + > drivers/staging/iio/dds/ad9832.c | 13 + > drivers/staging/iio/dds/ad9834.c | 13 + > drivers/staging/iio/dds/ad9850.c | 13 + > drivers/staging/iio/dds/ad9852.c | 13 + > drivers/staging/iio/dds/ad9910.c | 13 + > drivers/staging/iio/dds/ad9951.c | 13 + > drivers/staging/iio/gyro/adis16080_core.c | 13 + > drivers/staging/iio/gyro/adis16130_core.c | 13 + > drivers/staging/iio/gyro/adis16260_core.c | 13 + > drivers/staging/iio/gyro/adxrs450_core.c | 13 + > drivers/staging/iio/imu/adis16400_core.c | 13 + > drivers/staging/iio/meter/ade7753.c | 13 + > drivers/staging/iio/meter/ade7754.c | 13 + > drivers/staging/iio/meter/ade7758_core.c | 13 + > drivers/staging/iio/meter/ade7759.c | 13 + > drivers/staging/iio/meter/ade7854-spi.c | 13 + > drivers/staging/iio/resolver/ad2s1200.c | 13 + > drivers/staging/iio/resolver/ad2s1210.c | 13 + > drivers/staging/iio/resolver/ad2s90.c | 13 + > 47 files changed, 47 insertions(+), 567 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16201_core.c > b/drivers/staging/iio/accel/adis16201_core.c > index 1c5dad5..97f747e 100644 > --- a/drivers/staging/iio/accel/adis16201_core.c > +++ b/drivers/staging/iio/accel/adis16201_core.c > @@ -549,18 +549,7 @@ static struct spi_driver adis16201_driver = { > .probe = adis16201_probe, > .remove = __devexit_p(adis16201_remove), > }; > - > -static __init int adis16201_init(void) > -{ > - return spi_register_driver(&adis16201_driver); > -} > -module_init(adis16201_init); > - > -static __exit void adis16201_exit(void) > -{ > - spi_unregister_driver(&adis16201_driver); > -} > -module_exit(adis16201_exit); > +module_spi_driver(adis16201_driver); > > MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); > MODULE_DESCRIPTION("Analog Devices ADIS16201 Programmable Digital Vibration > Sensor driver"); > diff --git a/drivers/staging/iio/accel/adis16203_core.c > b/drivers/staging/iio/accel/adis16203_core.c > index 8a33374..a6d6d27 100644 > --- a/drivers/staging/iio/accel/adis16203_core.c > +++ b/drivers/staging/iio/accel/adis16203_core.c > @@ -504,18 +504,7 @@ static struct spi_driver adis16203_driver = { > .probe = adis16203_probe, > .remove = __devexit_p(adis16203_remove), > }; > - > -static __init int adis16203_init(void) > -{ > - return spi_register_driver(&adis16203_driver); > -} > -module_init(adis16203_init); > - > -static __exit void adis16203_exit(void) > -{ > - spi_unregister_driver(&adis1
[PATCH 5/5] staging:iio: Use module_spi_driver to register SPI driver
Use the newly introduced module_spi_driver macro for registering SPI drivers. This allows us to remove a few lines of boilerplate code. Signed-off-by: Lars-Peter Clausen --- drivers/staging/iio/accel/adis16201_core.c | 13 + drivers/staging/iio/accel/adis16203_core.c | 13 + drivers/staging/iio/accel/adis16204_core.c | 13 + drivers/staging/iio/accel/adis16209_core.c | 13 + drivers/staging/iio/accel/adis16220_core.c | 13 + drivers/staging/iio/accel/adis16240_core.c | 13 + drivers/staging/iio/accel/kxsd9.c | 13 + drivers/staging/iio/accel/lis3l02dq_core.c | 13 + drivers/staging/iio/accel/sca3000_core.c | 13 + drivers/staging/iio/adc/ad7192.c | 13 + drivers/staging/iio/adc/ad7280a.c | 13 + drivers/staging/iio/adc/ad7298_core.c | 13 + drivers/staging/iio/adc/ad7476_core.c | 13 + drivers/staging/iio/adc/ad7606_spi.c | 13 + drivers/staging/iio/adc/ad7780.c | 13 + drivers/staging/iio/adc/ad7793.c | 13 + drivers/staging/iio/adc/ad7816.c | 14 +- drivers/staging/iio/adc/ad7887_core.c | 13 + drivers/staging/iio/adc/adt7310.c | 14 +- drivers/staging/iio/addac/adt7316-spi.c| 14 +- drivers/staging/iio/dac/ad5064.c | 13 + drivers/staging/iio/dac/ad5360.c | 13 + drivers/staging/iio/dac/ad5446.c | 13 + drivers/staging/iio/dac/ad5504.c | 13 + drivers/staging/iio/dac/ad5624r_spi.c | 13 + drivers/staging/iio/dac/ad5686.c | 13 + drivers/staging/iio/dac/ad5791.c | 13 + drivers/staging/iio/dds/ad5930.c | 13 + drivers/staging/iio/dds/ad9832.c | 13 + drivers/staging/iio/dds/ad9834.c | 13 + drivers/staging/iio/dds/ad9850.c | 13 + drivers/staging/iio/dds/ad9852.c | 13 + drivers/staging/iio/dds/ad9910.c | 13 + drivers/staging/iio/dds/ad9951.c | 13 + drivers/staging/iio/gyro/adis16080_core.c | 13 + drivers/staging/iio/gyro/adis16130_core.c | 13 + drivers/staging/iio/gyro/adis16260_core.c | 13 + drivers/staging/iio/gyro/adxrs450_core.c | 13 + drivers/staging/iio/imu/adis16400_core.c | 13 + drivers/staging/iio/meter/ade7753.c| 13 + drivers/staging/iio/meter/ade7754.c| 13 + drivers/staging/iio/meter/ade7758_core.c | 13 + drivers/staging/iio/meter/ade7759.c| 13 + drivers/staging/iio/meter/ade7854-spi.c| 13 + drivers/staging/iio/resolver/ad2s1200.c| 13 + drivers/staging/iio/resolver/ad2s1210.c| 13 + drivers/staging/iio/resolver/ad2s90.c | 13 + 47 files changed, 47 insertions(+), 567 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201_core.c b/drivers/staging/iio/accel/adis16201_core.c index 1c5dad5..97f747e 100644 --- a/drivers/staging/iio/accel/adis16201_core.c +++ b/drivers/staging/iio/accel/adis16201_core.c @@ -549,18 +549,7 @@ static struct spi_driver adis16201_driver = { .probe = adis16201_probe, .remove = __devexit_p(adis16201_remove), }; - -static __init int adis16201_init(void) -{ - return spi_register_driver(&adis16201_driver); -} -module_init(adis16201_init); - -static __exit void adis16201_exit(void) -{ - spi_unregister_driver(&adis16201_driver); -} -module_exit(adis16201_exit); +module_spi_driver(adis16201_driver); MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); MODULE_DESCRIPTION("Analog Devices ADIS16201 Programmable Digital Vibration Sensor driver"); diff --git a/drivers/staging/iio/accel/adis16203_core.c b/drivers/staging/iio/accel/adis16203_core.c index 8a33374..a6d6d27 100644 --- a/drivers/staging/iio/accel/adis16203_core.c +++ b/drivers/staging/iio/accel/adis16203_core.c @@ -504,18 +504,7 @@ static struct spi_driver adis16203_driver = { .probe = adis16203_probe, .remove = __devexit_p(adis16203_remove), }; - -static __init int adis16203_init(void) -{ - return spi_register_driver(&adis16203_driver); -} -module_init(adis16203_init); - -static __exit void adis16203_exit(void) -{ - spi_unregister_driver(&adis16203_driver); -} -module_exit(adis16203_exit); +module_spi_driver(adis16203_driver); MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); MODULE_DESCRIPTION("Analog Devices ADIS16203 Programmable Digital Vibration Sensor driver"); diff --git a/drivers/staging/iio/accel/adis16204