Re: [PATCH 1/1] spi: intel_mid_ssp_spi: new SPI driver for intel Medfield platform
On Wed, Feb 02, 2011 at 10:40:54PM +, Alan Cox wrote: And this is the unified one that handles all the devices, but I gather may need some fixing/test work on Medfield. I've got the same question here as I had with Russ' patch: it looks like there's some overlap with the SSP ports used for audio (it's just a generic programmable serial port so even if it's not normally used for audio that's a possiblity), how is that handled? -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/1] spi: intel_mid_ssp_spi: new SPI driver for intel Medfield platform
On Thu, 3 Feb 2011 13:28:00 + Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Feb 02, 2011 at 10:40:54PM +, Alan Cox wrote: And this is the unified one that handles all the devices, but I gather may need some fixing/test work on Medfield. I've got the same question here as I had with Russ' patch: it looks like there's some overlap with the SSP ports used for audio (it's just a generic programmable serial port so even if it's not normally used for audio that's a possiblity), how is that handled? The SSP has PCI configuration indicating how it is being assigned, which is in vendor capability byte 6. The low 3 bits indicte the mode, where mode 1 is an SPI master/slave, and in that case bit 6 is set for a slave. The SSP/SPI driver will only grab ports that have been assigned to that purpose as part of the system design. I'm just putting the other bits from the generic driver back into the more featured/tested specific driver that Russ posted. Alan -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/1] spi: intel_mid_ssp_spi: new SPI driver for intel Medfield platform
On Thu, Feb 03, 2011 at 03:04:32PM +, Alan Cox wrote: Mark Brown broo...@opensource.wolfsonmicro.com wrote: I've got the same question here as I had with Russ' patch: it looks like there's some overlap with the SSP ports used for audio (it's just a generic programmable serial port so even if it's not normally used for audio that's a possiblity), how is that handled? The SSP has PCI configuration indicating how it is being assigned, which is in vendor capability byte 6. The low 3 bits indicte the mode, where mode 1 is an SPI master/slave, and in that case bit 6 is set for a slave. OK, cool - just checking as it's a common issue for these generic serial ports. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/1] spi: intel_mid_ssp_spi: new SPI driver for intel Medfield platform
On Wed, Feb 02, 2011 at 01:01:52PM -0800, Russ Gorby wrote: SPI master controller driver for the Intel MID platform Medfield This driver uses the Penwell SSP controller and configures it to be a SPI device (spibus 3). This bus supports a single device - the 3G SPI modem that can operate up to 25Mhz. The same hardware is also used for audio I believe - how do the two drivers share the hardware? +#define SSCR0_DSS (0x000f) /* Data Size Select (mask) */ +#define SSCR0_DataSize(x) ((x) - 1) /* Data Size Select [4..16] */ +#define SSCR0_FRF (0x0030) /* FRame Format (mask) */ +#define SSCR0_Motorola (0x0 4) /* Motorola's SPI mode */ +#define SSCR0_ECS (1 6) /* External clock select */ +#define SSCR0_SSE (1 7) /* Synchronous Serial Port Enable */ There certainly looks to be overlap with the register definitions. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/1] spi: intel_mid_ssp_spi: new SPI driver for intel Medfield platform
On Wed, 2 Feb 2011 13:01:52 -0800 Russ Gorby russ.go...@intel.com wrote: SPI master controller driver for the Intel MID platform Medfield This driver uses the Penwell SSP controller and configures it to be a SPI device (spibus 3). This bus supports a single device - the 3G SPI modem that can operate up to 25Mhz. NAK this. We have an existing development driver that covers 0x0815, 0x0816, 0x0825, 0x0832 in a single driver which needs tidying up and double checking on all the relevant Medfield and Moorestown devices and is based on work done by Mathieu Soulard. All these devices can be handled by a single driver, and should be. Alan -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
