Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.
On 08/17/2010 05:36 PM, Alexander Larsson wrote: On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. Ack (although you should git rm dd.c too). Oops, will resend the patch ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [Qxl PATCH] Change surfaces allocation method.
The driver no longer claims to support DirectDraw.
It uses mspace to allocate surfaces and not HeapVidMemAllocAligned.
This fixes freedesktop bug #29254.
---
display/dd.c | 122 -
display/dd.h | 15 -
display/driver.c | 18 ++-
display/qxldd.h | 19 +--
display/res.c| 158 +++---
display/sources |1 -
6 files changed, 111 insertions(+), 222 deletions(-)
delete mode 100644 display/dd.c
delete mode 100644 display/dd.h
diff --git a/display/dd.c b/display/dd.c
deleted file mode 100644
index 211a4fb..000
--- a/display/dd.c
+++ /dev/null
@@ -1,122 +0,0 @@
-#include
-#include
-#include
-#include "os_dep.h"
-#include "devioctl.h"
-#include "ntddvdeo.h"
-#include "ioaccess.h"
-#include "qxldd.h"
-
-static UINT8 get_depth(PDev *pdev)
-{
-if (pdev->bitmap_format == BMF_32BPP) {
-return 32;
-} else {
-return 16;
-}
-}
-
-BOOL DrvGetDirectDrawInfo(DHPDEV dhpdev, DD_HALINFO *pHallInfo,
- DWORD *pdvNumHeaps, VIDEOMEMORY *pvmList,
- DWORD *pdvNumFourCCCodes,
- DWORD *pdvFourCC)
-{
-PDev *pdev;
-DWORD offset;
-
-pdev = (PDev *)dhpdev;
-
-*pdvNumHeaps = 1;
-*pdvNumFourCCCodes = 0;
-
-if (!pdev->dd_slot_initialized) {
-return FALSE;
-}
-
-offset = pdev->resolution.cy * pdev->stride;
-
-if (pvmList) {
-VIDEOMEMORY *pvmobj = pvmList;
-
-pvmobj->dwFlags = VIDMEM_ISLINEAR;
-
-pvmobj->fpStart = (FLATPTR)pdev->fb;
-pvmobj->fpEnd = pvmobj->fpStart + pdev->fb_size - 1;
-
-pvmobj->ddsCaps.dwCaps = 0;
-pvmobj->ddsCapsAlt.dwCaps = 0;
-
-pdev->pvmList = pvmList;
-}
-
-memset(pHallInfo, 0, sizeof(DD_HALINFO));
-
-pHallInfo->vmiData.pvPrimary = pdev->fb;
-pHallInfo->vmiData.fpPrimary = 0;
-
-pHallInfo->dwSize = sizeof (DD_HALINFO);
-
-pHallInfo->vmiData.dwFlags = 0;
-pHallInfo->vmiData.dwDisplayWidth = pdev->resolution.cx;
-pHallInfo->vmiData.dwDisplayHeight = pdev->resolution.cy;
-pHallInfo->vmiData.lDisplayPitch = pdev->stride;
-pHallInfo->vmiData.ddpfDisplay.dwSize = sizeof(DDPIXELFORMAT);
-pHallInfo->vmiData.ddpfDisplay.dwFlags = DDPF_RGB;
-
-pHallInfo->vmiData.ddpfDisplay.dwRGBBitCount = get_depth(pdev);
-
-pHallInfo->vmiData.ddpfDisplay.dwRBitMask = pdev->red_mask;
-pHallInfo->vmiData.ddpfDisplay.dwGBitMask = pdev->green_mask;
-pHallInfo->vmiData.ddpfDisplay.dwBBitMask = pdev->blue_mask;
-
-pHallInfo->vmiData.dwOffscreenAlign = 4;
-pHallInfo->vmiData.dwOverlayAlign = 4;
-pHallInfo->vmiData.dwTextureAlign = 4;
-pHallInfo->vmiData.dwZBufferAlign = 4;
-pHallInfo->vmiData.dwAlphaAlign = 4;
-
-pHallInfo->ddCaps.dwSize = sizeof (DDCORECAPS);
-pHallInfo->ddCaps.dwVidMemTotal = pdev->fb_size;
-pHallInfo->ddCaps.dwVidMemFree = pdev->fb_size;
-
-pdev->dd_initialized = TRUE;
-
-return TRUE;
-}
-
-DWORD CALLBACK QxlCanCreateSurface(PDD_CANCREATESURFACEDATA data)
-{
-return DDHAL_DRIVER_NOTHANDLED;
-}
-
-DWORD CALLBACK QxlFlip(PDD_FLIPDATA lpFlip)
-{
-return DDHAL_DRIVER_NOTHANDLED;
-}
-
-BOOL DrvEnableDirectDraw(DHPDEV dhpdev, DD_CALLBACKS *pCallBacks,
- DD_SURFACECALLBACKS *pSurfaceCallBacks,
- DD_PALETTECALLBACKS *pPaletteCallBacks)
-{
-memset(pCallBacks, 0, sizeof (DD_CALLBACKS));
-memset(pSurfaceCallBacks, 0, sizeof (DD_SURFACECALLBACKS));
-memset(pPaletteCallBacks, 0, sizeof (DD_PALETTECALLBACKS));
-
-pCallBacks->dwSize = sizeof (DD_CALLBACKS);
-pCallBacks->CanCreateSurface = QxlCanCreateSurface;
-
-pSurfaceCallBacks->dwSize = sizeof (DD_SURFACECALLBACKS);
-pSurfaceCallBacks->Flip = QxlFlip;
-
-pPaletteCallBacks->dwSize = sizeof (DD_PALETTECALLBACKS);
-
-return TRUE;
-}
-
-void DrvDisableDirectDraw(DHPDEV dhpdev)
-{
-PDev *pdev;
-
-pdev = (PDev *)dhpdev;
-pdev->dd_initialized = FALSE;
-}
diff --git a/display/dd.h b/display/dd.h
deleted file mode 100644
index ffcd8e1..000
--- a/display/dd.h
+++ /dev/null
@@ -1,15 +0,0 @@
-#ifndef DD_H
-#define DD_H
-
-BOOL DrvGetDirectDrawInfo(DHPDEV dhpdev, DD_HALINFO *pHallInfo,
- DWORD *pdvNumHeaps, VIDEOMEMORY *pvmList,
- DWORD *pdvNumFourCCCodes,
- DWORD *pdvFourCC);
-
-BOOL DrvEnableDirectDraw(DHPDEV dhpdev, DD_CALLBACKS *pCallBacks,
- DD_SURFACECALLBACKS *pSurfaceCallBacks,
- DD_PALETTECALLBACKS *pPaletteCallBacks);
-
-void DrvDisableDirectDraw(DHPDEV dhpdev);
-
-#endif
diff --git a/display/driver.c b/display/driver.c
index 4eaedc4..c00adb0 100644
--- a/display/driver.c
+++ b/display/driver.c
@@ -35,7 +35,6 @@
#include "mspace.h"
#include "res.h"
#include "surface.h"
-#include "dd.h"
#define DEVICE_NAME L"qxldd"
@@ -65,10 +64,6 @@ st
Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.
On Wed, 2010-08-18 at 12:03 +0300, Yonit Halperin wrote: > On 08/17/2010 05:36 PM, Alexander Larsson wrote: > > On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: > >> The driver no longer claims to support DirectDraw. > >> It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. > >> This fixes freedesktop bug #29254. > > > > Ack (although you should git rm dd.c too). > > > Oops, will resend the patch Nah, no need. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a hate-fuelled playboy shaman with no name. She's a green-fingered red-headed femme fatale from a secret island of warrior women. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.
On Wed, 2010-08-18 at 12:03 +0300, Yonit Halperin wrote: > The driver no longer claims to support DirectDraw. > It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. > This fixes freedesktop bug #29254. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a suicidal vegetarian romance novelist from the 'hood. She's a violent green-skinned Valkyrie from beyond the grave. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] server: remove unnecessary dependency between surfaces and Glz drawables
On Wed, 2010-08-11 at 14:21 +0300, Yonit Halperin wrote: > Fixes freedesktop bug #28568 > --- Ack, although it would be nice to split this into two commits. One that removes the unnecessary red_clear_surface_glz_drawables() calls and moves the red_destroy_surface() call to release_drawable, which is the core problem. Then a second one that just removes the now-unused lists surface_id references. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a world-famous pirate Green Beret on the edge. She's a scantily clad streetsmart fairy princess with only herself to blame. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] vdagent: use vdagent.h
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote:
> From: Arnon Gilboa
>
> ---
> common/vdcommon.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/common/vdcommon.h b/common/vdcommon.h
> index 2e4ed5d..ba9d0ec 100644
> --- a/common/vdcommon.h
> +++ b/common/vdcommon.h
> @@ -21,7 +21,7 @@
> #pragma warning(disable:4200)
>
> #include
> -#include "vd_agent.h"
> +#include "vdagent.h"
> #include "vdlog.h"
>
> #define VD_SERVICE_PIPE_NAME TEXT(".\\pipe\\vdservicepipe")
But its called vd_agent.h in spice-protocol. Is this right?
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander LarssonRed Hat, Inc
al...@redhat.comalexander.lars...@gmail.com
He's a scarfaced Catholic hairdresser living undercover at Ringling Bros.
Circus. She's a brilliant Buddhist traffic cop from a secret island of warrior
women. They fight crime!
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: support x64 arch
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > > /* 7.18.1.4 Integer types capable of holding object pointers */ > > +#ifndef _WIN64 > + > typedef int intptr_t; > > typedef unsigned uintptr_t; > > +#endif > + So, the win64 compiler supports (u)intptr_t, but the win32 one doesn't? Seems kinda weird. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a hate-fuelled arachnophobic barbarian on the hunt for the last specimen of a great and near-mythical creature. She's a wealthy hip-hop magician's assistant who can talk to animals. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: upgrade solution & projects to vs2008
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- > vdagent.sln|4 +- > vdagent/vdagent.vcproj | 75 > +--- > vdservice/vdservice.vcproj | 73 -- > 3 files changed, 73 insertions(+), 79 deletions(-) Ack. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a war-weary small-town gangster for the 21st century. She's a wealthy paranoid politician with an MBA from Harvard. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: return error code -1 on service install/uninstall failure #576625
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an uncontrollable native American barbarian from a doomed world. She's an artistic cat-loving politician who believes she is the reincarnation of an ancient Egyptian queen. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: drop mouse event when SendInput fails due to DesktopSwitch event delay #598968
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > --- > vdagent/vdagent.cpp |9 - > 1 files changed, 4 in Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a sword-wielding neurotic romance novelist for the 21st century. She's a blind junkie magician's assistant who hides her beauty behind a pair of thick-framed spectacles. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa > > -currently supports text only (UTF8) > -add VDAgent::dispatch_message() > -in VDAgent::read_completion() handle multi-chunk msgs > -fix chunk size bug in VDService::handle_pipe_data() > -add size to VDPipeMessage This reads out the clipboard and writes it to the client on every change. This is bad for two reasons: 1) It sends a lot of data to the client when it might not be needed 2) It always forces clipboard using apps to serialize any clip board data it has to text and pass it to windows every time someone copies and pastes. This is unnecessary in most cases since cut and paste is mostly intra-application. Additionally it may be costly since if you copy something more complex like pdf or html extracting the text from it may not be trivial. I know we discussed this on irc. What is the status of that? I guess we could split out the pure bugfixes from this and commit though. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a globe-trotting amnesiac grifter possessed of the uncanny powers of an insect. She's a sarcastic junkie snake charmer with a birthmark shaped like Liberty's torch. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support
Sorry for hijacking this, but whats the irc server/channel name? Cheers, Attila On Wed, Aug 18, 2010 at 2:15 PM, Alexander Larsson wrote: > On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > > From: Arnon Gilboa > > > > -currently supports text only (UTF8) > > -add VDAgent::dispatch_message() > > -in VDAgent::read_completion() handle multi-chunk msgs > > -fix chunk size bug in VDService::handle_pipe_data() > > -add size to VDPipeMessage > > This reads out the clipboard and writes it to the client on every > change. This is bad for two reasons: > > 1) It sends a lot of data to the client when it might not be needed > 2) It always forces clipboard using apps to serialize any clip board > data it has to text and pass it to windows every time someone copies and > pastes. This is unnecessary in most cases since cut and paste is mostly > intra-application. Additionally it may be costly since if you copy > something more complex like pdf or html extracting the text from it may > not be trivial. > > I know we discussed this on irc. What is the status of that? > > I guess we could split out the pure bugfixes from this and commit > though. > > -- > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Alexander LarssonRed Hat, Inc > al...@redhat.comalexander.lars...@gmail.com > He's a globe-trotting amnesiac grifter possessed of the uncanny powers of > an > insect. She's a sarcastic junkie snake charmer with a birthmark shaped like > Liberty's torch. They fight crime! > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: virtio serial adaptations
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > From: Arnon Gilboa Overall this looks good to me, although its hard to read in places due to whitespace-only changes in some places. It would be good to split it up in independent parts though, to make the history easier to read etc. > -mostly based on Alon's patches with cleanup > -adapt vdi_port class to virtio serial > -replace vdi_port callbacks with events > -add get_device_path() - using setupapi.lib > -add struct VDIPortBuffer for read/write buffers > -add VD_EVENT_XXX enum for clarity > -add DEBUG_VDSERVICE for debugging as standalone executable > -add CLIPBOARD_ENABLED ifdefs in the agent for disabling clipboard support > -remove mutex.h usage, deines in vdcommon.h instead > -include the common spice/vd_agent.h Isn't this just reverting the previous patch that changes from vd_agent.h to vdagent.h? Anyway, we should have one single patch that fixes this to the right end state. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a gun-slinging one-eyed senator for the 21st century. She's a green-fingered kleptomaniac nun living on borrowed time. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support
On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size bug in VDService::handle_pipe_data() -add size to VDPipeMessage This reads out the clipboard and writes it to the client on every change. This is bad for two reasons: 1) It sends a lot of data to the client when it might not be needed 2) It always forces clipboard using apps to serialize any clip board data it has to text and pass it to windows every time someone copies and pastes. This is unnecessary in most cases since cut and paste is mostly intra-application. Additionally it may be costly since if you copy something more complex like pdf or html extracting the text from it may not be trivial. Additionally I think this should be designed with multiple formats in mind. We want only send the format the two parties agreed upon over the wire. So we need some negotiation here about which formats are available in the clipboard and which one should be used. Beside that I think it isn't a great idea to shuffle the (potentially) bulky clipboard data over the same channel the agent mouse uses. cheers, Gerd ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] Controlling Windows display settings (e.g., wallpaper, UI effects and font smoothing)
On Wed, 2010-08-11 at 08:46 +0300, Yonit Halperin wrote: > The configuration is received from Spice client. > The main usage of this option is for disabling display features in order to > accelerate Spice performance over limited network connections. > --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's an oversexed amnesiac rock star for the 21st century. She's a pregnant nymphomaniac lawyer from a family of eight older brothers. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] vdagent: use vdagent.h
Alexander Larsson wrote:
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote:
From: Arnon Gilboa
---
common/vdcommon.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/vdcommon.h b/common/vdcommon.h
index 2e4ed5d..ba9d0ec 100644
--- a/common/vdcommon.h
+++ b/common/vdcommon.h
@@ -21,7 +21,7 @@
#pragma warning(disable:4200)
#include
-#include "vd_agent.h"
+#include "vdagent.h"
#include "vdlog.h"
#define VD_SERVICE_PIPE_NAME TEXT(".\\pipe\\vdservicepipe")
But its called vd_agent.h in spice-protocol. Is this right?
i guess it's inconsistency between rhel6 & upstream, i'll fix it
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support
- "Gerd Hoffmann" wrote: > On 08/18/10 14:15, Alexander Larsson wrote: > > On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: > >> From: Arnon Gilboa > >> > >> -currently supports text only (UTF8) > >> -add VDAgent::dispatch_message() > >> -in VDAgent::read_completion() handle multi-chunk msgs > >> -fix chunk size bug in VDService::handle_pipe_data() > >> -add size to VDPipeMessage > > > > This reads out the clipboard and writes it to the client on every > > change. This is bad for two reasons: > > > > 1) It sends a lot of data to the client when it might not be needed > > 2) It always forces clipboard using apps to serialize any clip > board > > data it has to text and pass it to windows every time someone copies > and > > pastes. This is unnecessary in most cases since cut and paste is > mostly > > intra-application. Additionally it may be costly since if you copy > > something more complex like pdf or html extracting the text from it > may > > not be trivial. > > Additionally I think this should be designed with multiple formats in > > mind. We want only send the format the two parties agreed upon over > the > wire. So we need some negotiation here about which formats are > available in the clipboard and which one should be used. > > Beside that I think it isn't a great idea to shuffle the (potentially) > bulky clipboard data over the same channel the agent mouse uses. The chunking already in place takes care of this right now though. > > cheers, >Gerd > > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support
On Wed, 2010-08-18 at 14:18 +0200, Attila Sukosd wrote: > Sorry for hijacking this, but whats the irc server/channel name? #spice on gimpnet -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc al...@redhat.comalexander.lars...@gmail.com He's a maverick bohemian jungle king whom everyone believes is mad. She's a beautiful mute opera singer fleeing from a Satanic cult. They fight crime! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [Qxl PATCH] aligning surfaces stride to 4
---
display/res.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/display/res.c b/display/res.c
index 3fe5fe6..6be006e 100644
--- a/display/res.c
+++ b/display/res.c
@@ -600,15 +600,17 @@ _inline void GetSurfaceMemory(PDev *pdev, UINT32 x,
UINT32 y, UINT32 depth, UINT
*stride = x * depth / 8;
break;
case DEVICE_BITMAP_ALLOCATION_TYPE_DEVRAM:
-*base_mem = AllocMem(pdev, MSPACE_TYPE_DEVRAM, x * y * depth / 8);
-*phys_mem = PA(pdev, *base_mem, pdev->main_mem_slot);
*stride = x * depth / 8;
+*stride = ALIGN(*stride, 4);
+*base_mem = AllocMem(pdev, MSPACE_TYPE_DEVRAM, (*stride) * y);
+*phys_mem = PA(pdev, *base_mem, pdev->main_mem_slot);
break;
case DEVICE_BITMAP_ALLOCATION_TYPE_VRAM: {
-*base_mem = __AllocMem(pdev, MSPACE_TYPE_VRAM, x * y * depth / 8,
FALSE,
+*stride = x * depth / 8;
+*stride = ALIGN(*stride, 4);
+*base_mem = __AllocMem(pdev, MSPACE_TYPE_VRAM, (*stride) * y, FALSE,
SURFACE_ALLOC_RELEASE_BUNCH_SIZE);
*phys_mem = PA(pdev, (PVOID)((UINT64)*base_mem), pdev->vram_mem_slot);
-*stride = x * depth / 8;
break;
}
default:
--
1.7.1.1
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
