Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
Vadim, I just ran the Qemu monitor to get the PCI information. The information is listed belowe. From the listed information, I did not see anything wrong with the BAR0. --- INFO: Bus 0, device 0, function 0: Host bridge: PCI device 8086:1237 id Bus 0, device 1, function 0: ISA bridge: PCI device 8086:7000 id Bus 0, device 1, function 1: IDE controller: PCI device 8086:7010 BAR4: I/O at 0xc000 [0xc00f]. id Bus 0, device 1, function 2: USB controller: PCI device 8086:7020 IRQ 10. BAR4: I/O at 0xc020 [0xc03f]. id Bus 0, device 1, function 3: Bridge: PCI device 8086:7113 IRQ 9. id Bus 0, device 2, function 0: VGA controller: PCI device 1b36:0100 IRQ 5. BAR0: 32 bit memory at 0xf000 [0xf3ff]. BAR1: 32 bit memory at 0xf400 [0xf7ff]. BAR2: 32 bit memory at 0xf800 [0xf8001fff]. BAR3: I/O at 0xc040 [0xc05f]. BAR6: 32 bit memory at 0x [0xfffe]. id Bus 0, device 3, function 0: Ethernet controller: PCI device 10ec:8139 IRQ 10. BAR0: I/O at 0xc100 [0xc1ff]. BAR1: 32 bit memory at 0x [0x00fe]. BAR6: 32 bit memory at 0x [0xfffe]. id net0 Bus 0, device 4, function 0: RAM controller: PCI device 1af4:1002 IRQ 11. BAR0: I/O at 0xc200 [0xc21f]. id balloon0 Bus 0, device 5, function 0: Class 1920: PCI device 1af4:1003 IRQ 11. BAR0: I/O at 0xc220 [0xc23f]. BAR1: 32 bit memory at 0xf804 [0xf8040fff]. id virtio-serial0 QTREE: bus: main-system-bus type System dev: hpet, id gpio-in 1 dev-prop: timers = 3 dev-prop: msi = off irq 32 mmio fed0/0400 dev: i440FX-pcihost, id irq 0 bus: pci.0 type PCI dev: virtio-balloon-pci, id balloon0 dev-prop: indirect_desc = on dev-prop: event_idx = on bus-prop: addr = 04.0 bus-prop: romfile = null bus-prop: rombar = 1 bus-prop: multifunction = on bus-prop: command_serr_enable = on class RAM controller, addr 00:04.0, pci id 1af4:1002 (sub 1af4:0005) bar 0: i/o at 0xc200 [0xc21f] dev: rtl8139, id net0 dev-prop: mac = 52:54:00:e8:dc:b1 dev-prop: vlan = null dev-prop: netdev = hostnet0 dev-prop: bootindex = -1 bus-prop: addr = 03.0 bus-prop: romfile = pxe-rtl8139.rom bus-prop: rombar = 1 bus-prop: multifunction = on bus-prop: command_serr_enable = on class Ethernet controller, addr 00:03.0, pci id 10ec:8139 (sub 1af4:1100) bar 0: i/o at 0xc100 [0xc1ff] bar 1: mem at 0x [0xfe] bar 6: mem at 0x [0xfffe] dev: virtio-serial-pci, id virtio-serial0 dev-prop: ioeventfd = on dev-prop: vectors = 32 dev-prop: class = 0x780 dev-prop: indirect_desc = on dev-prop: event_idx = on dev-prop: max_ports = 31 bus-prop: addr = 05.0 bus-prop: romfile = null bus-prop: rombar = 1 bus-prop: multifunction = on bus-prop: command_serr_enable = on class Class 0780, addr 00:05.0, pci id 1af4:1003 (sub 1af4:0003) bar 0: i/o at 0xc220 [0xc23f] bar 1: mem at 0xf804 [0xf8040fff] bus: virtio-serial0.0 type virtio-serial-bus dev: virtserialport, id channel0 dev-prop: chardev = charchannel0 bus-prop: nr = 1 bus-prop: name = com.redhat.spice.0 port 1, guest on, host on, throttle off dev: PIIX4_PM, id dev-prop: smb_io_base = 45312 bus-prop: addr = 01.3 bus-prop: romfile = null bus-prop: rombar = 1 bus-prop: multifunction = off bus-prop: command_serr_enable = on class Bridge, addr 00:01.3, pci id 8086:7113 (sub 1af4:1100) bus: i2c type I2C dev: smbus-eeprom, id bus-prop: address = 87 dev: smbus-eeprom, id bus-prop: address = 86 dev: smbus-eeprom, id bus-prop: address = 85 dev: smbus-eeprom, id bus-prop: address = 84 dev: smbus-eeprom, id bus-prop: address = 83 dev: smbus-eeprom, id bus-prop: address = 82 dev: smbus-eeprom, id bus-prop: address = 81 dev: smbus-eeprom, id bus-prop: address = 80 dev: piix3-usb-uhci, id dev-prop: masterbus = null dev-prop: firstport = 0 bus-prop: addr = 01.2 bus-prop: romfile = null bus-prop: rombar = 1 bus-prop: multifunction = off bus-prop: command_serr_enable = on class USB controller, addr 00:01.2, pci id 8086:7020 (sub 1af4:1100) bar 4: i/o at
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
On Mon, Jan 16, 2012 at 10:02:22AM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, Thank you for your prompt reply. Here are the information for our test case. 1) we use the following command line to launch the guest OS /usr/bin/kvm -S -M pc-0.14 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name win_xp -uuid d9388815-ddd3-c38e-33c2-a9d5fcc7a775 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/win_xp.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=readline -rtc base=localtime -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,multifunction=on,addr=0x5.0x0 -drive file=/media/Images/Windows-XP.img,if=none,id=drive-ide0-0-0,format=raw -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 -netdev tap,fd=17,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:e8:dc:b1,bus=pci.0,multifunction=on,addr=0x3.0x0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -chardev spicevmc,id=charchannel0,name=vdagent -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=channel0,name=com.redhat.spice.0 I tried the virtio-serial pieces with qemu.git and a RHEL6 guest. The guest was able to see the com.redhat.spice.0 port. This suggests the problem was either fixed since QEMU 0.15 or that it only affects the Windows virtio drivers. -usb -device usb-tablet,id=input0 -spice port=5900,addr=0.0.0.0,disable-ticketing -vga qxl -global qxl-vga.vram_size=67108864 -device virtio-balloon-pci,id=balloon0,bus=pci.0,multifunction=on,addr=0x4.0x0 2). In Guest Windows XP OS When the following callback function of the vioserial device is called in guest OS. The allocated resources is empty. VIOSerialEvtDevicePrepareHardware() ---This function is to get the I/O address of the vioserial device and map the physical address to the logical address space. I added the following trace and the value of nListSize is ZERO. TraceEvents(TRACE_LEVEL_INFORMATION, DBG_PNP, %s (nListSize=%d)\n, __FUNCTION__,nListSize); So far, we have tested Qemu 0.14 without any problem but Qemu 0.15 seemed to be broken in vioserial device. Let me know if you need further information. Thanks. I suggest trying qemu-kvm 1.0 or qemu-kvm.git because the issue may have been fixed since 0.15. If the issue is still present, you could use git-bisect(1) to find the commit that caused behavior to change between 0.14 and 0.15. Stefan ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
Stefan, We need the spice support in Qemu. Does qemu-kvm 1.0 support for spice? -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, January 16, 2012 4:37 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: Vadim Rozenfeld; Alon Levy; spice-devel@lists.freedesktop.org; Alex Huang-黃必賢-研究發展部; qemu-devel Subject: Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15 On Mon, Jan 16, 2012 at 10:02:22AM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, Thank you for your prompt reply. Here are the information for our test case. 1) we use the following command line to launch the guest OS /usr/bin/kvm -S -M pc-0.14 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name win_xp -uuid d9388815-ddd3-c38e-33c2-a9d5fcc7a775 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/win_xp.monitor,server ,nowait -mon chardev=charmonitor,id=monitor,mode=readline -rtc base=localtime -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,multifunction=on,addr=0x 5.0x0 -drive file=/media/Images/Windows-XP.img,if=none,id=drive-ide0-0-0,format=raw -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex= 1 -netdev tap,fd=17,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:e8:dc:b1,bus=pci.0,multif unction=on,addr=0x3.0x0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -chardev spicevmc,id=charchannel0,name=vdagent -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=chann el0,name=com.redhat.spice.0 I tried the virtio-serial pieces with qemu.git and a RHEL6 guest. The guest was able to see the com.redhat.spice.0 port. This suggests the problem was either fixed since QEMU 0.15 or that it only affects the Windows virtio drivers. -usb -device usb-tablet,id=input0 -spice port=5900,addr=0.0.0.0,disable-ticketing -vga qxl -global qxl-vga.vram_size=67108864 -device virtio-balloon-pci,id=balloon0,bus=pci.0,multifunction=on,addr=0x4.0x0 2). In Guest Windows XP OS When the following callback function of the vioserial device is called in guest OS. The allocated resources is empty. VIOSerialEvtDevicePrepareHardware() ---This function is to get the I/O address of the vioserial device and map the physical address to the logical address space. I added the following trace and the value of nListSize is ZERO. TraceEvents(TRACE_LEVEL_INFORMATION, DBG_PNP, %s (nListSize=%d)\n, __FUNCTION__,nListSize); So far, we have tested Qemu 0.14 without any problem but Qemu 0.15 seemed to be broken in vioserial device. Let me know if you need further information. Thanks. I suggest trying qemu-kvm 1.0 or qemu-kvm.git because the issue may have been fixed since 0.15. If the issue is still present, you could use git-bisect(1) to find the commit that caused behavior to change between 0.14 and 0.15. Stefan ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
2012/1/16 Charles.Tsai-蔡清海-研究發展部 charles.t...@cloudena.com: We need the spice support in Qemu. Does qemu-kvm 1.0 support for spice? I believe so. Stefan ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk] gtk/display: Get rid of old FSF address in copyright headers
rpmlint pointed this out while I was checking the new spice-gtk-0.8 package for Fedora. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/display/edid.h |6 ++ gtk/display/gnome-rr-config.c |6 ++ gtk/display/gnome-rr-config.h |6 ++ gtk/display/gnome-rr-generic.c |6 ++ gtk/display/gnome-rr-generic.h |6 ++ gtk/display/gnome-rr-output-info.c |6 ++ gtk/display/gnome-rr-private.h |6 ++ gtk/display/gnome-rr-windows.c |6 ++ gtk/display/gnome-rr-windows.h |6 ++ gtk/display/gnome-rr-x11.c |6 ++ gtk/display/gnome-rr-x11.h |6 ++ gtk/display/gnome-rr.c |6 ++ gtk/display/gnome-rr.h |6 ++ 13 files changed, 26 insertions(+), 52 deletions(-) diff --git a/gtk/display/edid.h b/gtk/display/edid.h index 1fa0d1a..dc3daa3 100644 --- a/gtk/display/edid.h +++ b/gtk/display/edid.h @@ -14,10 +14,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-config.c b/gtk/display/gnome-rr-config.c index 53ff2be..7227d13 100644 --- a/gtk/display/gnome-rr-config.c +++ b/gtk/display/gnome-rr-config.c @@ -16,10 +16,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-config.h b/gtk/display/gnome-rr-config.h index 8616c3a..b1b6c15 100644 --- a/gtk/display/gnome-rr-config.h +++ b/gtk/display/gnome-rr-config.h @@ -16,10 +16,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-generic.c b/gtk/display/gnome-rr-generic.c index f662b4b..90c4055 100644 --- a/gtk/display/gnome-rr-generic.c +++ b/gtk/display/gnome-rr-generic.c @@ -15,10 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Marc-André Lureau marcandre.lur...@redhat.com */ diff --git a/gtk/display/gnome-rr-generic.h b/gtk/display/gnome-rr-generic.h index 3bd8505..6694cd7 100644 --- a/gtk/display/gnome-rr-generic.h +++ b/gtk/display/gnome-rr-generic.h @@ -14,10 +14,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Authors: Soren Sandmann sandm...@redhat.com * Marc-André Lureau marcandre.lur...@redhat.com diff --git a/gtk/display/gnome-rr-output-info.c b/gtk/display/gnome-rr-output-info.c index 8936eed..d9c1658 100644 --- a/gtk/display/gnome-rr-output-info.c +++ b/gtk/display/gnome-rr-output-info.c @@
[Spice-devel] [PATCH] Handle spice_audio_new failures
spice_audio_new can return a NULL pointer when there's a failure
during the initialization of the audio system. When this happens,
we shouldn't keep initializing the spice audio channel as if nothing
happened, but just stop the connection.
This can be tested by forcing the self variable to NULL in
spice_audio_new
---
gtk/spice-audio.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
index f58a81e..9eddf0c 100644
--- a/gtk/spice-audio.c
+++ b/gtk/spice-audio.c
@@ -222,9 +222,11 @@ SpiceAudio *spice_audio_new(SpiceSession *session,
GMainContext *context,
self = SPICE_AUDIO(spice_gstaudio_new(session, context, name));
#endif
-spice_g_signal_connect_object(session, notify::enable-audio,
G_CALLBACK(session_enable_audio), self, 0);
-spice_g_signal_connect_object(session, channel-new,
G_CALLBACK(channel_new), self, 0);
-update_audio_channels(self, session);
+if (self != NULL) {
+spice_g_signal_connect_object(session, notify::enable-audio,
G_CALLBACK(session_enable_audio), self, 0);
+spice_g_signal_connect_object(session, channel-new,
G_CALLBACK(channel_new), self, 0);
+update_audio_channels(self, session);
+}
return self;
}
--
1.7.7.5
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
Dominique, Thank you for your information and we will try it here. From: Dominique Rodrigues [mailto:dominique.rodrig...@nanocloud.com] Sent: Monday, January 16, 2012 5:51 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: Stefan Hajnoczi; spice-devel@lists.freedesktop.org; Alex Huang-黃必賢-研究發展部; Vadim Rozenfeld; qemu-devel Subject: Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15 I currently use qemu-1.0 and I confirm that this version works fine with SPICE. Regards, Dominique Rodrigues http://www.nanocloud.com 8, rue Lemercier 75017 Paris France standard : +33 1 77 69 64 38 529 002 743 R.C.S. Paris Le 16/01/2012 10:32, Charles.Tsai-蔡清海-研究發展部 a écrit : Stefan, We need the spice support in Qemu. Does qemu-kvm 1.0 support for spice? -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, January 16, 2012 4:37 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: Vadim Rozenfeld; Alon Levy; spice-devel@lists.freedesktop.org; Alex Huang-黃必賢-研究發展部; qemu-devel Subject: Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15 On Mon, Jan 16, 2012 at 10:02:22AM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, Thank you for your prompt reply. Here are the information for our test case. 1) we use the following command line to launch the guest OS /usr/bin/kvm -S -M pc-0.14 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name win_xp -uuid d9388815-ddd3-c38e-33c2-a9d5fcc7a775 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/win_xp.monitor,server ,nowait -mon chardev=charmonitor,id=monitor,mode=readline -rtc base=localtime -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,multifunction=on,addr=0x 5.0x0 -drive file=/media/Images/Windows-XP.img,if=none,id=drive-ide0-0-0,format=raw -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex= 1 -netdev tap,fd=17,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:e8:dc:b1,bus=pci.0,multif unction=on,addr=0x3.0x0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -chardev spicevmc,id=charchannel0,name=vdagent -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=chann el0,name=com.redhat.spice.0 I tried the virtio-serial pieces with qemu.git and a RHEL6 guest. The guest was able to see the com.redhat.spice.0 port. This suggests the problem was either fixed since QEMU 0.15 or that it only affects the Windows virtio drivers. -usb -device usb-tablet,id=input0 -spice port=5900,addr=0.0.0.0,disable-ticketing -vga qxl -global qxl-vga.vram_size=67108864 -device virtio-balloon-pci,id=balloon0,bus=pci.0,multifunction=on,addr=0x4.0x0 2). In Guest Windows XP OS When the following callback function of the vioserial device is called in guest OS. The allocated resources is empty. VIOSerialEvtDevicePrepareHardware() ---This function is to get the I/O address of the vioserial device and map the physical address to the logical address space. I added the following trace and the value of nListSize is ZERO. TraceEvents(TRACE_LEVEL_INFORMATION, DBG_PNP, %s (nListSize=%d)\n, __FUNCTION__,nListSize); So far, we have tested Qemu 0.14 without any problem but Qemu 0.15 seemed to be broken in vioserial device. Let me know if you need further information. Thanks. I suggest trying qemu-kvm 1.0 or qemu-kvm.git because the issue may have been fixed since 0.15. If the issue is still present, you could use git-bisect(1) to find the commit that caused behavior to change between 0.14 and 0.15. Stefan ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel image001.jpg___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
I currently use qemu-1.0 and I confirm that this version works fine with SPICE. Regards, Dominique Rodrigues 8, rue Lemercier 75017 Paris France standard : +33 1 77 69 64 38 529 002 743 R.C.S. Paris Le 16/01/2012 10:32, Charles.Tsai-蔡清海-研究發展部 a écrit : Stefan, We need the spice support in Qemu. Does qemu-kvm 1.0 support for spice? -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, January 16, 2012 4:37 PM To: Charles.Tsai-蔡清海-研究發展部 Cc: Vadim Rozenfeld; Alon Levy; spice-devel@lists.freedesktop.org; Alex Huang-黃必賢-研究發展部; qemu-devel Subject: Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15 On Mon, Jan 16, 2012 at 10:02:22AM +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, Thank you for your prompt reply. Here are the information for our test case. 1) we use the following command line to launch the guest OS /usr/bin/kvm -S -M pc-0.14 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name win_xp -uuid d9388815-ddd3-c38e-33c2-a9d5fcc7a775 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/win_xp.monitor,server ,nowait -mon chardev=charmonitor,id=monitor,mode=readline -rtc base=localtime -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,multifunction=on,addr=0x 5.0x0 -drive file=/media/Images/Windows-XP.img,if=none,id=drive-ide0-0-0,format=raw -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex= 1 -netdev tap,fd=17,id=hostnet0 -device rtl8139,netdev=hostnet0,id=net0,mac=52:54:00:e8:dc:b1,bus=pci.0,multif unction=on,addr=0x3.0x0 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -chardev spicevmc,id=charchannel0,name=vdagent -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charchannel0,id=chann el0,name=com.redhat.spice.0 I tried the virtio-serial pieces with qemu.git and a RHEL6 guest. The guest was able to see the "com.redhat.spice.0" port. This suggests the problem was either fixed since QEMU 0.15 or that it only affects the Windows virtio drivers. -usb -device usb-tablet,id=input0 -spice port=5900,addr=0.0.0.0,disable-ticketing -vga qxl -global qxl-vga.vram_size=67108864 -device virtio-balloon-pci,id=balloon0,bus=pci.0,multifunction=on,addr=0x4.0x0 2). In Guest Windows XP OS When the following callback function of the vioserial device is called in guest OS. The allocated resources is empty. VIOSerialEvtDevicePrepareHardware() ---This function is to get the I/O address of the vioserial device and map the physical address to the logical address space. I added the following trace and the value of nListSize is ZERO. TraceEvents(TRACE_LEVEL_INFORMATION, DBG_PNP, "%s (nListSize=%d)\n", __FUNCTION__,nListSize); So far, we have tested Qemu 0.14 without any problem but Qemu 0.15 seemed to be broken in vioserial device. Let me know if you need further information. Thanks. I suggest trying qemu-kvm 1.0 or qemu-kvm.git because the issue may have been fixed since 0.15. If the issue is still present, you could use git-bisect(1) to find the commit that caused behavior to change between 0.14 and 0.15. Stefan ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel attachment: dominique_rodrigues.vcf smime.p7s Description: S/MIME Cryptographic Signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] Handle spice_audio_new failures
On Mon, Jan 16, 2012 at 10:58 AM, Christophe Fergeau
cferg...@redhat.com wrote:
spice_audio_new can return a NULL pointer when there's a failure
during the initialization of the audio system. When this happens,
we shouldn't keep initializing the spice audio channel as if nothing
happened, but just stop the connection.
This can be tested by forcing the self variable to NULL in
spice_audio_new
---
gtk/spice-audio.c | 8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
index f58a81e..9eddf0c 100644
--- a/gtk/spice-audio.c
+++ b/gtk/spice-audio.c
@@ -222,9 +222,11 @@ SpiceAudio *spice_audio_new(SpiceSession *session,
GMainContext *context,
self = SPICE_AUDIO(spice_gstaudio_new(session, context, name));
#endif
- spice_g_signal_connect_object(session, notify::enable-audio,
G_CALLBACK(session_enable_audio), self, 0);
- spice_g_signal_connect_object(session, channel-new,
G_CALLBACK(channel_new), self, 0);
- update_audio_channels(self, session);
I would prefer to just return here:
if (!self)
return NULL;
+ if (self != NULL) {
+ spice_g_signal_connect_object(session, notify::enable-audio,
G_CALLBACK(session_enable_audio), self, 0);
+ spice_g_signal_connect_object(session, channel-new,
G_CALLBACK(channel_new), self, 0);
+ update_audio_channels(self, session);
+ }
return self;
}
ack otherwise
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH] Handle spice_audio_new failures
On Mon, Jan 16, 2012 at 11:13:37AM +0100, Marc-André Lureau wrote: On Mon, Jan 16, 2012 at 10:58 AM, Christophe Fergeau cferg...@redhat.com wrote: spice_audio_new can return a NULL pointer when there's a failure during the initialization of the audio system. When this happens, we shouldn't keep initializing the spice audio channel as if nothing happened, but just stop the connection. This can be tested by forcing the self variable to NULL in spice_audio_new --- gtk/spice-audio.c | 8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c index f58a81e..9eddf0c 100644 --- a/gtk/spice-audio.c +++ b/gtk/spice-audio.c @@ -222,9 +222,11 @@ SpiceAudio *spice_audio_new(SpiceSession *session, GMainContext *context, self = SPICE_AUDIO(spice_gstaudio_new(session, context, name)); #endif - spice_g_signal_connect_object(session, notify::enable-audio, G_CALLBACK(session_enable_audio), self, 0); - spice_g_signal_connect_object(session, channel-new, G_CALLBACK(channel_new), self, 0); - update_audio_channels(self, session); I would prefer to just return here: if (!self) return NULL; Pushed with these changes Christophe pgpEhwWhGRl54.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk] gtk/display: Get rid of old FSF address in copyright headers
ack On Mon, Jan 16, 2012 at 10:55 AM, Hans de Goede hdego...@redhat.com wrote: rpmlint pointed this out while I was checking the new spice-gtk-0.8 package for Fedora. Signed-off-by: Hans de Goede hdego...@redhat.com --- gtk/display/edid.h | 6 ++ gtk/display/gnome-rr-config.c | 6 ++ gtk/display/gnome-rr-config.h | 6 ++ gtk/display/gnome-rr-generic.c | 6 ++ gtk/display/gnome-rr-generic.h | 6 ++ gtk/display/gnome-rr-output-info.c | 6 ++ gtk/display/gnome-rr-private.h | 6 ++ gtk/display/gnome-rr-windows.c | 6 ++ gtk/display/gnome-rr-windows.h | 6 ++ gtk/display/gnome-rr-x11.c | 6 ++ gtk/display/gnome-rr-x11.h | 6 ++ gtk/display/gnome-rr.c | 6 ++ gtk/display/gnome-rr.h | 6 ++ 13 files changed, 26 insertions(+), 52 deletions(-) diff --git a/gtk/display/edid.h b/gtk/display/edid.h index 1fa0d1a..dc3daa3 100644 --- a/gtk/display/edid.h +++ b/gtk/display/edid.h @@ -14,10 +14,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-config.c b/gtk/display/gnome-rr-config.c index 53ff2be..7227d13 100644 --- a/gtk/display/gnome-rr-config.c +++ b/gtk/display/gnome-rr-config.c @@ -16,10 +16,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-config.h b/gtk/display/gnome-rr-config.h index 8616c3a..b1b6c15 100644 --- a/gtk/display/gnome-rr-config.h +++ b/gtk/display/gnome-rr-config.h @@ -16,10 +16,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Soren Sandmann sandm...@redhat.com */ diff --git a/gtk/display/gnome-rr-generic.c b/gtk/display/gnome-rr-generic.c index f662b4b..90c4055 100644 --- a/gtk/display/gnome-rr-generic.c +++ b/gtk/display/gnome-rr-generic.c @@ -15,10 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Author: Marc-André Lureau marcandre.lur...@redhat.com */ diff --git a/gtk/display/gnome-rr-generic.h b/gtk/display/gnome-rr-generic.h index 3bd8505..6694cd7 100644 --- a/gtk/display/gnome-rr-generic.h +++ b/gtk/display/gnome-rr-generic.h @@ -14,10 +14,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Library General Public License for more details. * - * You should have received a copy of the GNU Library General Public - * License along with the Gnome Library; see the file COPYING.LIB. If not, - * write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see http://www.gnu.org/licenses/. * * Authors: Soren Sandmann sandm...@redhat.com * Marc-André Lureau marcandre.lur...@redhat.com diff --git
Re: [Spice-devel] Error compiling Spice Client on ARM
On Mon, Jan 16, 2012 at 08:47:00AM -0300, Nicolas Antonio Corrarello wrote: Alo, Sorry for the delay's, I left the VM at the office. Here is the output you Thanks, Can you try this patch? diff --git a/client/foreign_menu.cpp b/client/foreign_menu.cpp index d1df49d..faef4c2 100644 --- a/client/foreign_menu.cpp +++ b/client/foreign_menu.cpp @@ -30,7 +30,7 @@ #ifdef WIN32 #define PIPE_NAME SpiceForeignMenu-%lu -#elif defined(__i386__) +#elif defined(__i386__) || __SIZEOF_LONG__ == 4 #define PIPE_NAME /tmp/SpiceForeignMenu-%llu.uds #else #define PIPE_NAME /tmp/SpiceForeignMenu-%lu.uds requested: # 1 stdin # 1 built-in #define __STDC__ 1 #define __STDC_HOSTED__ 1 #define __GNUC__ 4 #define __GNUC_MINOR__ 6 #define __GNUC_PATCHLEVEL__ 2 #define __VERSION__ 4.6.2 #define __FINITE_MATH_ONLY__ 0 #define __SIZEOF_INT__ 4 #define __SIZEOF_LONG__ 4 #define __SIZEOF_LONG_LONG__ 8 #define __SIZEOF_SHORT__ 2 #define __SIZEOF_FLOAT__ 4 #define __SIZEOF_DOUBLE__ 8 #define __SIZEOF_LONG_DOUBLE__ 8 #define __SIZEOF_SIZE_T__ 4 #define __CHAR_BIT__ 8 #define __BIGGEST_ALIGNMENT__ 8 #define __ORDER_LITTLE_ENDIAN__ 1234 #define __ORDER_BIG_ENDIAN__ 4321 #define __ORDER_PDP_ENDIAN__ 3412 #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ #define __FLOAT_WORD_ORDER__ __ORDER_LITTLE_ENDIAN__ #define __SIZEOF_POINTER__ 4 #define __SIZE_TYPE__ unsigned int #define __PTRDIFF_TYPE__ int #define __WCHAR_TYPE__ unsigned int #define __WINT_TYPE__ unsigned int #define __INTMAX_TYPE__ long long int #define __UINTMAX_TYPE__ long long unsigned int #define __CHAR16_TYPE__ short unsigned int #define __CHAR32_TYPE__ unsigned int #define __SIG_ATOMIC_TYPE__ int #define __INT8_TYPE__ signed char #define __INT16_TYPE__ short int #define __INT32_TYPE__ int #define __INT64_TYPE__ long long int #define __UINT8_TYPE__ unsigned char #define __UINT16_TYPE__ short unsigned int #define __UINT32_TYPE__ unsigned int #define __UINT64_TYPE__ long long unsigned int #define __INT_LEAST8_TYPE__ signed char #define __INT_LEAST16_TYPE__ short int #define __INT_LEAST32_TYPE__ int #define __INT_LEAST64_TYPE__ long long int #define __UINT_LEAST8_TYPE__ unsigned char #define __UINT_LEAST16_TYPE__ short unsigned int #define __UINT_LEAST32_TYPE__ unsigned int #define __UINT_LEAST64_TYPE__ long long unsigned int #define __INT_FAST8_TYPE__ signed char #define __INT_FAST16_TYPE__ int #define __INT_FAST32_TYPE__ int #define __INT_FAST64_TYPE__ long long int #define __UINT_FAST8_TYPE__ unsigned char #define __UINT_FAST16_TYPE__ unsigned int #define __UINT_FAST32_TYPE__ unsigned int #define __UINT_FAST64_TYPE__ long long unsigned int #define __INTPTR_TYPE__ int #define __UINTPTR_TYPE__ unsigned int #define __GXX_ABI_VERSION 1002 #define __SCHAR_MAX__ 127 #define __SHRT_MAX__ 32767 #define __INT_MAX__ 2147483647 #define __LONG_MAX__ 2147483647L #define __LONG_LONG_MAX__ 9223372036854775807LL #define __WCHAR_MAX__ 4294967295U #define __WCHAR_MIN__ 0U #define __WINT_MAX__ 4294967295U #define __WINT_MIN__ 0U #define __PTRDIFF_MAX__ 2147483647 #define __SIZE_MAX__ 4294967295U #define __INTMAX_MAX__ 9223372036854775807LL #define __INTMAX_C(c) c ## LL #define __UINTMAX_MAX__ 18446744073709551615ULL #define __UINTMAX_C(c) c ## ULL #define __SIG_ATOMIC_MAX__ 2147483647 #define __SIG_ATOMIC_MIN__ (-__SIG_ATOMIC_MAX__ - 1) #define __INT8_MAX__ 127 #define __INT16_MAX__ 32767 #define __INT32_MAX__ 2147483647 #define __INT64_MAX__ 9223372036854775807LL #define __UINT8_MAX__ 255 #define __UINT16_MAX__ 65535 #define __UINT32_MAX__ 4294967295U #define __UINT64_MAX__ 18446744073709551615ULL #define __INT_LEAST8_MAX__ 127 #define __INT8_C(c) c #define __INT_LEAST16_MAX__ 32767 #define __INT16_C(c) c #define __INT_LEAST32_MAX__ 2147483647 #define __INT32_C(c) c #define __INT_LEAST64_MAX__ 9223372036854775807LL #define __INT64_C(c) c ## LL #define __UINT_LEAST8_MAX__ 255 #define __UINT8_C(c) c #define __UINT_LEAST16_MAX__ 65535 #define __UINT16_C(c) c #define __UINT_LEAST32_MAX__ 4294967295U #define __UINT32_C(c) c ## U #define __UINT_LEAST64_MAX__ 18446744073709551615ULL #define __UINT64_C(c) c ## ULL #define __INT_FAST8_MAX__ 127 #define __INT_FAST16_MAX__ 2147483647 #define __INT_FAST32_MAX__ 2147483647 #define __INT_FAST64_MAX__ 9223372036854775807LL #define __UINT_FAST8_MAX__ 255 #define __UINT_FAST16_MAX__ 4294967295U #define __UINT_FAST32_MAX__ 4294967295U #define __UINT_FAST64_MAX__ 18446744073709551615ULL #define __INTPTR_MAX__ 2147483647 #define __UINTPTR_MAX__ 4294967295U #define __FLT_EVAL_METHOD__ 0 #define
[Spice-devel] Help regarding spice qemu compile
i have spice (spice-server-0.9.1-1.el6.x86_64) qemu-kvm-0.15.0-3.el6.x86_64 installed from http://yum.griddynamics.net/yum/diablo-centos repo. My question is if i compiled spice server 0.10.x replace the /usr/lib64/libspice-server.so.1 /usr/lib64/libspice-server.so.1.0.2. it will work??? or i need to compile with qemu-kvm. -- Thanks Avdhoot ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Help regarding spice qemu compile
On Mon, Jan 16, 2012 at 06:39:41PM +0530, Avdhoot Dendge - BetterLabs wrote: i have spice (spice-server-0.9.1-1.el6.x86_64) ߽ן߽ןqemu-kvm-0.15.0-3.el6.x86_64 installed from1]߽ן]http://yum.griddynamics.net/yum/diablo-centos repo. My question is if i߽ןcompiled spice server0.10߽ן.x߽ן replace the߽ן/usr/lib64/libspice-server.so.1 ߽ן/usr/lib64/libspice-server.so.1.0.2. it will work???߽ן ߽ןor i need to compile with qemu-kvm.߽ן --߽ן Thanks Avdhoot Sorry that I can't give a straight answer, it should, but the easiest way to find out is to replace them. To actually check for abi compliance you can use something like http://forge.ispras.ru/projects/abi-compliance-checker, although the main site is down right now. References Visible links 1. http://yum.griddynamics.net/yum/diablo-centos ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] segmentation faults with opengl canvas
I want to use opengl canvas with --canvas-type gl_fbo or --canvas-type gl_pbuff.. However, I always meet a segmentation fault when i execute the spice client with the option. I executed the spice-0.10.0 on fedora linux, and opengl library is installed. Please let me know what the problem is.. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk 1/2] Change the setting of the images cache size and the glz window size
Set the default sizes to be the same as in the old linux spice client.
cache_size=20M pixels (instead of 32M), window_size=8M pixels for a 64MB
dev ram (instead of 16M pixels).
---
gtk/channel-display-priv.h |2 -
gtk/channel-display.c | 22 +++---
gtk/channel-main.c |1 +
gtk/spice-session-priv.h | 12 ++
gtk/spice-session.c| 90 +++-
5 files changed, 117 insertions(+), 10 deletions(-)
diff --git a/gtk/channel-display-priv.h b/gtk/channel-display-priv.h
index 332d271..eca1787 100644
--- a/gtk/channel-display-priv.h
+++ b/gtk/channel-display-priv.h
@@ -36,8 +36,6 @@
G_BEGIN_DECLS
-#define DISPLAY_PIXMAP_CACHE (1024 * 1024 * 32)
-#define GLZ_WINDOW_SIZE (1024 * 1024 * 16)
typedef struct display_surface {
RingItemlink;
diff --git a/gtk/channel-display.c b/gtk/channel-display.c
index ec42829..2473ac6 100644
--- a/gtk/channel-display.c
+++ b/gtk/channel-display.c
@@ -766,13 +766,21 @@ static void emit_invalidate(SpiceChannel *channel,
SpiceRect *bbox)
static void spice_display_channel_up(SpiceChannel *channel)
{
SpiceMsgOut *out;
-SpiceMsgcDisplayInit init = {
-.pixmap_cache_id= 1,
-.pixmap_cache_size = DISPLAY_PIXMAP_CACHE,
-.glz_dictionary_id = 1,
-.glz_dictionary_window_size = GLZ_WINDOW_SIZE,
-};
-
+SpiceSession *s = spice_channel_get_session(channel);
+SpiceMsgcDisplayInit init;
+int cache_size;
+int glz_window_size;
+
+g_object_get(s,
+ cache-size, cache_size,
+ glz-window-size, glz_window_size,
+ NULL);
+SPICE_DEBUG(%s: cache_size %d, glz_window_size %d (bytes), __FUNCTION__,
+cache_size, glz_window_size);
+init.pixmap_cache_id = 1;
+init.glz_dictionary_id = 1;
+init.pixmap_cache_size = cache_size / 4; /* pixels */
+init.glz_dictionary_window_size = glz_window_size / 4; /* pixels */
out = spice_msg_out_new(channel, SPICE_MSGC_DISPLAY_INIT);
out-marshallers-msgc_display_init(out-marshaller, init);
spice_msg_out_send_internal(out);
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index ebf660f..b2df547 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -1128,6 +1128,7 @@ static void main_handle_init(SpiceChannel *channel,
SpiceMsgIn *in)
init-current_mouse_mode);
spice_session_set_mm_time(session, init-multi_media_time);
+spice_session_set_caches_hints(session, init-ram_hint,
init-display_channels_hint);
c-agent_tokens = init-agent_tokens;
if (init-agent_connected)
diff --git a/gtk/spice-session-priv.h b/gtk/spice-session-priv.h
index 5df1182..430f4a4 100644
--- a/gtk/spice-session-priv.h
+++ b/gtk/spice-session-priv.h
@@ -27,6 +27,10 @@
G_BEGIN_DECLS
+#define MAX_IMAGES_CACHE_SIZE (1024 * 1024 * 80)
+#define MIN_GLZ_WINDOW_SIZE (1024 * 1024 * 12)
+#define MAX_GLZ_WINDOW_SIZE MIN((LZ_MAX_WINDOW_SIZE * 4), 1024 * 1024 * 64)
+
struct _SpiceSessionPrivate {
char *host;
char *port;
@@ -84,6 +88,11 @@ struct _SpiceSessionPrivate {
display_cache images;
display_cache palettes;
SpiceGlzDecoderWindow *glz_window;
+int images_cache_size;
+int glz_window_size;
+uint32_t pci_ram_size;
+uint32_t display_channels_count;
+
/* associated objects */
SpiceAudio*audio_manager;
@@ -120,6 +129,9 @@ const gchar* spice_session_get_cert_subject(SpiceSession
*session);
const gchar* spice_session_get_ciphers(SpiceSession *session);
const gchar* spice_session_get_ca_file(SpiceSession *session);
+void spice_session_set_caches_hints(SpiceSession *session,
+uint32_t pci_ram_size,
+uint32_t display_channels_count);
void spice_session_get_caches(SpiceSession *session,
display_cache **images,
display_cache **palettes,
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 79ba1b6..54aeabd 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -101,6 +101,8 @@ enum {
PROP_DISABLE_EFFECTS,
PROP_COLOR_DEPTH,
PROP_READ_ONLY,
+PROP_CACHE_SIZE,
+PROP_GLZ_WINDOW_SIZE,
};
/* signals */
@@ -407,7 +409,13 @@ static void spice_session_get_property(GObject*gobject,
break;
case PROP_READ_ONLY:
g_value_set_boolean(value, s-read_only);
- break;
+ break;
+case PROP_CACHE_SIZE:
+g_value_set_int(value, s-images_cache_size);
+break;
+case PROP_GLZ_WINDOW_SIZE:
+g_value_set_int(value, s-glz_window_size);
+break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID(gobject, prop_id, pspec);
break;
@@ -508,6 +516,12 @@ static void spice_session_set_property(GObject
[Spice-devel] [PATCH spice-gtk 2/2] Add command line options for setting the cache size and the glz window size
This options will help us tune and find the optimal values.
---
gtk/spice-option.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/gtk/spice-option.c b/gtk/spice-option.c
index 394a07d..d466f94 100644
--- a/gtk/spice-option.c
+++ b/gtk/spice-option.c
@@ -36,6 +36,8 @@ static char *usbredir_filter = NULL;
static gboolean smartcard = FALSE;
static gboolean disable_audio = FALSE;
static gboolean disable_usbredir = FALSE;
+static gint cache_size = 0;
+static gint glz_window_size = 0;
static void option_version(void)
{
@@ -84,6 +86,10 @@ GOptionGroup* spice_get_option_group(void)
N_(Enable Spice-GTK debugging), NULL },
{ spice-gtk-version, '\0', G_OPTION_FLAG_NO_ARG,
G_OPTION_ARG_CALLBACK, option_version,
N_(Display Spice-GTK version information), NULL },
+{ spice-cache-size, '\0', 0, G_OPTION_ARG_INT, cache_size,
+ N_(Image cache size), N_(bytes) },
+{ spice-glz-window-size, '\0', 0, G_OPTION_ARG_INT, glz_window_size,
+ N_(Glz compression history size), N_(bytes) },
{ NULL, 0, 0, G_OPTION_ARG_NONE, NULL, NULL, NULL }
};
GOptionGroup *grp;
@@ -146,4 +152,8 @@ void spice_set_session_option(SpiceSession *session)
g_object_set(session, enable-usbredir, FALSE, NULL);
if (disable_audio)
g_object_set(session, enable-audio, FALSE, NULL);
+if (cache_size)
+g_object_set(session, cache-size, cache_size, NULL);
+if (glz_window_size)
+g_object_set(session, glz_window_size, glz_window_size, NULL);
}
--
1.7.6.4
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Error compiling Spice Client on ARM
Worked like charm... 2012/1/16 Alon Levy al...@redhat.com On Mon, Jan 16, 2012 at 08:47:00AM -0300, Nicolas Antonio Corrarello wrote: Alo, Sorry for the delay's, I left the VM at the office. Here is the output you Thanks, Can you try this patch? diff --git a/client/foreign_menu.cpp b/client/foreign_menu.cpp index d1df49d..faef4c2 100644 --- a/client/foreign_menu.cpp +++ b/client/foreign_menu.cpp @@ -30,7 +30,7 @@ #ifdef WIN32 #define PIPE_NAME SpiceForeignMenu-%lu -#elif defined(__i386__) +#elif defined(__i386__) || __SIZEOF_LONG__ == 4 #define PIPE_NAME /tmp/SpiceForeignMenu-%llu.uds #else #define PIPE_NAME /tmp/SpiceForeignMenu-%lu.uds requested: # 1 stdin # 1 built-in #define __STDC__ 1 #define __STDC_HOSTED__ 1 #define __GNUC__ 4 #define __GNUC_MINOR__ 6 #define __GNUC_PATCHLEVEL__ 2 #define __VERSION__ 4.6.2 #define __FINITE_MATH_ONLY__ 0 #define __SIZEOF_INT__ 4 #define __SIZEOF_LONG__ 4 #define __SIZEOF_LONG_LONG__ 8 #define __SIZEOF_SHORT__ 2 #define __SIZEOF_FLOAT__ 4 #define __SIZEOF_DOUBLE__ 8 #define __SIZEOF_LONG_DOUBLE__ 8 #define __SIZEOF_SIZE_T__ 4 #define __CHAR_BIT__ 8 #define __BIGGEST_ALIGNMENT__ 8 #define __ORDER_LITTLE_ENDIAN__ 1234 #define __ORDER_BIG_ENDIAN__ 4321 #define __ORDER_PDP_ENDIAN__ 3412 #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__ #define __FLOAT_WORD_ORDER__ __ORDER_LITTLE_ENDIAN__ #define __SIZEOF_POINTER__ 4 #define __SIZE_TYPE__ unsigned int #define __PTRDIFF_TYPE__ int #define __WCHAR_TYPE__ unsigned int #define __WINT_TYPE__ unsigned int #define __INTMAX_TYPE__ long long int #define __UINTMAX_TYPE__ long long unsigned int #define __CHAR16_TYPE__ short unsigned int #define __CHAR32_TYPE__ unsigned int #define __SIG_ATOMIC_TYPE__ int #define __INT8_TYPE__ signed char #define __INT16_TYPE__ short int #define __INT32_TYPE__ int #define __INT64_TYPE__ long long int #define __UINT8_TYPE__ unsigned char #define __UINT16_TYPE__ short unsigned int #define __UINT32_TYPE__ unsigned int #define __UINT64_TYPE__ long long unsigned int #define __INT_LEAST8_TYPE__ signed char #define __INT_LEAST16_TYPE__ short int #define __INT_LEAST32_TYPE__ int #define __INT_LEAST64_TYPE__ long long int #define __UINT_LEAST8_TYPE__ unsigned char #define __UINT_LEAST16_TYPE__ short unsigned int #define __UINT_LEAST32_TYPE__ unsigned int #define __UINT_LEAST64_TYPE__ long long unsigned int #define __INT_FAST8_TYPE__ signed char #define __INT_FAST16_TYPE__ int #define __INT_FAST32_TYPE__ int #define __INT_FAST64_TYPE__ long long int #define __UINT_FAST8_TYPE__ unsigned char #define __UINT_FAST16_TYPE__ unsigned int #define __UINT_FAST32_TYPE__ unsigned int #define __UINT_FAST64_TYPE__ long long unsigned int #define __INTPTR_TYPE__ int #define __UINTPTR_TYPE__ unsigned int #define __GXX_ABI_VERSION 1002 #define __SCHAR_MAX__ 127 #define __SHRT_MAX__ 32767 #define __INT_MAX__ 2147483647 #define __LONG_MAX__ 2147483647L #define __LONG_LONG_MAX__ 9223372036854775807LL #define __WCHAR_MAX__ 4294967295U #define __WCHAR_MIN__ 0U #define __WINT_MAX__ 4294967295U #define __WINT_MIN__ 0U #define __PTRDIFF_MAX__ 2147483647 #define __SIZE_MAX__ 4294967295U #define __INTMAX_MAX__ 9223372036854775807LL #define __INTMAX_C(c) c ## LL #define __UINTMAX_MAX__ 18446744073709551615ULL #define __UINTMAX_C(c) c ## ULL #define __SIG_ATOMIC_MAX__ 2147483647 #define __SIG_ATOMIC_MIN__ (-__SIG_ATOMIC_MAX__ - 1) #define __INT8_MAX__ 127 #define __INT16_MAX__ 32767 #define __INT32_MAX__ 2147483647 #define __INT64_MAX__ 9223372036854775807LL #define __UINT8_MAX__ 255 #define __UINT16_MAX__ 65535 #define __UINT32_MAX__ 4294967295U #define __UINT64_MAX__ 18446744073709551615ULL #define __INT_LEAST8_MAX__ 127 #define __INT8_C(c) c #define __INT_LEAST16_MAX__ 32767 #define __INT16_C(c) c #define __INT_LEAST32_MAX__ 2147483647 #define __INT32_C(c) c #define __INT_LEAST64_MAX__ 9223372036854775807LL #define __INT64_C(c) c ## LL #define __UINT_LEAST8_MAX__ 255 #define __UINT8_C(c) c #define __UINT_LEAST16_MAX__ 65535 #define __UINT16_C(c) c #define __UINT_LEAST32_MAX__ 4294967295U #define __UINT32_C(c) c ## U #define __UINT_LEAST64_MAX__ 18446744073709551615ULL #define __UINT64_C(c) c ## ULL #define __INT_FAST8_MAX__ 127 #define __INT_FAST16_MAX__ 2147483647 #define __INT_FAST32_MAX__ 2147483647 #define __INT_FAST64_MAX__ 9223372036854775807LL #define __UINT_FAST8_MAX__ 255 #define __UINT_FAST16_MAX__ 4294967295U #define __UINT_FAST32_MAX__ 4294967295U
[Spice-devel] Control Linux desktop remotey?
Is spice only useful for VDI? Can I control a Linux server or desktop remotely using a Spice client on Windows or is it best to use VNC or some other remote service/protocol. All of the examples I've read require QEMU and describe setting up a guest OS using QEMU. Did I miss something or is it just not possible? Thanks, George___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Control Linux desktop remotey?
- Original Message - From: George Pyle laxgoo...@yahoo.com To: spice-devel@lists.freedesktop.org Sent: Monday, January 16, 2012 11:19:44 AM Subject: [Spice-devel] Control Linux desktop remotey? Is spice only useful for VDI? Can I control a Linux server or desktop remotely using a Spice client on Windows or is it best to use VNC or some other remote service/protocol. All of the examples I've read require QEMU and describe setting up a guest OS using QEMU. Did I miss something or is it just not possible? Spice will work for servers or desktops. If you don't install a driver in the guest it will perform in a similar fashion to vnc. Thanks, George ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Control Linux desktop remotey?
Hi - Mensaje original - Is spice only useful for VDI? Can I control a Linux server or desktop remotely using a Spice client on Windows or is it best to use VNC or some other remote service/protocol. All of the examples I've read require QEMU and describe setting up a guest OS using QEMU. Did I miss something or is it just not possible? Spice will work for servers or desktops. If you don't install a driver in the guest it will perform in a similar fashion to vnc. George, if you want to use Spice as a remote desktop protocol only for Linux, you may be interested by XSpice, the X server using Spice. This way, your desktop/server doesn't need to run over QEMU. See http://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/README.xspice . You won't get all of the nice features however, mostly only display+inputs for now. Afaik, there is no way to export your current desktop (linux or windows) with Spice. That would be neat to have. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] Announcing spice-protocol 0.10.1 aka the miniheader release
Hi All, I'm happy to announce spice-protocol-0.10.1 Major changes in 0.10.1 === * Add support for a header without sublist and serial (mini header) You can download it here: http://spice-space.org/download.html Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Control Linux desktop remotey?
Thanks for the reply. I was kind of hoping there was a spice equivalent to the vncserver or some kind of configuration or spice that would work. Sounds like that would be a future. From: Marc-André Lureau mlur...@redhat.com To: Andrew Cathrow acath...@redhat.com Cc: spice-devel@lists.freedesktop.org; George Pyle laxgoo...@yahoo.com Sent: Monday, January 16, 2012 11:05 AM Subject: Re: [Spice-devel] Control Linux desktop remotey? Hi - Mensaje original - Is spice only useful for VDI? Can I control a Linux server or desktop remotely using a Spice client on Windows or is it best to use VNC or some other remote service/protocol. All of the examples I've read require QEMU and describe setting up a guest OS using QEMU. Did I miss something or is it just not possible? Spice will work for servers or desktops. If you don't install a driver in the guest it will perform in a similar fashion to vnc. George, if you want to use Spice as a remote desktop protocol only for Linux, you may be interested by XSpice, the X server using Spice. This way, your desktop/server doesn't need to run over QEMU. See http://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/README.xspice . You won't get all of the nice features however, mostly only display+inputs for now. Afaik, there is no way to export your current desktop (linux or windows) with Spice. That would be neat to have.___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] Windows VM hang during booting
hello again, https://bugzilla.redhat.com/show_bug.cgi?id=750773 This bug disaepear during some tests of qemu 1.0 and kernel 3.1.x Now I can reproduce it with latest git of qemu / spice / qxl on windows 32 bits and windows 64bits host : linux kernel 3.2.1 I do not understand why but it seems when i 'm using this program : http://www.ngohq.com/home.php?page=dseo start it, enable test mode . Stop VM . Bug is present when i restart the vm ( windows 64 bits ) I can give ssh access / or do some tests to help you. Regards, Nicolas Prochazka. /usr/local/bin/qemu -name 7spice -readconfig /etc/ich9-ehci-uhci.cfg -device usb-tablet -spice port=11978,disable-ticketing -vga qxl -device virtio-serial -chardev spicevmc,id=vdagent,debug=0,name=vdagent -device virtserialport,chardev=vdagent,name=com.redhat.spice.0 -chardev spicevmc,name=usbredir,id=usbredirchardev1 -device usb-redir,chardev=usbredirchardev1,id=usbredirdev1,debug=0 -chardev spicevmc,name=usbredir,id=usbredirchardev2 -device usb-redir,chardev=usbredirchardev2,id=usbredirdev2,debug=0 -chardev spicevmc,name=usbredir,id=usbredirchardev3 -device usb-redir,chardev=usbredirchardev3,id=usbredirdev3,debug=0 -vnc 10.98.98.1:148 -monitor tcp:127.0.0.1:10148,server,nowait,nodelay -m 1024 -pidfile /var/run/qemu/7spice.pid -net tap,vlan=5,name=externe,script=/etc/qemu-ifEup,downscript=/etc/qemu-ifEdown,ifname=vmEtap48 -net nic,vlan=5,macaddr=ac:de:49:2c:96:d7,model=e1000 -drive file=/swapfile-guest/swap1,if=ide,index=1,media=disk,snapshot=on -rtc base=localtime -no-hpet -cpu host -drive file=/mnt/vdisk/images/VM-7spice.1326287901.9487801,index=0,media=disk,snapshot=off,cache=writeback -fda fat:floppy:/mnt/vdisk/diskconf/7spice --enable-kvm ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
On Mon, 2012-01-16 at 17:17 +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, I just ran the Qemu monitor to get the PCI information. The information is listed belowe. From the listed information, I did not see anything wrong with the BAR0. --- Thank you. 2). In Guest Windows XP OS SP3? Can you try reproducing this problem on Win7? Best regards, Vadim. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] spice-protocol mess
On 01/15/2012 10:40 AM, Yaniv Kaul wrote: On 01/15/2012 10:13 AM, Yonit Halperin wrote: SNIP BTW, Yaniv, can you update the wireshark dissector to handle the new protocol? Yonit. Already on it, hopefully patch will be ready by the end of the week. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6743 Y. I'm not sure the capability exchange was done in the spirit of the protocol (I think each capability should have had its own word, so 'auth.' was the first word, 'wan features' the 2nd, and not just use the next bit, but I'll adjust the dissector to this). Y. I'm not sure. Someone needs to check. Right, which is why I called the code adventurous :) Regards, Hans ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15
Vadim, I am sorry that it was my mistake because I did not see there was a PIC device which was created with no device driver installed. Instead of updating the driver, I ran the hardware installation wizard to install the Vioserial driver. As such, the system could not install the device for me since it was taken over by another device already. Thank you for your help and I learned a lot about how a hardware device is virtualized by Qemu. -Original Message- From: Vadim Rozenfeld [mailto:vroze...@redhat.com] Sent: Tuesday, January 17, 2012 5:28 AM To: Charles.Tsai-蔡清海-研究發展部 Cc: Stefan Hajnoczi; Alon Levy; spice-devel@lists.freedesktop.org; Alex Huang-黃必賢-研究發展部; qemu-devel Subject: RE: [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15 On Mon, 2012-01-16 at 17:17 +0800, Charles.Tsai-蔡清海-研究發展部 wrote: Vadim, I just ran the Qemu monitor to get the PCI information. The information is listed belowe. From the listed information, I did not see anything wrong with the BAR0. --- Thank you. 2). In Guest Windows XP OS SP3? Can you try reproducing this problem on Win7? Best regards, Vadim. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Help regarding spice qemu compile
How i can check which version of spice server i am using. with qemu-kvm. On Mon, Jan 16, 2012 at 6:52 PM, Alon Levy al...@redhat.com wrote: On Mon, Jan 16, 2012 at 06:39:41PM +0530, Avdhoot Dendge - BetterLabs wrote: i have spice (spice-server-0.9.1-1.el6.x86_64) ߽ן߽ןqemu-kvm-0.15.0-3.el6.x86_64 installed from1]߽ן]http://yum.griddynamics.net/yum/diablo-centos repo. My question is if i߽ןcompiled spice server0.10߽ן.x߽ן replace the߽ן/usr/lib64/libspice-server.so.1 ߽ן/usr/lib64/libspice-server.so.1.0.2. it will work???߽ן ߽ןor i need to compile with qemu-kvm.߽ן --߽ן Thanks Avdhoot Sorry that I can't give a straight answer, it should, but the easiest way to find out is to replace them. To actually check for abi compliance you can use something like http://forge.ispras.ru/projects/abi-compliance-checker, although the main site is down right now. References Visible links 1. http://yum.griddynamics.net/yum/diablo-centos ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel -- Thanks Avdhoot ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
