Re: [Spice-devel] Spice client terminated (exitcode = 13)
Gentlemen: Thank you both for your advice. I set up the connection using virt-viewer and followed the documentation at libvirt.org/remote.html, and all is well. Sincerely, John Frye On Mon, 2013-05-13 at 15:25 +0300, Uri Lublin wrote: > On 05/13/2013 02:12 PM, Christophe Fergeau wrote: > > Hi, > > > > I'm not sure anyone answered that, so here's my take on this ;) > > > > On Mon, Apr 22, 2013 at 02:50:13AM -0400, John/Amy Frye wrote: > >> Dear Spice Developers: > >> > >> When I run spicec to connect securely to a virtual machine, it exits > >> leaving me only with the info "exitcode = 13." I am unable to find what > >> this means. > >> > >> The hypervisor log shows no errors. I checked other places for info or > >> problems: /var/log/audit/audit.log, /var/log/messages, dmesg output, > >> virsh dumpxml output, qemu.conf, ss output, and iptables. > >> > >> The virtual machine is Fedora 18 running on the same. > >> > >> As far as I know, spicec is talking to the hypervisor, as shown in the > >> latter's log via warnings from prior, failed attempts to connect. > >> > >> Everything works fine when done unsecurely. > >> > >> Thank you in advance for any help you may provide. > > I think there's a spicec.log file somewhere. However, these days we highly > > recommend using remote-viewer (part of virt-viewer) as a spice client, > > maybe you'd haveb etter luck with it. > > Thanks Christophe for bringing this up. > > Error 13 is SPICEC_ERROR_CODE_INVALID_ARG > What is your spicec command line ? > Look at stdout/stderr for messages explaining what went wrong. > Give remote-viewer a try ! > ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-gtk] any roadmap for supporting of OpenGL ?
> > There are any roadmap for OpenGL ? it will be expecting :) No, Its under investigation, by which I mean when its ready. But I am actually doing a lot of full time work on it at present, but quite when that work will a) be ready to demonstrate b) be actually useable is very indeterminate, also what form it will take wrt how much of spice display framework it will use are also unknown. Dave. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCHv2 spice-gtk] session: timeout after 10s of socket connect() attempt
- Mensaje original -
> https://bugzilla.redhat.com/show_bug.cgi?id=885101
> ---
> gtk/spice-session.c | 34 +-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> v2:
> - remove timeout on the created socket
>
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index 8f4e1bd..3f901e4 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -1693,6 +1693,9 @@ struct spice_open_host {
> GError *error;
> GSocketConnection *connection;
> GSocketClient *client;
> +#if !GLIB_CHECK_VERSION(2,26,0)
> +guint timeout_id;
> +#endif
> };
>
> static void socket_client_connect_ready(GObject *source_object, GAsyncResult
> *result,
> @@ -1795,6 +1798,20 @@ static gboolean open_host_idle_cb(gpointer data)
> return FALSE;
> }
>
> +#define SOCKET_TIMEOUT 10
> +
> +#if !GLIB_CHECK_VERSION(2,26,0)
> +static gboolean connect_timeout(gpointer data)
> +{
> +spice_open_host *open_host = data;
> +
> +open_host->timeout_id = 0;
> +coroutine_yieldto(open_host->from, NULL);
> +
> +return FALSE;
> +}
> +#endif
> +
> /* coroutine context */
> G_GNUC_INTERNAL
> GSocketConnection* spice_session_channel_open_host(SpiceSession *session,
> SpiceChannel *channel,
> @@ -1827,11 +1844,25 @@ GSocketConnection*
> spice_session_channel_open_host(SpiceSession *session, SpiceC
> }
>
> open_host.client = g_socket_client_new();
> +#if GLIB_CHECK_VERSION(2,26,0)
> +g_socket_client_set_timeout(open_host.client, SOCKET_TIMEOUT);
> +#else
> +open_host.timeout_id =
> +g_timeout_add_seconds(SOCKET_TIMEOUT, connect_timeout, &open_host);
> +#endif
>
> guint id = g_idle_add(open_host_idle_cb, &open_host);
> /* switch to main loop and wait for connection */
> coroutine_yield(NULL);
> -g_source_remove (id);
> +g_source_remove(id);
> +
> +#if !GLIB_CHECK_VERSION(2,26,0)
> +if (open_host.timeout_id == 0)
> +open_host.error = g_error_new(SPICE_CLIENT_ERROR,
> SPICE_CLIENT_ERROR_FAILED,
> + "connect timed out");
> +else
> +g_source_remove(open_host.timeout_id);
> +#endif
>
> if (open_host.error != NULL) {
> g_warning("%s", open_host.error->message);
> @@ -1839,6 +1870,7 @@ GSocketConnection*
> spice_session_channel_open_host(SpiceSession *session, SpiceC
> } else if (open_host.connection != NULL) {
> GSocket *socket;
> socket = g_socket_connection_get_socket(open_host.connection);
> +g_socket_set_timeout(socket, 0);
arf, and obviously, it needs the GLIB_CHECK_VERSION(2,26,0) there too.
> g_socket_set_blocking(socket, FALSE);
> g_socket_set_keepalive(socket, TRUE);
> }
> --
> 1.8.3.rc1.49.g8d97506
>
>
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCHv2 spice-gtk] session: timeout after 10s of socket connect() attempt
https://bugzilla.redhat.com/show_bug.cgi?id=885101
---
gtk/spice-session.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
v2:
- remove timeout on the created socket
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 8f4e1bd..3f901e4 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1693,6 +1693,9 @@ struct spice_open_host {
GError *error;
GSocketConnection *connection;
GSocketClient *client;
+#if !GLIB_CHECK_VERSION(2,26,0)
+guint timeout_id;
+#endif
};
static void socket_client_connect_ready(GObject *source_object, GAsyncResult
*result,
@@ -1795,6 +1798,20 @@ static gboolean open_host_idle_cb(gpointer data)
return FALSE;
}
+#define SOCKET_TIMEOUT 10
+
+#if !GLIB_CHECK_VERSION(2,26,0)
+static gboolean connect_timeout(gpointer data)
+{
+spice_open_host *open_host = data;
+
+open_host->timeout_id = 0;
+coroutine_yieldto(open_host->from, NULL);
+
+return FALSE;
+}
+#endif
+
/* coroutine context */
G_GNUC_INTERNAL
GSocketConnection* spice_session_channel_open_host(SpiceSession *session,
SpiceChannel *channel,
@@ -1827,11 +1844,25 @@ GSocketConnection*
spice_session_channel_open_host(SpiceSession *session, SpiceC
}
open_host.client = g_socket_client_new();
+#if GLIB_CHECK_VERSION(2,26,0)
+g_socket_client_set_timeout(open_host.client, SOCKET_TIMEOUT);
+#else
+open_host.timeout_id =
+g_timeout_add_seconds(SOCKET_TIMEOUT, connect_timeout, &open_host);
+#endif
guint id = g_idle_add(open_host_idle_cb, &open_host);
/* switch to main loop and wait for connection */
coroutine_yield(NULL);
-g_source_remove (id);
+g_source_remove(id);
+
+#if !GLIB_CHECK_VERSION(2,26,0)
+if (open_host.timeout_id == 0)
+open_host.error = g_error_new(SPICE_CLIENT_ERROR,
SPICE_CLIENT_ERROR_FAILED,
+ "connect timed out");
+else
+g_source_remove(open_host.timeout_id);
+#endif
if (open_host.error != NULL) {
g_warning("%s", open_host.error->message);
@@ -1839,6 +1870,7 @@ GSocketConnection*
spice_session_channel_open_host(SpiceSession *session, SpiceC
} else if (open_host.connection != NULL) {
GSocket *socket;
socket = g_socket_connection_get_socket(open_host.connection);
+g_socket_set_timeout(socket, 0);
g_socket_set_blocking(socket, FALSE);
g_socket_set_keepalive(socket, TRUE);
}
--
1.8.3.rc1.49.g8d97506
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk] session: timeout after 10s of socket connect() attempt
https://bugzilla.redhat.com/show_bug.cgi?id=885101
---
gtk/spice-session.c | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 8f4e1bd..51a75e4 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1693,6 +1693,9 @@ struct spice_open_host {
GError *error;
GSocketConnection *connection;
GSocketClient *client;
+#if !GLIB_CHECK_VERSION(2,26,0)
+guint timeout_id;
+#endif
};
static void socket_client_connect_ready(GObject *source_object, GAsyncResult
*result,
@@ -1795,6 +1798,20 @@ static gboolean open_host_idle_cb(gpointer data)
return FALSE;
}
+#define SOCKET_TIMEOUT 10
+
+#if !GLIB_CHECK_VERSION(2,26,0)
+static gboolean connect_timeout(gpointer data)
+{
+spice_open_host *open_host = data;
+
+open_host->timeout_id = 0;
+coroutine_yieldto(open_host->from, NULL);
+
+return FALSE;
+}
+#endif
+
/* coroutine context */
G_GNUC_INTERNAL
GSocketConnection* spice_session_channel_open_host(SpiceSession *session,
SpiceChannel *channel,
@@ -1827,11 +1844,27 @@ GSocketConnection*
spice_session_channel_open_host(SpiceSession *session, SpiceC
}
open_host.client = g_socket_client_new();
+#if GLIB_CHECK_VERSION(2,26,0)
+g_socket_client_set_timeout(open_host.client, SOCKET_TIMEOUT);
+#else
+open_host.timeout_id =
+g_timeout_add_seconds(SOCKET_TIMEOUT, connect_timeout, &open_host);
+#endif
guint id = g_idle_add(open_host_idle_cb, &open_host);
/* switch to main loop and wait for connection */
coroutine_yield(NULL);
-g_source_remove (id);
+g_source_remove(id);
+
+#if GLIB_CHECK_VERSION(2,26,0)
+g_socket_client_set_timeout(open_host.client, 0);
+#else
+if (open_host.timeout_id == 0)
+open_host.error = g_error_new(SPICE_CLIENT_ERROR,
SPICE_CLIENT_ERROR_FAILED,
+ "connect timed out");
+else
+g_source_remove(open_host.timeout_id);
+#endif
if (open_host.error != NULL) {
g_warning("%s", open_host.error->message);
--
1.8.2.1.342.gfa7285d
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Spice client terminated (exitcode = 13)
On 05/13/2013 02:12 PM, Christophe Fergeau wrote: Hi, I'm not sure anyone answered that, so here's my take on this ;) On Mon, Apr 22, 2013 at 02:50:13AM -0400, John/Amy Frye wrote: Dear Spice Developers: When I run spicec to connect securely to a virtual machine, it exits leaving me only with the info "exitcode = 13." I am unable to find what this means. The hypervisor log shows no errors. I checked other places for info or problems: /var/log/audit/audit.log, /var/log/messages, dmesg output, virsh dumpxml output, qemu.conf, ss output, and iptables. The virtual machine is Fedora 18 running on the same. As far as I know, spicec is talking to the hypervisor, as shown in the latter's log via warnings from prior, failed attempts to connect. Everything works fine when done unsecurely. Thank you in advance for any help you may provide. I think there's a spicec.log file somewhere. However, these days we highly recommend using remote-viewer (part of virt-viewer) as a spice client, maybe you'd haveb etter luck with it. Thanks Christophe for bringing this up. Error 13 is SPICEC_ERROR_CODE_INVALID_ARG What is your spicec command line ? Look at stdout/stderr for messages explaining what went wrong. Give remote-viewer a try ! ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] Spice client terminated (exitcode = 13)
Hi, I'm not sure anyone answered that, so here's my take on this ;) On Mon, Apr 22, 2013 at 02:50:13AM -0400, John/Amy Frye wrote: > Dear Spice Developers: > > When I run spicec to connect securely to a virtual machine, it exits > leaving me only with the info "exitcode = 13." I am unable to find what > this means. > > The hypervisor log shows no errors. I checked other places for info or > problems: /var/log/audit/audit.log, /var/log/messages, dmesg output, > virsh dumpxml output, qemu.conf, ss output, and iptables. > > The virtual machine is Fedora 18 running on the same. > > As far as I know, spicec is talking to the hypervisor, as shown in the > latter's log via warnings from prior, failed attempts to connect. > > Everything works fine when done unsecurely. > > Thank you in advance for any help you may provide. I think there's a spicec.log file somewhere. However, these days we highly recommend using remote-viewer (part of virt-viewer) as a spice client, maybe you'd haveb etter luck with it. Christophe pgpR8BzK5RLaO.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] spice-client: "-w password" (on the command line) is a security risk
On Sun, Apr 07, 2013 at 09:05:34PM -0500, Rob Browning wrote: > (If possible, please preserve the 704229-forwarded address in any replies.) > > I reported the following bug to the Debian bug tracker, but realized it > should probably just be forwarded upstream. > > Rob Browning writes: > > > Package: spice-client > > Version: 0.11.0-1 > > > > I think the spice client should probably support some other way of > > specifying the password since putting it on the command line makes it > > visible to any other users on the system. > > > > A reasonable alternative might be "--password-file foo". > > (cf. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704229) The recommended client these days is remote-viewer which does not allow passing the password on the command line, so this is less of an issue Christophe pgphUN7kVr72I.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [xf86-video-qxl] Eliminate gcc warning "initialization discards 'const' qualifier from pointer target type"
Sorry for the noise, brain fart.
On Mon, 2013-05-13 at 14:01 +0300, Alon Levy wrote:
> ACK from me.
>
> Soren, are you ok with this?
>
> On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote:
> > Signed-off-by: Jeremy White
> > ---
> >
> > This is the controversial patch; see previous conversation here:
> >
> http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html
> >
> > I feel the benefit (nearly zero warnings) outweighs the harm (our
> moral
> > outrage at what we have to do to the code). I don't think we would
> > successfully get a change in upstream xorg (changing the type
> declaration
> > of OptionInfoRec is the only other approach I could find that
> addressed this).
> >
> > Cheers,
> >
> > Jeremy
> >
> > src/qxl_driver.c | 22 +-
> > src/spiceqxl_inputs.c | 26 +-
> > 2 files changed, 30 insertions(+), 18 deletions(-)
> >
> > diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> > index ff58601..8e59b5f 100644
> > --- a/src/qxl_driver.c
> > +++ b/src/qxl_driver.c
> > @@ -62,6 +62,10 @@ extern void compat_init_scrn (ScrnInfoPtr);
> >
> > #define BREAKPOINT() do { __asm__ __volatile__ ("int $03"); }
> while (0)
> >
> > +static char filter_str[] = "filter";
> > +static char auto_str[] = "auto";
> > +static char auto_glz_str[] = "auto_glz";
> > +static char driver_name[] = QXL_DRIVER_NAME;
> > const OptionInfoRec DefaultOptions[] =
> > {
> > { OPTION_ENABLE_IMAGE_CACHE,
> > @@ -93,15 +97,15 @@ const OptionInfoRec DefaultOptions[] =
> > { OPTION_SPICE_X509_KEY_FILE,
> >"SpiceX509KeyFile", OPTV_STRING,{0}, FALSE},
> > { OPTION_SPICE_STREAMING_VIDEO,
> > - "SpiceStreamingVideo", OPTV_STRING,{.str =
> "filter"}, FALSE},
> > + "SpiceStreamingVideo", OPTV_STRING,{.str =
> filter_str}, FALSE},
> > { OPTION_SPICE_PLAYBACK_COMPRESSION,
> >"SpicePlaybackCompression", OPTV_BOOLEAN, {1}, FALSE},
> > { OPTION_SPICE_ZLIB_GLZ_WAN_COMPRESSION,
> > - "SpiceZlibGlzWanCompression", OPTV_STRING, {.str = "auto"},
> FALSE},
> > + "SpiceZlibGlzWanCompression", OPTV_STRING, {.str =
> auto_str}, FALSE},
> > { OPTION_SPICE_JPEG_WAN_COMPRESSION,
> > - "SpiceJpegWanCompression", OPTV_STRING,{.str = "auto"},
> FALSE},
> > + "SpiceJpegWanCompression", OPTV_STRING,{.str =
> auto_str}, FALSE},
> > { OPTION_SPICE_IMAGE_COMPRESSION,
> > - "SpiceImageCompression",OPTV_STRING,{.str =
> "auto_glz"}, FALSE},
> > + "SpiceImageCompression",OPTV_STRING,{.str =
> auto_glz_str}, FALSE},
> > { OPTION_SPICE_DISABLE_COPY_PASTE,
> >"SpiceDisableCopyPaste",OPTV_BOOLEAN, {0}, FALSE},
> > { OPTION_SPICE_IPV4_ONLY,
> > @@ -1197,8 +1201,8 @@ static void
> > qxl_init_scrn (ScrnInfoPtr pScrn)
> > {
> > pScrn->driverVersion= 0;
> > -pScrn->driverName = QXL_DRIVER_NAME;
> > -pScrn->name = QXL_DRIVER_NAME;
> > +pScrn->driverName = driver_name;
> > +pScrn->name = driver_name;
> > pScrn->PreInit = qxl_pre_init;
> > pScrn->ScreenInit = qxl_screen_init;
> > pScrn->SwitchMode = qxl_switch_mode;
> > @@ -1222,7 +1226,7 @@ qxl_probe (struct _DriverRec *drv, int flags)
> > pScrn = xf86AllocateScreen (drv, flags);
> > qxl_init_scrn (pScrn);
> >
> > -xf86MatchDevice (QXL_DRIVER_NAME, &device);
> > +xf86MatchDevice (driver_name, &device);
> > entityIndex = xf86ClaimNoSlot (drv, 0, device[0], TRUE);
> > pEnt = xf86GetEntityInfo (entityIndex);
> > pEnt->driver = drv;
> > @@ -1314,7 +1318,7 @@ qxl_pci_probe (DriverPtr drv, int entity,
> struct pci_device *dev, intptr_t match
> >
> > static DriverRec qxl_driver = {
> > 0,
> > -QXL_DRIVER_NAME,
> > +driver_name,
> > qxl_identify,
> > qxl_probe,
> > qxl_available_options,
> > @@ -1358,7 +1362,7 @@ qxl_setup (pointer module, pointer opts, int
> *errmaj, int *errmin)
> >
> > static XF86ModuleVersionInfo qxl_module_info =
> > {
> > -QXL_DRIVER_NAME,
> > +driver_name,
> > MODULEVENDORSTRING,
> > MODINFOSTRING1,
> > MODINFOSTRING2,
> > diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c
> > index 3c22d00..2b8a15e 100644
> > --- a/src/spiceqxl_inputs.c
> > +++ b/src/spiceqxl_inputs.c
> > @@ -46,9 +46,10 @@ void XSpicePointerUnInit(InputDriverPtr drv,
> InputInfoPtr pInfo, int flags);
> > static
> > void XSpiceKeyboardUnInit(InputDriverPtr drv, InputInfoPtr pInfo,
> int flags);
> >
> > +static char xspice_pointer_name[] = "xspice pointer";
> > static InputDriverRec XSPICE_POINTER = {
> > 1,
> > -"xspice pointer",
> > +xspice_pointer_name,
> > NULL,
> > XSpicePointerPreInit,
> > XSpicePointerUnInit,
> > @@ -56,9 +57,10 @@ static InputDriverRec XSPICE_POINTER = {
> > NULL /* defaults */
> > };
> >
> > +static char xspice_keyboa
Re: [Spice-devel] [xf86-video-qxl] Eliminate gcc warning "initialization discards 'const' qualifier from pointer target type"
ACK from me.
Soren, are you ok with this?
On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
>
> This is the controversial patch; see previous conversation here:
> http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html
>
> I feel the benefit (nearly zero warnings) outweighs the harm (our moral
> outrage at what we have to do to the code). I don't think we would
> successfully get a change in upstream xorg (changing the type declaration
> of OptionInfoRec is the only other approach I could find that addressed this).
>
> Cheers,
>
> Jeremy
>
> src/qxl_driver.c | 22 +-
> src/spiceqxl_inputs.c | 26 +-
> 2 files changed, 30 insertions(+), 18 deletions(-)
>
> diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> index ff58601..8e59b5f 100644
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -62,6 +62,10 @@ extern void compat_init_scrn (ScrnInfoPtr);
>
> #define BREAKPOINT() do { __asm__ __volatile__ ("int $03"); } while (0)
>
> +static char filter_str[] = "filter";
> +static char auto_str[] = "auto";
> +static char auto_glz_str[] = "auto_glz";
> +static char driver_name[] = QXL_DRIVER_NAME;
> const OptionInfoRec DefaultOptions[] =
> {
> { OPTION_ENABLE_IMAGE_CACHE,
> @@ -93,15 +97,15 @@ const OptionInfoRec DefaultOptions[] =
> { OPTION_SPICE_X509_KEY_FILE,
>"SpiceX509KeyFile", OPTV_STRING,{0}, FALSE},
> { OPTION_SPICE_STREAMING_VIDEO,
> - "SpiceStreamingVideo", OPTV_STRING,{.str = "filter"}, FALSE},
> + "SpiceStreamingVideo", OPTV_STRING,{.str = filter_str},
> FALSE},
> { OPTION_SPICE_PLAYBACK_COMPRESSION,
>"SpicePlaybackCompression", OPTV_BOOLEAN, {1}, FALSE},
> { OPTION_SPICE_ZLIB_GLZ_WAN_COMPRESSION,
> - "SpiceZlibGlzWanCompression", OPTV_STRING, {.str = "auto"}, FALSE},
> + "SpiceZlibGlzWanCompression", OPTV_STRING, {.str = auto_str}, FALSE},
> { OPTION_SPICE_JPEG_WAN_COMPRESSION,
> - "SpiceJpegWanCompression", OPTV_STRING,{.str = "auto"}, FALSE},
> + "SpiceJpegWanCompression", OPTV_STRING,{.str = auto_str}, FALSE},
> { OPTION_SPICE_IMAGE_COMPRESSION,
> - "SpiceImageCompression",OPTV_STRING,{.str = "auto_glz"},
> FALSE},
> + "SpiceImageCompression",OPTV_STRING,{.str = auto_glz_str},
> FALSE},
> { OPTION_SPICE_DISABLE_COPY_PASTE,
>"SpiceDisableCopyPaste",OPTV_BOOLEAN, {0}, FALSE},
> { OPTION_SPICE_IPV4_ONLY,
> @@ -1197,8 +1201,8 @@ static void
> qxl_init_scrn (ScrnInfoPtr pScrn)
> {
> pScrn->driverVersion= 0;
> -pScrn->driverName = QXL_DRIVER_NAME;
> -pScrn->name = QXL_DRIVER_NAME;
> +pScrn->driverName = driver_name;
> +pScrn->name = driver_name;
> pScrn->PreInit = qxl_pre_init;
> pScrn->ScreenInit = qxl_screen_init;
> pScrn->SwitchMode = qxl_switch_mode;
> @@ -1222,7 +1226,7 @@ qxl_probe (struct _DriverRec *drv, int flags)
> pScrn = xf86AllocateScreen (drv, flags);
> qxl_init_scrn (pScrn);
>
> -xf86MatchDevice (QXL_DRIVER_NAME, &device);
> +xf86MatchDevice (driver_name, &device);
> entityIndex = xf86ClaimNoSlot (drv, 0, device[0], TRUE);
> pEnt = xf86GetEntityInfo (entityIndex);
> pEnt->driver = drv;
> @@ -1314,7 +1318,7 @@ qxl_pci_probe (DriverPtr drv, int entity, struct
> pci_device *dev, intptr_t match
>
> static DriverRec qxl_driver = {
> 0,
> -QXL_DRIVER_NAME,
> +driver_name,
> qxl_identify,
> qxl_probe,
> qxl_available_options,
> @@ -1358,7 +1362,7 @@ qxl_setup (pointer module, pointer opts, int *errmaj,
> int *errmin)
>
> static XF86ModuleVersionInfo qxl_module_info =
> {
> -QXL_DRIVER_NAME,
> +driver_name,
> MODULEVENDORSTRING,
> MODINFOSTRING1,
> MODINFOSTRING2,
> diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c
> index 3c22d00..2b8a15e 100644
> --- a/src/spiceqxl_inputs.c
> +++ b/src/spiceqxl_inputs.c
> @@ -46,9 +46,10 @@ void XSpicePointerUnInit(InputDriverPtr drv, InputInfoPtr
> pInfo, int flags);
> static
> void XSpiceKeyboardUnInit(InputDriverPtr drv, InputInfoPtr pInfo, int flags);
>
> +static char xspice_pointer_name[] = "xspice pointer";
> static InputDriverRec XSPICE_POINTER = {
> 1,
> -"xspice pointer",
> +xspice_pointer_name,
> NULL,
> XSpicePointerPreInit,
> XSpicePointerUnInit,
> @@ -56,9 +57,10 @@ static InputDriverRec XSPICE_POINTER = {
> NULL /* defaults */
> };
>
> +static char xspice_keyboard_name[] = "xspice keyboard";
> static InputDriverRec XSPICE_KEYBOARD = {
> 1,
> -"xspice keyboard",
> +xspice_keyboard_name,
> NULL,
> XSpiceKeyboardPreInit,
> XSpiceKeyboardUnInit,
> @@ -149,15 +151,20 @@ static void xspice_keyboard_control(DeviceIntPtr
> device, KeybdCtrl *ctrl)
> }
> }
>
> +s
Re: [Spice-devel] [PATCH spice-gtk 6/7] keymaps: add basic x11 keysyms
Hi - Mensaje original - > On Fri, May 10, 2013 at 10:46:07PM +0200, Marc-André Lureau wrote: > > Ok, this isn't a good idea, but atm, the browser don't seem to send > > hardware keycode, and so Gtk+ broadway backend decided to use keysyms > > representation, which spice-gtk receives as "hardware keycodes"... > > > > Since Gdk keysyms are same as X11, add a new x11 keysym to keymap. > > > > This is not going to fly,... > > Yeah this is pretty much doomed to awfulness. We need to get GTK > to pass through better data for hardware keycodes It's probably a browser limitation atm, but it could already be a bit better: https://bugzilla.gnome.org/show_bug.cgi?id=700105 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [Engine-devel] ovirt user portal and attach a cd
Hi, On Fri, May 10, 2013 at 12:09:59PM +0300, Itamar Heim wrote: > On 05/10/2013 12:01 PM, Andrej Bagon wrote: > >while pressing the http://elmarco.fedorapeople.org/spice.cab download > >link there is a file Not Found. There is no .cab file in the directory > >listing either. > > maybe spice-devel (cc'd) knows of a different one I don't think there's an alternate link for this, my understanding is that the spice.cab file was there for some private tests, this was not an official release. Christophe pgpTe1js1x6H_.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-gtk] any roadmap for supporting of OpenGL ?
Hi, There are any roadmap for OpenGL ? it will be expecting :) -- jojo ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk 6/7] keymaps: add basic x11 keysyms
On Fri, May 10, 2013 at 10:46:07PM +0200, Marc-André Lureau wrote: > Ok, this isn't a good idea, but atm, the browser don't seem to send > hardware keycode, and so Gtk+ broadway backend decided to use keysyms > representation, which spice-gtk receives as "hardware keycodes"... > > Since Gdk keysyms are same as X11, add a new x11 keysym to keymap. > > This is not going to fly,... Yeah this is pretty much doomed to awfulness. We need to get GTK to pass through better data for hardware keycodes Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk] vncdisplaykeymap: add wayland support
ACK.
On 05/13/2013 01:13 AM, Marc-André Lureau wrote:
The Wayland keycode are just Linux evdev, but the Gdk backend
add the +8 offset used by Xorg evdev.
---
gtk/vncdisplaykeymap.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c
index 8b01294..6d75424 100644
--- a/gtk/vncdisplaykeymap.c
+++ b/gtk/vncdisplaykeymap.c
@@ -59,10 +59,19 @@ static struct {
static unsigned int ref_count_for_untranslated_keys = 0;
+#ifdef GDK_WINDOWING_WAYLAND
+#include
+#endif
+
#ifdef GDK_WINDOWING_BROADWAY
#include
#endif
+#if defined(GDK_WINDOWING_X11) || defined(GDK_WINDOWING_WAYLAND)
+/* Xorg Linux + evdev (offset evdev keycodes) */
+#include "vncdisplaykeymap_xorgevdev2xtkbd.c"
+#endif
+
#ifdef GDK_WINDOWING_X11
#include
#include
@@ -225,6 +234,14 @@ const guint16 const
*vnc_display_keymap_gdk2xtkbd_table(GdkWindow *window,
}
#endif
+#ifdef GDK_WINDOWING_WAYLAND
+ if (GDK_IS_WAYLAND_WINDOW(window)) {
+ VNC_DEBUG("Using Wayland Xorg/evdev virtual keycode mapping");
+ *maplen = G_N_ELEMENTS(keymap_xorgevdev2xtkbd);
+ return keymap_xorgevdev2xtkbd;
+}
+#endif
+
#ifdef GDK_WINDOWING_BROADWAY
if (GDK_IS_BROADWAY_WINDOW(window)) {
g_warning("experimental: using broadway, x11 virtual keysym
mapping - with very limited support. See also
https://bugzilla.gnome.org/show_bug.cgi?id=700105";);
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
