It would be great if somebody could post a binary version of the Spice
client for OSX.
Federico
On 4/27/11 5:29 AM, "spice-devel-requ...@lists.freedesktop.org"
wrote:
>Send Spice-devel mailing list submissions to
> spice-devel@lists.freedesktop.org
>
>To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>or, via email, send a message with subject or body 'help' to
> spice-devel-requ...@lists.freedesktop.org
>
>You can reach the person managing the list at
> spice-devel-ow...@lists.freedesktop.org
>
>When replying, please edit your Subject line so it is more specific
>than "Re: Contents of Spice-devel digest..."
>
>
>Today's Topics:
>
> 1. Re: Spice on OS/X (Mosebach Kai)
> 2. Re: Spice on OS/X (Christophe Fergeau)
> 3. Re: spice-gtk 0.6 : Ctrl+W closes the client (Christophe Fergeau)
> 4. Re: Spice on OS/X (Kai Mosebach)
> 5. Re: Spice on OS/X (Kai Mosebach)
> 6. Re: androidSpice-0.1.4 released (Alon Levy)
> 7. Re: windows bsod with spice 0.8.1 (Alon Levy)
>
>
>--
>
>Message: 1
>Date: Wed, 27 Apr 2011 08:59:02 +
>From: "Mosebach Kai"
>Subject: Re: [Spice-devel] Spice on OS/X
>To: Christophe Fergeau , Attila Sukosd
>
>Cc: "spice-devel@lists.freedesktop.org"
>
>Message-ID:
>Content-Type: text/plain; charset="us-ascii"
>
>I finally build it on OSX 10.6.6 successfully :-)
>
>>From the patches below I only used :
>
>common/lines.c
>gtk/Makefile.am
>
>
>Then a
>
>./configure --with-audio=gstreamer --without-python
>--with-coroutine=gthread
>
>did the trick, I think --with-coroutine=gthread avoid the _XOPEN_SOURCE
>patches.
>
>Best Kai
>
>
>On 4/27/11 10:47 AM, "Christophe Fergeau" wrote:
>
>>On Tue, Apr 26, 2011 at 08:39:13PM +0200, Attila Sukosd wrote:
>>> Also I've attached the patch which fixes a few things here and there...
>>>With
>>> this it builds fine.
>>
>>Ah, so you've already built spice-gtk on macosx? How well did it work?
>>
>>I had some questions about your patch, it would be really helpful if you
>>remembered why you had to change these things :)
>>
>>Thanks for the patch,
>>
>>Christophe
>>
>>diff --git a/common/lines.c b/common/lines.c
>>index 1a14c18..59d0689 100644
>>--- a/common/lines.c
>>+++ b/common/lines.c
>>@@ -2985,7 +2985,7 @@ miWideDashSegment (GCPtr pGC,
>> double L, l;
>> double k;
>> PolyVertexRec vertices[4];
>>-PolyVertexRec saveRight = { 0 }, saveBottom;
>>+PolyVertexRec saveRight = { 0 }, saveBottom = { 0 };
>> PolySlopeRec slopes[4];
>> PolyEdgeRec left[2], right[2];
>> LineFaceRec lcapFace, rcapFace;
>>
>>I assume this bit is to avoid a "saveBottom can be used without being
>>initialized" gcc warning?
>>
>>
>>
>>diff --git a/gtk/Makefile.am b/gtk/Makefile.am
>>index 7ce8a65..e5f3c1c 100644
>>--- a/gtk/Makefile.am
>>+++ b/gtk/Makefile.am
>>@@ -27,6 +27,7 @@ if HAVE_LD_VERSION_SCRIPT
>> VERSION_LDFLAGS = -Wl,--version-script=${srcdir}/map-file
>> else
>> VERSION_LDFLAGS = -export-symbols ${srcdir}/sym-file
>>+#VERSION_LDFLAGS =
>> endif
>>
>> KEYMAP_GEN = $(srcdir)/keymap-gen.pl
>>
>>
>>macosx ld indeed doesn't have any of --version-script nor
>>-export-symbols,
>>but it does have --exported_symbols_list which seems to be equivalent to
>>what we are trying to do here. This means m4/ld-version.m4 could be
>>improved to deal with this.
>>
>>
>>@@ -420,7 +421,6 @@ INTROSPECTION_GIRS =
>> INTROSPECTION_SCANNER_ARGS = --add-include-path=$(builddir)
>>$(PREFIX_ARGS)
>> INTROSPECTION_COMPILER_ARGS = --includedir=$(builddir)
>>
>>-if HAVE_INTROSPECTION
>> glib_introspection_files = $(libspice_client_glibinclude_HEADERS)
>> gtk_introspection_files = $(libspice_client_gtkinclude_HEADERS)
>>
>>@@ -453,7 +453,6 @@ typelibsdir = $(libdir)/girepository-1.0
>> typelibs_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)
>>
>> CLEANFILES += $(gir_DATA) $(typelibs_DATA)
>>-endif
>>
>>I'm not sure why you needed this change.
>>My first guess was that this change is needed to prevent autoconf from
>>complaining that HAVE_INTROSPECTION is not present in an AM_CONDITIONAL
>>when gobject-introspection (and introspection.m4) are not installed.
>>However, this would mean that unconditionally building the introspection
>>stuff would fail, and moreover, when I tested just this change without
>>introspection, configure didn't succeed. Can you tell more about why this
>>change was needed?
>>
>>
>>diff --git a/gtk/continuation.c b/gtk/continuation.c
>>index 4f5b027..3aefa54 100644
>>--- a/gtk/continuation.c
>>+++ b/gtk/continuation.c
>>@@ -21,7 +21,10 @@
>> #include
>>
>> #include "continuation.h"
>>-
>>+#ifdef __MACH__
>>+#define _XOPEN_SOURCE
>>+#include
>>+#endif
>>
>>continuation.h already has the #include , including it again
>>shouldn't do much. Does something like
>>--- a/gtk/continuation.c
>>+++ b/gtk/continuation.c
>>@@ -21,7 +21,10 @@
>> #include
>>
>>+#define _XOPEN_SOUR
