[Spice-devel] [PATCH] client: fix - exit on bad display-effect argument

2010-08-08 Thread Yonit Halperin
---
 client/application.cpp |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/client/application.cpp b/client/application.cpp
index 3dafbc6..490cd8c 100644
--- a/client/application.cpp
+++ b/client/application.cpp
@@ -1926,6 +1926,8 @@ bool 
Application::set_disabled_display_effects(CmdLineParser parser, char *val,
 disp_setting._disable_animation = true;
 } else {
 Platform::term_printf(%s: bad display effect type \%s\\n, 
arg0, val);
+_exit_code = SPICEC_ERROR_CODE_INVALID_ARG;
+return false;
 }
 } while ((val = parser.next_argument()));
 
-- 
1.7.1.1

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] [PATCH] client: fix - exit on bad display-effect argument

2010-08-08 Thread Alon Levy

- Yonit Halperin yhalp...@redhat.com wrote:

 ---
  client/application.cpp |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/client/application.cpp b/client/application.cpp
 index 3dafbc6..490cd8c 100644
 --- a/client/application.cpp
 +++ b/client/application.cpp
 @@ -1926,6 +1926,8 @@ bool
 Application::set_disabled_display_effects(CmdLineParser parser, char
 *val,
  disp_setting._disable_animation = true;
  } else {
  Platform::term_printf(%s: bad display effect type
 \%s\\n, arg0, val);
 +_exit_code = SPICEC_ERROR_CODE_INVALID_ARG;
 +return false;
  }
  } while ((val = parser.next_argument()));
  
 -- 
 1.7.1.1
 

ACK

 ___
 Spice-devel mailing list
 Spice-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/spice-devel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel