Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-25 Thread Alon Levy 
 On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote:
  Signed-off-by: Alon Levy al...@redhat.com
  ---
   src/qxl_driver.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
  
  diff --git a/src/qxl_driver.c b/src/qxl_driver.c
  index b9aa0e9..d9bf447 100644
  --- a/src/qxl_driver.c
  +++ b/src/qxl_driver.c
  @@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms)
   pScrn-ValidMode= NULL;
   }
   
  -#ifdef XF86DRM_MODE
  +#if defined(XF86DRM_MODE)  !defined(XSPICE)
   static char *
   CreatePCIBusID(const struct pci_device *dev)
   {
  --
  1.9.3
 
 ACK, though we could also ensure that XF86DRM_MODE is never defined when
 XSPICE is ?
 

You're right, but it's more work - mainly deciding what I want done - should 
configure not allow both drm and xspice? probably. Later patch?
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-25 Thread Christophe Fergeau 
On Wed, Jun 25, 2014 at 06:14:18AM -0400, Alon Levy wrote:
  On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote:
   Signed-off-by: Alon Levy al...@redhat.com
   ---
src/qxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
   
   diff --git a/src/qxl_driver.c b/src/qxl_driver.c
   index b9aa0e9..d9bf447 100644
   --- a/src/qxl_driver.c
   +++ b/src/qxl_driver.c
   @@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms)
pScrn-ValidMode= NULL;
}

   -#ifdef XF86DRM_MODE
   +#if defined(XF86DRM_MODE)  !defined(XSPICE)
static char *
CreatePCIBusID(const struct pci_device *dev)
{
   --
   1.9.3
  
  ACK, though we could also ensure that XF86DRM_MODE is never defined when
  XSPICE is ?
  
 
 You're right, but it's more work - mainly deciding what I want done - should 
 configure not allow both drm and xspice? probably. Later patch?

Sure, can even wait until next time there is a similar issue ;)

Christophe


pgpKnbaDyZiSa.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-24 Thread Christophe Fergeau 
On Mon, Jun 09, 2014 at 04:08:37PM +0300, Alon Levy wrote:
 Signed-off-by: Alon Levy al...@redhat.com
 ---
  src/qxl_driver.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/src/qxl_driver.c b/src/qxl_driver.c
 index b9aa0e9..d9bf447 100644
 --- a/src/qxl_driver.c
 +++ b/src/qxl_driver.c
 @@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms)
  pScrn-ValidMode= NULL;
  }
  
 -#ifdef XF86DRM_MODE
 +#if defined(XF86DRM_MODE)  !defined(XSPICE)
  static char *
  CreatePCIBusID(const struct pci_device *dev)
  {
 -- 
 1.9.3

ACK, though we could also ensure that XF86DRM_MODE is never defined when
XSPICE is ? 


pgpCNfZAWPgWP.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH] qxl_driver.c: fix compiler warning 'defined but not used' qxl_kernel_mode_enabled

2014-06-09 Thread Alon Levy 
Signed-off-by: Alon Levy al...@redhat.com
---
 src/qxl_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index b9aa0e9..d9bf447 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1242,7 +1242,7 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms)
 pScrn-ValidMode= NULL;
 }
 
-#ifdef XF86DRM_MODE
+#if defined(XF86DRM_MODE)  !defined(XSPICE)
 static char *
 CreatePCIBusID(const struct pci_device *dev)
 {
-- 
1.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel