[Spice-devel] [PATCH 0/8] Rework autotools build system
Hi, The autotools build system looked a bit convoluted when I looked at it, and after toying a bit with it when preparing the earlier patchset, it seemed more fragile than autotools build systems generally are. This patchseries rework the Makefile.am to get something more "standard". make distcheck still passes, but I couldn't test what happens on windows, let me know if you can test it and want help fixing it ;) This patch series applies on top of the cleanup series I just sent. Christophe Christophe Fergeau (8): autotools: refactor the whole build machinery configure.ac: remove unused AC_SUBST autotools: correctly build canvas-related code add #include to all source files add config.h to autogenerated files too use AC_DEFINE instead of hardcoding preprocessor flags s/USE_OGL/USE_OPENGL add comment to beginning of autogenerated files client/Makefile.am | 342 +--- client/application.cpp | 13 +- client/application.h |2 +- client/canvas.cpp |3 + client/canvas.h|1 - client/client_net_socket.cpp |3 + client/cmd_line_parser.cpp |3 + client/common.h|2 +- client/controller.cpp |3 + client/cursor.cpp |3 + client/cursor_channel.cpp |3 + client/display_channel.cpp | 43 +++-- client/display_channel.h | 12 +- client/foreign_menu.cpp|3 + client/glz_decode_tmpl.c |3 + client/glz_decoder.cpp |3 + client/glz_decoder.h |2 +- client/glz_decoder_window.cpp |3 + client/gui/gui.cpp |4 + client/gui/resource_provider.cpp |4 + client/gui/softrenderer.cpp|3 +- client/gui/softtexture.cpp |3 +- client/hot_keys.cpp|3 + client/inputs_channel.cpp |3 + client/jpeg_decoder.cpp|3 + client/jpeg_decoder.h |2 +- client/menu.cpp|3 + client/mjpeg_decoder.cpp |3 + client/monitor.cpp |3 + client/playback_channel.cpp|3 + client/process_loop.cpp|3 + client/record_channel.cpp |3 + client/red_canvas_base.h | 26 +++ client/red_channel.cpp |3 + client/red_client.cpp |5 +- client/red_gdi_canvas.cpp |9 + client/red_gdi_canvas.h|4 + client/red_gl_canvas.cpp |9 + client/red_gl_canvas.h |5 + client/red_peer.cpp|3 + client/red_sw_canvas.cpp |9 + client/red_sw_canvas.h |4 + client/red_window.h|2 +- client/screen.cpp |9 +- client/screen.h|6 +- client/screen_layer.cpp|3 + client/smartcard_channel.cpp |4 + client/threads.cpp |3 + client/tunnel_channel.cpp |3 + client/utils.cpp |3 + client/windows/Makefile.am | 236 - client/windows/event_sources_p.cpp |3 + client/windows/main.cpp|3 + client/windows/my_getopt.cpp |3 + client/windows/named_pipe.cpp |3 + client/windows/pixels_source.cpp |3 + client/windows/platform.cpp|3 + client/windows/platform_utils.cpp |3 + client/windows/playback.cpp|3 + client/windows/record.cpp |3 + client/windows/red_drawable.cpp|3 + client/windows/red_pixmap.cpp |3 + client/windows/red_pixmap_gdi.cpp |3 + client/windows/red_pixmap_sw.cpp |7 +- client/windows/red_window.cpp |5 +- client/x11/Makefile.am | 223 --- client/x11/event_sources_p.cpp |3 + client/x11/images/Makefile.am |5 - client/x11/main.cpp|3 + client/x11/named_pipe.cpp |3 + client/x11/pixels_source.cpp |3 + client/x11/pixels_source_p.h | 20 +- client/x11/platform.cpp| 27 ++-- client/x11/platform_utils.cpp |3 + client/x11/playback.cpp|3 + client/x11/record.cpp |3 + client/x11/red_drawable.cpp| 31 ++-- client/x11/red_pixmap.cpp |3 + client/x11/red_pixmap_gl.cpp |3 + client/x11/red_pixmap_sw.cpp |3 + client/x11/red_window.cpp | 27 ++-- client/x11/red_window_p.h | 16 +- client/x11/res.cpp |3 + client/x11/x_icon.cpp |3 + client/x11/x_platform.h|4 +- client/zlib_decoder.cpp|4 + client/zlib_decoder.h |2 +- common/Makefile.am | 83 ++ common/canvas_base.c |8 +
Re: [Spice-devel] [PATCH 0/8] Rework autotools build system
Hi On Thu, Apr 21, 2011 at 2:00 PM, Christophe Fergeau wrote: > Hi, > > The autotools build system looked a bit convoluted when I looked at it, > and after toying a bit with it when preparing the earlier patchset, it > seemed more fragile than autotools build systems generally are. This > patchseries rework the Makefile.am to get something more "standard". > > make distcheck still passes, but I couldn't test what happens on windows, > let me know if you can test it and want help fixing it ;) > > This patch series applies on top of the cleanup series I just sent. I am all for the autotools refactoring, which looks great. ACK'ing the series, even if the canvas define mess isn't sadly as pretty. It would be nice to find a simpler way, something left for the long TODO list. It would be great to get an ACK first from someone building with Windows before merging. regards -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH 0/8] Rework autotools build system
On Wed, Apr 27, 2011 at 05:43:10PM +0200, Marc-André Lureau wrote: > It would be great to get an ACK first from someone building with > Windows before merging. Ping? Anyone on the list who could test a build with these patches applied? If no one chimes in, I'll just commit them in a few days, and wait for people to complain :) Christophe pgpM84fJDN7jG.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH 0/8] Rework autotools build system
On Mon, May 02, 2011 at 11:18:50AM +0200, Christophe Fergeau wrote: > On Wed, Apr 27, 2011 at 05:43:10PM +0200, Marc-André Lureau wrote: > > It would be great to get an ACK first from someone building with > > Windows before merging. > > Ping? Anyone on the list who could test a build with these patches applied? > If no one chimes in, I'll just commit them in a few days, and wait for > people to complain :) this is now pushed, you now who to complain to if windows build is broken ;) Christophe pgpoFWVCQzspK.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
