Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice
Hey, On Thu, Jun 14, 2012 at 02:17:10PM +0300, Alon Levy wrote: By adding spice-protocol to SUBDIRS configure and make will be called in it. This patch has an unfortunate side-effect, it's that it causes spice-protocol headers to be installed. In particular, this means running make install in spice-gtk will install spice-protocol headers, which is not what we want imo. Christophe pgpQlizp9OyY3.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice
By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 28450b4..3b3c88d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@ NULL = ACLOCAL_AMFLAGS = -I m4 -SUBDIRS = python_modules common +SUBDIRS = python_modules common spice-protocol DIST_SUBDIRS = spice-protocol $(SUBDIRS) EXTRA_DIST = \ -- 1.7.10.1 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice
- Mensaje original - By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 28450b4..3b3c88d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@ NULL = ACLOCAL_AMFLAGS = -I m4 -SUBDIRS = python_modules common +SUBDIRS = python_modules common spice-protocol DIST_SUBDIRS = spice-protocol $(SUBDIRS) Can you check make distcheck? I wonder why I used DIST_SUBDIRS in the first place. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-common] Makefile.am: fix .gitignore not being generated in spice-protocol/spice
On Thu, Jun 14, 2012 at 08:28:24AM -0400, Marc-André Lureau wrote: - Mensaje original - By adding spice-protocol to SUBDIRS configure and make will be called in it. Spotted by Marc-André. --- Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 28450b4..3b3c88d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@ NULL = ACLOCAL_AMFLAGS = -I m4 -SUBDIRS = python_modules common +SUBDIRS = python_modules common spice-protocol DIST_SUBDIRS = spice-protocol $(SUBDIRS) Can you check make distcheck? I wonder why I used DIST_SUBDIRS in the first place. broke it already with spice-protocol/spice/enums.h, thanks for pointing it out. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
