Re: [Spice-devel] [PATCH spice-gtk] session: prefix proxy lookup errors

2014-07-07 Thread Alon Levy 
On 07/03/2014 07:49 PM, Marc-André Lureau wrote:
> Proxy errors are already reported with G_IO_ERROR_PROXY messages,
> however proxy name lookup error can be more detailed.

ACK

> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1115986
> ---
>  gtk/spice-session.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index fed57a4..7aef787 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -1730,6 +1730,7 @@ static void proxy_lookup_ready(GObject *source_object, 
> GAsyncResult *result,
>  addresses = g_resolver_lookup_by_name_finish(G_RESOLVER(source_object),
>   result, &open_host->error);
>  if (addresses == NULL || open_host->error) {
> +g_prefix_error(&open_host->error, "SPICE proxy: ");
>  coroutine_yieldto(open_host->from, NULL);
>  return;
>  }
> 

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-gtk] session: prefix proxy lookup errors

2014-07-03 Thread Marc-André Lureau 
Proxy errors are already reported with G_IO_ERROR_PROXY messages,
however proxy name lookup error can be more detailed.

https://bugzilla.redhat.com/show_bug.cgi?id=1115986
---
 gtk/spice-session.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index fed57a4..7aef787 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1730,6 +1730,7 @@ static void proxy_lookup_ready(GObject *source_object, 
GAsyncResult *result,
 addresses = g_resolver_lookup_by_name_finish(G_RESOLVER(source_object),
  result, &open_host->error);
 if (addresses == NULL || open_host->error) {
+g_prefix_error(&open_host->error, "SPICE proxy: ");
 coroutine_yieldto(open_host->from, NULL);
 return;
 }
-- 
1.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel