Re: [Spice-devel] [PATCH spice-gtk]channel-main.c: gssize type error with mingw32-gcc
On Sun, Apr 06, 2014 at 02:03:10PM +0800, Cody Chan wrote: Here , mingw32-configure --without-sasl --with-gtk=3.0 --with-audio=gstreamer --without-python --enable-usbredir=yes --enable-smartcard=no --enable-vala mingw32-make There is a error: .. CC channel-webdav.lo channel-webdav.c: In function 'demux_to_client': channel-webdav.c:318:5: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'gssize' [-Werror=format=] CHANNEL_DEBUG(self, pushing %ld to client %p, size, client); ^ cc1: all warnings being treated as errors make[4]: *** [channel-webdav.lo] Error 1 Should be fixed by http://lists.freedesktop.org/archives/spice-devel/2014-April/016569.html (make CFLAGS=-Wno-error will probably avoid this breaking the build) .. Doc says: typedef signed int gssize; It's just a tiny bug, but it is strange that it's ok with gcc. This is a platform dependent typedef, on my linux x86_64 machine it's: typedef signed long gssize; Christophe pgptOBwrxeryp.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH spice-gtk]channel-main.c: gssize type error with mingw32-gcc
On Mon, Apr 7, 2014 at 3:50 PM, Christophe Fergeau cferg...@redhat.com wrote: On Sun, Apr 06, 2014 at 02:03:10PM +0800, Cody Chan wrote: Here , mingw32-configure --without-sasl --with-gtk=3.0 --with-audio=gstreamer --without-python --enable-usbredir=yes --enable-smartcard=no --enable-vala mingw32-make There is a error: .. CC channel-webdav.lo channel-webdav.c: In function 'demux_to_client': channel-webdav.c:318:5: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'gssize' [-Werror=format=] CHANNEL_DEBUG(self, pushing %ld to client %p, size, client); ^ cc1: all warnings being treated as errors make[4]: *** [channel-webdav.lo] Error 1 Should be fixed by http://lists.freedesktop.org/archives/spice-devel/2014-April/016569.html (make CFLAGS=-Wno-error will probably avoid this breaking the build) .. Doc says: typedef signed int gssize; It's just a tiny bug, but it is strange that it's ok with gcc. This is a platform dependent typedef, on my linux x86_64 machine it's: typedef signed long gssize; So that explains it! Cheers Christophe ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk]channel-main.c: gssize type error with mingw32-gcc
Here ,
mingw32-configure --without-sasl --with-gtk=3.0 --with-audio=gstreamer
--without-python --enable-usbredir=yes --enable-smartcard=no
--enable-vala
mingw32-make
There is a error:
..
CC channel-webdav.lo
channel-webdav.c: In function 'demux_to_client':
channel-webdav.c:318:5: error: format '%ld' expects argument of type
'long int', but argument 5 has type 'gssize' [-Werror=format=]
CHANNEL_DEBUG(self, pushing %ld to client %p, size, client);
^
cc1: all warnings being treated as errors
make[4]: *** [channel-webdav.lo] Error 1
..
Doc says: typedef signed int gssize;
It's just a tiny bug, but it is strange that it's ok with gcc.
diff --git a/gtk/channel-webdav.c b/gtk/channel-webdav.c
index c619e48..1935aa3 100644
--- a/gtk/channel-webdav.c
+++ b/gtk/channel-webdav.c
@@ -315,7 +315,7 @@ static void demux_to_client(SpiceWebdavChannel *self,
SpiceWebdavChannelPrivate *c = self-priv;
gssize size = c-demux.size;
-CHANNEL_DEBUG(self, pushing %ld to client %p, size, client);
+CHANNEL_DEBUG(self, pushing %d to client %p, size, client);
if (size != 0) {
output_queue_push(client-output, (guint8 *)c-demux.buf, size,
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
