Re: [Spice-devel] [PATCH spice-gtk v4 2/2] spice-widget: Avoid deadlock for VAAPI
This patch fixes the issues I've experienced before Ack On 1/15/19 12:22 PM, Frediano Ziglio wrote: Calling gst_video_overlay_handle_events after gst_video_overlay_set_window_handle causes often a deadlock in gstreamer-vaapi. Reverting the calls fix this issue. Signed-off-by: Frediano Ziglio --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 69c00558..1d7c8c17 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -2588,8 +2588,8 @@ static void gst_sync_bus_call(GstBus *bus, GstMessage *msg, SpiceDisplay *displa GstVideoOverlay *overlay = GST_VIDEO_OVERLAY(GST_MESSAGE_SRC(msg)); g_weak_ref_set(>overlay_weak_ref, overlay); -gst_video_overlay_set_window_handle(overlay, (uintptr_t)GDK_WINDOW_XID(window)); gst_video_overlay_handle_events(overlay, false); +gst_video_overlay_set_window_handle(overlay, (uintptr_t)GDK_WINDOW_XID(window)); return; } } ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [PATCH spice-gtk v4 2/2] spice-widget: Avoid deadlock for VAAPI
Calling gst_video_overlay_handle_events after gst_video_overlay_set_window_handle causes often a deadlock in gstreamer-vaapi. Reverting the calls fix this issue. Signed-off-by: Frediano Ziglio --- src/spice-widget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index 69c00558..1d7c8c17 100644 --- a/src/spice-widget.c +++ b/src/spice-widget.c @@ -2588,8 +2588,8 @@ static void gst_sync_bus_call(GstBus *bus, GstMessage *msg, SpiceDisplay *displa GstVideoOverlay *overlay = GST_VIDEO_OVERLAY(GST_MESSAGE_SRC(msg)); g_weak_ref_set(>overlay_weak_ref, overlay); -gst_video_overlay_set_window_handle(overlay, (uintptr_t)GDK_WINDOW_XID(window)); gst_video_overlay_handle_events(overlay, false); +gst_video_overlay_set_window_handle(overlay, (uintptr_t)GDK_WINDOW_XID(window)); return; } } -- 2.20.1 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
