Re: [Spice-devel] [PATCH spice-server 1/4] Clear "msg" pointers after releasing

2017-02-15 Thread Christophe Fergeau 
On Wed, Feb 15, 2017 at 11:31:58AM +, Frediano Ziglio wrote:
> Avoid possible dangling pointers.


Acked-by: Christophe Fergeau 

> 
> Signed-off-by: Frediano Ziglio 
> ---
>  server/red-channel-client.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/server/red-channel-client.c b/server/red-channel-client.c
> index 9ab22e4..32db186 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channel-client.c
> @@ -1277,6 +1277,7 @@ static void 
> red_channel_client_handle_incoming(RedChannelClient *rcc)
>  if (bytes_read == -1) {
>  red_channel_client_release_msg_buf(rcc, msg_type, msg_size,
> buffer->msg);
> +buffer->msg = NULL;
>  red_channel_client_disconnect(rcc);
>  return;
>  }
> @@ -1296,6 +1297,7 @@ static void 
> red_channel_client_handle_incoming(RedChannelClient *rcc)
>  red_channel_client_release_msg_buf(rcc,
> msg_type, msg_size,
> buffer->msg);
> +buffer->msg = NULL;
>  red_channel_client_disconnect(rcc);
>  return;
>  }
> -- 
> 2.9.3
> 
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-server 1/4] Clear "msg" pointers after releasing

2017-02-15 Thread Frediano Ziglio 
Avoid possible dangling pointers.

Signed-off-by: Frediano Ziglio 
---
 server/red-channel-client.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 9ab22e4..32db186 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-client.c
@@ -1277,6 +1277,7 @@ static void 
red_channel_client_handle_incoming(RedChannelClient *rcc)
 if (bytes_read == -1) {
 red_channel_client_release_msg_buf(rcc, msg_type, msg_size,
buffer->msg);
+buffer->msg = NULL;
 red_channel_client_disconnect(rcc);
 return;
 }
@@ -1296,6 +1297,7 @@ static void 
red_channel_client_handle_incoming(RedChannelClient *rcc)
 red_channel_client_release_msg_buf(rcc,
msg_type, msg_size,
buffer->msg);
+buffer->msg = NULL;
 red_channel_client_disconnect(rcc);
 return;
 }
-- 
2.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-server 1/4] Clear "msg" pointers after releasing

2017-02-14 Thread Christophe Fergeau 
On Mon, Feb 13, 2017 at 11:03:16AM +, Frediano Ziglio wrote:
> Avoid possible dandling pointers.

'dangling', though let's delay that after my patch series doing changes
in that area (I can rebase/queue your patch there).

Christophe


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-server 1/4] Clear "msg" pointers after releasing

2017-02-13 Thread Frediano Ziglio 
Avoid possible dandling pointers.

Signed-off-by: Frediano Ziglio 
---
 server/red-channel-client.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/server/red-channel-client.c b/server/red-channel-client.c
index 06fb8a8..2450923 100644
--- a/server/red-channel-client.c
+++ b/server/red-channel-client.c
@@ -1133,6 +1133,7 @@ static void red_peer_handle_incoming(RedsStream *stream, 
IncomingHandler *handle
   msg_size - handler->msg_pos);
 if (bytes_read == -1) {
 handler->cb->release_msg_buf(handler->opaque, msg_type, 
msg_size, handler->msg);
+handler->msg = NULL;
 handler->cb->on_error(handler->opaque);
 return;
 }
@@ -1154,6 +1155,7 @@ static void red_peer_handle_incoming(RedsStream *stream, 
IncomingHandler *handle
 if (parsed == NULL) {
 spice_printerr("failed to parse message type %d", msg_type);
 handler->cb->release_msg_buf(handler->opaque, msg_type, 
msg_size, handler->msg);
+handler->msg = NULL;
 handler->cb->on_error(handler->opaque);
 return;
 }
-- 
2.9.3

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel