Re: [Spice-devel] [PATCH spice-server 2/2] RedStream: make some functions static

[Frediano Ziglio]

> 
> These were not used outside of red-stream.c, so make them static and
> remove them from the header.

Acked-by: Frediano Ziglio 

> ---
>  server/red-stream.c | 6 +++---
>  server/red-stream.h | 3 ---
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/server/red-stream.c b/server/red-stream.c
> index 6fdf1779f..6ce1642b4 100644
> --- a/server/red-stream.c
> +++ b/server/red-stream.c
> @@ -438,7 +438,7 @@ bool red_stream_is_ssl(RedStream *stream)
>  return (stream->priv->ssl != NULL);
>  }
>  
> -void red_stream_disable_writev(RedStream *stream)
> +static void red_stream_disable_writev(RedStream *stream)
>  {
>  stream->priv->writev = NULL;
>  }
> @@ -572,12 +572,12 @@ void red_stream_async_read(RedStream *stream,
>  }
>  
>  #if HAVE_SASL
> -bool red_stream_write_u8(RedStream *s, uint8_t n)
> +static bool red_stream_write_u8(RedStream *s, uint8_t n)
>  {
>  return red_stream_write_all(s, , sizeof(uint8_t));
>  }
>  
> -bool red_stream_write_u32(RedStream *s, uint32_t n)
> +static bool red_stream_write_u32(RedStream *s, uint32_t n)
>  {
>  return red_stream_write_all(s, , sizeof(uint32_t));
>  }
> diff --git a/server/red-stream.h b/server/red-stream.h
> index e6e37e3e7..05179d0a8 100644
> --- a/server/red-stream.h
> +++ b/server/red-stream.h
> @@ -53,9 +53,6 @@ void red_stream_set_async_error_handler(RedStream *stream,
>  ssize_t red_stream_write(RedStream *s, const void *buf, size_t nbyte);
>  ssize_t red_stream_writev(RedStream *s, const struct iovec *iov, int
>  iovcnt);
>  bool red_stream_write_all(RedStream *stream, const void *in_buf, size_t n);
> -bool red_stream_write_u8(RedStream *s, uint8_t n);
> -bool red_stream_write_u32(RedStream *s, uint32_t n);
> -void red_stream_disable_writev(RedStream *stream);
>  void red_stream_free(RedStream *s);
>  
>  void red_stream_push_channel_event(RedStream *s, int event);

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH spice-server 2/2] RedStream: make some functions static

[Jonathon Jongsma]

These were not used outside of red-stream.c, so make them static and
remove them from the header.
---
 server/red-stream.c | 6 +++---
 server/red-stream.h | 3 ---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/server/red-stream.c b/server/red-stream.c
index 6fdf1779f..6ce1642b4 100644
--- a/server/red-stream.c
+++ b/server/red-stream.c
@@ -438,7 +438,7 @@ bool red_stream_is_ssl(RedStream *stream)
 return (stream->priv->ssl != NULL);
 }
 
-void red_stream_disable_writev(RedStream *stream)
+static void red_stream_disable_writev(RedStream *stream)
 {
 stream->priv->writev = NULL;
 }
@@ -572,12 +572,12 @@ void red_stream_async_read(RedStream *stream,
 }
 
 #if HAVE_SASL
-bool red_stream_write_u8(RedStream *s, uint8_t n)
+static bool red_stream_write_u8(RedStream *s, uint8_t n)
 {
 return red_stream_write_all(s, , sizeof(uint8_t));
 }
 
-bool red_stream_write_u32(RedStream *s, uint32_t n)
+static bool red_stream_write_u32(RedStream *s, uint32_t n)
 {
 return red_stream_write_all(s, , sizeof(uint32_t));
 }
diff --git a/server/red-stream.h b/server/red-stream.h
index e6e37e3e7..05179d0a8 100644
--- a/server/red-stream.h
+++ b/server/red-stream.h
@@ -53,9 +53,6 @@ void red_stream_set_async_error_handler(RedStream *stream,
 ssize_t red_stream_write(RedStream *s, const void *buf, size_t nbyte);
 ssize_t red_stream_writev(RedStream *s, const struct iovec *iov, int iovcnt);
 bool red_stream_write_all(RedStream *stream, const void *in_buf, size_t n);
-bool red_stream_write_u8(RedStream *s, uint8_t n);
-bool red_stream_write_u32(RedStream *s, uint32_t n);
-void red_stream_disable_writev(RedStream *stream);
 void red_stream_free(RedStream *s);
 
 void red_stream_push_channel_event(RedStream *s, int event);
-- 
2.13.6

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel