Re: [Spice-devel] [PATCH v3 08/11] Add mention of fall-through comments

[Frediano Ziglio]

> 
> From: Christophe de Dinechin 
> 
> Signed-off-by: Christophe de Dinechin 
> ---
>  docs/spice_style.txt | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 68dbeeef..eb2ee252 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -128,6 +128,11 @@ goto
>  
>  Using goto is allowed in C code for error handling. In any other case it
>  will be used only as a special exception.
>  
> +switch fall-through
> +---

I would just use the "switch" title, but not strong about it.

> +
> +If a switch case falls through (i.e. does not end with a `break`), annotate
> it with a /* Fall through */ comment. Some compilers will emit a warning
> otherwise.
> +

I would quote the code comment with `/* fall through */` so gets monospace
font. Also I'd use lower case.

>  Defining Constant values
>  
>  

Otherwise,
Acked-by: Frediano Ziglio 

Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH v3 08/11] Add mention of fall-through comments

[Christophe de Dinechin]

From: Christophe de Dinechin 

Signed-off-by: Christophe de Dinechin 
---
 docs/spice_style.txt | 5 +
 1 file changed, 5 insertions(+)

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 68dbeeef..eb2ee252 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -128,6 +128,11 @@ goto
 
 Using goto is allowed in C code for error handling. In any other case it will 
be used only as a special exception.
 
+switch fall-through
+---
+
+If a switch case falls through (i.e. does not end with a `break`), annotate it 
with a /* Fall through */ comment. Some compilers will emit a warning otherwise.
+
 Defining Constant values
 
 
-- 
2.13.5 (Apple Git-94)

___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel