[Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Christophe Fergeau
They can be used to build spice-gtk / mingw-spice-gtk RPM packages.
These spec files are based off the .spec used in Fedora
---
 configure.ac |   2 +
 data/Makefile.am |   8 ++
 data/mingw-spice-gtk.spec.in | 279 +++
 data/spice-gtk.spec.in   | 256 +++
 4 files changed, 545 insertions(+)
 create mode 100644 data/mingw-spice-gtk.spec.in
 create mode 100644 data/spice-gtk.spec.in

diff --git a/configure.ac b/configure.ac
index cf5a039..c6c82ea 100644
--- a/configure.ac
+++ b/configure.ac
@@ -745,6 +745,8 @@ spice-client-gtk-3.0.pc
 spice-controller.pc
 data/Makefile
 data/spicy.nsis
+data/spice-gtk.spec
+data/mingw-spice-gtk.spec
 po/Makefile.in
 gtk/Makefile
 gtk/spice-version.h
diff --git a/data/Makefile.am b/data/Makefile.am
index a289c23..82f4ba1 100644
--- a/data/Makefile.am
+++ b/data/Makefile.am
@@ -1,13 +1,21 @@
 NULL=
 
 EXTRA_DIST =   \
+   mingw-spice-gtk.spec\
spicy.nsis  \
+   spice-gtk.spec  \
spice-protocol.vapi \
gtkrc   \
$(desktop_in_files) \
org.spice-space.lowlevelusbaccess.policy \
$(NULL)
 
+DISTCLEAN_FILES =  \
+   mingw-spice-gtk.spec\
+   spice-gtk.spec  \
+   $(NULL)
+
+
 vapidir = $(VAPIDIR)
 vapi_DATA = spice-protocol.vapi
 
diff --git a/data/mingw-spice-gtk.spec.in b/data/mingw-spice-gtk.spec.in
new file mode 100644
index 000..c27e91e
--- /dev/null
+++ b/data/mingw-spice-gtk.spec.in
@@ -0,0 +1,279 @@
+%{?mingw_package_header}
+
+Name:   mingw-spice-gtk
+Version:@VERSION@
+Release:1%{?dist}
+Summary:A GTK+ widget for SPICE clients
+
+License:LGPLv2+
+URL:http://spice-space.org/page/Spice-Gtk
+Source0:
http://www.spice-space.org/download/gtk/spice-gtk-%{version}%{?_version_suffix}.tar.bz2
+
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildArch: noarch
+
+BuildRequires: mingw32-filesystem >= 95
+BuildRequires: mingw64-filesystem >= 95
+BuildRequires: mingw32-gcc
+BuildRequires: mingw64-gcc
+BuildRequires: mingw32-binutils
+BuildRequires: mingw64-binutils
+BuildRequires: glib2-devel
+
+BuildRequires: mingw32-gtk2 >= 2.14
+BuildRequires: mingw64-gtk2 >= 2.14
+BuildRequires: mingw32-gtk3 >= 2.91.3
+BuildRequires: mingw64-gtk3 >= 2.91.3
+BuildRequires: mingw32-pixman
+BuildRequires: mingw64-pixman
+BuildRequires: mingw32-openssl
+BuildRequires: mingw64-openssl
+BuildRequires: mingw32-libjpeg-turbo
+BuildRequires: mingw64-libjpeg-turbo
+BuildRequires: mingw32-celt051
+BuildRequires: mingw64-celt051
+BuildRequires: mingw32-zlib
+BuildRequires: mingw64-zlib
+BuildRequires: mingw32-gstreamer1
+BuildRequires: mingw64-gstreamer1
+BuildRequires: mingw32-gstreamer1-plugins-base
+BuildRequires: mingw64-gstreamer1-plugins-base
+BuildRequires: mingw32-usbredir
+BuildRequires: mingw64-usbredir
+BuildRequires: mingw32-libusbx
+BuildRequires: mingw64-libusbx
+BuildRequires: mingw32-opus
+BuildRequires: mingw64-opus
+# Hack because of bz #613466
+BuildRequires: intltool
+BuildRequires: libtool
+
+%description
+Client libraries for SPICE desktop servers.
+
+
+# Mingw32
+%package -n mingw32-spice-gtk
+Summary: %{summary}
+Requires: mingw32-spice-glib = %{version}-%{release}
+Requires: mingw32-gtk2
+Requires: pkgconfig
+
+%description -n mingw32-spice-gtk
+Gtk+2 client libraries for SPICE desktop servers.
+
+%package -n mingw32-spice-gtk3
+Summary: %{summary}
+Requires: mingw32-spice-glib = %{version}-%{release}
+Requires: mingw32-gtk3
+Requires: pkgconfig
+
+%description -n mingw32-spice-gtk3
+Gtk+3 client libraries for SPICE desktop servers.
+
+%package -n mingw32-spice-glib
+Summary: GLib-based library to connect to SPICE servers
+Requires: pkgconfig
+Requires: mingw32-glib2
+Requires: mingw32-spice-protocol
+
+%description -n mingw32-spice-glib
+A SPICE client library using GLib2.
+
+%package -n mingw32-spice-gtk-static
+Summary: %{summary}
+Requires: mingw32-spice-gtk = %{version}-%{release}
+
+%description -n mingw32-spice-gtk-static
+Gtk+ client static libraries for SPICE desktop servers.
+
+# Mingw64
+%package -n mingw64-spice-gtk
+Summary: %{summary}
+Requires: mingw64-spice-glib = %{version}-%{release}
+Requires: mingw64-gtk2
+Requires: pkgconfig
+
+%description -n mingw64-spice-gtk
+Gtk+2 client libraries for SPICE desktop servers.
+
+%package -n mingw64-spice-gtk3
+Summary: %{summary}
+Requires: mingw64-spice-glib = %{version}-%{release}
+Requires: mingw64-gtk3
+Requires: pkgconfig
+
+%description -n mingw64-spice-gtk3
+Gtk+3 client libraries for SPICE desktop servers.
+
+%package -n mingw64-spice-glib
+Summary: GLib-based library to connect to SPICE servers
+Requires: pkgconfig
+Re

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Marc-André Lureau
Hi,

- Original Message -
> They can be used to build spice-gtk / mingw-spice-gtk RPM packages.
> These spec files are based off the .spec used in Fedora

Why is it needed?
I dislike having to maintain .spec files in several places. Furthermore, I 
don't get why we should have .spec file upstream and not of other distro.

> ---
>  configure.ac |   2 +
>  data/Makefile.am |   8 ++
>  data/mingw-spice-gtk.spec.in | 279
>  +++
>  data/spice-gtk.spec.in   | 256 +++
>  4 files changed, 545 insertions(+)
>  create mode 100644 data/mingw-spice-gtk.spec.in
>  create mode 100644 data/spice-gtk.spec.in
> 
> diff --git a/configure.ac b/configure.ac
> index cf5a039..c6c82ea 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -745,6 +745,8 @@ spice-client-gtk-3.0.pc
>  spice-controller.pc
>  data/Makefile
>  data/spicy.nsis
> +data/spice-gtk.spec
> +data/mingw-spice-gtk.spec
>  po/Makefile.in
>  gtk/Makefile
>  gtk/spice-version.h
> diff --git a/data/Makefile.am b/data/Makefile.am
> index a289c23..82f4ba1 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -1,13 +1,21 @@
>  NULL=
>  
>  EXTRA_DIST = \
> + mingw-spice-gtk.spec\
>   spicy.nsis  \
> + spice-gtk.spec  \
>   spice-protocol.vapi \
>   gtkrc   \
>   $(desktop_in_files) \
>   org.spice-space.lowlevelusbaccess.policy \
>   $(NULL)
>  
> +DISTCLEAN_FILES =\
> + mingw-spice-gtk.spec\
> + spice-gtk.spec  \
> + $(NULL)
> +
> +
>  vapidir = $(VAPIDIR)
>  vapi_DATA = spice-protocol.vapi
>  
> diff --git a/data/mingw-spice-gtk.spec.in b/data/mingw-spice-gtk.spec.in
> new file mode 100644
> index 000..c27e91e
> --- /dev/null
> +++ b/data/mingw-spice-gtk.spec.in
> @@ -0,0 +1,279 @@
> +%{?mingw_package_header}
> +
> +Name:   mingw-spice-gtk
> +Version:@VERSION@
> +Release:1%{?dist}
> +Summary:A GTK+ widget for SPICE clients
> +
> +License:LGPLv2+
> +URL:http://spice-space.org/page/Spice-Gtk
> +Source0:
> http://www.spice-space.org/download/gtk/spice-gtk-%{version}%{?_version_suffix}.tar.bz2
> +
> +BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> +BuildArch: noarch
> +
> +BuildRequires: mingw32-filesystem >= 95
> +BuildRequires: mingw64-filesystem >= 95
> +BuildRequires: mingw32-gcc
> +BuildRequires: mingw64-gcc
> +BuildRequires: mingw32-binutils
> +BuildRequires: mingw64-binutils
> +BuildRequires: glib2-devel
> +
> +BuildRequires: mingw32-gtk2 >= 2.14
> +BuildRequires: mingw64-gtk2 >= 2.14
> +BuildRequires: mingw32-gtk3 >= 2.91.3
> +BuildRequires: mingw64-gtk3 >= 2.91.3
> +BuildRequires: mingw32-pixman
> +BuildRequires: mingw64-pixman
> +BuildRequires: mingw32-openssl
> +BuildRequires: mingw64-openssl
> +BuildRequires: mingw32-libjpeg-turbo
> +BuildRequires: mingw64-libjpeg-turbo
> +BuildRequires: mingw32-celt051
> +BuildRequires: mingw64-celt051
> +BuildRequires: mingw32-zlib
> +BuildRequires: mingw64-zlib
> +BuildRequires: mingw32-gstreamer1
> +BuildRequires: mingw64-gstreamer1
> +BuildRequires: mingw32-gstreamer1-plugins-base
> +BuildRequires: mingw64-gstreamer1-plugins-base
> +BuildRequires: mingw32-usbredir
> +BuildRequires: mingw64-usbredir
> +BuildRequires: mingw32-libusbx
> +BuildRequires: mingw64-libusbx
> +BuildRequires: mingw32-opus
> +BuildRequires: mingw64-opus
> +# Hack because of bz #613466
> +BuildRequires: intltool
> +BuildRequires: libtool
> +
> +%description
> +Client libraries for SPICE desktop servers.
> +
> +
> +# Mingw32
> +%package -n mingw32-spice-gtk
> +Summary: %{summary}
> +Requires: mingw32-spice-glib = %{version}-%{release}
> +Requires: mingw32-gtk2
> +Requires: pkgconfig
> +
> +%description -n mingw32-spice-gtk
> +Gtk+2 client libraries for SPICE desktop servers.
> +
> +%package -n mingw32-spice-gtk3
> +Summary: %{summary}
> +Requires: mingw32-spice-glib = %{version}-%{release}
> +Requires: mingw32-gtk3
> +Requires: pkgconfig
> +
> +%description -n mingw32-spice-gtk3
> +Gtk+3 client libraries for SPICE desktop servers.
> +
> +%package -n mingw32-spice-glib
> +Summary: GLib-based library to connect to SPICE servers
> +Requires: pkgconfig
> +Requires: mingw32-glib2
> +Requires: mingw32-spice-protocol
> +
> +%description -n mingw32-spice-glib
> +A SPICE client library using GLib2.
> +
> +%package -n mingw32-spice-gtk-static
> +Summary: %{summary}
> +Requires: mingw32-spice-gtk = %{version}-%{release}
> +
> +%description -n mingw32-spice-gtk-static
> +Gtk+ client static libraries for SPICE desktop servers.
> +
> +# Mingw64
> +%package -n mingw64-spice-gtk
> +Summary: %{summary}
> +Requires: mingw64-spice-glib = %{version}-%{release}
> +Requires: mingw

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Christophe Fergeau
On Thu, Apr 16, 2015 at 06:11:40AM -0400, Marc-André Lureau wrote:
> Hi,
> 
> - Original Message -
> > They can be used to build spice-gtk / mingw-spice-gtk RPM packages.
> > These spec files are based off the .spec used in Fedora
> 
> Why is it needed?
> I dislike having to maintain .spec files in several places. Furthermore, I 
> don't get why we should have .spec file upstream and not of other distro.

I followed Fidencio's suggestion, it would have been nice to voice your
disagreement before I spent a few minutes doing the work ;)

Christophe


pgpEu5wHh4r4G.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Marc-André Lureau
I don't think there are valid reason to put fedora-specific spec file in
upstream. You can easily build a rpm with fedpkg. nack

On Thu, Apr 16, 2015 at 12:17 PM, Christophe Fergeau 
wrote:

> On Thu, Apr 16, 2015 at 06:11:40AM -0400, Marc-André Lureau wrote:
> > Hi,
> >
> > - Original Message -
> > > They can be used to build spice-gtk / mingw-spice-gtk RPM packages.
> > > These spec files are based off the .spec used in Fedora
> >
> > Why is it needed?
> > I dislike having to maintain .spec files in several places. Furthermore,
> I don't get why we should have .spec file upstream and not of other distro.
>
> I followed Fidencio's suggestion, it would have been nice to voice your
> disagreement before I spent a few minutes doing the work ;)
>
> Christophe
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>


-- 
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Daniel P. Berrange
On Thu, Apr 16, 2015 at 12:30:27PM +0200, Marc-André Lureau wrote:
> I don't think there are valid reason to put fedora-specific spec file in
> upstream. You can easily build a rpm with fedpkg. nack

We've done this for years with all libvirt related packages and it
has proved pretty userful for both end users and maintainers alike.

For example, when upstream makes a change that would impact the RPM
packaging, it is usually quicker & easier for the person making
that change to do the RPM spec file change upstream at the same
time, than for the downstream maintainer to waste time trying to
figure out what the change was.

By having an upstream RPM spec that is always buildable, it makes
it easier for users to test out new releases that are not yet in
the official distro repos, because again they don't have to figure
out how to fix the RPM spec to work with latest code changes.

Having a single canonical RPM spec that works across all current
versions of RHEL & Fedora has also reduced the workload on the
Fedora maintainers too.

The included RPM spec also serves as a helpful guide for other
distros figuring out how to package libvirt in non-RPM formats

So yes, it might seem odd to include a downstream specific RPM
spec in upstream, but in practice it has proved pretty useful
over the 9+ years libvirt & related apps have been around

Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel


Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Fabiano Fidencio


- Original Message -
> From: "Marc-André Lureau" 
> To: "Christophe Fergeau" 
> Cc: spice-de...@freedesktop.org
> Sent: Thursday, April 16, 2015 12:30:27 PM
> Subject: Re: [Spice-devel] [spice-gtk] Add spec files
> 
> I don't think there are valid reason to put fedora-specific spec file in
> upstream. You can easily build a rpm with fedpkg. nack
> 

I disagree. We have it for virt-viewer and another spice projects.
I'd prefer to have it here. It doesn't harm ...

> On Thu, Apr 16, 2015 at 12:17 PM, Christophe Fergeau 
> wrote:
> 
> > On Thu, Apr 16, 2015 at 06:11:40AM -0400, Marc-André Lureau wrote:
> > > Hi,
> > >
> > > - Original Message -
> > > > They can be used to build spice-gtk / mingw-spice-gtk RPM packages.
> > > > These spec files are based off the .spec used in Fedora
> > >
> > > Why is it needed?
> > > I dislike having to maintain .spec files in several places. Furthermore,
> > I don't get why we should have .spec file upstream and not of other distro.
> >
> > I followed Fidencio's suggestion, it would have been nice to voice your
> > disagreement before I spent a few minutes doing the work ;)
> >
> > Christophe
> >
> > ___
> > Spice-devel mailing list
> > Spice-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> >
> >
> 
> 
> --
> Marc-André Lureau
> 
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 

Best Regards,
--
Fabiano Fidêncio
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel