Re: [Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package
>
> On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> > It needs the corresponding library to be installed, as well as
> > pkg-config since it installs a .pc file.
> > ---
> > Since the plugins are going to be dlopened, and since the main package
> > does not ship a .so we need to link to, I'm unsure about the first
> > Requires this patch adds.
>
> FYI, the explicitly versioned requires from -devel to the base RPM is
> mandated
> by Fedora packaging rules
>
> https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
>
> "It is almost always better to over specify the version, so it is best
>practice to just use a fully versioned dependency:
> Requires: %{name}%{?_isa} = %{version}-%{release}.
>Devel packages are an example of a package that must require their base
>packages using a fully versioned dependency."
>
Maybe is just me but I read this as "when you need to depend from the main
package you must use a versioned dependency", not "you must depend on the
main package".
> > spice-streaming-agent.spec.in | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> > index 8c4f26e..351de11 100644
> > --- a/spice-streaming-agent.spec.in
> > +++ b/spice-streaming-agent.spec.in
> > @@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of
> > the X display to a remote
> >
> > %package devel
> > Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
> > +Requires: %{name}%{?_isa} = %{version}-%{release}
> > +Requires: pkgconfig
> > Summary: SPICE streaming agent development files
> >
> > %description devel
> > --
> > 2.13.6
> >
> > ___
> > Spice-devel mailing list
> > Spice-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
> Regards,
> Daniel
Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package
On Wed, Nov 08, 2017 at 12:51:01PM +0100, Christophe Fergeau wrote:
> It needs the corresponding library to be installed, as well as
> pkg-config since it installs a .pc file.
> ---
> Since the plugins are going to be dlopened, and since the main package
> does not ship a .so we need to link to, I'm unsure about the first
> Requires this patch adds.
FYI, the explicitly versioned requires from -devel to the base RPM is mandated
by Fedora packaging rules
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
"It is almost always better to over specify the version, so it is best
practice to just use a fully versioned dependency:
Requires: %{name}%{?_isa} = %{version}-%{release}.
Devel packages are an example of a package that must require their base
packages using a fully versioned dependency."
> spice-streaming-agent.spec.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> index 8c4f26e..351de11 100644
> --- a/spice-streaming-agent.spec.in
> +++ b/spice-streaming-agent.spec.in
> @@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of the
> X display to a remote
>
> %package devel
> Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
> +Requires: %{name}%{?_isa} = %{version}-%{release}
> +Requires: pkgconfig
> Summary: SPICE streaming agent development files
>
> %description devel
> --
> 2.13.6
>
> ___
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package
On 11/08/2017 01:51 PM, Christophe Fergeau wrote:
It needs the corresponding library to be installed, as well as
pkg-config since it installs a .pc file.
---
Since the plugins are going to be dlopened, and since the main package
does not ship a .so we need to link to, I'm unsure about the first
Requires this patch adds.
I'm unsure about the second either.
The -devel package provides a .pc file.
Anyone that wants to use it should install pkg-config.
It (pkg-config) would probably be a BuildRequired in the
package that BuildRequires this -devel package
Uri.
Christophe
spice-streaming-agent.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index 8c4f26e..351de11 100644
--- a/spice-streaming-agent.spec.in
+++ b/spice-streaming-agent.spec.in
@@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of the X
display to a remote
%package devel
Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
+Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: pkgconfig
Summary: SPICE streaming agent development files
%description devel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package
>
> It needs the corresponding library to be installed, as well as
> pkg-config since it installs a .pc file.
> ---
> Since the plugins are going to be dlopened, and since the main package
> does not ship a .so we need to link to, I'm unsure about the first
> Requires this patch adds.
>
> Christophe
>
There's no corresponding library, I think can be added if will
be a library in the future.
>
> spice-streaming-agent.spec.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
> index 8c4f26e..351de11 100644
> --- a/spice-streaming-agent.spec.in
> +++ b/spice-streaming-agent.spec.in
> @@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of the
> X display to a remote
>
> %package devel
> Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
> +Requires: %{name}%{?_isa} = %{version}-%{release}
> +Requires: pkgconfig
> Summary: SPICE streaming agent development files
>
> %description devel
Frediano
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-streaming-agent 7/7] spec: Add missing Requires for the -devel package
It needs the corresponding library to be installed, as well as
pkg-config since it installs a .pc file.
---
Since the plugins are going to be dlopened, and since the main package
does not ship a .so we need to link to, I'm unsure about the first
Requires this patch adds.
Christophe
spice-streaming-agent.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in
index 8c4f26e..351de11 100644
--- a/spice-streaming-agent.spec.in
+++ b/spice-streaming-agent.spec.in
@@ -20,6 +20,8 @@ An agent, running on a guest, sending video streams of the X
display to a remote
%package devel
Requires: spice-protocol >= @SPICE_PROTOCOL_MIN_VER@
+Requires: %{name}%{?_isa} = %{version}-%{release}
+Requires: pkgconfig
Summary: SPICE streaming agent development files
%description devel
--
2.13.6
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel
