Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50
Hi On Sun, Mar 24, 2019 at 6:49 PM Jakub Janku wrote: > > Hi, > > On Fri, Mar 22, 2019 at 4:13 PM wrote: > > > > From: Marc-André Lureau > > > > This is required for using the new GObject macros. > > Which macros are you referring to? > G_DECLARE_FINAL_TYPE is available since 2.44 That's right, we could probably take 2.44. But since our min os requirement is 2.50 already, it's easier to directly bump there. > > > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > > GLib version to 2.34"), RHEL6 is no longer supported. > > > > GLib version across some distributions, from repology: > > - Debian Stable (9): 2.50.3 > > - CentOS 7: 2.56.1 > > - Fedora 26: 2.52.3 (fwiw, Fedora 30: 2.60.0) > > > > Signed-off-by: Marc-André Lureau > > --- > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index fb0675f..9808f58 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -100,7 +100,7 @@ AC_ARG_ENABLE([static-uinput], > >[enable_static_uinput="$enableval"], > >[enable_static_uinput="no"]) > > > > -PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.34]) > > +PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.50]) > > You could bump glib version as well 5/11 replaced glib by gobject, so it's implicit now. > > > PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11]) > > PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.16]) > > PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22]) > > -- > > 2.21.0.4.g36eb1cb9cf > > > > Cheers, > Jakub > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50
Hi On Thu, Mar 28, 2019 at 4:27 PM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > This is required for using the new GObject macros. > > > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > > GLib version to 2.34"), RHEL6 is no longer supported. > > > > GLib version across some distributions, from repology: > > - Debian Stable (9): 2.50.3 > > - CentOS 7: 2.56.1 > > - Fedora 26: 2.52.3 (fwiw, Fedora 30: 2.60.0) > > > > Signed-off-by: Marc-André Lureau > > --- > > configure.ac | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure.ac b/configure.ac > > index fb0675f..9808f58 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -100,7 +100,7 @@ AC_ARG_ENABLE([static-uinput], > >[enable_static_uinput="$enableval"], > >[enable_static_uinput="no"]) > > > > -PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.34]) > > +PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.50]) > > PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11]) > > PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.16]) > > PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22]) > > I don't understand why not directly do it in 5/11, or why > not also bumping glib-2.0 to 2.50, are they not directly > related? 5/11 switches from glib dep to gobject dep. 6/11 bump version requirement. The 2 should probably be done & discussed separately. > > Frediano > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50
> > From: Marc-André Lureau > > This is required for using the new GObject macros. > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > GLib version to 2.34"), RHEL6 is no longer supported. > > GLib version across some distributions, from repology: > - Debian Stable (9): 2.50.3 > - CentOS 7: 2.56.1 > - Fedora 26: 2.52.3 (fwiw, Fedora 30: 2.60.0) > > Signed-off-by: Marc-André Lureau > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index fb0675f..9808f58 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -100,7 +100,7 @@ AC_ARG_ENABLE([static-uinput], >[enable_static_uinput="$enableval"], >[enable_static_uinput="no"]) > > -PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.34]) > +PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.50]) > PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11]) > PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.16]) > PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22]) I don't understand why not directly do it in 5/11, or why not also bumping glib-2.0 to 2.50, are they not directly related? Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [PATCH linux/vd-agent 06/11] configure: bump gobject >= 2.50
Hi, On Fri, Mar 22, 2019 at 4:13 PM wrote: > > From: Marc-André Lureau > > This is required for using the new GObject macros. Which macros are you referring to? G_DECLARE_FINAL_TYPE is available since 2.44 > > According to commit 61fc548fe1a323dd2344c8ae267e3ce05e86da7d ("Bump > GLib version to 2.34"), RHEL6 is no longer supported. > > GLib version across some distributions, from repology: > - Debian Stable (9): 2.50.3 > - CentOS 7: 2.56.1 > - Fedora 26: 2.52.3 (fwiw, Fedora 30: 2.60.0) > > Signed-off-by: Marc-André Lureau > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index fb0675f..9808f58 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -100,7 +100,7 @@ AC_ARG_ENABLE([static-uinput], >[enable_static_uinput="$enableval"], >[enable_static_uinput="no"]) > > -PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.34]) > +PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.50]) You could bump glib version as well > PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11]) > PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.16]) > PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22]) > -- > 2.21.0.4.g36eb1cb9cf > Cheers, Jakub ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel